T-compiler Meeting Agenda 2024-07-25

Announcements

  • Today release of stable Rust 1.80 (blog post)
  • Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @davidtwco or @Wesley Wiser so we can pass it along).

Other WG meetings

MCPs/FCPs

WG checkins

None

Backport nominations

T-compiler beta / T-compiler stable

  • No beta nominations for T-compiler this time.
  • No stable nominations for T-compiler this time.

T-types stable / T-types beta

  • No beta nominations for T-types this time.
  • No stable nominations for T-types this time.

PRs S-waiting-on-team

T-compiler

Issues of Note

Short Summary

P-critical

T-compiler

  • No P-critical issues for T-compiler this time.

T-types

  • No P-critical issues for T-types this time.

P-high regressions

P-high beta regressions

  • No P-high beta regressions this time.

Unassigned P-high nightly regressions

  • No unassigned P-high nightly regressions this time.

Performance logs

triage logs 2024-07-25

Light week, with few changes on any dimension (including memory), though
overall a slight regression.

Triage done by @simulacrum.
Revision range: 5572759b..9629b90b

Summary:

(instructions:u) mean range count
Regressions (primary) 0.4% [0.2%, 0.8%] 6
Regressions (secondary) 1.3% [0.2%, 7.3%] 13
Improvements (primary) -0.7% [-0.9%, -0.5%] 6
Improvements (secondary) - - 0
All (primary) -0.1% [-0.9%, 0.8%] 12

1 Regression, 1 Improvement, 1 Mixed; 2 of them in rollups
34 artifact comparisons made in total

Regressions

Rollup of 8 pull requests #127865 (Comparison Link)

(instructions:u) mean range count
Regressions (primary) 0.6% [0.4%, 0.7%] 4
Regressions (secondary) 1.1% [0.6%, 2.1%] 7
Improvements (primary) - - 0
Improvements (secondary) - - 0
All (primary) 0.6% [0.4%, 0.7%] 4

Clear regression, though contributing PR from the rollup is not clear. Started
a build to try to dig deeper.

Improvements

Represent type-level consts with new-and-improved hir::ConstArg #125915 (Comparison Link)

(instructions:u) mean range count
Regressions (primary) - - 0
Regressions (secondary) - - 0
Improvements (primary) -0.6% [-0.8%, -0.5%] 6
Improvements (secondary) - - 0
All (primary) -0.6% [-0.8%, -0.5%] 6

Mixed

Rollup of 9 pull requests #127998 (Comparison Link)

(instructions:u) mean range count
Regressions (primary) 0.3% [0.3%, 0.3%] 2
Regressions (secondary) 1.3% [1.3%, 1.3%] 1
Improvements (primary) -0.7% [-0.7%, -0.7%] 1
Improvements (secondary) - - 0
All (primary) -0.1% [-0.7%, 0.3%] 3

Clear regression, though contributing PR from the rollup is not clear. Started
a build to try to dig deeper.

Nominated Issues

T-compiler

  • "Async drop codegen" rust#123948
    • Nominated by @oli in comment: asking for someone else with enough context to take over the review.

RFC

  • No I-compiler-nominated RFCs this time.

Oldest PRs waiting for review

T-compiler

  • "Apply dllimport in ThinLTO for -Z dylib-lto" rust#122790 (last review activity: 4 months ago)
    • cc: @Wesley Wiser
  • "Issue 83060 fix" rust#119798 (last review activity: 3 months ago)
    • cc @Wesley Wiser
  • "Implement a lint for implicit autoref of raw pointer dereference - take 2" rust#123239 (last review activity: about 57 days ago)
    • cc: @León Orell Liehr (fmease) (?)
  • "Improve unconstrained impl diagnostic (fixes #107295)" rust#126026 (last review activity: about 49 days ago)
    • cc @León Orell Liehr (fmease) (+ pending a rebase from author)
  • "Silence errors in expressions caused by bare traits in paths in 2021 edition" rust#125784 (last review activity: about 48 days ago)
    • cc @León Orell Liehr (fmease)

Next week's WG checkins

None

Next meetings' agenda draft: hackmd link

Select a repo