Gluster maintainer meeting notes

# Gluster maintainer meeting notes ----- ## Meeting date: 2019-03-04 18:30 IST, 13:00 UTC, 08:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 ### Attendees * Aravinda, Sunny, MohitAgarwal, Amar, Deepshika ### Agenda #### release-6: * Did we get any further with 'upgrade' testing? - https://bugzilla.redhat.com/show_bug.cgi?id=glusterfs-6.0 - Testing revealed 2 major upgrade issues, 1 more bug needs to be RCA'd to figure out whether it is blocker or not. - As high as 10 bugs added to tracker, good to give it more time. * Path based geo-replication: - design shared by Aravinda [Add link] - need review comments * Experimental periodic is currently disabled - gbench testing is in progress * Performance testing: Any further updates? As of now, it looks like master is on-par with 3.12 with default options. * Next Gluster meetup should be announced. - Can we record the sessions? - Workshop was requested in previous meetup - Think how to reach wider / more global audience. * GCS - One more PR required to take brick-host path as argument. * Round Table - [Mohit] io-threads data generation is pending, would be done after glusterfs-6 upgrade blockers. - How about just having 1 gluster meetup (both for maintainers and community) bi-weekly? - Looks good, need to propose it in mailing list. - How about Having a roadmap discussion for future releases after release-6 ? - The first meeting could be roadmap discussion. - [Aravinda] It may need more time, mainly to have proposal ready, it to be validated, and then we can discuss it in meeting. - May be a month proposal heads-up time is good. ----- ## Meeting date: 2019-02-04 18:30 IST, 13:00 UTC, 08:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/37SS6/ ### Attendance * Nigel Babu * Sunil Heggodu * Amar Tumballi * Aravinda VK * Atin Mukherjee ### Agenda * Gluster Performance Runs (on Master): - Some regression since 3.12 compared to current master. - Few operations had major regresions. - Entry serialization (SDFS) feature caused regression. We have disable it by default, plan to ask users to turn it on for edge cases. - Some patches are currently being reviewed for perf improvements which are not enabled by default. - See [Xavi's email for perf improvements](https://lists.gluster.org/pipermail/gluster-devel/2019-January/055807.html) in self-heal. This can cause some regression on sequential IO. - [Nigel]Can we publish posts on 3.12 perf and our machine specs. Then we can do a follow up post after 6 release. - Yes. This is a release highlight that we want to talk about. * GlusterFS 6.0 branching: - upgrade tests, specially with some removed volume types and options. - [Atin] I've started testing some of the upgrade tests (glusterfs-5 to latest master), have some observations around some of the tiering related options which are leading to peer rejection issue post upgrade, we need changes to avoid the peer rejection failures. GlusterD team will focus on this testing in coming days. - performance patches - Discussed earlier - shd-mux - [Atin] Shyam highlighted concern in accepting this big change such late and near to branching timelines, so most likely not going to make into 6.0. - A risk because of the timeline. We will currently keep testing it on master and once stable we could do an exception to merge it to release-6 - The changes are glusterd heavy, so we want to make sure it's thoroughly tested so we don't cause regressions. * GCS - v1.0 - Can we announce it, yet? - [Atin] Hit a blocker issue in GD2, https://github.com/gluster/gcs/issues/129 , root cause is in progress. Testing of https://github.com/gluster/gcs/pull/130 is blocked because of this. We are still postive to nail this down by tomorrow and call out GCS 1.0 by tomorrow. - GCS has a website now - https://gluster.github.io/gcs/ Contribute by sending patches to the gh-pages branch on github.com/gluster/gcs repo. - What does it take to run the containers from Gluster (CSI/GD2 etc) on ARM architecture host machines? - It should theoretically work given Gluster has been known to work on ARM. And we know that k8s on ARM is something that people do. - Might be useful to kick it off on a Raspberry pi and see what breaks. * We need more content on website, and in general on internet. How to motivate developers to write blogs? - New theme is proposed for upstream documentation via the pull request https://github.com/gluster/glusterdocs/pull/454 - Test website: https://my-doc-sunil.readthedocs.io/en/latest/ * Round Table: - **Nigel**: AWS migration will happen this week and regressions will be a little flakey. Please bear with us. ----- ## Meeting date: 2019-01-21 18:30 IST, 13:00 UTC, 08:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/PAnE5 ### Attendance * Nigel Babu, Amar, Nithya, Shyam, Sunny, Milind (joined late). ### Agenda * GlusterFS - **v6.0** - Are we ready for branching? - Can we consider getting https://review.gluster.org/20636 (lock free thread pool) as an option in the code, so we can have it? - Lets try to keep it as an option, and backport it, if not ready by end of this week. - Fencing? - Most probable to make it. - python3 support for glusterfind - https://review.gluster.org/#/c/glusterfs/+/21845/ - Self-heal daemon multiplexing? - Reflink? - Any other performance enhancements? * Infra Updates * Moving to new cloud vendor this week. Expect some flakiness. This is on a timeline we do not control and already quite significantly delayed. * Going to delete old master builds from http://artifacts.ci.centos.org/gluster/nightly/ * Not deleting the release branch artifacts. * Performance regression test bed - Have machines, can we get started with bare minimum tests - All we need is the result to be out in public - Basic tests are present. Some more test failures, so resolving that should be good enough. - Will be picked up after above changes. - * Round Table - Have a look at website and suggest what more is required. - ----- ## Meeting date: 2019-01-07 18:30 IST, 13:00 UTC, 08:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/sGFpa ### Attendance ### Agenda * Welcome 2019: New goals / Discuss: - https://hackmd.io/OiQId65pStuBa_BPPazcmA - Give it a week and take it to mailing list, discuss and agree upon - [Nigel] Some of the above points are threads of its own. May need separate thread. * Progress with GCS - Email about GCS in community. - RWX: - Scale testing showing GD2 can scale to 1000s of PVs (each is a gluster volume) - Bricks with LVM - Some delete issues seen, specially with LV command scale. Patch sent. - Create rate: 500 PVs / 12mins - More details by end of the week, including delete numbers. - RWO: - new CSI for gluster-block showing good scale numbers, which is reaching higher than current 1k RWO PV per cluster, but need to iron out few things. (https://github.com/gluster/gluster-csi-driver/pull/105) - 280 pods in 3 hosts, 1-1 Pod->PV ratio: leaner graph. - 1080 PVs with 1-12 ratio on 3 machines - Working on 3000+ PVC on just 3 hosts, will update by another 2 days. - Poornima is coming up with steps and details about the PR/version used etc. * Static Analyzers: - glusterfs: - Coverity - 63 open - https://scan.coverity.com/projects/gluster-glusterfs?tab=overview - clang-scan - 32 open - https://build.gluster.org/job/clang-scan/lastCompletedBuild/clangScanBuildBugs/ - gluster-block: - https://scan.coverity.com/projects/gluster-gluster-block?tab=overview - coverity: 1 open (66 last week) * GlusterFS-6: - Any priority review needed? - Fencing patches - Reducing threads (GH Issue: 475) - glfs-api statx patches [merged] - What are the critical areas need focus? - Asan Build ? Currently not green - Some java errors, machine offline. Need to look into this. - How to make glusto automated tests become blocker for the release? - Upgrade tests, need to start early. - Schedule as called out in the [mail](https://lists.gluster.org/pipermail/gluster-devel/2018-December/055721.html) **NOTE:** Working backwards on the schedule, here's what we have: - Announcement: Week of Mar 4th, 2019 - GA tagging: Mar-01-2019 - RC1: On demand before GA - RC0: Feb-04-2019 - Late features cut-off: **Week of Jan-21st, 2018** - Branching (feature cutoff date): **Jan-14-2018** (~45 days prior to branching) - Feature/scope proposal for the release (end date): **Dec-12-2018** * Round Table? - [Sunny] Meetup in BLR this weekend. Please do come (at least those who are in BLR) - [Susant] Softserve has 4hrs timeout, which can't get full regression cycle. Can we get at least 2 more hours added, so full regression can be run. - ================= ## Meeting date: 2018-12-10 Meeting canceled due to lack of quorum. ## Meeting date: 2018-11-12, 18:30 IST, 13:00 UTC, 08:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/CDuce ### Attendance * Amar * Kaleb * Nithya * Nigel * Deepshikha * Rafi * Vijay ### Agenda * AI from previous week - Emails on timelines of GlusterFS6 - DONE * Automatically close bugs with CLOSED->NEXT_RELEASE instead of MODIFIED state. - MODIFIED state makes sense for a product, which would then go with ON_QA status, with a dedicated team testing bugs, etc. - Considering that on upstream patches, there are no active testing effort, makes sense to move the bug to NEXT_RELEASE status. - Helps in keeping 'time-to-close' record properly. - More on it @ [Maintainer's ML](https://lists.gluster.org/pipermail/maintainers/2018-November/005252.html)... check full conversation @ [archive](https://lists.gluster.org/pipermail/maintainers/2018-November/) - AI: Raise an infra bug to get this implemented. * Handling Github links on specs repo * Slightly tricky since we tend to not spam other repos with bot comments. * specs repo does not have an issue tracker. * Ideally spec should be approved and at that point there will be an external tracker reference. * AI: send email in ML, default closure is when merged, patch will take action acording to github commit. (like fixes: gluster/glusterfs#NNN etc.) * GlusterFS-6 : Anything more to add? - Discussion @ https://hackmd.io/sP5GsZ-uQpqnmGZmFKuWIg - How to use removed xlators in future? Will there be any experimentation at all? - All the removed xlators would be available in another repository, and would be provided with a RPM for users, every release. - Users can get them in the volume graph using GD2, as it now supports template based volfile generation. - VDSM had concerns about versioning scheme - AI: Need to understand more about version dependency. - Understanding is that, not every project picks `<latest>` tag, but picks `<major>.latest` tag. - There is a need to understand how different projects are dependent on Gluster, and what are the nature of these dependencies. - ASan: Start picking the tests from beginning. - GD2 : Will it ever be default? - Needs to get tests running against it first to consider the proposal. - GCS is a good candidate to get GD2 out of the way. - Should Aravinda's effort be revived? It can fail initially, but putting effort there would get us started on this. - Should we consider handling it like Glusto, where they are making changes in library level, and FS tests remain same. * GCS Status update: - Automated builds for CSI driver, updates. - Gluster Prometheus is now part of GCS. - Gluster-block is TBD * Round table: - All good! ----- ## Meeting date: 2018-10-29, 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/zH9eH ### Attendance * Nigel, Kaleb, Nithya, Shyam, Amar, Raghavendra Bhat, Atin, Sunny, Vijay Bellur, Vijay Baskar ### Agenda * AI from previous week? * [Nigel] Status of glusterfs-selinux * Currently waiting for it to be tested by our friends in QE. * * GlusterFS 6 ? - What to focus? - Draft @ https://hackmd.io/sP5GsZ-uQpqnmGZmFKuWIg - Need people to focus on this. - Can we also estimate time and dependencies - This is a good time to fix a lot of infra that Gluster uses. - Getting things to completion is more important than doing all the items in the list. - We should pick what we can finish. - The infra is ready - the xlator stack etc. But these are not useful unless used. ---- ## Meeting date: 2018-10-15, 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: ### Attendance * Nigel * Nithya * Deepshikha * Akarsha * Kaleb * Shyam * Sunny ### Agenda * AI from previous meeting: - Glusto-Test completion on release-5 branch - On Glusto team - Vijay will take this on. - He will be focusing it on next week. - Glusto for 5 may not be happening before release, but we'll do it right after release it looks like. - Discussion on (going to be) Deprecated features for Glusto - [Amar/VijayBaskar] - Not happened - Release 6 Scope - Will be sending out an email today/tomorrow for scope of release 6. - Send a biweekly email with focus on glusterfs release focus areas. - GCS scope into release-6 scope and get issues marked against the same - For release-6 we want a thinner stack. This means we'd be removing xlators from the code that Amar has already sent an email about. - Locking support for gluster-block. Design still WIP. One of the big ticket items that should make it to release 6. Includes reflink support and enough locking support to ensure snapshots are consistent. - GD1 vs GD2. We've been talking about it since release-4.0. We need to call this out and understand if we will have GD2 as default. This is call out for a plan for when we want to make this transition. - Round Table - [Nigel] Mimimum build and CI health for all projects (including sub-projects). - This was primarily driven for GCS - But, we need this even otherwise to sustain quality of projects - AI: Call out on lists around release 6 scope, with a possilble list of sub-projects - [Kaleb] SELinux package status - Waiting on testing to understand if this is done right - Can be released when required, as it is a separate package - Release-5 the SELinux policies are with Fedora packages - Need to coordinate with Fedora release, as content is in 2 packages - AI: Nigel to follow up and get updates by the next meeting ---- ## Meeting date: 2018-10-01, 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/eNNfZ ### Attendance * Jonathan (loadtheacc), Vijay Baskar, Amar Tumballi, Deepshikha, Raghavendra Bhat, Shyam, Kaleb, Akarsha Rai, ### Agenda * AI from previous week - Status check on bi-weekly Bugzilla/Github issues tracker ? Any progress? - Glusto Status and update? * [added by sankarshan; possibly requires Glusto and Glusto-test maintainers] Status of Test Automation * * Glusto and tests updates: - Glusto focus in Py3 port, alpha/beta branch for py3 possibly by next week, around 75% complete (ball park) - client and server need to be the same version of py (2 or 3) - Documentation and minor tweaks/polishing work - New feature in py3 would be the log format, would be configurable - Couple of issues: - scandir needing gcc, fixed upstream for this issue - [cartplex](https://github.com/loadtheaccumulator/glusto/commit/b4874812886d3727a800111ad6b5579860d56f72) - Glusto tests: - Priority is fixing the test cases, that are failing to get Glusto passing upstream - When running the tests as a suite, some tests are failing due to cleanup not correct in all test cases - Working on the above on a per component basis - Next up is py2->3, currently blocked on Glusto for some parts, certain other parts like IO modules are ported to py3 - Post Glusto, porting of tests would take 2 months - Next: GD2 libraries, target Dec. to complete the work - Testing Glusto against release-5: - Can we run against RC0 for release-5? - Requires a setup, can we use the same setup used by the Glusto-tests team? - AI: Glusto-tests team to run against release-5 and help provide results to the lists - Some components are being deprecated, so priorotization of correcting tests per component can leverage the same - AI: Vijay to sync with Amar on the list - Can we port Glusto and tests in parallel? - Interface to Gluto remains the same, and hence the port can start in parallel, but cannot run till Glusto port is ready, but first cut Glusto should be available in week, so work can start. * Release 5: - Py3 patches need to be accomodated - Needs backports from master - noatime needs to be merged - gbench initial runs complete (using CentOS packages) - glusto, upgrade tests, release notes pending - Regression nightly issue handled on Friday, need to check health - Mid-Oct release looks feasible as of now, with an RC1 by end of this week or Monday next week * GD2 release: - Can there be a production release, which just supports volume and peer life-cycle, but no features? - This may get us more users trying out, and giving feedback. - Not every users are using all the glusterd features like geo-rep, snapshot or quota. - Can we take it 1 step at a time, and treat it as a new project, and not a replacement ? - Ref: [gluster-user email on gd2 status](https://lists.gluster.org/pipermail//gluster-users/2018-October/035012.html). - AI: Take the discussion to mailing list - [Vijay] If we make it as separate releases, will it impact release of GCS? - [Amar] I don't think so, it would be more milestones for the project, instead of just 1 big goal. * Distributed-regression testing: - A few of the test is taking more time then expected. - One of them is `tests/bugs/index/bug-1559004-EMLINK-handling.t` is taking around 14 mins which adds up the overall time of running test suite (not just in distributed environment but also in centos7-regression). - Author of test or maintainer needs to look at it. * New Peer/Maintainers proposals ? * Round Table - [Kaleb] CVE in golang packages, so we need to update the bundle of GD2. --- ## Meeting date: 09/17/2018 (Sept 17th, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/MI4xY ### Attendance * ~~misc, ndevos(added few points to 'Version 5 Status)~~, * Nigel, Amar, Nithya, Raghavendra Bhat, Shyam, Kaushal, Pranith, Sunny ### Agenda * AI from previous week: - clang-format: Finally complete - Need to rebase patches - One best way is to submit it with basic changes, and clang-formatter job suggests the right patch to apply, and use that to get the final patch. - Talk to Nigel/Infra team if you are blocked on rebasing the existing patch. He wants to understand what are the problems, and hs, and how he can help. - [Shyam]: - Any feedbacks? - Use email list - Use [bz#564149](https://bugzilla.redhat.com/show_bug.cgi?id=1564149) * GCS Status: - Deploy scripts mostly working fine: https://github.com/kshlm/gd2-k8s - Few more patches required in GD2. - Whats the major difference between gluster-k8s and this? - Where to send the PR ? - Plan is to send it to GCS, as the plan is to get more issues and discussions, along with documentation on that repo. - k8s is initial focus, openshift origin would be future focus. - * Version 5 Status - Goal: Stability release - GD2 tagging is not done! - Pending on GCS dependant patches to get merged! - Branching done! - RC0 Tagging today (post cleanup patches are merged) - Need to get some cadence on testing release branches [Shyam] - Infra bug for release dash (regression and mux to start with) - Glusto with FUSE - Gbench - More ideas welcome! - PR to add release-5 to Jenking jobs ([centosci#19](https://github.com/gluster/centosci/pull/19)) - preparations for CentOS Storage SIG - seeding of dependencies ([cbs](https://cbs.centos.org/koji/builds?tagID=1621)) - centos-release-gluster5 package with YUM .repo file ([cbs](https://cbs.centos.org/koji/packageinfo?packageID=7242)) - repository sync for testing has been requested ([req#15282](https://bugs.centos.org/view.php?id=15282)) - Release and options notes/documentations to start [Shyam] * Triaging: - [~1050 Bugs](https://bugzilla.redhat.com/report.cgi?x_axis_field=bug_status&y_axis_field=version&z_axis_field=&no_redirect=1&query_format=report-table&short_desc_type=allwordssubstr&short_desc=&classification=Community&product=GlusterFS&bug_status=NEW&bug_status=ASSIGNED&bug_status=POST&bug_status=MODIFIED&bug_status=ON_DEV&bug_status=ON_QA&bug_status=VERIFIED&bug_status=RELEASE_PENDING&longdesc_type=allwordssubstr&longdesc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&deadlinefrom=&deadlineto=&bug_id=&bug_id_type=anyexact&votes=&votes_type=greaterthaneq&emailtype1=substring&email1=&emailtype2=substring&email2=&emailtype3=substring&email3=&chfieldvalue=&chfieldfrom=&chfieldto=Now&j_top=AND&f1=noop&o1=noop&v1=&format=table&action=wrap) (111 on 3.12, ~50 on 4.1, and 850+ on mainline) - ~400 MODIFIED on master (may be it gets closed on v5.0 release) - Everyone having a look on components and resolving would help. - On a glance, at least 50+ RFEs still open in Bugzilla from old time. - Use component-wise health status, and present it back to RHT programs. - AI: Nigel to volunteer to see how the status check helps. Shyam to help Nigel as a buddy in this effort. - Look at tools to see most of these issues. Understand the volume, see what is the effort needed. - 261 Open [Github Issues](https://github.com/gluster/glusterfs/issues) * New Peer/Maintainers proposals: - Sunny to Snapshot - Shubendu Tripati for gluster-prometheus - * Round Table * [Nigel] Can we have a section in this meeting every month to propose new maintainers/peers? We seem to be quite hesistant to add new folks (Shout out to Kruthika for adding Xavi). - Raghavenra Bhat sent one more patch for adding Sunny (to Snapshot). * [Shyam] Discuss "Lock down period merge process" mail [thread](https://lists.gluster.org/pipermail/maintainers/2018-September/004991.html) * Should we block at a component level or at a project level * Components are not tightly decoupled, hence allowing merges in other parts can make getting to stability harder [Nigel, Shyam] * Also, requesting at component level goes towards "good faith" approach than tooling and process approach, so not a direction we want to go with as a project. --------- ## Meeting date: 09/03/2018 (Sept 3rd, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Watch: https://bluejeans.com/s/2fxMI ### Attendance * Sunny, Amar, Atin, Pranith, Milind, Rafi * ~~Calendar Declines: Nithya, Shyam,~~ * ### Agenda * AI from previous week: - Tests GREEN: First successful nightly on Sept 1st - https://build.gluster.org/job/nightly-master/ - clang-format: Update email Sent, plan is to finish this, this week. * Coverity: - We are @ 250 or less, started with 500 last month. - How to check the total defects per components - Go down the [overview page](https://scan.coverity.com/projects/gluster-glusterfs?tab=overview), which has graphs. * Reviews: - Significant number of patches pending review, would appreciate everyone's contribution here. * Round Table: - [Atin] - Observation about log files, there are many logs in master, which are not necessary! - Is these logs same as the few fixed in https://review.gluster.org/#/c/glusterfs/+/19989/ ? - [Atin] Not these, there are more logs in glusterd. Planning to send an email on gluster-devel. - [Milind] Selinux work almost finished. Still need to figure out how to build in Fedora Repo. - [Pranith] Looked at Coverity, would pick it up next for AFR - [Amar] recommends others fixing it, and you and team reviewing it, instead. ----- ## Meeting date: 08/20/2018 (August 20th, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Download: https://bluejeans.com/s/IVExy ### Attendance * Nithya, Amar, Nigel, Sunny, Ravi, Kaleb, kshlm, Raghavendra M, Shyam (Partial) * ~~Calendar Declines: ppai~~ * ### Agenda * Master lockdown, and other stability initiatives - Where do we stand? - [Amar] Everything looks good at this point. Not as many random failures as there used to be. - What needs further attention? - There are still some random failures on brick-mux regression. - Any metrics? - [Atin] https://fstat.gluster.org/summary?start_date=2018-08-13&end_date=2018-08-20 - tracks the failures reported since master lock down is revoked. - [Atin] Overall, things look much more stable after a bunch of test fixes being worked on during this lock down. - c7 nightly had reported green 5 out of 7 times, 1 failed with some core (https://lists.gluster.org/pipermail/gluster-devel/2018-August/055298.html), 18th August's run seem to hit n/w failure. - brick mux nightly had seen couple of issues since last week, 1. crash from tests/basic/ec/ec-5-2.t & 2. spurious failure from tests/bugs/replicate/bug-1586020-mark-dirty-for-entry-txn-on-quorum-failure.t. (fix posted) - line-cov nightly had failed once in tests/bugs/replicate/bug-1586020-mark-dirty-for-entry-txn-on-quorum-failure.t (fix posted) * Outstanding review queue is quite long, need review attention. * Maintainers keep track of their lanes and how many patches are pending. * v5.0 branching - Can we get all the features completed by today?? - What are the features we're targetting for this release? Github doesn't give a clear picture. This is a problem. - Will this release be just a stability release? - There is nothing wrong in calling it a stability release. - If there are no features, and as we are still working on coverity, clang and other code coverage initiatives, should we delay the branching? - If we're calling this a stability release, perhaps we should look into memory leaks that have been reported on the lists already. - What about clang-formatter? Planned [email content here](https://hackmd.io/sP5GsZ-uQpqnmGZmFKuWIg?view) - Around branching point is the time to get this done. - The messaging around "personal preference" for style vs "project preference" needs to be clear. - [Nigel] Still need to see the content, and give the proper set of tasks. - 2 options: - 1. Big change where we can change all files, and make currently posted patches conflict. - 2. Or make user change the file he touches with clang format. - Precommit hook Vs Server side change. - problem with git review, or git push directly. We need a smoke job for sure. - Should we force everyone to install clang? Make it optional for user. - AI on Amar for giving a date for this activity completion, by EOD 21st August, 2018. - [Kaleb] what is the status of python3? (fedora 29(?) and rhel8 are looming.) - Seemingly, we're not 100% [python3 ready](https://lists.gluster.org/pipermail/gluster-devel/2018-August/055216.html). There are bugs that need fixing. - Ship with Python3 and we'll fix the bugs as we find them. - Let's change all the shebangs to python3. * GCS: - Any updates? - CSI driver under review - https://github.com/gluster/gluster-csi-driver/pull/11 - We can land the patch and fix the license later too. - Good to go ahead and merge, and then get the followup patches, it would move things faster. - Kaushal to review Madhu's changes on top of the PR, and if things look OK, then we can merge the PR. - GD2 + Gluster nightly container image - https://hub.docker.com/r/gluster/glusterd2-nightly/ - https://github.com/gluster/glusterd2/tree/master/extras/nightly-container - Build pipeline - in progress. Waiting on infra to have all the deps installed. - Deployment script in-progress * Mountpoint - Presentations ready? - All set for travel? - Some delays with Visa arrival, few maintainers who were supposed to travel from India will be confirming only by end of the week. * Round Table - [Amar] Can we disable bd (block-device) translator from the build/code? No users raised concerns over it on deprecation email. This resolves many issues on coverity/gcc8/clang etc. - Generally, yes - [Nigel] Who owns glusterfsd folder? Could not find a module or owner in maintainers file. Right now tracked as "other" in Coverity. - Generally the same set who are part of 'libglusterfs?' - [Kaleb] what is the status of the selinux package? - Repo created, no more updates ever since. - AI: Milind to update the status. Latest known status is spec file being written. - [Nigel] Glusto test runs and failures - We need more dev involvement to help debug test failures. More in the next meeting. - Focused components should pass for sure. - AI: Make a list of components ----- ## Meeting date: 08/06/2018 (August 06th, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Download: ### Attendance * <Add your name> ### Agenda * AIs from previous meeting - None * Master lockdown - Randomly tests are failing. Need immediate fixes - No more patches without getting all the tests to GREEN - ie, fixes to pass the tests are the ones which will go through merging. - Use the proposal of deprecating of few features to take 'priority' decisions on if a test is really needed. * Focus on 'stability' - No major features coming out of Red Hat engineering, and focus is on stability of the project. - Initially, gcc8, coverity, regression and brick-mux tests, along with line coverage. - Let Infra team know all your needs for stability through bugzilla, so it can be tracked. * GCS - Email sent, repo created. - All discussions on GCS to happen on https://github.com/gluster/gcs/issues - More details on how everyone can track progress in another week - AI: * Round Table - <Everyone gets a chance to talk> - ----- ## Meeting date: 07/23/2018 (July 23rd, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Download: https://bluejeans.com/s/qGMqd ### Attendance * Amar, Kaleb, Nigel, Ravi, Vijay, Shyam, Rafi, Nithya, Kaushal, Pranith ### Agenda * AI from previous meetings: - AI-1: Python3/Python2 discussion, take it to closure: - We now have agreed upon how it all looks. - Will be running tests on Fedora 28 for python3, and CentOS for Python2 - AI: Shyam to update release notes - DONE - AI-2: Coding Standard - Clang format - All set to do it this week. - There is more work on coding standard agreement. - AI: Amar to send a proposal on going live * [Documentation Hackathon](https://bit.ly/gluster-doc-hack): - Review help needed: http://bit.ly/gluster-doc-hack-report - Help more, fix your component. - Hold another hackathon with more advance notice * Coding Standard: - Need to improve the [existing coding standard properly](https://github.com/gluster/glusterfs/blob/master/doc/developer-guide/coding-standard.md), and point it clearly in developer document. - For example, one point added here: https://review.gluster.org/20540 - More suggestions welcome * Commit message: - While there is a standard we 'try' to follow, it is not enforced. Can we try to get it documented? - Sample [here @ github](https://github.com/gluster/glusterfs/blob/master/doc/developer-guide/coding-standard.md). Review [it in Gerrit](https://review.gluster.org/20541). - Can we bring back the gerrit URL to commit messages? There is a wealth of information and review comments captured there and going back to see the discussions later on is becoming a pain point. - One way to get that is by using notes in a local repo : https://gerrit.googlesource.com/plugins/reviewnotes/+/master/src/main/resources/Documentation/refs-notes-review.md - Also, in the repo do `git config notes.displayRef notes/ref` after setting up the notes remote. * Infrastructure: - Now the regression failure output comes in Gerrit itself, hence please check the reason for failure before re-triggerring regression. * Emails on Feature classification & Sunset of few features: - Have a look @ [Proposal for deprecation](https://lists.gluster.org/pipermail/gluster-devel/2018-July/054990.html) and [Classification of Features](https://lists.gluster.org/pipermail/gluster-devel/2018-July/054998.html) emails. * What happens to tests when we sunset components? * We will tag tests that map to components that we don't support anymore. * We will no longer run tests that are not relevant to releases anymore. * What is the difference between sunset and deprecated? * We seem to be using them with opposite meanings that other projects use. * Sunset - We will remove it in the future. * Deprecated - We are going to remove it in the next release - Add anything more missing into the emails. Or even your thoughts. * [Mountpoint.IO](https://mountpoint.io/) - Who all are attending? - kshlm (visa dependent) - nigelb (depends on visa) - amarts (depends on visa) - gobinda Das (depends on visa) * Release **v5.0** - Have you tagged the feature you are working on, for next release? - Feature tagging and a post on devel list about proposed features would be awesome! * Status update from other projects? - GlusterD2 - Focus on GCS - Automatic volume provisoning is in alpha state - Ongoing work on transacation framework, snapshots etc. - NFS-Ganesha - Upcoming Bakeathon in September - storahug being integrated with gd2? * Round Table: - Kaleb: Coverity tool updated to 2018-06, 50 more defects observed - Possible move back to gerrit for gd2 reviews ### Decisions --- ## Meeting date: 07/09/2018 (July 09th, 2018), 18:30 IST, 13:00 UTC, 09:00 EDT ### BJ Link * Bridge: https://bluejeans.com/217609845 * Download: https://bluejeans.com/s/FC2Qi ### Attendance * Sorry Note: Ravi, NigelBabu, ndevos, * Nithya, Xavi, Rafi, Susant, Raghavendra Bhat, Amar, Deepshika, Csaba, Atin, ppai, Sachi, Hari. ### Agenda * Python3 migration: - Some confusion existed about Py2 support in RHEL etc. Should we bother? - [Amar] For upstream, focusing on just 1 version is good, and confusion less. Downstream projects can decide for themselves about how to handle the project, when they ship it. - [ndevos] Maybe we need to decide which distributions/versions we want to offer to our users? Many run on CentOS-7 and there is no reasonable way to include Python3 there. I assume other commonly used stable distributions (Debian, Ubuntu?) are also lacking Python3. - [Atin] Are we not supporting python2 at all? What are the patches intended to? - [ppai] Code is mostly py2 and py3 compatible. The issue is with #! line, where we have to have specific python2 or python3. Fedora mandates it to be one of it. - [Atin] My vote would be to go for both py2 & py3 compatibility and figure out a way how to handle builds? - [Amar] Need a guidelines about how to handle existing code Vs reviewing new code into the repository. - [ppai] Many companies are moving towards new project being python3 only, where as supporting py2 for existing projects. - [AI] Amar to respond to Nigel's email, and plan to take to completion soon. - If we go with only python3, what is the work pending? - What are the automated validation tests needed? Are we good there? * Infra: Update on where are we. - Distributed tests - [Deepshika] jobs are running, figuring out issues as we run tests. - Need to increase the disk storage. - Coding Standard as pre-commit hook (clang) - In progress, need to finalize the config file. - AI: all gets 1 week to finalize config. - shellcheck? - [Sac] shellcheck is good enough! Does check for unused variable etc. - Anything else? * Failing regression: - tests/bugs/core/bug-1432542-mpx-restart-crash.t - consistently failing now. Need to address ASAP. Even if it takes disabling it. - It is an important feature, but not default in the project yet, hence should it be blocking all the 10-15 patches now? - Mohit/Xavi's patches seems to solve the issue, is it just fine for all the pending patches? - [Atin] We should try to invest some time to figure out why the cleanup is taking more time. - [Xavi] noticed that selinux is taking more time (semanage). Mostly because there are many volumes. - [Deepshika] I saw it takes lot of memory, is that a concern? - [Atin] It creates 120 volumes, so expected to take more than 1GB memory, easily. - [Nithya] Do we need so many volumes for regression? - [Atin] Looks like we can reduce it a bit. - tests/00-geo-rep/georep-basic-dr-rsync.t - Test itself passes, but generates CORE. Doesnt' happen always. - Not a geo-rep issue. The crash is in cleanup path, in gf_msg() path. - Any other tests? * Round Table - <Everyone gets to talk/make a point> - [Atin] - Timing works great for me. - [Csaba] - all good - [Deepshika] - all good - [Nithya] - Anyone triaging upstream BZs? - Most like not happening. - [ppai] -all good ### Decision(s)? * <If any decision is taken, note it down> ----- ## Meeting date: 05/02/2018 (May 02nd, 2018), 19:30 IST, 14:00 UTC, 10:00 EDT ### BJ Link * Bridge: https://bluejeans.com/205933580 * Download: https://bluejeans.com/s/fPavr ### Attendance * Raghavendra M (Raghavendra Bhat), Kaleb, Atin, Amar, Nithya, Rafi, Shyam ### Agenda * Commitment (GPLv2 Cure) - [Email](http://lists.gluster.org/pipermail/gluster-devel/2018-April/054751.html) and [Patch](https://review.gluster.org/19902) - [amarts] 20+ people already have done +1. Will wait another 15days before any action on this. - AI: Send a reminder to the lists and get the changes merged around next maintainers meeting [Amar] * GD2 testing upstream - Is there a glusterd v1 Vs v2 parity check matrix? - Functional parity of the CLI - As the cli format is not 100% compatible, how to proceed further with regression tests without much fuss? - [amarts] Easier option is to handle it similar to brick-mux test. Create a new directory 'tests2/' which is copy of current tests, and files changed as per glusterd2/glustercli needs. We can do bulk replace etc etc... start small, make incremental progress. Run it once a day. - Add smoke check for core glusterfs to keep things working with GD2 - Add GD2 tests into the said patch, to ensure functionality of GD2 itself - Approach ack: Shyam - Approach nack: * Coding standards - Did we come to conclusion? What next? - Need some more votes to take it forward - Settle current conflicts to the settings - [amarts] Need to see what should be 'deadline' for this. Ideal to have before 4.1, or else backporting would be serious problem. - AI: Reminder mail on release to get this closed [Shyam] - Conversion work should be doable in 1/2 a day - Per-patch format auto-verifier/correction job readiness - Possibly not ready during roll-out - Not looking at it as the blocker, as we can get it within a week and sanitize patches that were merged in that week [Shyam] * Branching for 4.1? - Today would be branching date [Shyam] - No time to fold slipping features, as we are 2 weeks off already! - Branching is on 4th May, 2018, what makes it gets in, rest is pushed to 4.2 - Leases? - Ctime? - Thin-Arbiter? - <Any other features>? * Round Robin: - [amarts] - Is the plan for version change (or not change) ready after 4.1? or do we need to extend the period for this? - AI: Send proposal to devel -> users and take action on getting this done before 4.2 - Fold in xlator maturity states into the same release - [kkeithley] - new (untriaged) upstream bugs list is getting longer. - Triage beyond assignment - Tracking fixes and closure of the same - AI: Shyam to work on this and next steps ### Decisions and Actions - AI (GPL cure): Send a reminder to the lists and get the changes merged around next maintainers meeting [Amar] - Decision: GD2 tests to create a patch of tests and work on it using nightly runs to get GD2 integrated - AI (format conversion): Reminder mail on release to get this closed [Shyam] - AI (format conversion): Conversion done Thursday, ready for merge Friday [Amar/Nigel] - Decision (4.1 branching): 4.1 branching date set at 4th May, no feature slips allowed beyond that [Shyam] - AI (release cadence and version numbers change): Send proposal to devel -> users and take action on getting this done before 4.2 [Shyam] - AI (Bugs triage cadence): Shyam to work on this and next steps [Shyam] ---- ## Meeting date: 04/18/2018 (April 18th, 2018), 19:30 IST, 14:00 UTC, 10:00 EDT ### BJ Link * Bridge: https://bluejeans.com/205933580 * Download: https://bluejeans.com/s/qjebZ ### Attendance * Nigel * Hari * Nithya * Kotresh * Raghavendra M * Shyam * Milind * Sorry Note: ndevos (travelling), kkeithle, amarts ### Agenda * Format change proposal: - [Check the bug](https://bugzilla.redhat.com/show_bug.cgi?id=1564149) - Provide feedbacks * We want to do a big bang format change with clang-format. * Which format should we start with as base? Google/LLVM/Mozilla/Webkit/Chromium * [Samples present in repo](https://github.com/nigelbabu/clang-format-sample). **NOTE**: Samples generated with indent as 4 spaces. * [Google Style Guide](https://google.github.io/styleguide/cppguide.html) * [LLVM Style Guide](http://llvm.org/docs/CodingStandards.html) * [Mozilla Style Guide](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style) * [WebKit style guide](https://webkit.org/code-style-guidelines/) * [Chromium style guide](https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md) * When do we want to make this change? Before the 4.1 branching seems like a good time to make vast changes. * AGREED to do this prior to 4.1 * Gluster's Adoption of **GPL cure period enforcement** * [What is it?](https://www.redhat.com/en/blog/fostering-greater-open-source-development) * How to go about implementing it? * [Intended patch here](https://github.com/amarts/glusterfs/commit/91918bbe7afaafd8e5bcf4a163ed98ffb39c4d21) * [The Commitment looks like this](https://github.com/amarts/glusterfs/blob/commitment/COMMITMENT) * Next steps are to announce this to the lists and implement the same into the repository (possibly this week or early next week)[AI: Amar] * Automation Update: - Run regressions with brick multiplex directly from Gerrit now with a keyword rather than hacky temporary review requests. Keyword is 'run brick-mux regression'. Example: https://review.gluster.org/#/c/19734/ - More automation moving to Python so we have the ability to write unit tests. If you are going to write a complicated shell script as a test runner, please get approval from CI component maintainers. - We've been testing Facebook's distributed test runner and have managed to get it working. Time for regression drops with every new machine added to the pool. Targetting a few weeks to bring it to production. - Test infrastructure has some minor fixes from FB, so need a sync up meeting on the same [AI: Nigel] - We can factor in test run times to achieve better overall results, and keep workers equally busy - Github Label check is now enforced: - Need help from others to identify the needs for going to give the flag. - As 'ndevos' asked, we need to highlight this in Developer Guide and other places in documentation. - Can we fix the 'gluter spec' format and ask people to fill the github issues in that format? So that it becomes easier to give the flags. * [Handled Already]~~Regression failures~~ - ~~`trash.t` and `nfs-mount-auth.t` are failing frequently~~ - ~~git bisect shows https://review.gluster.org/19837 as possible suspect~~ - ~~Need to resolve soon as some critical patches are failing regression~~ * Release timelines: * Can we extend branching out by a week or two? to compansate for github flag enforcement? - Target GA date should remain same. - Things we want for 4.1 - clang formatting - Github flag enforcment for all features - We branch out later, but still release at the same time. - No concerns during meeting. Shyam to announce. - * Round Table: - kkeithle - comment-on-issue test is (still) broken. E.g. see https://review.gluster.org/#/c/19871 Can we please get this fixed? - This is working as intended. Please see automation updates - kkeithle - For the record, I'm opposed to any kind of bulk reformat of the source. In my experience this just complicates porting changes between branches. And isn't it also going to break `git blame` history? - Nithya - Can we split experimental xlators into it's own package - AI: Get experimental xlators in a separate package. Shyam will work with Kaleb, et al - [Name] Note ### Decisions * <Add them here> ---- ## Meeting date: 04/04/2018 (AprilAprl 4rd, 2018. 19:30IST, 14:00UTC, 09:00EST) ### BJ Link * Bridge: https://bluejeans.com/205933580 * Download: Amar's Fault, meeting not recorded. ### Attendance * Amar, Nigel, Ppai, Xavi, Kaleb, Shyam, RaBhat, Deepshika ### Agenda * AI from previous meeting: * How to land experimental features into master * Option 1: Land into master but not user visible * Option 2: Land into master under experimental, but do not ship into releases.t do not ship * [Experimental README](https://github.com/gluster/glusterfs/blob/master/xlators/experimental/README.md), where item (2) which calls for building an experimental RPM, which is not done yet! * Round Table * Discuss comments in issue around API/ABI compatability [here](https://github.com/gluster/glusterfs/issues/389) * AIs around that, documentation around API/ABI compat, Release notes to call out any API compat issues, CI around API consumers * Update libgfapi-python * Ensure deps are right, so that the right version is installed when upgrading gfapi as well ## Meeting date: 03/07/2018 (March 3rd, 2018. 19:30IST, 14:00UTC, 09:00EST) ### BJ Link * Bridge: https://bluejeans.com/205933580 * Download: https://bluejeans.com/s/huECj ### Attendance * Amar, Kaleb, PPai, Nithya, Sac, Deepshika, Shyam (joined late) ### Agenda * AI from previous meeting: - Email on version numbers: [Done] - Email on 4.1 features: [Done] - Email on bugzilla automation etc: [Done] * Any more features required, wanted in 4.1? - Question to FB team: are you fine with features being merged? Any more pending features, bug fixes from FB branch? - Question to Red Hat: are the features fine? - Question to community: Is there any concerns? - GD2: Can we update the community about the proposal for 4.1 - [PPai] we can send the github link to the project to community. * https://bugzilla.redhat.com/show_bug.cgi?id=1193929 * If agreed for option change, what would be good version number next? - [Sac] Need more discipline to have calendar based releases - [ppai] http://semver.org is more practised * Round Table - [kaleb] fyi, I'm NOT making progress with debian packaging of gd2. I've been told that Marcus (a ~~nfs-ganesha~~/ceph dev) has Debian pkging skillz. When he returns from the Ceph dev conf in China I'll see if I can get some of his time. Also my appeals for help from debian packages and from Patrick Matthaie have gone unanswered. Debian packaging is already voodoo black magic; golang makes it even harder. ;-) - [amarts] auto tunable options is the future requirement for us. Everyone, please consider figuring out for your components work for it. - [shyam] I see a good response for features this time. Expectation is to meet what we promised. See github projects page for seeing whats agreed for 4.1 -----

Syntax	Example	Reference
# Header	Header	基本排版
- Unordered List	Unordered List
1. Ordered List	Ordered List
- [ ] Todo List	Todo List
> Blockquote	Blockquote
Bold font	Bold font
Italics font	Italics font
~~Strikethrough~~	~~Strikethrough~~
19^th^	19^th
H~2~O	H₂O
++Inserted text++	Inserted text
==Marked text==	Marked text
[link text](https:// "title")	Link
![image alt](https:// "title")	Image
`Code`	`Code`	在筆記中貼入程式碼
```javascript var i = 0; ```	`var i = 0;`
:smile:		Emoji list
{%youtube youtube_id %}	Externals
$L^aT_eX$	L^aT_eX
:::info This is a alert area. :::	This is a alert area.