owned this note
owned this note
Published
Linked with GitHub
# DEV Call
[![hackmd-github-sync-badge](https://hackmd.io/Qqhlz_EYQH-J8aXTgeqCWg/badge)](https://hackmd.io/Qqhlz_EYQH-J8aXTgeqCWg)
Sunday and Wednesday 17:00 CET (Berlin) // set up as weekly
- Share DEV progress
- GitHub issue cleaning (process `new issues`, look at `in progress` and assign, review `review and QA`, close `done` issues)
- Saturday: Plan weekly sprint (what issues, projection and time commitment)
- Wednesday: Evaluate sprint progress and talk about implementation details and pain points
## Notes for DEV CALL 2021/06/02
- Update from Kay: ready to push to live
- Update from Mateo:
- some testing was done last week, had fixed issues that were found
- missing segment integration for mail subscription and contact form, should be solved quickly
- other issues appearing are the same as current version
- James will help
- when someone makes donation, segment fails
- Sprint planning:
- going to move to Giveth-next board
## Notes for DEV CALL 2021/05/26
- Staging (next.giveth.io) is working, but main (main.next.giveth.io) has some issues, perhaps due to the impact graph
- Update from Merlin
- 3 PRs are ready and still pending:
- UI updates on create project:
- could not change wallet on xdai (should work now)
- now xdai my wallet redirects to blockscout
- fixed donation search on page “my donations”
- xdai amonut price is fixed in $
- James
- thinking future of impact graph is IDX - can't rush into 3box
- take a step back and look at bigger picture
- want to get next.js stable and live
- concerned with how and where things are going
- Marko
- same concerns as James - tried to initiate sprint planning
- we need a roadmap and clear view of where we are going
- plan: to algin on roadmap in gov call, to move dev meeting to 1 hr earlier to allow for participation by willy and or griff
## Notes for DEV CALL 2021/05/19
- Update from Mateo:
- Working on bugs "500 error unexpected error"
- Working on fixing testing issues on next version of staging
- Thinks we will be able to migrate soon, but changing the environment can always bring some issues
- Mateo will be offline for a couple of days because he's moving
- will make migration to live on sunday or monday
- Update from James:
- Hasn't had much time for Giveth issues
- working on impact graph
- Update from Mitch:
- Emails are going through but titles are showing up blank in staging... when we deploy it should fix it!
- Needs testing on live
- James reducing his commitment to Giveth and not going to be receiving regular rewards
- Marko focusing on brand book, style guide, topography, design in May
- will finish on remaining issues in github
- Project Verification
- we need to add something to the impact graph that can be pulled to the front end
- front end will need a badge
- we're only verifying 2-5 project every 2 weeks
## Notes for DEV CALL 2021/05/12
- Update from James
- Staging needs more testing
- Server was down, some issues created by Lauren were blocking testing
- Issue with projects that have the same slug name, creates an issue
- working on rich text editor image uploading
- trying to get staging live
- Update from Mateo
- working on getting rich text on live
- Mateo wants testing from testers on nexxt.js
- Mateo been solving many edge cases in these days that may have been msised in migration, likely solved now
- rich text functionality not working properly so far on gatsby
- to work on 3box and prject verification
- Team decision: to focus resources on next.js migration so we have everything working correctly asap
- Test on next.js
- Update from Merlin:
- moved to giveth next repo, made PRs
- issue with cyprus: when you run a test, shows an error like unexpected token error but no issue in the code, running fine locally (just the test crashes) - result is that all tests are crashing
- fixed issues with gas price and tokens... error assuming that donations not in crypto were in fiat but in actuality they were not donations
- on account page: text was squished, now account wallet shows correctly
- are we planning to move issues from one repo to the other?
- To ask Kay to create one branch for each so devs can use same flow as on staging, for now, can use mateo branch
- Support issue not know how to access funds in torus wallet on xdai - communications issue?
- Marko working on brand book with styles and visual direction of giveth brand (topography, colours, guide, etc.)
## Notes for DEV CALL 2021/05/05
- Update from Mateo:
- did shallow migration from gatsby to next.js - will solve issues like rereneder of projects page, will void long building time AMAAAAZING... we had issues upgrading to gatsby 3, were having many issues with gatsby, we're in a bug fixing phase
- finished rich text
- Update from James:
- Unsplash API for image headers for redesign (user can search for images)... changes for this are on nexjs version
- Didn't finish copy link when sharing project
- Outstanding issue about fixing console warning
- added boolean for GIV backs and verified projects, added wallet connect, backend solution allowing people to see list of verified, projects that were cancelled don't show up anymore, commons simulator link to blank page - resolved
- testing guidelines ongoing
- Update from Mitch
- fixes on staging seemed to work, emails coming through correctly
- guidelines for testers is on giveth docs
- Update from Merlin
- Mateo merged gas fix to staging
- Merged create a project test
- Faced new issue with cyprus, maybe will change with the move to next.js
- Update to Kay
- made a few visual fixes for mobile (alignment, footer info)
- support chat widget was running
- next sprint want to tackle support page
- Sprint planning, let's do
- remaining previous sprint backlog issues
- 3box
- next.js testing
- anything people feel stoked about
- join our community update
- James to push fixes from develop to staging and we need testing before going to live. Testing of next.js to be done on develop
- IDX by 3box perhaps a better solution for project verification
## Notes for DEV CALL 2021/04/28
- Update from Kay
- Ashley to be designated support person
- Kay setup support chat
- Update from Mateo
- Rich text functionality IPR - resizing images, allowing larger images. Encountering an error making build in netlify, fighting the error. Will first upload to develop, then will move to staging (made some breaking changes in the backend).
- Kay recommending react quill - Metagame using it for rich text formatting - Mateo to follow up
- Update from Merlin
- PR on fixed gas price is ready to review and merge on staging
- Last week tried to make demo of test with web3 provider using cyprus, but it failed, spent time fixing the issue. Will work on over-test to implement
- Merlin to make automated tests for GitHub issuse in testing flow
- Want to be able to change donation wallet when using xDAI chain - will talk a look at this issue
- Update from Mitch
- Impact graph work - segment is mostly working with autopilot flows
- Needs to stop type error in impact graph - looking for advice
- Comms team needs feedback on developer guides to update docs
- Mateo & Mitch to collab segment issues
- Testing issues
- Dani can't heart projects - to follow up w Mateo
- Other users are adding projects (Mamos and Gaia Gives) - had small challenges with editing
- Sort function works funky on mobile (it doesn't "stick"), formatting is weird
- Updating docs, join form, contribute - Adar to get involved
- Update from James
- Been working on issues outside of sprint - pricing on live website was wrong (totals were not showing)
- Issues w authentication on his local machine
- Completed walletconnect thing
- Didn't hear back from Simplex
- Update from Marko
- Design UI for uploading project images and seaching web via unsplash
- Cropping image ready
- Been playing around w rebranding - getting feedback from team - playing with lines and circles, mockups in the figma
- Board Review
- New column "On Develop" for issues that are complete but not yet on staging
## Notes for DEV CALL 2021/04/21
- Update from Kay
- Working on support chat integration: having issue with build. Gatsby issue. James and Kay to check it. Maybe if we just pay the $15/month to access the new version of the support widget.
- Update from Merlin
- Updated MetaMask popup, small typos, alignment of text, currently fixing gas price calculation
- Mitch taking on segment/autopilot config - to sync up w Kay/James
- Mitch/James: to update retroactive quality score
- Lauren/James: to finalize tesing flow documentation
- Sprint planning reflected in the board
## Notes for DEV CALL 2021/04/14
- Update from Kay
- Refactor contact page using segment: now if you put a message there it goes directly to support channel in our discord w the email so we can respond
- Looked at discord integration, did lazy implementation, for $7.50 can have single channel mode, popup in the DApp which is basically the support channel in our discord so people can communicate w us directly. Don't think we are able to change the styling, still working making this smooth
- They are on the brink of releasing a total record - they use Patron for support. For $13 Paton gets access to alpha, can customize CSS. Kay is talking to them right now. It's not as quick as discord direct. He enabled guest acccess - so you don't need to be registered with Discord to access this. Will look into more options and update next week. We still have contact form.
- Still working on small mobile issue
- If you hit X on annoying popup, now it closes and will reappear after 3 days
- Support widget: would use chatio.com - for slack, so we could implement it. it's $49 per month...
- Be sure... if we introduce environmental variables, they should be consistent
- Update from Mateo
- Solved many issues with logos on donation flow
- URL, if you click it, nothing was happening. Now we are validating on the moment you are updating you profile so every screen should resemble URL
- Added "badge" to projects (changed text from GIVback text to "your donation goes a long way")
- Want to discuss rich text issue... can add images and videos. How much should we limit the user re: adding content? If we are going to allow many optimization, the short description on the projects page should be simplified. How much ability should we provide the user to customize the content? *ready to test adding images, videos, etc. *
- Update from Marko
- Request to implement Unsplash UI for adding images
- Can we enhance project creation flow?
- signup/signin Torus UX thing unclear for some people. Now we have sign in for MetaMask and then below there is email/twitter/etc.
- Quality score: info updated in docs, will add link on projects page
- Update from Merlin
- Fixed some small issues, "f" now "xdai" on xdai donations
- text alignment on my wallet
- transaction history via xdai chain now redirects to blockscout, not etherscan
- If you donate PAN on xDai, total amount (donation + gas fees), price of xdai and pan need to be in the same unit... now network fees and donation amount are separate
- From Marko: please move banner below the donation amount
- Spring Planning
- To take new issues from the backlog? Should finish issues in In Progress, should also do prioritization before this meeting
- Merlin to take on some issues from backlog
- Autopilot
- 2/3 journeys are not running as they should - Mitch working on this
- To have meeting w Willy/James to learn more how to fix this. Mitch to work w Kay
## Notes for DEV CALL 07/04/2021
- Update from James
- Fixed donations calculation issue
- Update from Mateo
- Implemented infinite scroll for projects *test on staging before going to live
- Focusing on research for rich text functionality
- Transac for giving option to users to buy crypto
- Sorting by likes on staging bug found by Dani should be fixed now
- When you try to put ENS domain in project creation, you get another address - now it is fixed
- Update from Merlin
- No new issues since last week, wants James/Mateo to run the current PR (on their local computer) before merging to make sure it's working
- Merlin to tackle new issues from sprint backlog
- FYI: Dev to staging pushes can be done by anyone
- Dev Reorganization
- Change to have 1 dev call per week (probably Wedbesday), have updates in discord, add hack sessions as needed, option to get feedback from Willy as part of governance meeting
- We will have sprint planning meeting before sprint to decide what should go in (can raise issues in this meeting)
- In current sprint, we should look only at sprint backlog (not at new issues)
- When you make a new issue, assign multiple people to get their attention and then they will unassign accordingly
- If something is urgent/important devs can take on those issues outside of the sprint, but we want to keep things prioritized and clean
- Fiat onramp situation
- Needs 2-3 owners who are responsible for investigating this
- Need a list of ideal features: per transaction fee (rather than percentage), onramp to xDai
- Who are the providers that provide this? Reach out to providers *this should be on governance agenda
- Dani to list Giveth as a project on the Giving Block and then try out their payment process as a recipient
## Notes for DEV CALL 04/04/2021
- Segment/Autopilot Email Issues
- Just switched on Segment hook for autopilot, we were wondering why it was disabled
- Emails not working on live, only on staging (Willy and James working on two parts of this issue)
- Update from James
- Total donations not adding up correctly - there was an issue reaching our node... the amount of donations was not properly converting and totalling into ETH and USD. James set out to write a script to calculate value of all donations - should be finished by today or tomorrow
- Moved some issues into sprint backlog to discuss later
- Update from Mateo
- Search/filter/sort - Mateo fixed the styling, pushed everything to staging
- Added popups for when person doesn't have enough funds: shows icon of token you are donating
- Gas issue from Griff also fixed
- Many small fixes, will push to live tomorrow
- Update from Amin
- We have some API that we promised you about rates... by transaction hash we give you rate... we are still using that rate for something...?
- James wondering if the cause of the donation problem was the API and not the node - not sure how we are using it right now
- Amin wants to close the API so we can't access transction hash from outside
- We can send time stamp rather than transaction hash
- Sprint Planning
- Rich text formatting, adding video/images to project descriptions (Mateo to sync w Merlin)
- James put issues in sprint backlog
- How do you remove projects?
- Go into database, and update "status" on project from 5 to 2 and it gets removed
- Status codes are documented in GitHub issue (project status ID)
- Kay can take on project disabling - ping Kay if you want projects unlisted
- Discord organization
- New Project channel in discord RN gives notification anytime anything happens on live
- Segment-dev channel in discord gives notifications anytime anything happens on live (now under "uninteresting")
- New projects channel is pretty noisy - maybe make 2 channels? one for notifications and one for discussing new projects - Kay to fix
- Dev-ops channel is bot channel
- GIVback
- Fabio set up script for GIVbacks for rewarding - just needs to know which projects are eligible
- Every 2 weeks, we add projects which are eligible
- Marko going to put together mockups for what specs look like for UI
- We don't know exactly when token will launch: Ashley and Forest will lead verification parties
- Need reliable prices for all the tokens
- Quality Score
- Intention was to have best results at the top and worst at the bottom
- Then thought to improve project listings by showing to project owners
- Default option is to sort by quality score... to change title from "quality score" to "default"
- Project Verification
- Keep in mind trust score, how to check track record
## Notes for DEV CALL 31/03/2021
- Update from James:
- Sorting/filtering/searching is done on develop, Mateo to finish visual stuff
- Build optimization: how often + optimization + automated database backups - blocked by deplotment and didn't have time to prioritize
- Fixed console warnings (WIP) #588: has't been able to merge, still being worked on
- Donation values and prices at the time of donation aren't saved in the database - there was an issue reaching out Node, and so any donations that have been made haven't saved the equivalent values (currently writing script to do this retroactively)
- This will also address retroactive quality score, and he hopes to have this testable by tomorrow
- Update from Kay:
- Need to discuss with Willy about segment notifications because we are not getting discord notifications when new projects are added
- Update from Mateo:
- Working on visual stuff for filtering/sorting. Noticed that filtering by quality score/hearts is not working
- Added banner at the top saying that you can use xdai
- Other small visual fixes
- Will finalize all parts and move from develop to staging for testing today
- Gas-related issue: the value should be shown properly but is currently not... currently IPR
- Wants to discuss GIV token economy
- Mateo working on token list revisions - adding necessary tokens
- Update from Merlin:
- Created entire test to create a project, each step (project name, admin, address, etc.) is included... "go back" and ensure what was created before is still there, then go forward, review all that's there. Totally automated! Test passes if all conditions are met.
- Did not add test to submit a project because didn't want to overload the backend with many projects - thoughts? Kay suggests to leave out final sumbission, or to submit and then "delete" or "cancel"? Merlin to determine if he can fake project submission, but also shouldn't be a problem to have lots of projects in develop. *ask James
- Update from Marko:
- Rebranding has been pushed to backlog (won't finish this sprint)
- Sprint Planning
- Today!! Should have end of sprint evaluation and then plan next sprint
- everyone responsible for their own issues, move to appropriate column, add comment
- Marko *added label* "next sprint" to issues in first column
- Devs to assign themselves to the issues they can take on this sprint (starting today!) then move to sprint backlog and remove "next sprint" label
- GIVback token economy
- What advances can we make on GIVback UI right now? (Mateo)
- Griff updates: Fabio is working w/ James to get what he needs to scripts
- Right now, GIVbacks will remain backend until we have everything sorted
- This sprint: we are figuring out project verification and doing a proof of concept to get our projects verified, then once that is complete, we'll have the "verified projects" list to devs to add to backend
- Then Fabio takes that data from backend and calculated GIVbacks for the round
- We're optimizing everything on the backend and hiding on the frontend until things start feeling good, then Marko can start w designs and we can begin to implement on the frontend
- Not sure if we'll have verified projects before or after token launch, but this will be one of the first things to implement in development for giveth.io
## Notes for DEV CALL 28/03/2021
- 1 HNY went into the void! Someone donated to Giveth on xdai to our multisig address on mainnet
- Should check if address is real/accepting donations on that chain before donation goes through
- Conisder contracts that are only on ethereum or xdai... also consider that a lot of people have DAOs on xdai
- Need to check, if when creating a project, added address is a smart-contract wallet, and then not allow this
- Need to make sure no one else has contracts as their address on giveth.io already
- Short term solution: block all contract addresses - create system that scans etherum and xdai chain and doesn't allow it
- James to go through database and check if we have other smart contract addresses
- Griff to create issue about this so we have comprehnsive info about what we will do
- Longer term solution that covers all the bases of this to be thought-out and developed
- Update from James
- Investigating live bug where donation amount isn't correct, may have something to do w xDAI
- Put on dev some processes for sorting/filtering... design isn't right yet, but enough to try out to see functionality. Open to feedback
- Worked on automating backups, now it's working on his local computer. Need to deploy on staging server to test it there. Will work w Kay on this
- Update from Mateo
- Pushed something from master - initial fix... when user creates a project w no image, shows image of kids running - fixed now!
- When there was no picture, showed team in Barcelona - fixed
- Fixed xDAI login and other minor bugs
- Going to prioritize isssues from Sem this week
- Update from Kay
- Fixed two small issues.. lotty
- Currently fixing deployment for impact graph for dev that got stuck
- Activated digital ocean backups
- Issue with Circle, can't connect to server - WIP
- Update from Merlin
- End-to-end test: connect two fake metamask accounts...testing create project etc requires metamask account - WIP
- Refactor of donation page - design fixes from Marko - in PR
- When cyprus opens chrome browser, it's a whole new page, no metamask browser extension... Maybe we don't need metamask at all
- May be difficult to test donations because need to fake tokens? WIP
- Amzing to be able to run tests before deploy and have higher level of confidence that things won't break
- Feature request from Barcelona group:
- Request to be able to log-in with multiple wallets from just one organization
- James: What is the functionality right now that would benefit from this? Seems like something for the future
- If we had this, more than one person could change project description - would be good
- Request from Mitch
- Can we all "endless scroll" instead of having to click "see more projects" repeatedly
- Need to have quality score updated for inital onboards - James to run a script to update them all
- Update from Willy
- Segment analytics... Shows donations, projects created (on March 25 we have 80 donations!)
- Shows list of events we are tracking in segment
- Impact measurement - want to enable projects to post their impact (e.g. we planted 1000 trees! w pictures/GPS/timestamp)... show how much it cost to make that impact, and then you can have on each donor's page how much impact they helped create
- Can also show impact of donations to Giveth (your dollars to Giveth helped this many dontations to other projects)
- Superfluid - token streaming - COOL IDEA
- Someone could implement that w Giveth as a hack-a-thon project
- Could be good for onboarding fiat... thinking of $500 going into project and then it streams to projects over time. Related to UBI
- Constructing conceptually narrative of streaming sponsorship
- In the future... payments will be a constant stream (not every 2 weeks, e.g.)
- Money streaming into your wallet, money streaming into projects - could be conditional upon projects demonstrating updates/results
- Could stream money to causes
## Notes for DEV CALL 24/03/2021
- Update from James: Project Editing Issue - Related to deployment
- James has been working on deployment, atm if someone edits a project - the old description is still showing... right now requires a new build in order to update edits
- Netlify supports webhooks to trigger a build... James has a hook in place that when an edit is done or a project is created it pings netlify and netlify builds... but we don't really want things to be build many times after many consecutive project edits/saves
- Thinking of setting something up that pings netflix when build is needed, and then every 5 (or 10?) minutes, can be rebuilt
- The functionality of this depends on how much action the DApp experiences
- This is problem because we don't have a server like php or xbs
- By the end of today, James will incorporate this 5 min thing... we could add a message to say that the user must wait 5 min to see edits
- Update from Mateo: been working on feedback/fix requests since Sunday. Donations table on public route of project, annoying metamask popups, visual issues from Griff, will now check to see if he can make project updates appear instantly
- Need to add PAN contract to backend to add $PAN price properties
- Also working on xdai login option - will get this working by tomorrow or friday
- Update from Merlin: Implemented automated testing for the DApp
- Testing is super important because it could allow us to confidently deploy quickly: runs 4-5 test cases to confirm nothing is broken
- CI w netlify - it's working but it's really intensive computationally (takes ~3min)
- Maybe we can run tests locally: save something on local storage or make a test token in the browser
- Update from Kay: we have alerts and monitoring (monitoring w prometheus), alerts go into devopps channel. Merlin to send current IP address to Kay to get access past whitelist firewall
- White page issue: if someone visited the old website before we deployed, they may have some part of the old service working stored. What if we remove our custom service worker? James to look into it
## Notes for DEV CALL 21/03/2021
- Update from Kay: was busy w MetaFest will complete tasts in sprint
- Update from James: go live worked well, James to work on filterin/sorting
- Update from Mateo: hasn't done much beyond getting things live, ready to work on sprint
- Mitch testing issues: quality score, price fetching, segment issues
- Projects that are added or created starting now... the ones that exist already, we will need to edit them in order for them to be properly sorted
- to add info about how quality score is calculated and how to improve it, make it out of 100%, project users can see the score for their own projects, will add as tooltip
- low priority: perhaps create admin user that has the ability to edit project (e.g. Giveth project which is only in the database w no owner)
- Thing to add to Giveth docs: xDAI(will incorporate ability for user to login w xDAI), quality score information
- Get feature complete before discussing details of whitelabeling... Panvala and GaiaGives
## Notes for DEV CALL 17/03/2021
- Update from Kay: New Testing Channel on discord for tesitng
- Update from James: we're live on staging, investigating 1 bug, want to use this time for sprint planning w help from Marko
- Sprint planning: the columns we will have are new issues, backlog (to be completed eventually), sprint backlog (to be completed this sprint), in progress, etc.
- In GitHub/Zenhub there is a projects tab... can use this to plan our roadmaps - can have Q1, Q2, etc.
- Sprint planning setup in in GitHub: https://github.com/Giveth/giveth-2/
- Update from Marko: going to have two groups of Figma files - one for TRACE and one for giveth.io, cleaning up giveth.io & TRACE brand and styleguides
- Plan to have everything deployed to staging Monday (or Tuesday morning), Tested Tuesday, Bug fixes by Wednesday? This structure is TBD based on the flow of this sprint
## Notes for DEV CALL 14/03/2021
- Update from James: everything marked as critical is live on giveth.io, everything plus emails is on staging ready for testing
- Update from Mateo: mess that was happening with SSR and CSR is fixed - new "likes" show up now
- Update from Kay/Willy/James: Segment is great, very powerful in relaying events from the DApp:
- can perform tasks like send follow-up email after 3 days if user hasn't taken action
- drag-and-drop settings... everything done on backend
- there is a gatsby plugin - adds analytics, sends info to amplitude, tracks everything, provides opportunity for nondevs to configure hooks upon hooks
- easier to implement than we thought
- segment can track all events - can show amount, currency donated, link to tranaction ID, etc.
- Emails are already in place if user logs in w Torus. No email grabbed if user logs-in w MetaMask:
- Adding an email when logging in with Metamask is still optional. Might be required as part of create project flow. Validation (user added email) should be built in.
- Will require user to input email when creating a project, but not when donating*
- James already added "add email" field - this needs to be tested on staging
- Need more organized/thorough user testing so we can ensure we're not missing any bugs: James to create user testing guide/flow - will create issue and get help from Lauren
- Giveth default project text on giveth.io should be updated (needs issue), Dani can write new text, James to update
- Next sprint should start on Wednesday, sprint planning starts now. Devs can commit to completing sprints, other planning can be done around this. This will help take some pressure off our awesome devs!!
- Sprints are now organized in the "sprints" feature of Zenhub. They are named by the timeframe chosen for the sprint and are designed to last two weeks.
- #558 on zenhub - lists breakdown of what the time estimates so each issue can be organized appropriated and fit comfortable into sprints
## Notes for DEV CALL 10/03/2021
- Update from Kay: suggesting autopilot for emails, will send issue and info over to James for review
- Updates from James & Mateo: we are live on staging, ready for testing, fixing one small issue re: SSR and "likes" not showing up
- Project curation issue: how do we ensure that we don't get scammy projects?
- Marko is creating means for verifying project owners via twitter, GitHub etc. After this we'll have more credibility, no need to do a lot of work creating other new features
- In the meantime, intention to optimize build so that projects show up "right away". Will still need to delete scammy project
- New issue: metamask allows user to confirm transation w insufficient funds, and then it gets displayed as if the donation has gone through
- Even with transaction hash we need to confirm that it's mined on a block
- Could add in some pending spinning wheel like 1inch - maybe not a priority
- UX can show the transaction as pending until it is confirmed
- Need to do lots of testing right now to find/fix any bugs, hopefully getting ready for public release
- Intention to get more organized with sprint planning: have meeting at the start of a new sprint to plan it and commit to completing those issues
- Marko is creating GIVback implementation epic, adding issues to it - aiming for consistency accross teams
## Notes for DEV CALL 07/03/2021
- Update by Kay: Got a bit stuck with segment and notifications. Recommendation by Willy is to use Autopilot and send events via segment. Epic issue was created to hold further discussion.
- Update by James: xDAI chain pricing got pushed to dev - still having problems because honeyswap uses UniswapV1 instead of V2. Not ready for testing yet - **please note:** developers should use develop.serve.giveth.io as database instead of hosting it locally until packages are updated. Got stuck with SSR and our many outdated packages. First step is to upgrade things and work methodically with the goal of fully including SSR.
- Mitch is wondering about progress on removing sketchy projects, making user guide for xdai
## Notes for DEV CALL 17/02/2021
### Agenda:
- We all take turns to show the zenhub board, and talk about the issues we're working on
- Sprint planning for the 1st of March. What is critical and why.
- Other issues for discussion
- Issue estimation https://github.com/Giveth/giveth-2/issues/558
### Updates:
- James: `Post Valentines` is current sprint for fixes. `Giveth to the future` is the next big feature sprint leading to full launch.
- Mateo: Done with most issues of current sprint. Next issues to work on include: "Allow donations in other cryptocurrency"
## Notes for DEV CALL 07/02/2021
### Updates
James - Migrations for database, fix bugs with metamask donations when logged in with tor.us
Mateo - Changes donation flow. Now checks for way the user is logged in as default and other wallets optional. Some issues with wallets fixed. Network connection indicator. Needs to do still: Event that catches if Metamask is on wrong network. After that will look out for more issues in ZenHub.
Kay - Change landing page content [here](https://raw.githubusercontent.com/Giveth/giveth-2/staging/src/content/giveth.md)
### Softlaunch
- We need a way for users to delete campaigns!
- We need to speed up build time. A good way to do this is described in #484
## Notes for DEV CALL 03/02/2021
### Updates
Mateo-metamask and torus integration, made login smoother. currently working on wallet notifications
James-working on authentication issue and login
Amin- no real updates
Mitch- ready for testing
Lauren- ready for testing
Forest- orgazational guru
Kay- merged changes to master,
Marco- no real updates
Dani- ready for testing
Agenda:
- evaluate last changes
James working on authentication login issue from last broken testing session
- notes for testers
use staging.giveth.io this week
We will also soon test v2 on mainnet for soft launch
next week it will be on giveth.io and it will be announced to test there or move giveth1 projects
user and developers testing needed
- check "Last before MVP sprint" milestone
- assign and discuss new issues
https://github.com/Giveth/giveth-2/issues/452 - Mateo,Marco - how to prioritize using the wallet users are logged in as. add a notice above the donate button
https://github.com/Giveth/giveth-2/issues/386 - James and Kay
banner for soft launch is done - Mateo
https://github.com/Giveth/giveth-2/issues/454- Dani - pop up for firsttime users- if a user has been logged in then how do they choose their previous user account. do we have a 'remember me? option'? if you return, you should be logged in. fast follow/ice box
https://github.com/Giveth/giveth-2/issues/435 - Mateo - fiat onramp, donating crypto still? will it be on the crypto ledger?
can we know and have a transcation i.d.? fiat donations have a fee, and currently we advertise not having fees. fiat fees need clarity that they are not giveth fees
https://github.com/Giveth/giveth-2/issues/436- James, Kay- graphQL endpoints pants down? currently anyone can run queries.
engineX configurations expert would be helpful
- LAST SPRINT before soft launch
we have many issues that do not have anyone assigned, though we have plenty to do.
Whatever is in backlog and progress is good for MVP
bug fixes only now please
Reminders:
Need to choose a feature completeness lockdown
Do not use v2 for testing right now, use staging.giveth.io
When we are live on soft launch will need to test mainnet v2
Landing page textblock put into Contentful? or Markdown file?
if we use markdown and github we can allow for more editors. Contentful has limited available users. Github also comes with SourceCred ease.
We use Contentful for the FAQ. if you want to be added to the Contentful profile page, send Kay one Picture and bonus points for some social links
FAQ needs more help on hackmd. Dani needs to transfer some content from google docs.
Where is our central note taking space? We are spread between Notion and hackmd
share links to all platforms between them
markdown is handy for wiki, docs, and is connected to Github
## Notes for DEV CALL gaps 31/01/2020 to 03/02/2021 need transfer from Notion?
## Notes for DEV CALL 31/01/2020
### Updates & Login/Wallet Flow Discussion
Mateo - James implemented a check if user has metamask installed and falls back to tor.us
James - User should not be able to create project before profile is updated. We should change the flow accordingly. If Metamask is not installed it should automatically default to torus sign-in. If Metamask IS installed we should show onboard.js (might be complicated). Alternative - NO MM installed we show Tor.us, when MM installed show selection menu like now.
Dani - Tor.us does have some pitfalls when it comes to that login procedure (i.e. she expected a different social login to use the same wallet but it creates a different one). Another thing - "My Projects" should also contain projects the user donated to.
Willy - Will present it at ETH Denver on Wednesday!! There should be a banner at the top that we are in softlaunch.
To summarize the rest of the call - we talked a lot about the wallet and login flow and spent some minutes looking at various UX issues. We fixed to softlaunch to giveth.io on Tuesday 02nd February 2021 - ideally 24 hours before Willy presents it at ETH Denver.
## Notes for DEV CALL 27/01/2020
### Notes
James: Refactor of Authentication is done
Mateo: Implement other User public profile view, missing mutation on impact-graph for user account (issue follows)
For Tester: Login, Logout, Refresh, try to break it
## Notes for DEV CALL 24/01/2020
### Agenda
- Roadmap and go live tomorrow?
- Authentication refactor - is supernice now but would push softlaunch out for at least one more week
## Notes for DEV CALL 20/01/2020
- State of giveth2 looking good
- some things still to optimize, i.e. gracefully recovering from errors, trying to add ramp.network as FIAT provider
## Notes for DEV CALL 10/01/2020
### Agenda
- Torus embed
- support from Torus - domain prefix signing functionality
- Multiple wallets
### Notes
## Notes for DEV CALL 30/12/2020
- If Camilo is available he is happy to work on issues.
## Notes for DEV CALL 20/12/2020
- Mateo mentions problem with creating projects currently
- Circle CI failed to build, Amin was looking at it. Once git credentials were updated the build was working.
- Mateo added lots of visual updates on likes, updates, fixes, address display. Missing alerts, optimization with impact-graph following.
- Requesting for early (internal) user testing and collection of questions for faq.
## Notes for DEV CALL 16/12/2020
Mateo dropped SSR in favor of client side rendering. Network indicator will show tor.us network (account page). Donations will remember choice of user.
Amin is working on API for currency conversion. Unsure how to secure access at this point.
## Notes for DEV CALL 25/11/2020
Attending:
Check ins:
Amin, Mateo, Benjamin, Kay, Mateo, Camilo, WIlly, Griff
Using hackMD for Notes and agenda instead of google docs.
Mateo: participating in hackathon
Kay: not much news since wednesday did switch out graphics and names for pages biggest thing on todo list and backend
was very interested in codebase
Camilo: working with matthew on webflow on fiat flow and project slug no more distractions no more updates
Griff no major updates no distrcations
Mateo: already downloaded it to computer needs some changes to environment variables. some changes in environment backend to localhost. Mentioned to James that camilo made some changes. Now only need to be a user to make a project. if you comment those lines it will break. it didnt work when they made a PR.
we are having a token when having a user.
better when making changes on repo because of sourcecred. Camilo does a lot of work but not sure it's measured somewhere.
Camilo: who can make a project and that is supposed to be a token.
Enviornment variables and API keys we have prod for Stripe. Now we can test doing a real donation and receive it in the SDG impact fund bank account.
Should we use production keys or development keys? even when using prod keys you can make test transactions.
Willy: We got bank account enabled. next day Stripe: your account has been closed because of crowdfunding. Willy is back and fourth with Stripe to be reenalbed.
Not planning for failure yet!
We have disabled the application. Have no implemented
Talked to Bryan on Friday about PDF generation, was worried if he made big updates
Meeting recording: what about using YouTube?
Griff has someone on UpWork to standardize streaming
*Ben will talk to Kay about meeting streaming/recording*
mateo is working on graphql. donate fiat Epic is moved to Review/QA.
need to set up an issue to make the backend points
## Notes for DEV CALL 18/11/2020
Notes are also on https://docs.google.com/document/d/1EQKAGlxM-xH2hbq3AzE540iaRhF1i84Fnsx-rLf6Ggw/edit?usp=sharing
#144 donation flow that is almost done after both of those parts are done we should be a qa for the MVP for a basic version. revising all the design after the "my account" is complete and "project details"
#141 authentication is a complete mess
Kay:
Amin: create page API in gatsby because its a common functionality that's required.
* need to figure out authentication flow.
* we should design organization first.
* Marko is the best to figure it out.
*
Search Algolia: plugin with gastby, really good search
## Notes for DEV CALL 11/10/2020
* Ben: Organizing dev meetings. Donation executive summary material creation with Dani. Distracted by markets. Intentions listen to updates and take notes.
* Mateo: Excited to have started work on last Friday. Busy with donation flow. Need PDF receipt for fiat donations. Will make issue and ask Marco for design. Donation history is next in line. Intention is to dive fully into things this week.
* Bryan: Working on account page. Intention is to get updated.
* Amin: Pushed tor.us embed. Error when building with Gatsby. Tries to fix.
* Kay: did mostly build stuff set up source cred. maintaining bridges because discord changed some stuff. Still hogging low hanging fruit issues promise to be ready soon. Crazy week. Left some questions in figma for marco and willy and got some responses from Marco some things to decide so will keep adding to questions. Info pages about Giveth which did not change the text. Heavily distracted, intentions are to still follow meeting.
#31 want to implement search using Minisearch. Assigned to Amin.
#61 Project View Mateo asked Bryan about implementation. Bryan needs to know what to do to generate the slug. Needs to generate projects. Markup in gastby node file.
#120 bryan will investgiate
Kay will build front end info pages like About Us and FAQ from Figma.
Bryan and Amin are generating pages based on Gatsby files. When you want to create a new page. Gasby has templates you can use so without templates using from a slug to rehydrate.
Mateo forked the previous Impact Graph repository which has all implementation of stripe. Will try and make a pull request and so will Kay.
Kay: Please don't push anything yet just create a pull request.
## Notes for DEV CALL 07/10/2020
* Amin: changed Torus wallet to standard wallet. asked user to sign message with private key. popup will be shown
* Kay: do we really want search on the FAQ pages. will do the pixel for vector graphics
* Reoganize ZenHub to correct flow. Bring up ideas in Discord.
* Proposal for work sprints to deliver work.
* Mateo: needs a lot of changes in the backend, make the screen actually synchronized
*
## Notes for DEV call 04/10/2020
* Kay: meeting monday. The issue was Epic editing pages. Most links are already up there. Played with wiki
* Bryan: started project view making more updates to it making some pages generated during deployment. Check latest branches that has fiat credit card
* Mateo: finished most of the stripe payment, only missing a webhook, hoping james would jump in.
* Camilo: 1. Simple flow want to create temporary token 2. Identity of donations now donations are anonymous or require user token 3. Apollo web checking change to apollo express. We should let Camilo and Mateo finish backend.
* Willy: ask James to explain white labeling and organizations. How to create an organization.
Post MVP, consider migrating from Gatsby to Next.js so front and backend can be bundled together and whitelabeling can be streamlined.
## Notes for DEV call of 01/10/2020
* Amin - closed issues related to node gateway. web socket connections were broken. Andre changed config and fixed it. Will handle buttons this week. Questions about mobile view. was occupied this week, needs help with leaderboard. Adding PAN moved to beta and needs to be tested.
* Andre - Adding tokens in beta server. looking for contract address in forwarding address. Need to test "In Progress" issues so it doesnt break system.
* Hadai - question about 1459 button off center. if button is moved to right, button is not in the center. No progress on issue cleanup task. Will implement #1413 tomorrow finally.
* Griff - closed #1459 and made it part of #1376 #1214 moved to sprint backlog because of low priority.
* Benjamin - testing adding PAN to Dapp with Amin.
## Notes for DEV Sprint Call of 28/09/2020
- Amin is going to take ownership of the Topia backend, specifically mapping new features in front end to backend. Next step is connecting the project creation flow to the backend.
- Mateo and Camillo are aiming to finish the 'Donate Fiat' flow this week
- New issue: Replace Tor.Us direct auth integration with Tor.us wallet integration
- New design needs: Show projects their donation address in the project creation flow (maybe the high five screen?) Give 'crypto savvy' projects the ability to 'Edit' their donation address. Give 'crypto noobie' projects a path to learn more about their new donation address and how it works.
- Time zones:
- Ben: Virginia (GMT -5)
- Mateo: Columbia (GMT -7)
- Camillo: Columbia (GMT -7)
- Bryan: East Africa (GMT +3)
- Amin: Iran (GMT+3.3)
- Kay: Austria (GMT +2)
## Notes for DEV Call of 27/09/2020
- Attending: Kay, Amin, Benjamin (Socretes), Mateo, Willy
- Staging is great again! Login is fixed: staging.giveth.io
- Gatsby handles env variables in a unique way. Kay needs to investigate and will report back.
- Mateo: Made a PR for donation flow earlier in the week. Need access to official account for Stripe Connect.
- Amin: Amin is back! Will be working on some v2 issues this week
-
## Notes for DEV Call of 20/09/2020
- We use Stripe Connect Express. Stripe handles KYC. Enables Project bank accounts and accept FIAT donations
- add create_organization mutaion to backend?
- Fiat donations and account management: Organizations might have more than one bank account. Lots of variables to talk about in follow up.
- Camilo created automated stripe customer creation on log-in. Created stripe endpoint that manages communication with stripe and have confirmations, errors about FIAT tranactions.
- Mateo takes care of frontend for Camilo's work
- PRs coming from Mateo for frontend and Camilo for the backend server
---
## Notes for DEV Call of 13/09/2020
- All PRs have been approved and merged!
- Amin, Mateo, Bryan: Please test your changes in prod and ensure they are still working as intended
- There is a bug in staging where users cannot sign in. Need to debug this. A request is being made for the $walletaddress and the response is causing an error.
- Next step: finalize project create flow so that projects are saved after creation. Bryan is working on this along with the High Five success page and the Project View page. (https://github.com/Giveth/giveth-2/pull/103)
- Willy worked with Mateo on donate fiat workflow. working with marko on more mockups. Use stripe to simply donate fiat.
- Mateo has a friend who wants to take on some backend development. He is badass. Wants to help us with stuff like graphql integration with stripe. auto creation of market place i.e.
---
## Notes for DEV Call of 05/09/2020
- Check out the new staging environment! (h/t @geleeroyale) https://staging.giveth.io/
- New process for reviewing and merging PRs: feature-branch -> staging -> master
- Mateo was able to replace some PNGs with SVGs. Some of the SVGs were not rendering properly. Mateo will make a PR to update the images that rendered correctly, and Kay will update the remaining images in the future.
- Mateo will make a PR to update the style of the Project Cards.
- Amin completed image upload functionality on the client side. Projects can upload a photo to IPFS in the project creation flow. *Still needs to be implemented in the project creation flow
*We are using pinata's IPFS service for this. This gives us 1GB of storage for free, after that we should pay
- Marko and Willy had a call. Shared doc from this in chat. Talked about settings. Required: Send funds example (should we just let app.tor.us pop up). Can we get the same private key in our dapp that they get in app.tor.us - torus embed could give us required functionality. (Amin explains drawback: behaviour of torus should be considered in our tx. rewrite functionality that use transactions for embed.)
To-Do
- Amin to create a ticket to move image upload functionality to server side so we're not exposing our pinata/IPFS key.
- Ping Bryan about implementing the pinata image upload functionality in the
- Project creation flow: Need the 'Confirm' and High Five' page along with the publishing the project to the backend
---
## Notes for DEV Call of 30/08/2020
- Kay reviewed Bryan's contribution, did some issue cleaning, deployed new sourcecred (cred.giveth.io), did start code work on localhost
- Bryan's update: Has a complete branch with Create a Project epic (https://github.com/Giveth/giveth-2/tree/dev/create-project-flow-epic). Kay will review and merge so we can test. Final remaining step is to make the call to GraphQL to save the project and fix any bugs.
- Mateo: Call with Willy, private issues so not much progress this week, James accepted backend PR for FIAT donation flow, help invetigate integration for Paypal or similar, SVG transformation is in progress. Will wait for Bryan's PR for SVG (Kay will ping)
- James: Wants to realize staging with Kay, need to schedule call
- Amin:
- Willy: Update board
To-Do
- Set up the backend for a staging environment for testing new features (https://github.com/Giveth/giveth-2/issues/88)
- Customize weight configurations in cred.giveth.io; Schedule meeting for Giveth 2 members and Hamad to determine optimal weight config. Propose to DAO before merging.
-
---
## Notes for DEV Call of 23/08/2020
- Kay is on last stretch of vacation, so assigned issues come next week
- Bryan is making good progress. Needs someone to look through PRs, bug with validation. Will schedule with Kay and Mateo to go through PR. Should be finished by Friday. Awesome!
- Mateo was able to set up project from guides. Solved on frontend and needs help with integration into backend. Needs invite to repo to make PR. Was looking at codebase and has some suggestions. Starting with replacing PNGs with SVGs.
- Amin implemented IPFS image upload. Is done client-side, but should be sent on to backend.
- To-do: Create an issue to replace PNG illlustrations with vector images (SVGs)
### Dev Progress
---
## Notes for DEV Call of 16/08/2020
### Dev Progress
- James worked on the GraphQL server, basically ready for MVP
- Amin looked at image uploader services (will implement IPFS service and push within next days)
- Bryan is almost done with create project flow and will issue PR soon
- Kay implemented sourcecred for GitHub and Discord. We need to work on weighting for it to be useful (see https://cred.giveth.io)
- Matteo will take on the Donation Flow epic
---
## Notes for DEV Call of 26/07/2020
- not much progress on frontend this week, more elements for homepage - still not done
- Amin finishes Tor.us embed integration and opened a new PR for @jamespfarrell to review
- Kay will continue working on frontend, Amin will pick an issue to work on (likely project view filtering)
- Gus takes charge of compiling info to guide contributors and development in general across Giveth and The Commons Stack
- Whitelabel versions will be feature-heavy. Currently two different ones are talked about (Panvala and https://gaiaprotection.com/)
---
## Giveth2 - technical planning
### Frontend Framework
Which framework do we want to build on. Currently we are using Gatsby, but that decision might be too opinionated for our aplication going forward. We are sure we want to build it on React.
- `gatsbyjs` stick with gatsbyjs for now
- ~~`vercel`~~
- ~~`create-react-app`~~ + some library for static rendering like [react-snap](https://github.com/stereobooster/react-snap)
### Tech stack
What is our full software stack? Should include important dependencies as well.
- `tech stack`
- `Frontend: React-based`
- `State Management: Apollo Client`
- `GraphQL server: Apollo, TypeGraphQL`
- `Blockchain-development: Set of smart contracts? Reuse?`
- `Blockchain-production: xDAI POA sidechain`
- `services`
- `Authentication integration and wallet provider: tor.us` (investigate risks of unseein issues with tor.us for complex usescases like managing campaigns and milestones, talk to tor.us)
- `OAuth provider: google`
- `blockchain query: infura?, thegraph?` - GraphQL stitching and federation
- `devtools`
- `storybook ?`
### Data structure and backend(s)
We have multiple pieces of data infrastructure. We should define:
- `data models`
- `db` & `blockchain` -> use database as store for state (postgres ...) -> triggers in database fire off actions to write to blockchain. Makes probably most sense for i.e. campaigns
- `data flow` : User enters data of a project -> we create entry in db -> upload info to ipfs -> return ipfs hash value to user -> user sign transaction with value of ipfs hash
### Deployment
Where is code deployed and hosted
- `code hosting: GitHub`
- `frontend & frontend CI: Netlify`
- `backend: digitalocean?`
- `backend CI: ?`
- `smart contracts`
### Development
How development is structured and organized
- DevFlow: `figma -> storybook -> develop`
- GitFlow: `feature-branch -> develop -> master`
- Project Management: `GitHub issues` & `Zenhub` & `Trello`
- Issue cleaning: `every 2 weeks?`