# FY21 Q4 Weekly Sync Meeting Notes

[Project board](https://github.com/github/connected-enterprise/projects/1)

(newest notes on top)

## Monday, Jun 28, 2021
- Metrics project
- Need tweaks to ensure reliability
- Need another 2 weeks
- Have some copy tweaks and UI covers
- Banner needs to be added when the admin logs in calling attention to new feature
- Team post coming soon re: performance testing
- Decoupling Connect ADR
- GHES security considerations -- need to ping security folks
- merge it this week
- Azure portal still blocked?
- [Blocked upstream](https://github.com/github/ghae-kube/issues/2083); the feature to send the email doesn't work so we have nothing to do as of now
- [Also need various accounts in Fairfax](https://github.com/github/ghae-azure-portal-extension/issues/73#issuecomment-868887760)
- Other things
- OKRs
- Actions marketplace badge
- Kelly to log a ticket and put it on the FR board
- Kelly to get M2 date so we can understand priority ☝️
- Product
- New user journey to minimise decision fatigue wrt turning features on & off
- UI changes to make features more visible
- Connect usage metrics need some love
- We should allocate time to iterate on features
- Probably in September after 3.2 ships
- Engineers in customer interviews
- Let's do it!

## Monday, Jun 21, 2021
- GHES metrics
- PRs need review
- current performance testing is good enough
- add a failure/timout reporting functionality to the metric gathering job
- Decoupling Connect
- ADR got several edits last week.
- A couple notes to add about "future considerations", e.g. GHES, then ready for final review
- review with LT on wednesday
- [x] Ted to schedule something for Sergio, Ted, Vanessa, and Kelly
- Azure Portal Extension
- smooth sailing right now
- FF deployment is done
- still blocked on testing
- FR
- bounty issue needs to be investigated and closed out

## Monday, Jun 14, 2021

- GHES metrics
- Next milestones
- MEC calculation: running the code on review lab
- Transmission: Make it work (merge 3 PRs)
- Current blockers:
- none
- What about in foreseeable future?
- Performance-wise for MEC calculation, there should be no concern but will try to replicate it as close as possible to be sure
- do we need integration test for enterprise 2?
- decide on Wednesday
- Decoupling Connect
- Next milestones
- Updating the ADR to address feedback and getting a 👍
- Meeting with LT to discuss & align
- Azure Portal Extension
- FF rollout hit a problem that needs fixing
- blocker:
- cannot log into instance after creating, so cannot test atm
- First responder (@tjl2)
- https://github.com/github/connected-enterprise/issues/137: may not be relevant anymore, just need to close the loop
- Product conversations
- share more wild ideas going forward
- service metrics toggle copy
- waffling on the dashboard incentive for metrics
- ideas on oss

## Monday, June 7, 2021
- First Reponder (@rubiojr)
- Testing Connect on GHAE (It works!)
- https://github.com/github/connected-enterprise/discussions/138
- GHES metrics
- MEC Calculation
- Started a draft PR and getting reviews from the data team.
- One last item for their(data team) review/help
- Will open to code review from the team (connected-enterprise)
- Testing only locally but will test against ghe.io this week
- How could we QA the retro-fill portion in time for release?
- A maximum of 24 months worth of data to backfill.
- Error/Retry management for the MEC job is still being decided. Currently, there is no retry.
- Admin Stats
- no date range parameters for the admin stats endpoint.
- Customer success team is asking for historical data.
- This team (connected-enterprise) is responsible for the Admin Stats Dashboard.
- Customer presentation of Admin Stats, the response was positive. Their desire is to keep "User" data anonymized.
- New dates to 3.2 release. FF: July 27, CF: August 10th, RC: Sept 28th , GA: Oct. 26th , Kelly will followup with Bwestover
- Kelly is getting copy from Legal for the Call To Action.
- Possibly having this feature only available for Enterprise accts.
- Azure Portal Extension
- Smooth Sailing
- lildude presented demo on how feature flags would work.
- GHAE Status Page
- Procurement Speed Bump
- SSPA review, it requires the vendor to go through code audits.
- As a result it might jeopardize the githubstatus.com site

## Monday, May 24, 2021

- GHES metrics
- MEC calculation
- discussion around MEC calculation on dotcom vs GHES
- our assumption: data team will own the query long term
- to be clarified with arfon & co
- activerecord vs single query
- go with single query so it's easier/simplier for data team to maintain going forward
- potential scope creep
- metrics gathering SDK is not in scope for this MVP
- admin stats "carrot"
- easy -- Colin can personally do this in a day 😆
- Azure Portal Extension
- RP has all the context
- need to flag concerns asap since this is needed for M2
- GHAE status page
- waiting to go through procrument which is a pain

## Monday, May 17, 2021
- First responder (@deleonjavier)
- Priority was testing fix for GHAE-Kube license
- It got reviewed
- Problems with launching ghae-kube clusters (script/setup)
- Others having issues as well; status check-ins; it was an issue with Azure
- Cutoff for M2 freeze is on a day-by-day slip still
- GHES Minimal Usage Ping
- Question from Kelly about sending metrics from this API and building a cloud dashboard for it: https://docs.github.com/en/enterprise-server@3.0/rest/reference/enterprise-admin#admin-stats
- Additional metrics being sent using the new metrics/telemetry framework soon (admin stats)
- The possibility of sending more metrics and having a compelling reason for our customers to enable the telemetry was discussed (analysing customer's GHES server performance and offering reports and hints to improve GHES performance for example)
- Decoupling Connect from GHEC
- Ted had productive meeting with James from ce-apps
- Consensus established on plan for ADR; long term ideas are on the table for M2M auth
- Potential future leverage of authnd project
- Bug fix for GHAE-Kube license path (@tbehling)
- PR was blocked on validation (see above); will retry today

## Monday, May 10, 2021

- GHES Minimal Usage Ping
- demo last week: https://github.rewatch.com/video/8087/status-update-demo-for-ghes-minimal-usage-ping-6-may-2021/
- Decoupling Connect from GHEC
- Writing ADR based on JWT-based proposal in #65
- Ted is meeting with James on Tuesday evening EST
- Push for alternatives or what's needed to move forward
- GHES Helpings
- Ted will talk with Brett about any questions on details of goals, hurdles, etc.
- First Responder?
- @deleonjavier
- Connect on GHAE-kube
- Ted has PR in flight for license path fix
- Anything else?
- 💡 enabling open source consumption & contribution for enterprises through connect

## Monday, May 03, 2021

- GHES Minimal Usage Ping (@deleonjavier)
- still making progress with feature 1 & 2
- can potentially just use a mock query to get the rest of the plumbing working first
- @rubiojr: WIP demo this week
- Decoupling Connect from GHEC (@tbehling)
- Working on ADR
- will need appsec review
- QA things
- GHAE ready?
- GHES helpings
- @tbehling will do it after wrapping up decoupling work
- Anything else?
- @everyone: work on setting up SAW a little bit at a time

## Monday, Apr 26, 2021

- GHES Minimal Usage Ping
- Timeline updates (@vanessayuenn)
- Feature 1: Calculate MEC (@deleonjavier @electroniko)
- mapping controller actions to SQL query ([reference](https://docs.google.com/spreadsheets/d/1RUpNC_Ii1cm90S1DH0F1nTqFPKrN-Uchc1lnV-2ZfCo/edit#gid=0))
- blockers: -
- Feature 2: Transmit data (@tjl2 @lildude @rubiojr)
- PR for the internal usage metrics endpoint: https://github.com/github/github/pull/177788
- blockers: -
- can potentially leverage decoupled gh connect (for future)
- Re: showing data collected in audit log
- we need to establish "rules" around data collection for GHE. e.g. only collect data we need/plan to use, only aggregated data.
- potentially hiding the granularity of what data is being collected
- Decoupling Connect from GHEC (@tbehling)
- Update at https://github.com/github/connected-enterprise/issues/58#issuecomment-826868918
- Prototyping of JWT token auth is ongoing in https://github.com/github/github/pull/177968
- @tbehling and @rubiojr will connect with James to understand if the proposed solution will work
- @tbehling to keep the experiment going for another week or so, then document findings and proposal for path forward
- Anything else?
- GHAE kube (i.e. M2)
- need to test connect on an AE-kube instance
- Can we finish documenting [this](https://github.com/github/connected-enterprise/issues/41) and close it off?
- @electroniko to make discussion thread for FR handoff

## Monday, Apr 19, 2021

- GHES Minimal Usage Ping
- Feature 1: Calculate MEC (@deleonjavier, @electroniko)
- shipped or learned anything?
- learned a lot how MEC is calculated for dotcom
- we are likely doing it differently
- @arfon will help with collaboration with data team
- they will own the MEC calculation query
- blockers:
- none
- Feature 2: Transmit data (@tjl2 and @lildude)
- can we start on this?
- yes, can be parallelised
- @tjl2 and @lildude will sync with @deleonjavier and @electroniko
- Decoupling Connect from GHEC (@tbehling, @rubiojr)
- shipped or learned anything?
- See tracking issue update at https://github.com/github/connected-enterprise/issues/75#issuecomment-821736402
- It has helped to split the problem into layers
- PoC of proposed UI for split basic/enterprise Connect features
- Worked on turning assumptions into running code in the form of an integration test
- We have been learning more about internal forms of GitHub Apps
- @rubiojr will have something to share by end of week
- Sergio has an open question for ecosystem-apps from #65
- blockers:
- none
- Anything else?
- QA for 3.1 RC?
- "each team will be responsible for their own QA"
- tentative plan:
- figure out process from corehub on getting the final artifact of release
- rotate manual walkthrough of manifest among team members per release
- data pipeline became a hot topic in product 👀
- sounds like we can get resources we need
- Question for Kelly: is there any impact for decoupling Connect from GHEC? this is focused on GHAE now; will these customers expect to use Connect on GHES without Cloud?

## Monday, Apr 12, 2021
Q4 Kickoff! Watch it on [rewatch](https://github.rewatch.tv/video/6926/connected-enterprise-fy21-q4-kickoff/) or read the [deck](https://docs.google.com/presentation/d/1zysn0F5sNFget31EOUSH5pAFkwfZDqg-yMBySKhR6KA/edit?usp=sharing)

## Tuesday, Apr 06, 2021

- Dev environment set up & documentation (@lildude)
- can close out this [issue](https://github.com/github/connected-enterprise/issues/61) after the steps to set up dev env are well documented
- next steps: do the doc
- blockers: -
- "How we work" document (@vanessayuenn and @deleonjavier)
- https://github.com/github/connected-enterprise/issues/38
- @vanessayuenn and @deleonjavier will pair on it this week
- Decoupling Connect from GHEC (for spike: @tbehling)
- https://github.com/github/connected-enterprise/issues/58
- what did we ship/learn? Gathered SME input on #65 with ideas for several options
- next steps:
- Local dev hacking on "Global App";
- Goal: confirm or refute whether this will work for GHAE Connect
- blockers: -
- Bug last week: [GitHub Connect new links broken](https://github.com/github/github/issues/175631)
- actually the fix was done by another team
- follow up items: none, a new test has been added already that will catch it shall this situation happen again
- Anything else?
- Data retention for `hive.snapshots_all.github_mysql1_enterprise_installations`
- Add model for MySQL Enterprise Installations table to Looker