Nushell core team meeting 2024-02-07

Attendees

• Darren
• Antoine
• Michael
• Yash
• Sophia
• Ed
• Ian

Agenda

• Anyone heard of problems on the 0.90.1 release (other than winget failing)? Should we go ahead and land the 0.90.2 bump?
• Catching upstream panics #11699, #11393, #11720
  • Wrap panicking code into catch_unwind()?
  • Wrap all command calls into catch_unwind()?
  • Wrap entire Nushell into catch_unwind()?
    • Did we use to have Miette for pretty backtraces? Maybe we could use something similar to reset the REPL in the case of panic?
  • Fix panicking by not passing panicking inputs to the panicking crate
    • not always possible / extremely difficult, see #11720
  • Problematic dependencies tracking: #11721
• PR landing flow to help compiling release notes
  • Adding merged PRs to milestone? E.g., #11718
    • needs to be applied to all merged PRs, otherwise not worth it
  • Adding labels on PRs
• Backticks #17130 - Is it time to move away from our backtick use case? Discord conversaiton
  • paths with spaces
  • make this work? ^c:\program files (x86)\some\thing.exe
  • change backticks for raw strings? darren's raw string pr 9956
  • add triple backticks for raw strings ala python's triple double quotes
• Reedline History # 741 - Remove duplicates from file-based history search
  • Right now if you type…

  ​​​​version
  ​​​​ls
  ​​​​help commands
  ​​​​version
  ​​​​ls
  ​​​​help commands
  

  • you get all of this stuff in your history
  • This PR would remove having duplicates
  • However if you go through the comments in the PR there is a counter argument by another committer that preserving all of your commands is important to them
  • Thoughts on the way to go ?
• Sophia's availability

Discussed Topics

Release 0.90.1

No issues reported

Panics

Let's wrap entire Nushell into catch_unwind(). We might need to pull out the Miette stuff and just use vanilla std::panic::catch_unwind().
Kubouch to talk with Jack/ayax79

Ed talked about some internal panics occuring. The new "fix" that doesn't exist yet should help with panics globally. Ed's issue has the panic label on it.

Help organize PRs for release notes

Kubouch - Should we put PRs in a milestone to make things easier to make release notes?

We need to do something better because it's always a rush and difficult to compile.

Maybe if we did a better job labels to query on.

There are labels that start with pr:. So use these labels when the PR is landed and add the issue to the milestone.

Backticks

All backtick words are bare words and can become strings.

Reedline

Use sophia's special forgetting.

git stash drop
git add .
git status | something | else
git status
git commit -m 'something'
ls
git push
git status

git s<tab> shows git status
hitting up again shows git status | something | else but does not show the git status proceeding it.

Issues

Image Not Showing Possible Reasons

• The image file may be corrupted
• The server hosting the image is unavailable
• The image path is incorrect
• The image format is not supported

Learn More →

the issues which needs-core-team-attention

Image Not Showing Possible Reasons

• The image file may be corrupted
• The server hosting the image is unavailable
• The image path is incorrect
• The image format is not supported

Learn More →

Note
to list all the PRs currently opened in nushell/nushell:

gh pr list --json url,number,author,title
| from json
| each {|i|
    $"- [($i.number)]\(($i.url)\) ($i.title) \(@($i.author.login)\)"
}
| reverse
| to text