owned this note changed 7 months ago
Linked with GitHub

Onbloc Gno Core Tasks

Kanban: link

Ongoing

  • Issue: we should not allow injecting methods on a non-exist PackageNode #1099 by Byeungjun
  • Common Wallet API for Gnoweb (Manfred issue #2799) by Jinwoo
    • Scope of work
      • Wirte API specification
      • Ref: (EIP-6963) Multi Injected Provider Discovery
      • Ref: (EIP-1193) Ethereum Provider JavaScript API
  • Go version inconsistency fails local unit tests #3174 by Byeongjun
    • Is there any way to reproduce it?
      • go 1.23 and run test file, then it will fail.

Ready for review

  • gnolang/overflow repo and math/overflow (ex p/demo/maths) should be synced up #1729 by @Byeongjun
  • Bug: contract execution fee is added on top of the transaction fee. #1067 by Myunghwan
    • PR: https://github.com/gnolang/gno/pull/3209
    • #1067 is alreday fixed. and then we focus #1070. we want to know what is goal clearly.
      • As is: gas fee is process when checkTx to validate signature from transaction.
      • To be: gas fee will be proccess after runTx that call vm to execute transaction. after runtx, we are able to know actually used gas. so, we calculate used gas * gas-fee to collect fee from account.
      • Is this correct approach? -> Makes sense
    • Update
      • Change the location where you collect GAS
  • [chain] Gas Estimations #1826 by Jinwoo
    • PR (tx-indexer): https://github.com/gnolang/tx-indexer/pull/120
    • Issue (tm2-js-client) https://github.com/gnolang/gno/issues/2799
    • PR (gno): https://github.com/gnolang/gno/pull/3207
    • PR (tm2-js-client): https://github.com/gnolang/tm2-js-client/pull/192
    • Scope of work
      1. (tx-indexer) Add a method to get the average gas price
        • Add a function that gives the average, minimum, and maximum value of the transaction's gas fee for each block with transactions.
          • Add an RPC endpoint and a graph QL endpoint.
          • If there is a transaction when the block is created, the gas price information will be updated.
        • Question: Additionally, do we need to add a method to calculate the above valus with a given block range? (or just need to calculate in a block?) -> Range
      2. (GnoVM) Add a estimatedGas RPC endpoint (using simulator)
        • Work based on master, forget about Ray's PR for this work for now.
        • We already have an endpoint to simulate transactions with the path /.app/simulate in ABCI query.
        • Questions:
          • During an ABCI query, requests from the /.app path have different response values than other paths. (tm2/pkg/sdk/baseapp.go#L413)
            • It uses values from Value instead of ResponseBase data from ResponseQuery. What is the intent? If it's not intended, can we change this? -> Change to data
            • Also, the response values from /.app/simulate are giving Amino marshaled values, do we need to follow this? or can we change it to be a json marchaled values? -> Use marshaled values
          • In the RunTxModeSimulate option of the options to run the Transaction, the code consumes txSize of gas, which makes the result different from the other options. Can we remove this? -> Remove this
        • Do we want to implement this also to tm2-js-client? -> Yes
          • getGasPrice
          • estimateGas
          • In order for tm2-js-client's gasPrice implementation to work, an indexer client needs to be added.
      3. (gnokey) Add a simulator option (separate PR)
        • Checked that it's done by Morgan in #1702
  • Add a Upgradable Realm pattern by IBCJoon

Merged

Select a repo