**Description of the change**
After upgrading to the latest Redis chart version from 12.0.1 we noticed that sentinel behaviour was broken.
Initially, we made another [PR](https://github.com/bitnami/charts/pull/7124) that tackled one specific issue we wanted to fix. However, we then realized that the current sentinel implementation is much more fragile than we thought it was.
In the current sentinel configuration there is an option to use `staticID: true` or not. This leads to two different behaviours to ensure the system's stability and resiliency.
Having different, functionally identical behaviours can introduce fragility. Specifically, supporting two incompatible configurations adds an additional burden to ensure that new bugs are not introduced to the other path.
- When **NOT** using `staticID: true`, new sentinel nodes will boot up with a randomly generated ID. And as per the sentinel’s [documentation](https://redis.io/topics/sentinel), `Sentinels never forget already seen Sentinels, even if they are not reachable for a long time`. In order to forget dead nodes, we need to command running nodes to clean their list of sentinel peers. Which is currently the case.
- When using `staticID: true`, new sentinel nodes will boot up with a fixed ID based on their hostname which is static when using a Statefulset. When a new node sentinel boots up, it reaches out to running sentinels on the network and announces itself with a constant ID. Because the other sentinels recognize this ID they update the IP of the sentinel node rather than registering it as a new sentinel node. This effectively alleviates the need to command sentinels to clean their list of sentinel peers.
Although both systems work, we believe using `staticID: true` is the superior solution for the following reason:
- Command sentinels to clean their list of sentinels, is done in a loop and a `sleep` command is run at each iteration. The `sleepDelay` value is defined in the values file, default is 5 seconds. Sentinel nodes run with a readinessProbe with a default timeout of 45secs before it fails and restarts the container. This sets a limit to the number of replicas your deployment can have before you need to manually override the readinessProbe values. And also, the more replicas, the longer it takes to boot up a new node. We believe it's not the most scalable system.
This PR harmonized the sentinel behaviours by making `staticID: true` as the default behaviour. The value is removed from the values file and cannot be overridden anymore. It offers a much more resilient and stable sentinel system which should allow for self-recovery in all scenarios.
**Benefits**
- Removes the need to command running sentinels on the network to clean their list of sentinel peers every time a new node joins the cluster. A `sleep` command was run at each iteration. Removing this makes the system more robust and scalable.
- Removes the need to check for master availability, which currently leads to a `CrashLoopBackOff` state when we lose enough nodes so that the quorum is not met to elect & promote a new master.
**Possible drawbacks**
- When a new node joins the cluster and the previous master is down and failover has not been performed yet, it will still consider it as the current master. When the next failover runs and the quorum is met, a new master will be elected and promoted. It might be considered as a drawback, however, there is no difference between a `CrashLoopBackOff` state and this, but now we can expect a full recovery. How fast a new master will be elected will depend on your `sentinel.downAfterMilliseconds` and `sentinel.failoverTimeout` values.
**Applicable issues**
<!-- Enter any applicable Issues here (You can reference an issue using #) -->
- fixes https://github.com/bitnami/charts/issues/5181
**Additional information**
- Removed `sentinel.staticID` and `sentinel.cleanDelaySeconds` from the values file. Should not be disruptive in any way.
**Checklist**
<!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] -->
- [X] Chart version bumped in `Chart.yaml` according to [semver](http://semver.org/).
- [X] Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])