Charles Bournhonesque
    • Create new note
    • Create a note from template
      • Sharing URL Link copied
      • /edit
      • View mode
        • Edit mode
        • View mode
        • Book mode
        • Slide mode
        Edit mode View mode Book mode Slide mode
      • Customize slides
      • Note Permission
      • Read
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
      • Write
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
    • Invite by email
      Invitee

      This note has no invitees

    • Publish Note

      Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note No publishing access yet

      Your note will be visible on your profile and discoverable by anyone.
      Your note is now live.
      This note is visible on your profile and discoverable online.
      Everyone on the web can find and read all notes of this public team.

      Your account was recently created. Publishing will be available soon, allowing you to share notes on your public page and in search results.

      Your team account was recently created. Publishing will be available soon, allowing you to share notes on your public page and in search results.

      Explore these features while you wait
      Complete general settings
      Bookmark and like published notes
      Write a few more notes
      Complete general settings
      Write a few more notes
      See published notes
      Unpublish note
      Please check the box to agree to the Community Guidelines.
      View profile
    • Commenting
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
      • Everyone
    • Suggest edit
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
    • Emoji Reply
    • Enable
    • Versions and GitHub Sync
    • Note settings
    • Note Insights New
    • Make a copy
    • Transfer ownership
    • Delete this note
    • Save as template
    • Insert from template
    • Import from
      • Dropbox
      • Google Drive
      • Gist
      • Clipboard
    • Export to
      • Dropbox
      • Google Drive
      • Gist
    • Download
      • Markdown
      • HTML
      • Raw HTML
Menu Note settings Note Insights Versions and GitHub Sync Sharing URL Create Help
Create Create new note Create a note from template
Menu
Options
Make a copy Transfer ownership Delete this note
Import from
Dropbox Google Drive Gist Clipboard
Export to
Dropbox Google Drive Gist
Download
Markdown HTML Raw HTML
Back
Sharing URL Link copied
/edit
View mode
  • Edit mode
  • View mode
  • Book mode
  • Slide mode
Edit mode View mode Book mode Slide mode
Customize slides
Note Permission
Read
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
Write
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
  • Invite by email
    Invitee

    This note has no invitees

  • Publish Note

    Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note No publishing access yet

    Your note will be visible on your profile and discoverable by anyone.
    Your note is now live.
    This note is visible on your profile and discoverable online.
    Everyone on the web can find and read all notes of this public team.

    Your account was recently created. Publishing will be available soon, allowing you to share notes on your public page and in search results.

    Your team account was recently created. Publishing will be available soon, allowing you to share notes on your public page and in search results.

    Explore these features while you wait
    Complete general settings
    Bookmark and like published notes
    Write a few more notes
    Complete general settings
    Write a few more notes
    See published notes
    Unpublish note
    Please check the box to agree to the Community Guidelines.
    View profile
    Engagement control
    Commenting
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    • Everyone
    Suggest edit
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    Emoji Reply
    Enable
    Import from Dropbox Google Drive Gist Clipboard
       Owned this note    Owned this note      
    Published Linked with GitHub
    • Any changes
      Be notified of any changes
    • Mention me
      Be notified of mention me
    • Unsubscribe
    * # LeafwingInputManager handling inputs in FixedUpdate ## Background The leafwing flow is:d - PreUpdate: - tick every action from `just_pressed` to `pressed` (let's call this `consuming` the input) - read from the Input events (emitted every frame) to update the ActionState to `just_pressed` for new inputs ## Problem We cannot reliably use `if action.just_pressed()` in `FixedUpdate` systems because: 1. in some cases,`FixedUpdate` runs 2 times in the same frame, which means that they would both had `just_pressed() = True` which is misleading situation 1 (S1): `F - FU - FU - F` 2. in some cases, `FixedUpdate` runs 0 times in one frame, which means that `just_pressed` becomes `pressed` and the input is never seen by the FixedUpdate system. situation 2 (S2): `F - F - FU - F` ``` Glossary: - `F` = `Frame start` - `FU` = `FixedUpdate start` ``` ## Prior work Relevant bevy issues: - input events don't have timestamp information [Issue](https://github.com/bevyengine/bevy/issues/5984). This doesn't seem really related. It would solve the problem of disambiguating input order within a single frame. - inputs can be missed in FixedTimeStep [Issue](https://github.com/bevyengine/bevy/issues/6183): relevant. The issue talks a lot about fixing this problem for bevy `Events` in general, which is not really what interests us in leafwing. In leafwing, all events are read correctly at the start of the frame, and used to update the `ActionState`. The problem is rather: "at what point do we make an action go from `just_pressed` to `pressed`"? ## What we want Solve: 1. After a `FixedUpdate` system runs, we want the input to be `consumed` 2. An input must always be seen by a FixedUpdate system; i.e. I want the input to be considered as 'consumed' (`just_pressed`->`pressed`) only if the `FixedUpdate` system saw it once. Other invariants we want to uphold: - An input is `just_pressed` only if it's also `pressed`. ``` NOTE: This means that we could still miss inputs if we are in the situation: `InputPress - F - InputRelease - F - FU - F` On the `FixedUpdate` run, the button is not pressed anymore so we don't want to have `just_pressed = True`. (i.e. the button press happened in a single frame, and no FixedUpdate schedule ran during that frame) That should be pretty rare because normally a button press lasts for more than a frame. The real solution is having timestamped inputs as described in [Issue](https://github.com/bevyengine/bevy/issues/5984). ``` ## Potential solutions #### Run leafwing systems in FixedPreUpdate and FixedPostUpdate This would solve 1. Problem: an input emitted on the first frame of S2 would get lost, since the leafwing systems would not run for that frame. This forces users to handle inputs in FixedUpdate, which is not ideal (ideally both Update and FixedUpdate could be used) #### Just_pressed = input happened since the last time I asked Currently, `just_pressed` = input happened on this frame, since all inputs are consumed at the beginning of the next frame. This might not be the definition that we want. Instead what is often useful is: - `pressed` = give me all inputs that are pressed right now (for example if a user keeps pressing a button) - `just_pressed` = give me all the button presses that happened since the last time I asked. (which makes sense if FixedUpdate or F) This could be implemented by storing the WorldTick when the input was emitted, and then `just_pressed` would return all events where the input's tick is more recent than the last run of the system. (Or maybe the implementation could be more simple, with just two button_states (one for Update and one for FixedUpdate). And two separate `consume` systems.) Let's see how this would do in the two faulty situations: - In `InputPress - F - FU - FU - F - InputRelease - F`, the first `F` and `FU` would have `just_pressed` for that input, which is what we want. - In `InputPress - F - F - FU - InputRelease - F`, the first `F` and `FU` would have `just_pressed` for that input, which is what we want. How do we update the API? As for the API, I guess we could have 2 just_pressed, one for FixedUpdate and one for Update; the first one is updated in PreUpdate by comparing the ticks. The second one is updated in FixedPreUpdate by comparing the tick as mentioned above. To make this more ergonomic, we could make both `just_pressed` accessible behind the same API, depending on which schedule is running. (similar to the `Time` plugin). This behavior should also be overridable.

    Import from clipboard

    Paste your markdown or webpage here...

    Advanced permission required

    Your current role can only read. Ask the system administrator to acquire write and comment permission.

    This team is disabled

    Sorry, this team is disabled. You can't edit this note.

    This note is locked

    Sorry, only owner can edit this note.

    Reach the limit

    Sorry, you've reached the max length this note can be.
    Please reduce the content or divide it to more notes, thank you!

    Import from Gist

    Import from Snippet

    or

    Export to Snippet

    Are you sure?

    Do you really want to delete this note?
    All users will lose their connection.

    Create a note from template

    Create a note from template

    Oops...
    This template has been removed or transferred.
    Upgrade
    All
    • All
    • Team
    No template.

    Create a template

    Upgrade

    Delete template

    Do you really want to delete this template?
    Turn this template into a regular note and keep its content, versions, and comments.

    This page need refresh

    You have an incompatible client version.
    Refresh to update.
    New version available!
    See releases notes here
    Refresh to enjoy new features.
    Your user state has changed.
    Refresh to load new user state.

    Sign in

    Forgot password
    or
    Sign in via Google Sign in via Facebook Sign in via X(Twitter) Sign in via GitHub Sign in via Dropbox Sign in with Wallet
    Wallet ( )
    Connect another wallet

    New to HackMD? Sign up

    By signing in, you agree to our terms of service.

    Help

    • English
    • 中文
    • Français
    • Deutsch
    • 日本語
    • Español
    • Català
    • Ελληνικά
    • Português
    • italiano
    • Türkçe
    • Русский
    • Nederlands
    • hrvatski jezik
    • język polski
    • Українська
    • हिन्दी
    • svenska
    • Esperanto
    • dansk

    Documents

    Help & Tutorial

    How to use Book mode

    Slide Example

    API Docs

    Edit in VSCode

    Install browser extension

    Contacts

    Feedback

    Discord

    Send us email

    Resources

    Releases

    Pricing

    Blog

    Policy

    Terms

    Privacy

    Cheatsheet

    Syntax Example Reference
    # Header Header 基本排版
    - Unordered List
    • Unordered List
    1. Ordered List
    1. Ordered List
    - [ ] Todo List
    • Todo List
    > Blockquote
    Blockquote
    **Bold font** Bold font
    *Italics font* Italics font
    ~~Strikethrough~~ Strikethrough
    19^th^ 19th
    H~2~O H2O
    ++Inserted text++ Inserted text
    ==Marked text== Marked text
    [link text](https:// "title") Link
    ![image alt](https:// "title") Image
    `Code` Code 在筆記中貼入程式碼
    ```javascript
    var i = 0;
    ```
    var i = 0;
    :smile: :smile: Emoji list
    {%youtube youtube_id %} Externals
    $L^aT_eX$ LaTeX
    :::info
    This is a alert area.
    :::

    This is a alert area.

    Versions and GitHub Sync
    Get Full History Access

    • Edit version name
    • Delete

    revision author avatar     named on  

    More Less

    Note content is identical to the latest version.
    Compare
      Choose a version
      No search result
      Version not found
    Sign in to link this note to GitHub
    Learn more
    This note is not linked with GitHub
     

    Feedback

    Submission failed, please try again

    Thanks for your support.

    On a scale of 0-10, how likely is it that you would recommend HackMD to your friends, family or business associates?

    Please give us some advice and help us improve HackMD.

     

    Thanks for your feedback

    Remove version name

    Do you want to remove this version name and description?

    Transfer ownership

    Transfer to
      Warning: is a public team. If you transfer note to this team, everyone on the web can find and read this note.

        Link with GitHub

        Please authorize HackMD on GitHub
        • Please sign in to GitHub and install the HackMD app on your GitHub repo.
        • HackMD links with GitHub through a GitHub App. You can choose which repo to install our App.
        Learn more  Sign in to GitHub

        Push the note to GitHub Push to GitHub Pull a file from GitHub

          Authorize again
         

        Choose which file to push to

        Select repo
        Refresh Authorize more repos
        Select branch
        Select file
        Select branch
        Choose version(s) to push
        • Save a new version and push
        • Choose from existing versions
        Include title and tags
        Available push count

        Pull from GitHub

         
        File from GitHub
        File from HackMD

        GitHub Link Settings

        File linked

        Linked by
        File path
        Last synced branch
        Available push count

        Danger Zone

        Unlink
        You will no longer receive notification when GitHub file changes after unlink.

        Syncing

        Push failed

        Push successfully