# Known bugs/issues

- [x] Sender contact page leads to transporter page
- [x] backend: fix tests
- [x] "Postal code city" :)
- [x] Strange formatting of pick-up and delivery window of created shipments in sender
- [ ] Multimodal is not supported for services
- [x] No clear error message when incorrect phone number when registering
- [x] No test coverage metrics (mabye use Jenkins?) (REVIEW) (Niels)
- [x] Recent deliveries in transporter dashboard keep appending when switching tabs
- [x] Reloading the page logs the user out (minor issue)
- [ ] Only VAN works as a transport means when creating a service (REVIEW)(Gust)
- [x] Location of shipment is always center of Belgium
- [x] The rule system is not easy to understand for new users (REVIEW)(Michiel + Robin)
- [ ] General: error message for wrong fields is not clear
- [ ] Some values can still be 0 when creating a service/shipment (e.g. weight capacity)
- [x] Components page for transporter is outdated and buggy (REMOVE FOR REVIEW)(Tijs)
- [ ] Edges of rules are not perfect (very minor, very low priority)
- [ ] The ' character in a transporter name is replaced by '
- [ ] When registering, it is not clear that you should link with google account (Robbe)
- [ ] Peer feedback: Upon submitting a Shipment with negative values, your backend will correctly validate the wrong data but the creation prompt will be closed. Now your user will have to fill it in all over again...
- [x] Shipment pick-up window and delivery window should be allowed to overlap
- [x] frontend + backend: shipment patch (delivered) (REVIEW)(Tijs)(Michiel)
- [x] frontend: shipment patch (edit drafted shipment) (REVIEW)(Tijs)(Michiel)
- [ ] frontend: points can dupclicate in region editor after patch.
- [x] Docs (Gust)
- [x] if you make a service, you can keep clicking on. This generates multiple, all the same, services (Robbe)
- [ ] When editing something about a service, you need to reload to see the change ()
- [ ] You cannot move an edge when editing the area of operations of a service
- [ ] Sorting options in transporter dashboard overlap when no shipments are allocated
- [ ] The frontend will not give error warnings when creating a service when fields are put on 0 (e.g. the maximum package weight can be 0)
- [ ] When creating a shipment, the start of the delivery window should lie after the start of the pick-up window, and the same for the end. If this is not done correctly, the shipment creation will fail without error message

# Ideas for improvements
- [ ] information icon with description
- [ ] undeletable nodes + marked in frontend
- [x] better naming conventions (e.g. true/false operations) (REVIEW) (Michiel)
- [x] default nodes on create
- [ ] frontend validation (in progress)
- [ ] When selecting the zone you want to deliver to, it is a little bit annoying that you can place unlimited points and the line of the last point follows the mouse constantly even when you try to press "confirm zone".
- [ ] The transporter rule system is understandable but it’s quite slow to use. For example for a maximum of 4 parameters you have to work in layers. Maybe it is possible to add some default premade rule systems which could be chosen and or modified.
- [ ] As a sender, reasonable defaults throughout would be nice so I don't have to fill in all parameters of the form.
- [ ] As a sender, can it be guaranteed that my package will be sent? It would be nice to get some indication (which I guess you can calculate based on transporter's services) while creating the shipment of how reasonable my parameters are. I suppose pick-up window and delivery window are the most significant.

# to think about
- [ ] heeft een service een minimal pickup/delivery window size nodig?
- [ ] optional fields in package?
- [x] get email from google account instead of form
- [ ] frontend + backend: split service createion in patch and post
- [ ] frontend + backend: grouping (REVIEW) (To + Gust, Robin + Robbe)

User manual + aanmaken docs (Daan)
Installation (Robin)
Dev manual ()