owned this note
owned this note
Published
Linked with GitHub
New PR https://github.com/TERITORI/teritori-dapp/pull/637
Old PR https://github.com/TERITORI/teritori-dapp/pull/384
### UI remarks
- Too many loaders styles : I think we need just one embedded loader and one full screen loader, currently we have many full screen loader styles and many embedded loader styles
- We need to definitely fix the inputs style (No crop borders, label outside, or something, etc..)
- Need many small UI fixes
### Actions with a multisig wallet
- Buy a TNS name : After approbations and broadcasting, the name is still available
- Delegate (Stake) : Doesn't work because the code need to be updated with the current way to make TX, using `SigninCosmWasmClient delegateTokens`
- Create Transaction (Send tokens) : It works, but the code need to be updated with the current way to make TX, using `SigninCosmWasmClient sendTokens`
- Switch account : We can switch account. But nothing changes.
- I need a precision as exemple (Multisig wallet selected): If the user clicks on Send (top menu), the multisig wallet is used ? The available tokens of this wallet are shown ?

- By extension, all the TXs on the dApp will be done with this multisig wallet ?
- So, where to see the multisig wallet's NFT, assets, etc ? In My Wallet, in Multisig ?
### Transactions status
- We don't show the received Transfers, it not depends on the Multisig feature, we don't still have this pattern "Get the TXs emitted to a wallet"
- We can't know if a TX has been broadcast, so the user can click on Broadcast indefinitely and get an error like "Already done blabla"
==> Maybe we need an end for this flow, what to do with the dozen of broadcasted (this world doesn't exist but fuckit) TXs in th history ?
- The flow "Make TX, then users approve, then Broadcast, and show the TX status" is OK
### Searching user by TNS
- We can make another PR for this : Search users by TNS => We put this future component on the fields for the wallet adresses, the user will be able to search TNS users (by typing) and select one, instead of typing a wallet adress
### Important point about the flow (Just my advise)
Maybe the flow is too complicated. Example :
==> We have the UI for Staking, Delegate, Undelegate etc..
We could just :
- Switch to multisig
- Go to /staking, then do things
- Then the multisig wallet's users have to approve or not
==> So, we don't have to re-make existing UIs. All the actions made with a multisig wallet will use the multisig approbation flow, but starts from the existing UIs.
===> Instead of listing some actions in the Multisig UI, creating a specific UI, etc...
All the msg used by `https://cosmos-multisig-ui-kohl.vercel.app` can be integrated globally on the dApp, not only for the Multisig feature :
MsgSend
MsgDelegate
MsgUndelegate
MsgBeginRedelegate
MsgWithdrawDelegatorReward
MsgSetWithdrawAddress
MsgCreateVestingAccount
MsgTransfer
========> BUUUUT, what about the "bulk transaction" ? On `https://cosmos-multisig-ui-kohl.vercel.app`, we can add many msg, then create a grouped transaction. Is this really usefull ?