OpenEBS Backup/Restore Discussions Notes
===
**This meeting has been merged with OpenEBS Community Syncup call. To join the call, you will need to RSVP to the events [here](https://community.cncf.io/openebs-community).**
:::info
- **Location:** ~~https://meet.google.com/frr-omqq-ofs~~
- **Date:** ~~Monthly on the third Monday from 10:00 pm to 10:30 pm (IST)~~
- **Agenda**
2.~~Walk through the status update~~
3.~~Discussion topic~~

*Add your request, question or suggestion to our [issue list](https://github.com/openebs/velero-plugin/issues)*

*If you have anything you’d like to put on the agenda, please do so below for the next meeting:*
:::

## June 17, 2021
Attendees: Mayank, Kiran
### Discussion topic
1. https://github.com/openebs/velero-plugin/issues/119
- Since this requires changes in CR, need a design on how we can support this feature : Mayank
2. ~~https://github.com/openebs/velero-plugin/issues/82~~
- ~~Verify this with the existing version : Mayank~~

## May 17, 2021
Attendees: Mayank, Kiran
### Discussion topic
1. https://github.com/openebs/velero-plugin/issues/119
- Since this requires changes in CR, need a design on how we can support this feature : Mayank
2. https://github.com/openebs/velero-plugin/issues/82
- Verify this with the existing version : Mayank

## March 15, 2021
Attendees: Mayank
[Mayank]
- configurable timeout for maya-apiserver API execution https://github.com/openebs/velero-plugin/issues/148

#### Status Update

## February 15, 2021
Attendees: Mayank

#### Status Update

## January 18, 2021
Attendees: Mayank, Kiran

#### Status Update
[Mayank]
- ~~Support to create destination namespace in case of namespace mapping for restore~~ [PR #140](https://github.com/openebs/velero-plugin/pull/140)
- ~~Optimizing restore to restoe all the scheduled backup~~ [PR #99](https://github.com/openebs/velero-plugin/pull/99)
- ~~Working: Restore is partially failed when autosetTarget ip is enabled~~ https://github.com/openebs/velero-plugin/issues/141~~

## December 21, 2020
Attendees: Kiran, Vishnu, Mayank

#### Status Update
[Mayank]
- Support to create destination namespace in case of namespace mapping for restore [PR #140](https://github.com/openebs/velero-plugin/pull/140)
- Optimizing restore to restoe all the scheduled backup [PR #99](https://github.com/openebs/velero-plugin/pull/99)
- Working: Restore is partially failed when autosetTarget ip is enabled https://github.com/openebs/velero-plugin/issues/141

[Discussion]
- https://github.com/openebs/velero-plugin/issues/119

#### Community Shoutouts
- @zlymeda : Marking CVRs after successful restore with openebs.io/restore-completed if autoSetTargetIP=true or restoreAllIncrementalSnapshots=true [PR #131](https://github.com/openebs/velero-plugin/pull/140)

## October 19, 2020
Attendees: Mayank, Ashutosh

#### Status Update
[Mayank]
- Optimizing restore for incremental backup. [PR #99](https://github.com/openebs/velero-plugin/pull/99)
- Fix restore controller to return success if snapshot is already present. -- Pending

- After a restore, cStorVolume remains in Init, CVRs remain in Error state [Issue #127](https://github.com/openebs/velero-plugin/issues/127)
- Automate manual steps to set target-ip [Issue #120](https://github.com/openebs/velero-plugin/issues/120)
- This requires setting target-ip from velero-plugin on restore completion. Relevant [PR #99](https://github.com/openebs/velero-plugin/pull/99), to restore incremental backups in single restore, is under review stage.
- Ondrej Beluský is working on cstor control plane to set target-ip through replica controller
- How to combine snapshots (incremental backups) with backup deletion because of TTL [Issue #119](https://github.com/openebs/velero-plugin/issues/119)
- Existing schedule snapshots are an incremental snapshot. Changing this behavior will impact existing users.
- We can add a new config parameter to disable incremental snapshots for schedules

In review:
- https://github.com/openebs/velero-plugin/pull/99

## September 17, 2020
Attendees: Mayank, Vitta, Kiran, Ashutosh

#### Status Update
[Sai]
- Refactoring API from openebs.io group to cstor.io group is done. Waiting for reviews to complete.

[Mayank]
- Fix restore controller to return success if snapshot is already present. -- Pending
- Support to pass certificate data to velero-plugin trough volumesnapshotlocation [PR](https://github.com/openebs/velero-plugin/pull/115)

Pending review:
- https://github.com/openebs/api/pull/58
- https://github.com/openebs/openebs/pull/3072
- https://github.com/openebs/velero-plugin/pull/99

## August 18, 2020
Attendees: Sai, Mayank

#### Status Update
[Sai]
- Refactoring API from openebs.io group to cstor.io group is done. Waiting for reviews to complete.

[Mayank]
- Fix restore controller to return success if snapshot is already present. -- Pending
- Raised a [PR](https://github.com/openebs/velero-plugin/pull/104) to disable some linters to fix flaky travis build
- Review [PR](https://github.com/openebs/velero-plugin/pull/102) for zfs-localpv

Pending review:
- https://github.com/openebs/api/pull/58
- https://github.com/openebs/openebs/pull/3072
- https://github.com/openebs/velero-plugin/pull/99
- https://github.com/openebs/velero-plugin/pull/102
- https://github.com/openebs/velero-plugin/pull/104

## August 4, 2020
Attendees: Sai, Mayank

#### Status Update
[Sai]
- Refactoring API from openebs.io group to cstor.io group is done. Waiting for reviews to complete.

[Mayank]
- Raised a PR to restore incremental backups in a single restore.
- Fix restore controller to return success if snapshot is already present. -- Pending

Pending review:
- https://github.com/openebs/api/pull/58
- https://github.com/openebs/openebs/pull/3072
- https://github.com/openebs/velero-plugin/pull/99

## July 21st, 2020
Attendees: Sai, Vitta, Mayank, Ashutosh

#### Status Update
[Sai]
- Refactoring API from openebs.io group to cstor.io group.

[Mayank]
- To restore incremental backup in one restore process.
- Fix restore controller to return success if snapshot is already present.

[Ashutosh]
- Reviewed OEP document.

Pending review:
- https://github.com/openebs/openebs/pull/3072

## June 23rd, 2020
Attendees: Sai, Mayank, Ashutosh

#### Status Update
[Sai]
- refactoring required in code base to use constants instead of literals in code for cstor-operator
- Working on approach to add/update new field in cstorcompletedbackup resource

[Mayank]
- Adding log message for error during REST call
- Support to add progress in cstor{backup/restore} resource

[Ashutosh]
- Added support to backup/restore cstor v1 in velero-plugin

## June 9th, 2020
Attendees: Vitta, Sai, Mayank, Kiran, Shashank

#### Status Update
[Sai]
- Little refactoring might required in code base to use constants instead of literals in code for cstor-operator

[Mayank]
- Will test plugin with cstor v1 [https://github.com/openebs/velero-plugin/pull/91]
- missing part
- handling output of backup request
- check for apiserver/cvc-server from storageclass : this check is required during restore

[Shashank]
- Added new test cases in pipeline
- backup/restore using multiple s3 profile
- Restore of remote backup in different namespace
- Working on failed backup deletion
- Add support for velero v1.4. [next release]

## May 26th, 2020

Attendees: Vitta, Sai, Mayank, Shashank

#### Status Update
[sai]
- Working on REST API for Backup / Restore in CVC Controller
- Will work on backup controller in Pool Manager (with cstor v1)

[Shashank]
- Restore of remote backup in different NS (PR under review)
- Working on deletion of failed backup

[Mayank]
- Coding for CSI support blocked on OEP

[Vitta]
- Work on OEP PR to fill details on velero plugin

### Discussion Topics

- Annotation being passed through PVC is needed during restore operation
Ashutosh will explore the CSI versions from which annotations are passed to CSI driver by CSI external provisioner

## May 12th, 2020

Attendees: Vitta, Kiran, Sai, Mayank, Ashutosh, Shashank

#### Status Update
[Mayank]
- Added support to restore remote backup in different namespace
- Minor bug fixes
- Working on https://github.com/openebs/maya/issues/1689
- Will work on velero-plugin changes to contact REST API from CVC Controller for CSI Driver volumes.
- Blocked on CVC Controller API changes

[Shashank]
- Following test case planned for next release
- Restoring remote backup in different namespace
- Deletion of failed backup, created through velero-plugin (https://github.com/openebs/e2e-tests/issues/323)
- Multiple S3 profile for remote backup for cstor volumes
- Automation to create weekly backup on workload cluster, having data more than 50G.

[Sai]
- Working on OEP for backup/restore with cstor v1
- Will work on REST API for Backup / Restore in CVC Controller
- Will work on backup controller in Pool Manager (with cstor v1)

[Ashutosh]
- Will work on restore controller in Pool Manager (with cstor v1)

### Discussion Topics

- [Kiran] Low level tasks for getting cStor CSI backup/restore working
- Added task to implement backup/restore support in cstor V1 for Sai and Ashutosh

- [Vitta] Backup/Restore progress in CRs and syncing them at destination
- Updating progress of backup/restore in cstorbackup/cstorrestore CR
- Sync cstorbackup CR at remote storage to fetch the size of backup
- [Kiran] Review Product and E2e Backlogs
- [Kiran] Support for Restore from Backup taken from old schema. Add to backlog.

## April 28, 2020

Attendees: Vitta, Kiran

### Discussion Topics
[Kiran]
- Scope of OpenEBS Backup / Restore.
- Should this be limited to supporting via Velero? (Yes for now)
- Identify the pending backlogs for velero based backup/restore by checking
- requests from openebs and velero commuinity
- mentioned at https://github.com/openebs/velero-plugin/issues
- complaince with velero plugin features (like local snapshots)
- Future backlogs can include supporting other opensource or standards like CSI enhancements to backup/restore.
- What are the pending items to mark Backup/Restore as GA in OpenEBS.
- cStor Backup/Restore GA
- Support for cStor CSI based Volumes?
- https://github.com/openebs/openebs/issues/2905
- Check with Mayank on pending functionality?
- tracked at https://github.com/openebs/velero-plugin/issues?q=is%3Aissue+is%3Aopen+label%3AEnhancement
- Check with Mayank/Shashank on E2e Tests?
- Jiva, Local PV Hostpath, Device Backup/Restore GA
- Check with Mayank on pending functionality?
- for all three storage engine, mentioned above, we are using velero-restic for backup. Haven't recieved any request from community as of now
- Check with Mayank/Shashank on E2e Tests?

## April 14, 2020

#### Status Update
[Mayank]
- Added support for snapshot and backup-resource deletion in plugin
- Improve backup functionality to delete snapshot and backup-resource for completed backup
- Added support for local backup/restore which enables the user to create volume from existing snapshot and use it in different namespace

[Shashank]
- Automated test case for verification of local snapshot deletion for remote backup
- Automated test case for local snapshot restore
- Test case for maya-apiserver restart during backup
- Added velero version to 1.3.0 in test case
- Perfomed test to verify backup failure for cstor volume having data more than 50G

#### Discussion Topics
[Mayank] Supporting mutliple s3 profile

[Mayank] Refactoring documents for plugin
- Required documents are in docs.openebs.io, current version of README.md is sufficent for backup/restore information.

[Shashank] e2e test
- Extend existing test case for snapshot deletion verification to verify in schedule backup
- Test case to delete cstor volume from where local restore already happened
- Weekly remote backup/restore for workload cluster having data >=100G
- Test case to restore from scheduled backup where backup is already expired

[Vitta] Remote restore in different namespace
- If the feature is not supported then we need to clean-up the code due to different approach for local/remote backup/restore