JeongAh Hong
    • Create new note
    • Create a note from template
      • Sharing URL Link copied
      • /edit
      • View mode
        • Edit mode
        • View mode
        • Book mode
        • Slide mode
        Edit mode View mode Book mode Slide mode
      • Customize slides
      • Note Permission
      • Read
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
      • Write
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
      • Engagement control Commenting, Suggest edit, Emoji Reply
    • Invite by email
      Invitee

      This note has no invitees

    • Publish Note

      Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note

      Your note will be visible on your profile and discoverable by anyone.
      Your note is now live.
      This note is visible on your profile and discoverable online.
      Everyone on the web can find and read all notes of this public team.
      See published notes
      Unpublish note
      Please check the box to agree to the Community Guidelines.
      View profile
    • Commenting
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
      • Everyone
    • Suggest edit
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
    • Emoji Reply
    • Enable
    • Versions and GitHub Sync
    • Note settings
    • Note Insights New
    • Engagement control
    • Make a copy
    • Transfer ownership
    • Delete this note
    • Save as template
    • Insert from template
    • Import from
      • Dropbox
      • Google Drive
      • Gist
      • Clipboard
    • Export to
      • Dropbox
      • Google Drive
      • Gist
    • Download
      • Markdown
      • HTML
      • Raw HTML
Menu Note settings Note Insights Versions and GitHub Sync Sharing URL Create Help
Create Create new note Create a note from template
Menu
Options
Engagement control Make a copy Transfer ownership Delete this note
Import from
Dropbox Google Drive Gist Clipboard
Export to
Dropbox Google Drive Gist
Download
Markdown HTML Raw HTML
Back
Sharing URL Link copied
/edit
View mode
  • Edit mode
  • View mode
  • Book mode
  • Slide mode
Edit mode View mode Book mode Slide mode
Customize slides
Note Permission
Read
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
Write
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
Engagement control Commenting, Suggest edit, Emoji Reply
  • Invite by email
    Invitee

    This note has no invitees

  • Publish Note

    Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note

    Your note will be visible on your profile and discoverable by anyone.
    Your note is now live.
    This note is visible on your profile and discoverable online.
    Everyone on the web can find and read all notes of this public team.
    See published notes
    Unpublish note
    Please check the box to agree to the Community Guidelines.
    View profile
    Engagement control
    Commenting
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    • Everyone
    Suggest edit
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    Emoji Reply
    Enable
    Import from Dropbox Google Drive Gist Clipboard
       Owned this note    Owned this note      
    Published Linked with GitHub
    • Any changes
      Be notified of any changes
    • Mention me
      Be notified of mention me
    • Unsubscribe
    @lina0322 엘림 안녕하세요! Step1 PR을 보냅니다!! 저희가 날씨요청을 받아오기 위한 APIKey를 APIKey.plist 파일에 저장해두었습니다. 근데 레포에는 올리지 않았기 때문에 저희가 보내드리는 APIKey.plist 파일을 `/WeatherForecast/WeatherForecast/` 에 옮겨두시면 아마 잘 작동될 것 같습니다! 리뷰 잘 부탁드립니다 감사합니다 :) ## 궁금증/고민 ### 1. 에러 처리 아직 에러 처리를 어떻게 해야할지 어렵습니다. 예를 들어 WeatherForecastRoute.swift의 APIKey 연산 프로퍼티의 경우 파일이 없을 때와 키가 없을 때 에러 처리를 해야하는데 사용자에게도 알려줘야할지 개발자만 알 수 있도록 하면 될지 고민입니다. - 만약 사용자에게 알려야 한다면 Alert같은 것을 띄워줘야할 것 같다고 생각했습니다. 근데 그럴 경우 Alert를 만들어서 ViewController에서 present()해야하는데, 이를 어떻게 ViewController에게 전달할지가 의문입니다. 혹시 delegate 패턴을 써서 WeatherForecastRoute가 ViewController를 delegate으로 지니고 있는게 좋을지 아니면 NotificationCenter 등을 활용해야하는 것인지, 그것도 아니라면 APIKey를 받아오는 로직을 ViewController에서 구현해야할지 등이 어렵습니다. 현재는 APIKey를 못 받아오면 nil을 리턴해서 요청에 실패하는 식으로 처리하고 있습니다. ```swift private static var apiKey: String? { guard let filePath = Bundle.main.path(forResource: APIKey.fileName, ofType: APIKey.fileExtension) else { return nil } let plist = NSDictionary(contentsOfFile: filePath) guard let key = plist?.object(forKey: APIKey.fileName) as? String else { return nil } return key } ``` - 만약 사용자에게 알리지 않는 에러의 경우 어떻게 처리하면 좋을지도 궁금합니다. 보통 print()문으로 에러를 출력해서 확인하곤 했는데 코드에 print()문을 남기면 좋지 않다고 들었습니다. 그렇다면 예를 들어 다음과 같은 경우 catch 블럭에 무엇을 써줘야할지 궁금합니다. 지금 생각으로는 그냥 무시하거나 사용자에게 알리는 방법 등이 떠오르는데 더 좋은 방법은 없는지 엘림의 조언을 부탁드립니다! ```swift do { try throwingFunction() } catch { // 이 부분의 처리가 궁금합니다 } ``` ### 2. Network 타입의 재사용성 재사용성을 위해 최대한 Network 타입의 역할을 분리해봤습니다. 현재 header, bodyParameters, queryItems을 모두 개별 매개변수로 받고 있는데 이 항목들은 하나의 타입으로 합쳐서 관리하도록 리팩토링할 예정입니다. 현재 구조가 괜찮은지 혹은 어떻게 개선하면 좋을지 조언 부탁드립니다. ### 3. Model타입에서 어떤 프로퍼티를 옵셔널로 둘지 Current 날씨랑 FiveDay 날씨의 데이터를 받아올 때 일부 프로퍼티에 위도/경도에 따라 없는 것을 발견했습니다. 어떤 프로퍼티가 생략되어있을지 몰라서 저희가 임의로 옵셔널임을 확인한 프로퍼티들만 옵셔널로 설정해두었습니다. 이처럼 json의 데이터 중 어느 값이 없을지 모르는 경우 지금과 같은 방식이 괜찮은지 아니면 프로퍼티들을 모두 옵셔널로 둬야할지, 그것도 아니라면 더 좋은 방법은 없는지 궁금합니다!

    Import from clipboard

    Paste your markdown or webpage here...

    Advanced permission required

    Your current role can only read. Ask the system administrator to acquire write and comment permission.

    This team is disabled

    Sorry, this team is disabled. You can't edit this note.

    This note is locked

    Sorry, only owner can edit this note.

    Reach the limit

    Sorry, you've reached the max length this note can be.
    Please reduce the content or divide it to more notes, thank you!

    Import from Gist

    Import from Snippet

    or

    Export to Snippet

    Are you sure?

    Do you really want to delete this note?
    All users will lose their connection.

    Create a note from template

    Create a note from template

    Oops...
    This template has been removed or transferred.
    Upgrade
    All
    • All
    • Team
    No template.

    Create a template

    Upgrade

    Delete template

    Do you really want to delete this template?
    Turn this template into a regular note and keep its content, versions, and comments.

    This page need refresh

    You have an incompatible client version.
    Refresh to update.
    New version available!
    See releases notes here
    Refresh to enjoy new features.
    Your user state has changed.
    Refresh to load new user state.

    Sign in

    Forgot password

    or

    By clicking below, you agree to our terms of service.

    Sign in via Facebook Sign in via Twitter Sign in via GitHub Sign in via Dropbox Sign in with Wallet
    Wallet ( )
    Connect another wallet

    New to HackMD? Sign up

    Help

    • English
    • 中文
    • Français
    • Deutsch
    • 日本語
    • Español
    • Català
    • Ελληνικά
    • Português
    • italiano
    • Türkçe
    • Русский
    • Nederlands
    • hrvatski jezik
    • język polski
    • Українська
    • हिन्दी
    • svenska
    • Esperanto
    • dansk

    Documents

    Help & Tutorial

    How to use Book mode

    Slide Example

    API Docs

    Edit in VSCode

    Install browser extension

    Contacts

    Feedback

    Discord

    Send us email

    Resources

    Releases

    Pricing

    Blog

    Policy

    Terms

    Privacy

    Cheatsheet

    Syntax Example Reference
    # Header Header 基本排版
    - Unordered List
    • Unordered List
    1. Ordered List
    1. Ordered List
    - [ ] Todo List
    • Todo List
    > Blockquote
    Blockquote
    **Bold font** Bold font
    *Italics font* Italics font
    ~~Strikethrough~~ Strikethrough
    19^th^ 19th
    H~2~O H2O
    ++Inserted text++ Inserted text
    ==Marked text== Marked text
    [link text](https:// "title") Link
    ![image alt](https:// "title") Image
    `Code` Code 在筆記中貼入程式碼
    ```javascript
    var i = 0;
    ```
    var i = 0;
    :smile: :smile: Emoji list
    {%youtube youtube_id %} Externals
    $L^aT_eX$ LaTeX
    :::info
    This is a alert area.
    :::

    This is a alert area.

    Versions and GitHub Sync
    Get Full History Access

    • Edit version name
    • Delete

    revision author avatar     named on  

    More Less

    Note content is identical to the latest version.
    Compare
      Choose a version
      No search result
      Version not found
    Sign in to link this note to GitHub
    Learn more
    This note is not linked with GitHub
     

    Feedback

    Submission failed, please try again

    Thanks for your support.

    On a scale of 0-10, how likely is it that you would recommend HackMD to your friends, family or business associates?

    Please give us some advice and help us improve HackMD.

     

    Thanks for your feedback

    Remove version name

    Do you want to remove this version name and description?

    Transfer ownership

    Transfer to
      Warning: is a public team. If you transfer note to this team, everyone on the web can find and read this note.

        Link with GitHub

        Please authorize HackMD on GitHub
        • Please sign in to GitHub and install the HackMD app on your GitHub repo.
        • HackMD links with GitHub through a GitHub App. You can choose which repo to install our App.
        Learn more  Sign in to GitHub

        Push the note to GitHub Push to GitHub Pull a file from GitHub

          Authorize again
         

        Choose which file to push to

        Select repo
        Refresh Authorize more repos
        Select branch
        Select file
        Select branch
        Choose version(s) to push
        • Save a new version and push
        • Choose from existing versions
        Include title and tags
        Available push count

        Pull from GitHub

         
        File from GitHub
        File from HackMD

        GitHub Link Settings

        File linked

        Linked by
        File path
        Last synced branch
        Available push count

        Danger Zone

        Unlink
        You will no longer receive notification when GitHub file changes after unlink.

        Syncing

        Push failed

        Push successfully