--- tags: outreachy, cohort-call, template --- # Outreachy Cohort Call 2 :::info **Call info:** - Time/date: {{insert date and time here}} - Your timezone: {{insert an arewemeetingyet.com link here}} - Video conference link: {{insert link to a video conferencing platform here}} ::: ## Joining the call / Roll call Once you've joined the call: - Add your name to the attendee list below - Don't forget to turn on your camera :) **Attendees:** Name / Project / GitHub username / Favourite dinosaur? - - - ## Code of Conduct :::info - Code of Conduct: https://jupyter.org/governance/conduct/code_of_conduct.html - Generally, treat others with kindness and respect, no matter who they are. - We know you do this already! ::: ## Group Update What have you worked on so far? Is there help from another intern you'd like to ask for? - [name=Name] / Project - Write an update here - [name=Name] / Project - Write an update here - [name=Name] / Project - Write an update here ## What makes code "good" or "bad"? _(10 mins)_ Think back to the last group call where we made a list of good open source practices as well as the train-wrecks we'd encountered. Could any of these apply to a code review sesion? Try to think of more, focusing on technical issues such as code quality, git commits, documentation, etc. Here is the link to the last call to refresh your memory: {{insert link to previous call's notes here}} ### :pencil2: Things you never want to see in a code repo :no_good: (but maybe have) - write something here - write something here - write something here ### :pencil2: Things that make a code repo really easy to work with, update, run :ok_hand: - write something here - write something here - write something here ## :speech_balloon: Breakout rooms: Code review practice We'll start by reviewing code that isn't written by anyone in the group. _(15 mins)_ - **Thinking:** _(3 mins)_ - Pick **one** of these repos: - https://github.com/madetech/sensible_logging - https://github.com/taverna/taverna-svn - https://github.com/biopython/biopython - https://github.com/mozilla/jschannel - Spend a couple of minutes looking through your chosen repo. Note down 2-3 points each for: - Things that could be improved - Good quality code - **Sharing:** _(3 mins per person)_ - Share one good thing and one thing that could be improved with your group. Try to bring something new that wasn't discussed before! - Did the group agree with your assessment? Discuss. ### Giving Feedback _(15 mins)_ - Silent writing #### :pencil2: What is feedback? - [name=Name] - answer - [name=Name] - answer - [name=Name] - answer #### :pencil2: How do you feel when you're expecting to receive feedback? - [name=Name] - answer - [name=Name] - answer - [name=Name] - answer #### :pencil2: What happens when we only give negative feedback? - [name=Name] - answer - [name=Name] - answer - [name=Name] - answer #### :pencil2: What about when we only give positive feedback? - [name=Name] - answer - [name=Name] - answer - [name=Name] - answer #### :pencil2: What are your tips for giving feedback? - [name=Name] - answer - [name=Name] - answer - [name=Name] - answer ## :speech_balloon: Breakout rooms: Code review This time we will review code you've been working on for Outreachy. ### Sharing & feedback _(7 mins per person)_ Share the code repository (or just one of them, if you have multiple repos) that you've been working on with JupyterHub for Outreachy. Your group mates will spend a couple of minutes looking at your code repo, and like before: - Try to find 1-2 things to improve - Try to find 1-2 good things about the repo / code Each group member should share one good thing and one thing to improve, then move onto the next code repo. ## Open Q&A Anything we didn't cover? Feel free to add question via text or verbally. - type your question - type your question - type your question