Libs-API Meeting 2022-08-09

tags: Libs Meetings Minutes

Meeting Link: https://meet.jit.si/rust-libs-meeting-crxoz2at8hiccp7b3ixf89qgxfymlbwr
Attendees: Amanieu, Jane, Josh, Mara, Mark, Chris Denton, J Haigh, vincenzopalazzo

Agenda

• Triage
• Anything else?
  • ACP process discussion, in particular around old pending PRs.

Triage

FCPs

17 rust-lang/rust T-libs-api FCPs

m-ou-se (7), BurntSushi (11), yaahc (10), joshtriplett (4), dtolnay (5), Amanieu (6)

Nominated

• 10 rust-lang/rust I-libs-api-nominated items
  • rust.tf/64102 Tracking issue for RFC 2360, `hint::bench_black_box`
    • Compiler fcp ongoing. Naming+signature still tbd.
  • rust.tf/70887 Tracking Issue for Integer::{log,log2,log10}
    • i prefix for these integer versions?
    • C++ has log(int) -> float, so a separate ilog could make sense.
    • powi has the i at the end. but that's a method on floats taking an int, not the other way around.
    • Mark links a netbsd man page with ilog2
    • Let's go for ilog
  • rust.tf/98704 Implement FromRawFd/Handle for ChildStdin/out/err object
    • Let's not add the old 'raw' traits for now. We might want to deprecate it in the future.
  • rust.tf/98862 Make mem::uninitialized inaccessible in future editions
    • the function is already deprecated, but that might not be 'strong enough'. it's invisible for dependencies
    • getting warnings for dependencies is useful. e.g. a future incompatibility lint. (regardless of edition)
    • josh to comment.
  • rust.tf/99606 Guarantees of content preservation on `try_reserve` failure?
    FCP finished. Needs PR
  • rust.tf/99683 regression: Join impl for OsStr insufficiently generic
    • One crater failure, where the code has their own Join trait that now no longer gets selected.
    • Additional discussion on whether or not we could move from Borrow to AsRef because Borrow is meant to be used when you have additional constraints on the behavior of hash and eq impls between the borrowed and owned types, which does not apply at all for these Join impls, so AsRef would be the more appropriate bound.
  • rust.tf/99684 regression: "self" in writeln! drops too early
    • Reverted/fixed and backported.
    • Hack: https://github.com/rust-lang/rust/pull/100202/files
      • Complicated. Probably not worth it.
  • rust.tf/99878 Panic in escape_ascii().len()
    • We could remove ExactSizeIterator. It's breaking, but it seems like no one actually depends on that.
    • Let's merge it and see what happens.
    • PR for removing it: https://github.com/rust-lang/rust/pull/99880
  • rust.tf/99898 typeck: silence lint for "collision safe" items
    • Could cause subtle issues when someone forgets to enable #![feature(..)] and they silently get the stable version, which might be more strict w.r.t. soundness.
    • Mara to comment.
  • rust.tf/100196 env::temp_dir returns /private/tmp on Apple instead while /tmp is
    • Motivation unclear. Asked for clarification.

Waiting on team

None

Needs decision

None

Stalled Tracking Issues

• 30 rust-lang/rust T-libs-api C-tracking-issue items
  • rust.tf/79676 Tracking Issue for `backtrace_frames`
  • rust.tf/42839 Peer credentials on Unix socket
  • rust.tf/55132 Tracking issue for thread::Builder::spawn_unchecked
  • rust.tf/66893 Tracking issue for atomic_mut_ptr
  • rust.tf/72505 Tracking issue for `#![feature(const_float_classify)]`

Actions

• Reply to all issues/PRs discussed in this meeting, or add them to the open action items.

Generated by fully-automatic-rust-libs-team-triage-meeting-agenda-generator