Github issue

Implicit features

  • Should we have a transitional note that implicit features are no longer supported? (comment)
    • If we stabilize lints table, move to warning (note the msrv bump when fixing), else only warn based on msrv
  • This message doesn't make sense pre-2024 (comment)
  • We're only making this Deny for 2024? That means people can override this to allow it. If they do, we should make sure that the dependency truly is unused and doesn't create a feature. (comment)
  • Cargo fix migration

Lints

Design

  • Why is Allow translating to Note. We shouldn't be showing Allow (comment)
  • We should verify this handles Forbid correctly (comment)
  • rustc/clippy lints display the lint name (and where the level was set) on first instance of it being reported (comment)
  • We need a test to ensure this is subject to cap-lints (comment)
  • No longer needed see #13833 We need to strip lints.cargo before we publish (comment)
    • To avoid MSRV bumps
  • Would it be possible to update unstable.md with documentation about this feature? (comment)
    • Also, is #12235 the main tracking issue for what needs to be done next? Is there an outline of what steps need to be taken?
  • Workspace inheritance for cargo lints needs tested
  • im-a-teapot needs a permenantly unstable lint comment
  • Stabilize lints table

Non-blocking

  • Suggestions
  • unknown_lints
  • all group
  • any groups
  • Do we document anywhere the status of the warnings group? (comment)
    • Note: even if we don't support the group in [lints], we'd need to be able to support it in the future with #8424.

Bugs

Non-blocking

Implementation

Non-blocking

  • nit: please put the focus of the file (what comes first) on the API and not the implementation details (comment)
  • imo its a bit messy to shove lint implementations in here just because they are lints. This body should live where its called (comment)
  • These needs documentation, especially around how arrays are handled (comment)
    • ditto, this belongs at the end of the file
  • String in this is suspect. Should this have display in the name? Or should we try to switch to camino? (comment)
  • Should we have an is_error function? (comment)
  • None of our other UI tests nest this deeply (comment)