# Open Floor/Triage Minutes
Pulp open floor, every Tuesday at 10:30 ET (either EST or EDT) (That is 16:30 CET) in pulp-meeting on Matrix.
See https://pulpproject.org/help/community/get-involved/ for more info about this meeting.

## Open Floor Agenda

* pulpcore Triage query: https://github.com/pulp/pulpcore/issues?q=is%3Aopen+is%3Aissue+label%3ATriage-Needed

## Agenda Next

## November 19, 2024

* quba42: Is there a good way to turn a Pulp ID into an href and vice versa? I am trying to avoid doing something like the following in plugin code:

  package_href = f"{settings.V3_API_ROOT}content/deb/packages/{package.pulp_id}/"

Background: The user supplies a list of href to the repo modify API, e.g. via `remove_content_units` parameter. We need to do some querrying and then add extra hrefs to the list supplied by the user: https://github.com/pulp/pulp_deb/pull/1185
* **Answer:** `from pulpcore.plugin.util import extract_pk, get_url`

## October 8, 2024
* ggainey: should this be a 30-min window instead of 60?
* YES (AI: lmjachky will ensure we will shorten the meeting)

## August 6, 2024

* pedro: working on RPM issue where wrong RemoteArtifact is picked up (checksum dont match related dist/pub md)
* https://github.com/pulp/pulpcore/blob/4f6515298ab8b1e3de957256e52e52c86fa35ce7/pulpcore/content/handler.py#L815-L818
* Safe to try to pick the 'right' one on pulpcore level?

## July 30, 2024

* hstct: can I get a quick review for this PR? https://github.com/pulp/pulpcore/pull/5636

## July 16, 2024

* Next steps for this PR? https://github.com/pulp/pulpcore/pull/5405
* Looks like it's waiting on a review?
* dkliban will comment on PR and reach out to contributor

## June 18, 2024

* quba42: https://discourse.pulpproject.org/t/selinux-and-restorecon/1264
* FYI: We have merged [our initial staging docs](https://github.com/pulp/pulp_deb/pull/1095) for pulp_deb. I believe we were the last plugin to do so.
* Question: Do we need to backport the docs to our supported release branches?
* Answer: no need, the CI converting the CHANGELOG on release branches is only for collecting the changelog to main branch.

## June 11, 2024

* Does anyone from Pulp want to participate at the [Foreman Birthday Event](https://community.theforeman.org/t/foreman-birthday-event-2024-celebrate-the-15th-birthday/37370)?
* It is an in person event at the ATIX office near Munich, but there is a possibility to hold a remote talk.

# April 30, 2024

* Remove q filter from tech preview?
* https://github.com/pulp/pulpcore/pull/5280#issuecomment-2072418698

# April 23, 2024

* quba42, continued from last week: https://discourse.pulpproject.org/t/how-to-analyze-task-performance/1194
* more additions would be welcome
* hstct, quba42: There is a [community pulp_deb RBAC PR](https://github.com/pulp/pulp_deb/pull/1062). Is there anyone with RBAC experience (from other plugins) who could help us review it?
* gerrod to take a look
* ggainey to find pulp_rpm rbac commits to look at for examples
* some links:
* https://github.com/pulp/pulp_ostree/pull/352/commits/ea2222214211f171adb697f12f506e16efb624c6
* https://discourse.pulpproject.org/t/pulp-rbac/328/3
* https://docs.pulpproject.org/pulp_container/rbac/roles.html

# April 16, 2024

* quba42: What tools are you all using for performance profiling (of let's say for example, a sync task)?
* Let's say syncing some large test repo X takes 3 hours on the initial sync. How would you approach analysing what is taking the time? Which bits might be avoidable/improvable, and which bits are set in stone?
* Discussion to be continued here: https://discourse.pulpproject.org/t/how-to-analyze-task-performance/1194

## February 27, 2024

* What determines if a action creates a task?
* For example `pulp deb content --type release_component create --distribution test --component empty --repository my_repo` does not create a task, even though it does create a new repo version.
* This makes it difficult to retrieve the new repo version since it does not appear in any `created_resources`.
* Opinions on this design?
* It is a hard requirement to use a task here, to ensure resources are locked!
* Triggering a task is a matter of viewset: https://github.com/pulp/pulpcore/blob/main/pulpcore/plugin/viewsets/content.py#L32
* See also: https://github.com/pulp/pulpcore/issues/3661

## February 20, 2024

* https://discourse.pulpproject.org/t/consistent-docstring-formatting/1108

## December 5, 2023

dosas: broken build for [pulp-openapi-generator](https://github.com/pulp/pulp-openapi-generator/pull/88)

## November 28, 2023

dosas: pulp-oci-image [tags](https://github.com/pulp/pulp-oci-images/pkgs/container/pulp-ci-centos) are always overwritten.
I would expect the latest tag to change regularly but not the other ones?

## November 21, 2023

* PRs for open-api-generator [1](https://github.com/pulp/pulp-openapi-generator/pull/87) [2](https://github.com/pulp/pulp-openapi-generator/pull/86)
* Include pytest-cov in [plugin_template](https://github.com/pulp/plugin_template) for adding coverage to test runs

## October 17, 2023

* quba42: Whom can I ask for a few minutes of input to check if any pulpcore 3.40 breaking changes affect pulp_deb? (Does not necessarily need to be right now, I think a short 1:1 session with someone who did it for another plugin would be more efficient than wasting everyones time within open floor.)

## August 29, 2023
* We are trying to add a new test to pulp_deb and it looks like just the s3 test is using a different client, and can't import the right API object. How is this possible?
* PR: https://github.com/pulp/pulp_deb/pull/878
* Failed Test: https://github.com/pulp/pulp_deb/actions/runs/6010665664/job/16302579792?pr=871
* gerrod:
* "the class it generates is PulpV3DebCopyApi in the s3 runner"
* "s3 runs with the api root being /rerouted/djnd/ instead of the normal /pulp/"
* x9c4:
* "We may have an oversight in the code that removes the /pulp/api/v3/ before generating the operation id."
* gerrod:
* "this is the problem https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/urls.py#L5"
* and here is the solution: https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/urls.py
* cheers ensue

## August 8, 2023
* Include django-auth-ldap in our OCI images?
* yes, let's include in the image. Not as a python package requirement.

## July 18th

* pulp_deb Release pipeline is failing for 2.21 branch (latest release branch with latest CI changes):
* https://github.com/pulp/pulp_deb/actions/runs/5588002467
* There are no obvious recent plugin template changes to the script throwing the error.
* The first run with out applying the latest plugin template changes also failed in the same way.
* Last successfull release was 2.21.0 on May 22.

## June 20th

* Why are we using `from gettext import gettext as _` instead of just `from gettext import gettext`?
* Background: There is a convention to use `_, second_element = function_returning_a_tuple()` when one needs only one of the elements returned by `function_returning_a_tuple()` that is not compatible with our gettext habits.

## June 13

* Is there (should there be) logging options beyond the system log for Pulp? See: https://github.com/pulp/pulp_deb/pull/760#discussion_r1226654405 (trigger for this question)
Update, we are testing using the following PoC:

  LOGGING = {
    "dynaconf_merge": True,
    "handlers": {
        "file": {
            "level": "INFO",
            "class": "logging.FileHandler",
            "filename": "/var/lib/pulp/pulp_deb_migration_0025.log",
        },
    },
    "loggers": {
        "pulp_deb.app.migrations.0025_merge_colliding_structure_content": {
            "handlers": ["file"],
            "level": "INFO",
            "propagate": True,
        },
    },
  }

## June 6

* How to debug failing tests, here: https://github.com/pulp/pulp_deb/pull/295#issuecomment-1576629544

## May 17
* Need to be more explicit about pulp_installer no longer supported
* https://github.com/pulp/pulp_installer/issues/1478
* pointers in other places/docs need to be updated as well
* [discourse announcement](https://discourse.pulpproject.org/t/pulp-installer-3-22-will-be-the-last-release-for-the-installer/706)
* clearly not sufficient based on upstream feedback
* AI: [ipanova] to open task to track down remaining references

## May 9
* [quba42] pulp_deb cloud CI test woes:
* Azure CI tests often failing (sometimes succeed) for all branches: e.g.: https://github.com/pulp/pulp_deb/pull/759
* https://github.com/pulp/pulp_deb/pull/744 fails the s3 test only (may be identifying a real issue?) not sure how to debug.
* In general: How to interpret tests failing for just a single cloud provider? Random failures vs. real issue?!
* running tests in oci-env in parallel (or not):
* `pytest -v -r sx --color=yes --suppress-no-test-exit-code --pyargs pulp_deb.tests.functional -m parallel -n 8`
* `pytest -v -r sx --color=yes --pyargs pulp_deb.tests.functional -m 'not parallel'`
* can use the minio profile to siumulate S3
* core/3.25 releasing today!
* assuming github gets better...
* compatibility promise is now "pulpcore<3.40"

## May 2
* core/3.24 releasing Today
* last release before the breaking-changes in core/3.25 happen
* core/3.25 coming SOON
* will be based on Django4.2

## April 18
- [hstct] We have a problem with the web server created by the pytest fixtures which seems to be due to some missing content header configuration.
- This is driven by a community contribution and requires a change in pulp-smash.
- Can we get some input on how move forward with this?
- https://github.com/pulp/pulp_deb/issues/742
- https://github.com/pulp/pulp-smash/issues/1309
- https://github.com/pulp/pulp-smash/pull/1310
- discussion ensued
- outcomes: pulp-smash PR accepted/merged, #742 moved to pulpcore to get same applied to pulpcore fixture-utils

## April 11
* discussion around https://github.com/pulp/pulpcore/issues/3730
* decision: revert some problem code in pulp_container to help AAP, take some time to review implications of the associated PR before accepting

## March 14th

- [quba42] Can I get maintainer status on pypi for [pulp-cli-deb](https://pypi.org/project/pulp-cli-deb/) for user [quba42](https://pypi.org/user/quba42/)? (Right now I have access to pulp-deb and pulp-deb-client).

## February 14, 2023
- [lmjachky] What do you think about renaming repositories from pulp-plugin to pulp_plugin (e.g., pulp-certguard -> pulp_certguard)?
- This is just to prevent discrepancies between installed packages and repositories' names (there is an issue with this when running oci_env with pulp-certguard).
- GitHub provides a facility for redirects:
- github.com/evgeni/debian-talks/
- [quba42] The search on the [documentation](https://docs.pulpproject.org/pulpcore/) is broken (also for various plugins)!
- To me this renders the docs nearly useless, it is a serious issue!
- Is this a pulpcore or a plugin_template issue?! => We should open an issue to track this!
- errors in webconsole:
- Uncaught ReferenceError: jQuery is not defined
- Uncaught ReferenceError: $ is not defined

## January 17, 2023
- contribute to the tech preview labels discussion https://discourse.pulpproject.org/t/features-in-tech-preview/737

## January 10, 2023
* hstct: Pulp doesn't have permission to create symlinks in the container CI. I don't know who to ask for advice here. [reference](https://github.com/pulp/pulp_deb/pull/704#issuecomment-1375483512)

## Archive
### [2022](https://hackmd.io/@pulp/triage_2022)
### [2021](https://hackmd.io/@pulp/triage_2021)
### [2020](https://hackmd.io/@pulp/triage_2020)

###### tags: `Minutes`