Maternity leave notes

Discussion

• bring withStyles and makeStyles back https://github.com/mui-org/material-ui/issues/24109#issuecomment-780805118
• When to us sx vs. flat props? https://github.com/mui-org/material-ui/issues/20012#issuecomment-782821025 Agree, sx whenever possible, flat props in my opinion are good for prototyping purposes…
• normalize supported colors use https://github.com/mui-org/material-ui/issues/24778 Agree, no objections, just we should be carefull on documenting the changes
• performance aren't great https://github.com/mui-org/material-ui/pull/24663#issuecomment-778492717 - is it still an issue? Last comment says it's fine, should we anyway investigate further? see where is the bottleneck and then consider performance flag

Postponed

• scoped css with emotion https://github.com/mui-org/material-ui/issues/20461#issuecomment-809248743 POSTPONED after v5

Bugs:

• styled() spreading theme values https://github.com/mui-org/material-ui/pull/25164#discussion_r586410490 - agree with the proposed, marked as good first issue

Docs:

• add docs for @material-ui/styled-engine https://github.com/mui-org/material-ui/issues/24748#issuecomment-771851443

---

IN PROGRESS

• GlobalStyles types https://github.com/mui-org/material-ui/issues/25208
• Broken GlobalStyle https://github.com/mui-org/material-ui/issues/24970
• GlobalStyles SSR leak https://github.com/mui-org/material-ui/issues/25458

DONE

• document extending types of styled https://github.com/mui-org/material-ui/issues/24862
• Portal https://github.com/mui-org/material-ui/issues/22342#issuecomment-808885233
• @font-face support https://github.com/mui-org/material-ui/issues/24966 - commented, will pick it up
• RTL broken https://github.com/mui-org/material-ui/issues/24899 - was fixed and released
• Fork this repo? https://github.com/styled-components/stylis-plugin-rtl/pull/21#issuecomment-795226682 - no need
• '&.Mui-disabled': { or [&.${stepIconClasses.disabled}]: { // we should be consistent https://github.com/mui-org/material-ui/issues/25659
• How to document unstyled only components? https://github.com/mui-org/material-ui/pull/25505#pullrequestreview-621630246 - responded, only add some kind of tag on the docs should be enough

Resolved:

• Why do we need to use CSS template strings with keyframe? - It was not working in styled-components (when it was callback fn), but it was fixed by using css template by Olivier
• update color="textSecondary" https://github.com/mui-org/material-ui/pull/24798 - Great, no objections
• Components without root https://github.com/mui-org/material-ui/issues/25141
• Slider exports SliderThumb. Why not the others too? - as far as I can see all components are exported, maybe it was fixed in mean time
• Merge stylesOverrides not working https://github.com/mui-org/material-ui/issues/25075
• Should remove getThemeProps from the codebase, and bundle it all inside useThemeProps? - it's used also inside WithStyles, so would leave it as is
• background should be white https://github.com/mui-org/material-ui/issues/24440

Notes

• A quick exploration with goober: https://github.com/oliviertassinari/material-ui/tree/goober - were there any issues along the way? Looks great if it is this easy to setup a new style engine :) (wow it even includes css and keyframes, I am impressed)