# Baseapp audit

## VoteInfos

https://github.com/cosmos/cosmos-sdk/blob/aba08339140d4856a6a4ca7197870de79c8d6447/baseapp/baseapp.go#L91 -> why absent validators? If we do this in BeginBlock:

	// set the signed validators for addition to context in deliverTx
	app.voteInfos = req.LastCommitInfo.GetVotes()

voteInfos is a bit confusing:

> * `voteInfos`: This parameter carries the list of validators whose precommit is missing, either
> because they did not vote or because the proposer did not include their vote. This information is
> carried by the [Context](#context) and can be used by the application for various things like
> punishing absent validators.
> ... some other place:
> * Set the [`VoteInfos`](https://docs.tendermint.com/master/spec/abci/abci.html#voteinfo) of the application, i.e. the list of validators whose _precommit_ for the previous block was included by the proposer of the current block. This information is carried into the [`Context`](./02-context.md) so
>
## Small nit in getState, the comment is not up to date.

Will open a PR for this

// Returns the application's deliverState if app is in runTxModeDeliver,
// otherwise it returns the application's checkstate.
func (app *BaseApp) getState(mode runTxMode) *state {
	switch mode {
	case runTxModeDeliver:
		return app.deliverState
	case runTxPrepareProposal:
		return app.prepareProposalState
	case runTxProcessProposal:
		return app.processProposalState
	default:
		return app.checkState
	}
}

## Comment in abci.go ProcessProposal states that it's possible to do parallel execution

`It may even execute the block in parallel.`

But according to the docs this is not possible right now:

> It is important to note that in ABCI 1.0 integration, the application is NOT responsible for locking semantics -- Tendermint will still be responsible for that. In the future, however, the application will be responsible for locking, which allows for parallel execution possibilities.

Let's remove it until it's actually possible to avoid people asking how to do it. Or if it's possible, let's adjust the docs.

##