Regen Cosmos SDK Architecture Review

Agenda Items

• Status on cli tx migration
• Cli tx module interface & simplification
• Cli integration tests in SDK
• gRPC querier - action planA
• Cli tx oneof handling

Notes

type TxCmdContext interface {
Marshaler() codec.Marshaler
AccountRetriever() AccountRetriever
TxGenerator() tx.Generator
}

type ClientModule interface {
NewTxCmd(TxCmdContext) *cobra.Command
NewQueryCmd()
// alternative
NewTxCmd( codec.Marshaler, AccountRetriever, tx.Generator) *cobra.Command

}

• Aaron's proposed plan of action:
  • Aaron focuses on completing tx module interface and helpers + x/gov, upgrade & params (which use oneof's)
  • Sahith focuses on pulling CLI integration tests from Gaia into the SDK
  • when CLI tx module interface is done, existing tx CLI commands are wired up to the new module interface
  • gRPC querier work starts after sufficient integration tests are ready

Follow-ups

• Aaron will wrap up x/gov & x/upgrades and update ADR to reflect oneOf handling
• Sahith will start with an assessment for migrating integration tests from gaia to cosmos sdk
  • Starting with migration of gaiad&gaiacli to simd and simcli
  • Integration test migration
• Aaron will create a PR for the module interface (maybe to be coordinated with integration tests work)
• gRPC is coming soon