# Regen Ledger Architecture Review - 2022-11-28

## Agenda

- [ ] Bridge
- [ ] Outstanding PRs
- [x] Use event owner rather than msg owner
- [x] fix: incorrect usage of `SKIP LOCKED`
- [x] Add metrics to run process
- [x] Convert metadata (toucan > regen)
- [ ] Manual Testing & Gameday
- [ ] ETA Launch?
- [ ] Regen Ledger v5.0
- [ ] Ledger support for group module?

## Notes
- Use event owner rather than msg owner
- if a message includes multiple credit items with different owners
- fix: incorrect usage of `SKIP LOCKED`
- before we had reader and writer
- we only supported lock on writer previously
- impossible to select and update on transaction
- updated database interface to implement reader and writer
- added `getDBTX` method (better name?)
- allows us to role back if error occurs
- when we commit the transaction, there is an error we are not checking - oversight?
- aaron: I'm pretty sure we should panic on those errors
- if we can't connect to the database, the error should be fatail/instant
- determine if `getDbTx` is the best approach
- alternative being adding `Begin` at the start of each process
- we need to make sure each process is using a separate db isntance
- Add metrics to run process
- allows asynchronous updates that provide more insight into process resolution
-
- Convert metadata (toucan > regen)
- need to update data schema
- need to add condition (do not include uri field if empty)
- Ledger support for group module?
- amino types are not registered properly in the group module on the sdk
- someone raised a pull request recently
- a number of pull requests happening on sdk