Try   HackMD

c-lightning community meeting 2021/09/20

Team updates

Release progress

The next release is scheduled for Oct. 10 2021. The following is an overview

  • 4599 Merged
  • 4668 Merged
  • 4737 Merged
  • 4748 Merged
  • 4750 Merged
  • 4751 Merged
  • 4526 waiting for @darosior to undraft it, rebased to see if the CI failure was unrelated
  • 4527 blocked by 4526 and needs a rebase.
  • 4567 Currently working down the list of failing tests, reworking the groupid generation logic
  • 4595 shepherding through CI then merge when happy
  • 4620 Currently broken in CI, seems to exacerbate issues with stderr being parsed as JSON result from plugins
  • 4685 @rusty to undraft so we can merge, if this should really land
  • 4745 Pending review feedback to be addressed
  • 4756 Still fails two tests, presumably because it overeagerly identifies channels as being leased
  • 4767 @rusty to decide whether to upstream it into CCAN
  • 4770 Shepherding new contributor
  • 4771 Waiting on feedback for routing efficiency, @cdecker to check with @rpickhardt
  • 4790 Discussing whether to make the plugin shutdown a two step process

Agenda

Remove derived files from the repository?

We decided some time ago to check in committed files, and verify that it works with the NO_PYTHON=1 configuration on CI. However since then several issues have cropped up, and it's time to revisit and evaluate the pros and cons:

  • Checking in derived files may free users building from source from requiring python and some packages installed (mostly mako)
  • Derived files often cause merge conflicts, requiring rebases for PRs, costing us CI and development time
  • Failing to commit derived files ends up with a confusing error on CI about not being able to generate them
  • Changes in derived files obfuscate the change that is actually for review

Generating source tarballs from a clean tree, but after generating the derived files may be a middleground.