Fmtscan

PR

  1. git fetch
  2. check branch for merging PR
  3. Practice - ya, just merge it on two remotes.
  4. Do the PR or Rebase in the branch
  5. Finish

Previous words

Pull Request 274 was made by me , Urbaner3, in lab0/ sysprog21. And it was closed for Rework and submit pull requests later. So I am working here to submit another pull request.

Commit message

Title: Fix: condition statements in fmtscan.c
Message: A warning from static analysis from fmtscan.c tells us conditions of 2 branches might conflict. There is a likely macro to check if it's end of the parsor. And the other branch is using a function to see if parsor get a valid digit.

So I slightly copy the first condition and put it together with the condition in the latter branch.

And It turns out static analysis accept the condition statements.

Running static analysis
tools/fmtscan.c:664:26: warning: Either the condition 'nextch2!=256' is redundant or isxdigit() argument nr 1 can have invalid value. The value is 256 but the valid values are '0:255'. [invalidFunctionArg]

Ref

STAR manner
lab0_PR274
fb_fmt_error_msg
fb_post
issue_279

Enhance the descriptions by focusing on executable subtasks.
By Jserv