Try   HackMD

Damage Refactoring

Goals

  • Refactor damage application to be more consistent, especially when it comes to items.
  • Standardise various elements of damage application.
    • For example, objects with a similar sharpness should have the same style of damage application, one shouldn't cause bleeding while the other does something entirely else.
  • Get us in a position where damage can be easilly expanded on in the future and allow us to implement features such as wounds/injuries.
  • This in of itself should provide little changes to current damage, except for cases where the damage was being applied inconsistently; in which cases it will be made more consistent.

Damage Application

Some things cannot be standardised when applying damage as it will always be different for every object, for example force and armour penetration. These will always be passed in if the damage dealing requires it.

Applying damage without an instantiated damage source:

target.apply_damage(/datum/damage_source/chemical, /datum/damage/burn, 20 * rem)

Apply damage with an instantiated damage source:

damage_source.apply_direct(target, /datum/damage/burn, 20 * rem)

Damage Source

Defines some parameters for what is dealing damage. These will be consistently applied.
For example, a battle hammer may have a heavy blunt damage source and things like knifes would have a short blade damage source. Toolboxes would have a light blunt damage source etc.

Things like chemicals and armour bypassing damage sources would have their own datums.

// This is for applying the damage directly to the target rather than from performing an attack.
/datum/damage_source/proc/apply_direct(mob/living/target, damage_type, damage_amount, target_zone, update_health = TRUE)

// Has an atom target to allow for easy refactoring to swing combat later
// Default behaviour is to just apply directly if the target is a mob or deal structural damage if the target is a structure (how?)
/datum/damage_source/proc/deal_attack(mob/living/attacker, obj/item/attacking_item, atom/target, damage_type, damage_amount, target_zone = null, update_health = TRUE)

Applies the damage source to the specified target with the provided damage amount. This will do different things depending on the damage source, chemical damage is internal and will apply the damage directly.

PowerfulBacon If we are instantiating a damage source for every object this will need to be done lazilly, otherwise we may get a decent performance cost at roundstart from instantiating so many of these objects.

Damage sources will be able to define stuff such as the actions/procs to call when damage is defined and how to mutate the damage type (For example, a sharp object may have a higher chance of inflicting bleeding damage as well).

What is applied here?

  • Armour calculations
  • Damage type translation (sharp injury to blunt injury if wearing armour, for example)
  • Bleeding
  • Choosing where to attack (internal organ, bodypart, mob as a whole)

What ones will we need?

  • Sharp Light (Light knives)
  • Sharp Heavy (Energy sword)
  • Blunt Light (Toolboxes, Wrenches, etc.)
  • Blunt Point (Screwdrivers)
  • Blunt Heavy (Battle-axes)
  • Unarmed
  • Stunning (Stun batons, takes stamina armour into account)
  • Chemical (Chemicals, may deal internal organ damage in future)
  • Magic (Magical weapons or supernatural events)
  • Gunshot (Bullet armour, may be expanded to deal internal organ injueries/wounds or could be expanded to have different calibers in the future)
  • Laser (Takes into account laser armour)
  • Energy (Takes into account energy armour)
  • Temperature (Account for temperature resistances?)
  • Fire (Fire armour resistance)
  • Crush (Airlock/elevator crushing. Accounts for melee armour.)
  • Explosion (Overall body damage from explosions. Ignores damage type, will apply both brute and burn. Respects explosive armour.)
  • Pressure (Overall body damage from pressure)
  • Abstract (Direct damage application with no conditions)
  • Acid (Takes into account acid armour)
  • Electricity (Takes into account insulation)

We can add other specific sources as needed which just use the default behaviour of applying the damage directly.

Damage Type

Simplies the type of damage that will be applied. For now these are just burn, brute, oxyloss, cloneloss, brain however will be expanded on in the future if we want a more complicated medical system.
This makes new damage types much easier to add as it is more modularised.

In the future these may be expanded to either:

  • Implement wound support/harder to heal damages
  • Implement all damages as wounds (Similar to barotrauma/rimworld damage style)
/datum/damage/proc/apply(mob/living/target, damage)
/datum/damage/proc/apply(obj/item/organ/target, damage)
/datum/damage/proc/apply(obj/item/bodypart/target, damage)

Armour penetration is applied in the damage source and this simply applies the damage directly to the mob, in the specified amount by doing something like calling adjustBruteLoss.

What is applied here?

  • Damage directly to mob in the specified amount.

What ones will we need?

  • Burn
  • Brute
  • Clone
  • Oxyloss
  • Toxin loss
  • Brain (this is used in VV and is a damage type? Its a bit less shitcodey with this solution)

Additional

Q: We may want to move towards something like swing combat in the future. How can we make apply_damage either easy enough to refactor or have enough data that all we would need to do is modify the contents of the apply damage function?
This has been thought about and applied in the above proposal. This is why we have both apply_direct and deal_attack. Deal_attack will allow us to give certain damage sources different swing combat effects.

Q: Should we refactor things that can recieve damage into a datum or component so that we don't need to have 3 different apply procs? Really we need interfaces for this but byond doesn't support it.
For now, we will just do type checks for structures and organs.

Q: How should we handle healing damage?

  • Needs to be able to handle overall and specific injury healing for the future (support wound handling)
  • Doesn't need stuff like armour penetration or swing combat potential support.
Last changed by 
 
PowerfulBacon
0
156

Read more

Guide To Coding For Space Station 13

Contents Introduction So, you want to code for space station 13, but have either never used byond or never coded in general? Well this guide is somewhat for you! In this guide we will go through the process of creating some new and original items for Space Station 13, as well as the process of creating a pull request and getting that item added into the game. Space Station 13 is an open source game, meaning that anybody can contribute to it and create, rework, remove or rebalance features. As such, many of the game developers are players themselves. Even if you have no experience with game development, SS13 is an excellent place to get started. Lets get started

Mar 10, 2025
Guide to Hard Dels

Contents What causes hard deletes? :::warning This is a simplication, see Qdel VS del for a slighly more complex explanation (Some details about the garbage system are still omitted, this guide is more about avoiding and locating hard-dels rather than how garbage collection works in Byond) ::: A hard-delete occurs when something is requested to be destroyed, but it doesn't properly remove all references to itself. This prevents Byond from automatically deleting the object, meaning we have to ask Byond to remove all references to it for us which is very expensive. Hard dels are extremely expensive and account for the majority of CPU usage of the server despite being fairly irregular.

Apr 18, 2023
Mindshields

Mindshields limit activity within certain areas of the brain known for subconcious activity and stress. This region of the brain is commonly associated with 'autopilot' functions, which if manipulated can result in victims being highly easy to control. Mindshields do have side effects however and many find that it takes time to adjust to the effects. The most common side effect is an inability to sense danger. While the calmness it provides helps in many situations, it can sometimes be deterimental to the users (The effects of mindshields on the civillian population are detailed further on in this report). While mindshields provide a sense of peace within the user and protect the brain from being brainwashed, they do not themselves brainwash the user into blindly accepting Nanotrasen ideals. It is for this reason that mindshields have proven to be ineffective against hostile agents who truly believe in their cause and aren't simply victims of a quick mind re-altering scheme. After undergoing training and re-adjusting to live with the restrictions that the mindshield provides, the majority of crewmembers who undergo mindshield therapy eventually have their brains create new pathways which offset the limitations entirely, while still providing protection from brainwashing. Widespread mindshield distribution has previously been authorised in emergency situations, civillian subjects exposed to the effects without training were successfully protected from any mind-altering effects but suffered short-term memory-loss, lower reasoning skills and, in exceptional circumstances, an inability to sense obvious danger. Many of the civillians exposed to these emergency procedures opted to keep the mindshield after the situations were brought under control.

Mar 6, 2023
Anomaly Science

Flux Flux anoamly density is a measure of the build up of anomalous precense. This is global for the station and independent of area. Anomaly Entropy A localised value that represents the density of nearby anomalies. If a lot of anomalies are nearby, or there is an anomaly about to appear, the value will be very high in this area. Devices Entropic Anomaly Analyser Used to measure the levels of anomalitic entropy in a localised area. Areas near anomalies have a high anomalitic entropy level, areas with an anomaly about to appear will have an insanely anomalitic entropy flux level.

Oct 16, 2022
Read more from PowerfulBacon
Published on HackMD