Dan Gould
    • Create new note
    • Create a note from template
      • Sharing URL Link copied
      • /edit
      • View mode
        • Edit mode
        • View mode
        • Book mode
        • Slide mode
        Edit mode View mode Book mode Slide mode
      • Customize slides
      • Note Permission
      • Read
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
      • Write
        • Only me
        • Signed-in users
        • Everyone
        Only me Signed-in users Everyone
      • Engagement control Commenting, Suggest edit, Emoji Reply
    • Invite by email
      Invitee

      This note has no invitees

    • Publish Note

      Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note

      Your note will be visible on your profile and discoverable by anyone.
      Your note is now live.
      This note is visible on your profile and discoverable online.
      Everyone on the web can find and read all notes of this public team.
      See published notes
      Unpublish note
      Please check the box to agree to the Community Guidelines.
      View profile
    • Commenting
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
      • Everyone
    • Suggest edit
      Permission
      Disabled Forbidden Owners Signed-in users Everyone
    • Enable
    • Permission
      • Forbidden
      • Owners
      • Signed-in users
    • Emoji Reply
    • Enable
    • Versions and GitHub Sync
    • Note settings
    • Note Insights New
    • Engagement control
    • Make a copy
    • Transfer ownership
    • Delete this note
    • Save as template
    • Insert from template
    • Import from
      • Dropbox
      • Google Drive
      • Gist
      • Clipboard
    • Export to
      • Dropbox
      • Google Drive
      • Gist
    • Download
      • Markdown
      • HTML
      • Raw HTML
Menu Note settings Note Insights Versions and GitHub Sync Sharing URL Create Help
Create Create new note Create a note from template
Menu
Options
Engagement control Make a copy Transfer ownership Delete this note
Import from
Dropbox Google Drive Gist Clipboard
Export to
Dropbox Google Drive Gist
Download
Markdown HTML Raw HTML
Back
Sharing URL Link copied
/edit
View mode
  • Edit mode
  • View mode
  • Book mode
  • Slide mode
Edit mode View mode Book mode Slide mode
Customize slides
Note Permission
Read
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
Write
Only me
  • Only me
  • Signed-in users
  • Everyone
Only me Signed-in users Everyone
Engagement control Commenting, Suggest edit, Emoji Reply
  • Invite by email
    Invitee

    This note has no invitees

  • Publish Note

    Share your work with the world Congratulations! 🎉 Your note is out in the world Publish Note

    Your note will be visible on your profile and discoverable by anyone.
    Your note is now live.
    This note is visible on your profile and discoverable online.
    Everyone on the web can find and read all notes of this public team.
    See published notes
    Unpublish note
    Please check the box to agree to the Community Guidelines.
    View profile
    Engagement control
    Commenting
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    • Everyone
    Suggest edit
    Permission
    Disabled Forbidden Owners Signed-in users Everyone
    Enable
    Permission
    • Forbidden
    • Owners
    • Signed-in users
    Emoji Reply
    Enable
    Import from Dropbox Google Drive Gist Clipboard
       Owned this note    Owned this note      
    Published Linked with GitHub
    • Any changes
      Be notified of any changes
    • Mention me
      Be notified of mention me
    • Unsubscribe
    # Pull PayJoins <pre> BIP: 77 (tentative) Layer: Applications Title: A Pull Payjoin Proposal Author: Dan Gould <d@ngould.dev> Replaces: 78 Comments-Summary: No comments yet. Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0077 Status: Draft Type: Standards Track Created: 2022-12-12 License: BSD-2-Clause </pre> ==Introduction== ===Abstract=== This document proposes a protocol for two parties to negotiate a payjoin transaction where the sender hosts a server instead of the receiver. ===Copyright=== This BIP is licensed under the 2-clause BSD license. ===Motivation=== When two parties (later referred to as sender and receiver) want to payjoin, a receiver hosts a secure endpoint for the receiver to connect to over bip21, the sender provides their inputs to the receivers outputs, the receiver adds their own inputs, returns it to the signer, it and broadcasts it on the network. This makes it difficult to offer payjoin in instances where the recipient cannot run a server. It's easier for e.g. a swap service to host the communications server The problems we aim to solve are: * Have the sender host a server instead of the receiver. * Somehow make the flows compatible. Perhaps the receiver gives a bip21 that says "please host!" ==Specification== ===Protocol=== In a payjoin payment, the following steps happen: * The receiver of the payment, presents a [[bip-0021.mediawiki|BIP 21 URI]] to the sender with a parameter <code>pj=</code> describing a payjoin endpoint. * The sender creates a signed, finalized PSBT with witness UTXO or previous transactions of the inputs. We call this PSBT the <code>original</code>. * The receiver replies back with a signed PSBT containing his own signed inputs/outputs and those of the sender. We call this PSBT <code>Payjoin proposal</code>. * The sender verifies the proposal, re-signs his inputs and broadcasts the transaction to the Bitcoin network. We call this transaction <code>Payjoin transaction</code>. <pre> +----------+ +--------+ +-----------------+ | Sender | | Receiv | | Bitcoin Network | +----+-----+ +---+----+ +-------+---------+ | +-----------------+ | | +-------+ pull-pj endpoint|- - - ->| (out of band) | | +-----------------+ | | | | | | +---------------+ | | +<-------+ BIP21 & .5 PJ +---------+ | | +---------------+ | | | | | | +------------------+ | | | | Payjoin Proposal | | | +-------+ PSBT +------>+ | | +------------------+ | | | | +--------------+ | | |---+ Payjoin | | | | | transaction +-->+ | | +--------------+ | + + + </pre> A BIP21 URI with pull-payjoin parameter ?ppj=PSBT containing an input and payable output amount is sent in the HTTP POST request body, base64 serialized, with <code>text/plain</code> in the <code>Content-Type</code> HTTP header and <code>Content-Length</code> set correctly. The payjoin proposal PSBT is sent in the HTTP response body, base64 serialized with HTTP code 200. To ensure compatibility with web-wallets and browser-based-tools, all responses (including errors) must contain the HTTP header <code>Access-Control-Allow-Origin: *</code>. The receiver must ensure that the pull payjoin endpoint operates on a scheme or protocol using authenticated encryption, for example TLS with certificate validation, or a .onion link to a hidden service whose public key identifier has already been communicated via a TLS connection. Recievers SHOULD NOT use pull payjoin endpoints via unencrypted or unauthenticated connection. The .5 PJ PSBT SHOULD: * Have outputs unrelated to the payment for batching purpose. The payjoin proposal PSBT MUST: * Have all the <code>witnessUTXO</code> or <code>nonWitnessUTXO</code> information filled in. * Be finalized. * Not include unecessary fields such as global xpubs or keypath information. * Be broadcastable. * Use all the inputs from the .5 PJ PSBT. * Use all the outputs which do not belongs to the receiver from the .5 PJ PSBT. * Only finalize the inputs added by the sender. (<code>sender inputs</code>) * Only fill the <code>witnessUTXO</code> or <code>nonWitnessUTXO</code> for the sender inputs. The payjoin proposal MAY: * Add, remove or modify the outputs belonging to the receiver. The payjoin proposal MUST NOT: * Shuffle the order of inputs or outputs, the sender outputs or sender inputs must be inserted at a random index. * Decrease the absolute fee of the original transaction. ===BIP21 payjoin parameters=== This proposal is defining the following new [[bip-0021.mediawiki|BIP 21 URI]] parameters: * <code>ppj=</code>: Represents an pull-payjoin http(s) endpoint which the receiver can POST the .5 PJ PSBT. ===<span id="optional-params"></span>Optional parameters=== When the payjoin sender posts the original PSBT to the receiver, he can optionally specify the following HTTP query string parameters: * <code>v=</code>, the version number of the pull-payjoin protocol that the sender is using. The current version is <code>1</code>. This can be used in the future so the receiver can reject a payjoin if the sender is using a version which is not supported via an error HTTP 400, <code>version-unsupported</code>. If not specified, the receiver will assume the sender is <code>v=1</code>. If the receiver does not support the version of the sender, they should send an error with the list of supported versions: <pre> { "errorCode": "version-unsupported", "supported" : [ 2, 3, 4 ], "message": "The version is not supported anymore" } </pre> * <code>transferindex=</code>, specified the output that the bip21 amount should be delivered to. * <code>additionalfeeoutputindex=</code>, if the receiver is willing to pay for increased fee, the indicated output can have its value decreased to pay for it. If the <code>additionalfeeoutputindex</code> is out of bounds or pointing to the payment output meant for the sender, the sender should ignore the parameter. See [[#fee-output|fee output]] for more information. * <code>minfeerate=</code>, a decimal in satoshi per vbyte that the sender can use to constraint the receiver to not drop the minimum fee rate too much. * <code>disableoutputsubstitution=</code>, a boolean indicating if the sender forbids the sender to substitute the receiver's output, see [[#output-substitution|payment output substitution]]. (default to <code>false</code>) ===Receiver's well known errors=== If for some reason the sender is unable to create a payjoin proposal, it will reply with a HTTP code different than 200. The sender is not constrained to specific set of errors, some are specified in this proposal. The errors have the following format: <pre> { "errorCode": "leaking-data", "message": "Key path information or GlobalXPubs should not be included in the original PSBT." } </pre> The well-known error codes are: {| class="wikitable" !Error code !Meaning |- |unavailable |The payjoin endpoint is not available for now. |- |not-enough-money |The receiver added some inputs but could not bump the fee of the payjoin proposal. |- |version-unsupported |This version of payjoin is not supported. |- |half-psbt-rejected |The receiver rejected the .5 PJ PSBT. |} The sender is allowed to return implementation specific errors which may assist the receiver to diagnose any issue. However, it is important that error codes that are not well-known and that the message do not appear on the receiver's software user interface. Such error codes or messages could be used maliciously to phish a non technical user. Instead those errors or messages can only appear in debug logs. It is advised to hard code the description of the well known error codes into the sender's software. ===<span id="fee-output"></span>Fee output=== In some situation, the receiver might want to pay some additional fee in the payjoin proposal. If such is the case, the receiver must use both [[#optional-params|optional parameters]] <code>additionalfeeoutputindex=</code> and <code>maxadditionalfeecontribution=</code> to indicate which output and how much the receiver can substract fee. There is several cases where a fee output is useful: * The receiver's .5 PJ PSBT transaction's fee rate is at the minimum accepted by the network, aka <code>minimum relay transaction fee rate</code>, which is typically 1 satoshi per vbyte. In such case, the sender will need to increase the fee of the transaction after adding his own inputs to not drop below the minimum relay transaction fee rate. * The receiver's wallet software is using round fee rate. If the receiver's fee rate is always round, then a blockchain analyst can easily spot the receiver payjoin transactions by checking if, when removing a single input of the suspected payjoin transaction, the resulting fee rate is round. To prevent this, the sender can agree to pay more fee so the receiver makes sure that the payjoin transaction fee is also round. * The receiver's transaction is time sensitive. When a receiver pick a specific fee rate, the receiver expects the transaction to be confirmed after a specific amount of time. But if the sender adds an input without bumping the fee of the transaction, the payjoin transaction fee rate will be lower, and thus, longer to confirm. Our recommendation for <code>maxadditionalfeecontribution=</code> is <code>originalPSBTFeeRate * vsize(sender_input_type)</code>. {| class="wikitable" !sender_input_type !vsize(sender_input_type) |- |P2WPKH |68 |- |P2PKH |148 |- |P2SH-P2WPKH |91 |- |P2TR |58 |} ===Receiver's original PSBT checklist=== The receiver needs to do some check on the original PSBT before proceeding: * Non-interactive receivers (like a payment processor) need to check that the original PSBT is broadcastable. <code>*</code> * If the sender included inputs in the original PSBT owned by the receiver, the receiver must either return error <code>original-psbt-rejected</code> or make sure they do not sign those inputs in the payjoin proposal. * If the sender's inputs are all from the same scriptPubKey type, the receiver must match the same type. If the receiver can't match the type, they must return error <code>unavailable</code>. * Make sure that the inputs included in the original transaction have never been seen before. ** This prevent [[#probing-attack|probing attacks]]. ** This prevent reentrant payjoin, where a sender attempts to use payjoin transaction as a new original transaction for a new payjoin. <code>*</code>: Interactive receivers are not required to validate the original PSBT because they are not exposed to [[#probing-attack|probing attacks]]. ===Sender's payjoin proposal checklist=== The sender should check the payjoin proposal before signing it to prevent a malicious receiver from stealing money. * Verify that the absolute fee of the payjoin proposal is equals or higher than the original PSBT. * If the receiver's BIP21 signalled <code>pjos=0</code>, disable payment output substitution. * Verify that the transaction version, and the nLockTime are unchanged. * Check that the sender's inputs' sequence numbers are unchanged. * For each inputs in the proposal: ** Verify that no keypaths is in the PSBT input ** Verify that no partial signature has been filled ** If it is one of the sender's input *** Verify that input's sequence is unchanged. *** Verify the PSBT input is not finalized *** Verify that <code>non_witness_utxo</code> and <code>witness_utxo</code> are not specified. ** If it is one of the receiver's input *** Verify the PSBT input is finalized *** Verify that <code>non_witness_utxo</code> or <code>witness_utxo</code> are filled in. ** Verify that the payjoin proposal did not introduced mixed input's sequence. ** Verify that the payjoin proposal did not introduced mixed input's type. ** Verify that all of sender's inputs from the original PSBT are in the proposal. * For each outputs in the proposal: ** Verify that no keypaths is in the PSBT output ** If the output is the [[#fee-output|fee output]]: *** The amount that was substracted from the output's value is less than or equal to <code>maxadditionalfeecontribution</code>. Let's call this amount <code>actual contribution</code>. *** Make sure the actual contribution is only paying fee: The <code>actual contribution</code> is less than or equals to the difference of absolute fee between the payjoin proposal and the original PSBT. *** Make sure the actual contribution is only paying for fee incurred by additional inputs: <code>actual contribution</code> is less than or equals to <code>originalPSBTFeeRate * vsize(sender_input_type) * (count(payjoin_proposal_inputs) - count(original_psbt_inputs))</code>. (see [[#fee-output|Fee output]] section) ** If the output is the payment output and payment output substitution is allowed. *** Do not make any check ** Else *** Make sure the output's value did not decrease. ** Verify that all sender's outputs (ie, all outputs except the output actually paid to the receiver) from the original PSBT are in the proposal. * Once the proposal is signed, if <code>minfeerate</code> was specified, check that the fee rate of the payjoin transaction is not less than this value. The sender must be careful to only sign the inputs that were present in the original PSBT and nothing else. Note: * The sender must allow the receiver to add/remove or modify the receiver's own outputs. (if payment output substitution is disabled, the receiver's outputs must not be removed or decreased in value) * The sender should allow the receiver to not add any inputs. This is useful for the receiver to change the paymout output scriptPubKey type. * If no input have been added, the sender's wallet implementation should accept the payjoin proposal, but not mark the transaction as an actual payjoin in the user interface. Our method of checking the fee allows the receiver and the sender to batch payments in the payjoin transaction. It also allows the receiver to pay the fee for batching adding his own outputs. ==Rationale== There is several consequences of our proposal: * The receiver can bump the fee of the original transaction. * The receiver can modify the outputs of the original PSBT. * The sender must provide the UTXO information (Witness or previous transaction) in the PSBT. ===Respecting the minimum relay fee policy=== To be properly relayed, a Bitcoin transaction needs to pay at least 1 satoshi per virtual byte. When blocks are not full, the original transaction might already at the minimum relay fee rate (currently 1 satoshi per virtual byte), so if the receiver adds their own input, they need to make sure the fee is increased such that the rate does not drop below the minimum relay fee rate. In such case, the sender must set both <code>maxadditionalfeecontribution=</code> and <code>additionalfeeoutputindex=</code>. See the [[#fee-output|Fee output]] section for more information. We also recommend the sender to set <code>minfeerate=</code>, as the sender's node policy might be different from the receiver's policy. ===Defeating heuristics based on the fee calculation=== Most wallets are creating a round fee rate (like 2 sat/b). If the payjoin transaction's fee was not increased by the added size, then those payjoin transactions could easily be identifiable on the blockchain. Not only would those transactions stand out by not having a round fee (like 1.87 sat/b), but any suspicion of payjoin could be confirmed by checking if removing one input would create a round fee rate. In such case, the sender must set both <code>maxadditionalfeecontribution=</code> and <code>additionalfeeoutputindex=</code>. The recommended value <code>maxadditionalfeecontribution=</code> is explained in the [[#fee-output|Fee output]] section. We also recommend the sender to set <code>minfeerate=</code>, as the sender's node policy might be different from the receiver's policy. ===Receiver does not need to be a full node=== Because the receiver needs to bump the fee to keep the same fee rate as the original PSBT, it needs the input's UTXO information to know what is the original fee rate. Without PSBT, light wallets like Wasabi Wallet would not be able to receive a payjoin transaction. The validation (policy and consensus) of the original transaction is optional: a receiver without a full node can decide to create the payjoin transaction and automatically broadcast the original transaction after a timeout of 1 minute, and only verify that it has been propagated in the network. However, non-interactive receivers (like a payment processor) need to verify the transaction to prevent UTXO probing attacks. This is not a concern for interactive receivers like Wasabi Wallet, because those receivers can just limit the number of original PSBT proposals of a specific address to one. With such wallets, the attacker has no way to generate new deposit addresses to probe the UTXOs. ===<span id="spare-change"></span>Spare change donation=== Small change inside wallets are detrimental to privacy. Mixers like Wasabi wallet, because of its protocol, eventually generate such [[https://docs.wasabiwallet.io/using-wasabi/ChangeCoins.html#first-round-coinjoin-change|small change]]. A common way to protect your privacy is to donate those spare changes, to deposit them in an exchange or on your favorite merchant's store account. Those kind of transactions can easily be spotted on the blockchain: There is only one output. However, if you donate via payjoin, it will look like a normal transaction. On top of this the receiver can poison analysis by randomly faking a round amount of satoshi for the additional output. ===<span id="output-substitution"></span>Payment output substitution=== Unless disallowed by sender explicitely via `disableoutputsubstitution=true` or by the BIP21 url via query parameter the `pjos=0`, the receiver is free to decrease the amount, remove, or change the scriptPubKey output paying to himself. Note that if payment output substitution is disallowed, the reveiver can still increase the amount of the output. (See [[#reference-impl|the reference implementation]]) For example, if the sender's scriptPubKey type is P2WPKH while the receiver's payment output in the original PSBT is P2SH, then the receiver can substitute the payment output to be P2WPKH to match the sender's scriptPubKey type. ===<span id="unsecured-payjoin"></span>Unsecured payjoin server=== A receiver might run the payment server (generating the BIP21 invoice) on a different server than the payjoin server, which could be less trusted than the payment server. In such case, the payment server can signal to the sender, via the BIP21 parameter <code>pjos=0</code>, that they MUST disallow [[#output-substitution|payment output substitution]]. A compromised payjoin server could steal the hot wallet outputs of the receiver, but would not be able to re-route payment to himself. ===Impacted heuristics=== Our proposal of payjoin is breaking the following blockchain heuristics: * Common inputs heuristics. Because payjoin is mixing the inputs of the sender and receiver, this heuristic becomes unreliable. * Change identification from scriptPubKey type heuristics When Alice pays Bob, if Alice is using P2SH but Bob's deposit address is P2WPKH, the heuristic would assume that the P2SH output is the change address of Alice. This is now however a broken assumption, as the payjoin receiver has the freedom to mislead analytics by purposefully changing the invoice's address in the payjoin transaction. See [[#output-substitution|payment output substitution]]. * Change identification from round change amount If Alice pays Bob, she might be tempted to pay him a round amount, like <code>1.23000000 BTC</code>. When this happens, blockchain analysis often identifies the output without the round amount as the change of the transaction. For this reason, during a [[#spare-change|spare change]] case, the receiver may add an output with a rounded amount randomly. ==Attack vectors== ===<span id="probing-attack"></span>On the receiver side: UTXO probing attack=== When the receiver creates a payjoin proposal, they expose one or more inputs belonging to them. An attacker could create multiple original transactions in order to learn the UTXOs of the receiver, while not broadcasting the payjoin proposal. While we cannot prevent this type of attack entirely, we implemented the following mitigations: * When the receiver detects an original transaction being broadcast, or if the receiver detects that the original transaction has been double spent, then they will reuse the UTXO that was exposed for the next payjoin. * While the exposed UTXO will be reused in priority to not leak other UTXOs, there is no strong guarantee about it. This prevents the attacker from detecting with certainty the next payjoin of the merchant to another peer. Note that probing attacks are only a problem for automated payment systems such as BTCPay Server. End-user wallets with payjoin capabilities are not affected, as the attacker can't create multiple invoices to force the receiver to expose their UTXOs. ===On the sender side: Double payment risk for hardware wallets=== For a successful payjoin to happen, the sender needs to sign two transactions double spending each other: The original transaction and the payjoin proposal. The sender's software wallet can verify that the payjoin proposal is legitimate by the sender's checklist. However, a hardware wallet can't verify that this is indeed the case. This means that the security guarantee of the hardware wallet is decreased. If the sender's software is compromised, the hardware wallet would sign two valid transactions, thus sending two payments. Without payjoin, the maximum amount of money that could be lost by a compromised software is equal to one payment (via [[#output-substitution|payment output substitution]]). Note that the sender can disallow [[#output-substitution|payment output substitution]] by using the optional parameter <code>disableoutputsubstitution=true</code>. With payjoin, the maximum amount of money that can be lost is equal to two payments. ==<span id="reference-impl"></span>Reference sender's implementation== Here is pseudo code of a sender implementation. <code>RequestPayjoin</code> takes the bip21 URI of the payment, the wallet and the <code>signedPSBT</code>. The <code>signedPSBT</code> represents a PSBT which has been fully signed, but not yet finalized. We then prepare <code>originalPSBT</code> from the <code>signedPSBT</code> via the <code>CreateOriginalPSBT</code> function and get back the <code>proposal</code>. While we verify the <code>proposal</code>, we also import into it informations about our own inputs and outputs from the <code>signedPSBT</code>. At the end of this <code>RequestPayjoin</code>, the proposal is verified and ready to be signed. We logged the different PSBT involved, and show the result in our [[#test-vectors|test vectors]]. <pre> public async Task<PSBT> RequestPayjoin( BIP21Uri bip21, Wallet wallet, PSBT signedPSBT, PayjoinClientParameters optionalParameters) { Log("Unfinalized signed PSBT" + signedPSBT); // Extracting the pj link. var endpoint = bip21.ExtractPayjointEndpoint(); if (signedPSBT.IsAllFinalized()) throw new InvalidOperationException("The original PSBT should not be finalized."); ScriptPubKeyType inputScriptType = wallet.ScriptPubKeyType(); PSBTOutput feePSBTOutput = null; bool allowOutputSubstitution = !optionalParameters.DisableOutputSubstitution; if (bip21.Parameters.Contains("pjos") && bip21.Parameters["pjos"] == "0") allowOutputSubstitution = false; if (optionalParameters.AdditionalFeeOutputIndex != null && optionalParameters.MaxAdditionalFeeContribution != null) feePSBTOutput = signedPSBT.Outputs[optionalParameters.AdditionalFeeOutputIndex]; Script paymentScriptPubKey = bip21.Address == null ? null : bip21.Address.ScriptPubKey; decimal originalFee = signedPSBT.GetFee(); PSBT originalPSBT = CreateOriginalPSBT(signedPSBT); Transaction originalGlobalTx = signedPSBT.GetGlobalTransaction(); TxOut feeOutput = feePSBTOutput == null ? null : originalGlobalTx.Outputs[feePSBTOutput.Index]; var originalInputs = new Queue<(TxIn OriginalTxIn, PSBTInput SignedPSBTInput)>(); for (int i = 0; i < originalGlobalTx.Inputs.Count; i++) { originalInputs.Enqueue((originalGlobalTx.Inputs[i], signedPSBT.Inputs[i])); } var originalOutputs = new Queue<(TxOut OriginalTxOut, PSBTOutput SignedPSBTOutput)>(); for (int i = 0; i < originalGlobalTx.Outputs.Count; i++) { originalOutputs.Enqueue((originalGlobalTx.Outputs[i], signedPSBT.Outputs[i])); } // Add the client side query string parameters endpoint = ApplyOptionalParameters(endpoint, optionalParameters); Log("original PSBT" + originalPSBT); PSBT proposal = await SendOriginalTransaction(endpoint, originalPSBT, cancellationToken); Log("payjoin proposal" + proposal); // Checking that the PSBT of the receiver is clean if (proposal.GlobalXPubs.Any()) { throw new PayjoinSenderException("GlobalXPubs should not be included in the receiver's PSBT"); } //////////// if (proposal.CheckSanity() is List<PSBTError> errors && errors.Count > 0) throw new PayjoinSenderException($"The proposal PSBT is not sane ({errors[0]})"); var proposalGlobalTx = proposal.GetGlobalTransaction(); // Verify that the transaction version, and nLockTime are unchanged. if (proposalGlobalTx.Version != originalGlobalTx.Version) throw new PayjoinSenderException($"The proposal PSBT changed the transaction version"); if (proposalGlobalTx.LockTime != originalGlobalTx.LockTime) throw new PayjoinSenderException($"The proposal PSBT changed the nLocktime"); HashSet<Sequence> sequences = new HashSet<Sequence>(); // For each inputs in the proposal: foreach (PSBTInput proposedPSBTInput in proposal.Inputs) { if (proposedPSBTInput.HDKeyPaths.Count != 0) throw new PayjoinSenderException("The receiver added keypaths to an input"); if (proposedPSBTInput.PartialSigs.Count != 0) throw new PayjoinSenderException("The receiver added partial signatures to an input"); PSBTInput proposedTxIn = proposalGlobalTx.Inputs.FindIndexedInput(proposedPSBTInput.PrevOut).TxIn; bool isOurInput = originalInputs.Count > 0 && originalInputs.Peek().OriginalTxIn.PrevOut == proposedPSBTInput.PrevOut; // If it is one of our input if (isOurInput) { OutPoint inputPrevout = ourPrevouts.Dequeue(); TxIn originalTxin = originalGlobalTx.Inputs.FromOutpoint(inputPrevout); PSBTInput originalPSBTInput = originalPSBT.Inputs.FromOutpoint(inputPrevout); // Verify that sequence is unchanged. if (input.OriginalTxIn.Sequence != proposedTxIn.Sequence) throw new PayjoinSenderException("The proposedTxIn modified the sequence of one of our inputs") // Verify the PSBT input is not finalized if (proposedPSBTInput.IsFinalized()) throw new PayjoinSenderException("The receiver finalized one of our inputs"); // Verify that <code>non_witness_utxo</code> and <code>witness_utxo</code> are not specified. if (proposedPSBTInput.NonWitnessUtxo != null || proposedPSBTInput.WitnessUtxo != null) throw new PayjoinSenderException("The receiver added non_witness_utxo or witness_utxo to one of our inputs"); sequences.Add(proposedTxIn.Sequence); // Fill up the info from the original PSBT input so we can sign and get fees. proposedPSBTInput.NonWitnessUtxo = input.SignedPSBTInput.NonWitnessUtxo; proposedPSBTInput.WitnessUtxo = input.SignedPSBTInput.WitnessUtxo; // We fill up information we had on the signed PSBT, so we can sign it. foreach (var hdKey in input.SignedPSBTInput.HDKeyPaths) proposedPSBTInput.HDKeyPaths.Add(hdKey.Key, hdKey.Value); proposedPSBTInput.RedeemScript = signedPSBTInput.RedeemScript; proposedPSBTInput.RedeemScript = input.SignedPSBTInput.RedeemScript; } else { // Verify the PSBT input is finalized if (!proposedPSBTInput.IsFinalized()) throw new PayjoinSenderException("The receiver did not finalized one of their input"); // Verify that non_witness_utxo or witness_utxo are filled in. if (proposedPSBTInput.NonWitnessUtxo == null && proposedPSBTInput.WitnessUtxo == null) throw new PayjoinSenderException("The receiver did not specify non_witness_utxo or witness_utxo for one of their inputs"); sequences.Add(proposedTxIn.Sequence); // Verify that the payjoin proposal did not introduced mixed inputs' type. if (inputScriptType != proposedPSBTInput.GetInputScriptPubKeyType()) throw new PayjoinSenderException("Mixed input type detected in the proposal"); } } // Verify that all of sender's inputs from the original PSBT are in the proposal. if (originalInputs.Count != 0) throw new PayjoinSenderException("Some of our inputs are not included in the proposal"); // Verify that the payjoin proposal did not introduced mixed inputs' sequence. if (sequences.Count != 1) throw new PayjoinSenderException("Mixed sequence detected in the proposal"); decimal newFee = proposal.GetFee(); decimal additionalFee = newFee - originalFee; if (additionalFee < 0) throw new PayjoinSenderException("The receiver decreased absolute fee"); // For each outputs in the proposal: foreach (PSBTOutput proposedPSBTOutput in proposal.Outputs) { // Verify that no keypaths is in the PSBT output if (proposedPSBTOutput.HDKeyPaths.Count != 0) throw new PayjoinSenderException("The receiver added keypaths to an output"); if (originalOutputs.Count == 0) continue; var originalOutput = originalOutputs.Peek(); bool isOriginalOutput = originalOutput.OriginalTxOut.ScriptPubKey == proposedPSBTOutput.ScriptPubKey; bool substitutedOutput = !isOriginalOutput && allowOutputSubstitution && originalOutput.OriginalTxOut.ScriptPubKey == paymentScriptPubKey; if (isOriginalOutput || substitutedOutput) { originalOutputs.Dequeue(); if (output.OriginalTxOut == feeOutput) { var actualContribution = feeOutput.Value - proposedPSBTOutput.Value; // The amount that was substracted from the output's value is less than or equal to maxadditionalfeecontribution if (actualContribution > optionalParameters.MaxAdditionalFeeContribution) throw new PayjoinSenderException("The actual contribution is more than maxadditionalfeecontribution"); // Make sure the actual contribution is only paying fee if (actualContribution > additionalFee) throw new PayjoinSenderException("The actual contribution is not only paying fee"); // Make sure the actual contribution is only paying for fee incurred by additional inputs int additionalInputsCount = proposalGlobalTx.Inputs.Count - originalGlobalTx.Inputs.Count; if (actualContribution > originalFeeRate * GetVirtualSize(inputScriptType) * additionalInputsCount) throw new PayjoinSenderException("The actual contribution is not only paying for additional inputs"); } else if (allowOutputSubstitution && output.OriginalTxOut.ScriptPubKey == paymentScriptPubKey) { // That's the payment output, the receiver may have changed it. } else { if (originalOutput.OriginalTxOut.Value > proposedPSBTOutput.Value) throw new PayjoinSenderException("The receiver decreased the value of one of the outputs"); } // We fill up information we had on the signed PSBT, so we can sign it. foreach (var hdKey in output.SignedPSBTOutput.HDKeyPaths) proposedPSBTOutput.HDKeyPaths.Add(hdKey.Key, hdKey.Value); proposedPSBTOutput.RedeemScript = output.SignedPSBTOutput.RedeemScript; } } // Verify that all of sender's outputs from the original PSBT are in the proposal. if (originalOutputs.Count != 0) { // The payment output may have been substituted if (!allowOutputSubstitution || originalOutputs.Count != 1 || originalOutputs.Dequeue().OriginalTxOut.ScriptPubKey != paymentScriptPubKey) { throw new PayjoinSenderException("Some of our outputs are not included in the proposal"); } } // After signing this proposal, we should check if minfeerate is respected. Log("payjoin proposal filled with sender's information" + proposal); return proposal; } int GetVirtualSize(ScriptPubKeyType? scriptPubKeyType) { switch (scriptPubKeyType) { case ScriptPubKeyType.Legacy: return 148; case ScriptPubKeyType.Segwit: return 68; case ScriptPubKeyType.SegwitP2SH: return 91; default: return 110; } } // Finalize the signedPSBT and remove confidential information PSBT CreateOriginalPSBT(PSBT signedPSBT) { var original = signedPSBT.Clone(); original = original.Finalize(); foreach (var input in original.Inputs) { input.HDKeyPaths.Clear(); input.PartialSigs.Clear(); input.Unknown.Clear(); } foreach (var output in original.Outputs) { output.Unknown.Clear(); output.HDKeyPaths.Clear(); } original.GlobalXPubs.Clear(); return original; } </pre> ==<span id="test-vectors"></span>Test vectors== A successful exchange with: {| class="wikitable" !InputScriptType !Orginal PSBT Fee rate !maxadditionalfeecontribution !additionalfeeoutputindex |- |P2SH-P2WPKH |2 sat/vbyte |0.00000182 |0 |} <code>Unfinalized signed PSBT</code> <pre>cHNidP8BAHMCAAAAAY8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////AtyVuAUAAAAAF6kUHehJ8GnSdBUOOv6ujXLrWmsJRDCHgIQeAAAAAAAXqRR3QJbbz0hnQ8IvQ0fptGn+votneofTAAAAAAEBIKgb1wUAAAAAF6kU3k4ekGHKWRNbA1rV5tR5kEVDVNCHAQQWABTHikVyU1WCjVZYB03VJg1fy2mFMCICAxWawBqg1YdUxLTYt9NJ7R7fzws2K09rVRBnI6KFj4UWRzBEAiB8Q+A6dep+Rz92vhy26lT0AjZn4PRLi8Bf9qoB/CMk0wIgP/Rj2PWZ3gEjUkTlhDRNAQ0gXwTO7t9n+V14pZ6oljUBIgYDFZrAGqDVh1TEtNi300ntHt/PCzYrT2tVEGcjooWPhRYYSFzWUDEAAIABAACAAAAAgAEAAAAAAAAAAAEAFgAURvYaK7pzgo7lhbSl/DeUan2MxRQiAgLKC8FYHmmul/HrXLUcMDCjfuRg/dhEkG8CO26cEC6vfBhIXNZQMQAAgAEAAIAAAACAAQAAAAEAAAAAAA==</pre> <code>Original PSBT</code> <pre>cHNidP8BAHMCAAAAAY8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////AtyVuAUAAAAAF6kUHehJ8GnSdBUOOv6ujXLrWmsJRDCHgIQeAAAAAAAXqRR3QJbbz0hnQ8IvQ0fptGn+votneofTAAAAAAEBIKgb1wUAAAAAF6kU3k4ekGHKWRNbA1rV5tR5kEVDVNCHAQcXFgAUx4pFclNVgo1WWAdN1SYNX8tphTABCGsCRzBEAiB8Q+A6dep+Rz92vhy26lT0AjZn4PRLi8Bf9qoB/CMk0wIgP/Rj2PWZ3gEjUkTlhDRNAQ0gXwTO7t9n+V14pZ6oljUBIQMVmsAaoNWHVMS02LfTSe0e388LNitPa1UQZyOihY+FFgABABYAFEb2Giu6c4KO5YW0pfw3lGp9jMUUAAA=</pre> <code>payjoin proposal</code> <pre>cHNidP8BAJwCAAAAAo8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////jye60aAl3JgZdaIERvjkeh72VYZuTGH/ps2I4l0IO4MBAAAAAP7///8CJpW4BQAAAAAXqRQd6EnwadJ0FQ46/q6NcutaawlEMIcACT0AAAAAABepFHdAltvPSGdDwi9DR+m0af6+i2d6h9MAAAAAAAEBIICEHgAAAAAAF6kUyPLL+cphRyyI5GTUazV0hF2R2NWHAQcXFgAUX4BmVeWSTJIEwtUb5TlPS/ntohABCGsCRzBEAiBnu3tA3yWlT0WBClsXXS9j69Bt+waCs9JcjWtNjtv7VgIge2VYAaBeLPDB6HGFlpqOENXMldsJezF9Gs5amvDQRDQBIQJl1jz1tBt8hNx2owTm+4Du4isx0pmdKNMNIjjaMHFfrQAAAA==</pre> <code>payjoin proposal filled with sender's information</code> <pre>cHNidP8BAJwCAAAAAo8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////jye60aAl3JgZdaIERvjkeh72VYZuTGH/ps2I4l0IO4MBAAAAAP7///8CJpW4BQAAAAAXqRQd6EnwadJ0FQ46/q6NcutaawlEMIcACT0AAAAAABepFHdAltvPSGdDwi9DR+m0af6+i2d6h9MAAAAAAQEgqBvXBQAAAAAXqRTeTh6QYcpZE1sDWtXm1HmQRUNU0IcBBBYAFMeKRXJTVYKNVlgHTdUmDV/LaYUwIgYDFZrAGqDVh1TEtNi300ntHt/PCzYrT2tVEGcjooWPhRYYSFzWUDEAAIABAACAAAAAgAEAAAAAAAAAAAEBIICEHgAAAAAAF6kUyPLL+cphRyyI5GTUazV0hF2R2NWHAQcXFgAUX4BmVeWSTJIEwtUb5TlPS/ntohABCGsCRzBEAiBnu3tA3yWlT0WBClsXXS9j69Bt+waCs9JcjWtNjtv7VgIge2VYAaBeLPDB6HGFlpqOENXMldsJezF9Gs5amvDQRDQBIQJl1jz1tBt8hNx2owTm+4Du4isx0pmdKNMNIjjaMHFfrQABABYAFEb2Giu6c4KO5YW0pfw3lGp9jMUUIgICygvBWB5prpfx61y1HDAwo37kYP3YRJBvAjtunBAur3wYSFzWUDEAAIABAACAAAAAgAEAAAABAAAAAAA=</pre> ==Implementations== * [[https://github.com/BlueWallet/BlueWallet|BlueWallet]] is in the process of implementing the protocol. * [[https://github.com/btcpayserver/btcpayserver|BTCPay Server]] has implemented sender and receiver side of this protocol. * [[https://github.com/zkSNACKs/WalletWasabi/|Wasabi Wallet]] has merged sender's support. * [[https://github.com/JoinMarket-Org/joinmarket-clientserver|Join Market]] has implemented sender and receiver side of this protocol. * [[https://github.com/bitcoinjs/payjoin-client|JavaScript sender implementation]]. ==Backward compatibility== The receivers are advertising payjoin capabilities through [[bip-0021.mediawiki|BIP21's URI Scheme]]. Senders not supporting payjoin will just ignore the <code>pj</code> variable and thus, will proceed to normal payment. ==Special thanks== Special thanks to Kukks for developing the initial support to BTCPay Server, to junderw, AdamISZ, lukechilds, ncoelho, nopara73, lontivero, yahiheb, SomberNight, andrewkozlik, instagibbs, RHavar for all the feedback we received since our first implementation. Thanks again to RHavar who wrote the [[bip-0079.mediawiki|BIP79 Bustapay]] proposal, this gave a good starting point for our proposal.

    Import from clipboard

    Paste your markdown or webpage here...

    Advanced permission required

    Your current role can only read. Ask the system administrator to acquire write and comment permission.

    This team is disabled

    Sorry, this team is disabled. You can't edit this note.

    This note is locked

    Sorry, only owner can edit this note.

    Reach the limit

    Sorry, you've reached the max length this note can be.
    Please reduce the content or divide it to more notes, thank you!

    Import from Gist

    Import from Snippet

    or

    Export to Snippet

    Are you sure?

    Do you really want to delete this note?
    All users will lose their connection.

    Create a note from template

    Create a note from template

    Oops...
    This template has been removed or transferred.
    Upgrade
    All
    • All
    • Team
    No template.

    Create a template

    Upgrade

    Delete template

    Do you really want to delete this template?
    Turn this template into a regular note and keep its content, versions, and comments.

    This page need refresh

    You have an incompatible client version.
    Refresh to update.
    New version available!
    See releases notes here
    Refresh to enjoy new features.
    Your user state has changed.
    Refresh to load new user state.

    Sign in

    Forgot password

    or

    By clicking below, you agree to our terms of service.

    Sign in via Facebook Sign in via Twitter Sign in via GitHub Sign in via Dropbox Sign in with Wallet
    Wallet ( )
    Connect another wallet

    New to HackMD? Sign up

    Help

    • English
    • 中文
    • Français
    • Deutsch
    • 日本語
    • Español
    • Català
    • Ελληνικά
    • Português
    • italiano
    • Türkçe
    • Русский
    • Nederlands
    • hrvatski jezik
    • język polski
    • Українська
    • हिन्दी
    • svenska
    • Esperanto
    • dansk

    Documents

    Help & Tutorial

    How to use Book mode

    Slide Example

    API Docs

    Edit in VSCode

    Install browser extension

    Contacts

    Feedback

    Discord

    Send us email

    Resources

    Releases

    Pricing

    Blog

    Policy

    Terms

    Privacy

    Cheatsheet

    Syntax Example Reference
    # Header Header 基本排版
    - Unordered List
    • Unordered List
    1. Ordered List
    1. Ordered List
    - [ ] Todo List
    • Todo List
    > Blockquote
    Blockquote
    **Bold font** Bold font
    *Italics font* Italics font
    ~~Strikethrough~~ Strikethrough
    19^th^ 19th
    H~2~O H2O
    ++Inserted text++ Inserted text
    ==Marked text== Marked text
    [link text](https:// "title") Link
    ![image alt](https:// "title") Image
    `Code` Code 在筆記中貼入程式碼
    ```javascript
    var i = 0;
    ```
    var i = 0;
    :smile: :smile: Emoji list
    {%youtube youtube_id %} Externals
    $L^aT_eX$ LaTeX
    :::info
    This is a alert area.
    :::

    This is a alert area.

    Versions and GitHub Sync
    Get Full History Access

    • Edit version name
    • Delete

    revision author avatar     named on  

    More Less

    Note content is identical to the latest version.
    Compare
      Choose a version
      No search result
      Version not found
    Sign in to link this note to GitHub
    Learn more
    This note is not linked with GitHub
     

    Feedback

    Submission failed, please try again

    Thanks for your support.

    On a scale of 0-10, how likely is it that you would recommend HackMD to your friends, family or business associates?

    Please give us some advice and help us improve HackMD.

     

    Thanks for your feedback

    Remove version name

    Do you want to remove this version name and description?

    Transfer ownership

    Transfer to
      Warning: is a public team. If you transfer note to this team, everyone on the web can find and read this note.

        Link with GitHub

        Please authorize HackMD on GitHub
        • Please sign in to GitHub and install the HackMD app on your GitHub repo.
        • HackMD links with GitHub through a GitHub App. You can choose which repo to install our App.
        Learn more  Sign in to GitHub

        Push the note to GitHub Push to GitHub Pull a file from GitHub

          Authorize again
         

        Choose which file to push to

        Select repo
        Refresh Authorize more repos
        Select branch
        Select file
        Select branch
        Choose version(s) to push
        • Save a new version and push
        • Choose from existing versions
        Include title and tags
        Available push count

        Pull from GitHub

         
        File from GitHub
        File from HackMD

        GitHub Link Settings

        File linked

        Linked by
        File path
        Last synced branch
        Available push count

        Danger Zone

        Unlink
        You will no longer receive notification when GitHub file changes after unlink.

        Syncing

        Push failed

        Push successfully