## Meeting notes Sean/Erik 2022-01-20 The current plugin hook implementation is responsible for providing a local git repository for this non-git source, and then return relevant information. You want to return: - To name a folder from having done "git clone" provided content is trivial, you use the external git repository name. - You want to return the local destination path Input: - WARNING: there are some changes upstream, so you may have some merge conflict someplace. - Refactor current PR to not change `_wait_sync_progress_something...`` - Refactor to pass GitPuller object to the plugin hook implementation - Add inline comments about awkward names etc or assumptions that break with having a content provider - Avoid bleeding assumptions on what the plugin does to provide a local git repo to clone from into the names etc of what we find in the nbgitpuller repo. - Deliberate on when to do plugin discovery - once or every time? - Plugin discovery should always be done in its own function or similar, like discover_plugins() - One concrete idea to consider: - 1. Load plugins during startup, emit logs about what was discovered - 2. Let the plugins define patterns that influences if they are used or not. For example, if you pass a source url matching a google drive link, then you can assume you want to use the google-downloader-plugin - Current implementation: - We declare the plugin to use by saying what content_provider