# Stat Panel removal

## The Goal
1. Making things more visible and direct to the player makes it easier for new players to figure out what's going on in their game. Many verbs or bits of information that items provide simply go over people's heads because no one thinks to look at their stat panel every time they pick up a new item. [ [Exhibit A](https://github.com/tgstation/tgstation/pull/95461#issuecomment-4093222635) | [Exhibit B](https://github.com/tgstation/tgstation/pull/95460#issuecomment-4093226761) ]
2. Complimenting goal #1, things being on the game's screen rather than on a large OOC box taking 1/3 of your screen is an immediate upgrade for immersion, now players see the big 'OFF' on their Space suit, hovering over it will read the battery closely, and clicking on it will toggle it, all this instead of a stat panel entry of simple text that forces you to pull yourself out of the game screen to read.
3. Bring SS13 up to speed with the UI of SS14, players who are new to both games tend to prefer SS14 because of 13's outdated & confusing UI with a bunch of text boxes as options which you don't need more than half the time, many of which you probably have never touched once. If OpenDream or a Steam release were to happen anytime soon, making the UI nicer would ease the transition from SS14 players onto SS13 servers.
4. The removal of the Stat panel means more screen space for chat, the actual important part of the right side of your screen. It alternatively could also be more screen space in a potential fullscreen SS13 a la SS14, but that's not the end goal for this project.
5. Removing "IC" stuff from the Stat Panel means that the people that DO have the stat panel (Admins) have less clutter to sift through to get to the tools they actually care for.

## What to avoid

1. Add too many HUD elements where they could possibly overlap with eachother (Changeling Chem storage, Plasma Vessel Organ and Vampire's Blood HUD are possible overlaps we should avoid or figure out a solution to).
2. Bloat the Escape menu, it should be easy for players to navigate through. Adding to it is fine but just try not to overdo it.

## What we're doing

Removing the stat panel for all players EXCEPT AIs (or Silicons?), Interviewees, and Admins. The list below shows everything and what it's being replaced with.

###### Self-note: With the amount of work that is necessary for this, and the amount of verbs that seems nigh impossible to replace, perhaps it would be better to instead make it more Goon-style, with a dropdown status panel meant just for commands that can't fit elsewhere?

This is gonna mean a lot more HUDs, so be ready.

## List of all things that must be moved before stat panel is removed
### Anything not listed needs an entry so if you can think of something to replace it with, let me know.

### Status tab

##### This part needs to be focused on the most so the Stat panel could at the very least be made optional, see https://github.com/tgstation/tgstation/pull/95383 for more information.

Map/IRL Time/Round ID/Time Dilation: Removed in favor of being in the Escape menu.
Round Time / Station Time: Removed in favor of being in the PDA.
Shuttle timer - Perhaps outright removed for non-admins? We already have telescreens around the station to indicate time, does the crew need this 24/7?

#### Alternate Stat Panel idea

With the recent removals from the stat panel and the [merging of times](https://github.com/tgstation/tgstation/pull/95744) making it easier for players to know the IC time, perhaps the rest of the stat panel is fine as-is, and could simply be removed from players? Limiting this to *<span style='border-bottom: 1px dotted;'>AIs</span>/Admins, turning Stat Panel's info into an IC thing for AIs (and OOC for Admins) as people can either look at their PDA for the time, a telescreen for shuttle time, or simply ask the <span style='border-bottom: 1px dotted;'>AIs</span> (or more than likely the <span style='border-bottom: 1px dotted;'>AIs</span> will say "[x] time until shuttle please make your way towards departures").

*Or silicon in general (pAI included).

#### Unique HUD entries

Blob minion - Could be a HUD element
Blob - Health & power is already HUD, blobs to win like blob minion could be a new HUD element or it can be part of their antag panel. Time until placement could be a HUD that disappears once they place.
Parrot - Inventory slot like gorillas.
Slimes - HUD elements, replacing the health HUDs.
Revenant - HUD elements, essence is already one but doesn't show the max, could work like the new Changeling HUD (hover over to see max).
Larva - Balloon alert when ready to grow, or time-until-ready over the evolve action button.
Silicon - Laws are already in their built-in PDA
Robot energy storage - HUD element added when you're holding the item in question
Robot - HUD element
Mulebots - HUD element, maybe taking from the new space suit HUD?
pAI - Basic mob health doll like everyone else.

### Admin tab

Adminhelp - Already in Escape menu & F1
Adminnotice -
Adminwho - https://hackmd.io/443_dE5lRWeEAp9bjGcKYw#Player-List
View Latest Ticket - [Removed, already in Escape menu](https://github.com/tgstation/tgstation/pull/95744)

### IC tab

Activate Held Object - Removed, already "Z" Hotkey
Look Down/Look Up - Unfortunately this is already an obscure verb, perhaps it could be added to the Look Up/Look Down HUD element as RMB action, otherwise this becomes hotkey-only.
Move Upwards/Down - Already a HUD element, removed
Memories - Already a HUD element, removed
Navigate - Already a HUD element, removed
Open Language Menu - Already a HUD element, removed
Pull - Already CtrlClick, one of the most important hotkeys, easy removal. (This is also kinda broken as it tries to grab anchored items like floor lights, rendering the list full of items that aren't even 'grabbable')
Resist - Already a HUD element, removed
Rest - Already a HUD element, removed
Sleep - Already a HUD element, removed
Stop Pulling - Already a HUD element, removed
View Skills - Removed, we already have ways in-game to see your skill, and skills aren't important enough to take screen space.
Swap Style - See 'Misc Tab' section.
Exit Hivemind (Imaginary Friend) - Already an action button, removed.

### OOC tab

Cancel Camera view - Incorporated into hitting Escape (just like how it's also used to instantly release all key presses).
Changelog - Moved to Escape menu, removed.
Check achievements -
Export Preferences - Moved either to the preference menu under your name, or in the keybinds menu next to "Reset all Keybinds".
Fit Viewport -
Fix Chat -
Reset UI Positions -
Ignore/Unignore - https://hackmd.io/443_dE5lRWeEAp9bjGcKYw#Player-List
MOTD -
Notify Restart -
Ping - We already show ping in the chatbar, this could be removed?
Refresh TGUI -
Request Internet Sound - Moved into a button in the chat's Music player section.
Respawn - Replaces "Leave Body" in the Esc menu when you're a Ghost, if respawning is enabled.
Server's Last Round -
Show Policy -
Show Server Revision -
Stop Sounds -
View Admin Remarks - [Removed, now in Escape menu](https://github.com/tgstation/tgstation/pull/95477)
View Tracked Playtime -
Vote -
Who - https://hackmd.io/443_dE5lRWeEAp9bjGcKYw#Player-List
Your Last Round -
Link Forum Account -
Verify Discord Account -
Server Hop (Dead only) -
Reset Menu HUD (Dead only) -
Ghost - Removed, already in the Esc menu.
Show Map Vote Tallies -

### Misc Tabs

Boxing/Evil Boxing/Hunter Boxing/CQC/Plasma Fist/Sleeping Carp/Spider's Bite/Wrestling all exists as categories that show your martial art help button. Perhaps this could instead be made an action button, LMB would show the current martial art help and RMB would swap modes. We have precedent of action buttons doing multiple things w/ MODsuits.

Interview - The interview should be non-closable and auto-close on accept (IMO), but this is still important enough that Interviewees should keep the stat panel on 24/7.

Drones:
- "Check Laws": Relaced with laws in the statpanel (like Borgs)
- "Drone Ping": Replaced with HUD button.

MMIs:
- "Toggle Listening": Replaced with Action button.

### AIs

AIs (and AIs using the cybernetic brain) keep the stat panel as they have many tools in it that isn't currently feasible to move away, they have enough buttons on their HUD currently and their expectation of knowing what theyre doing puts them in a higher skill floor than most roles and we can realistically expect them to learn how to navigate the status panel.

They will have one panel, with no title so it's simply text & verbs, that contains (in order):

1. List of borgs and buttons to follow each one (From their current stat panel entry)
2. List of Laws
3. AI verbs currently listed under "AI Commands" tab.

### Player List

The Esc menu should get a new button called "Players" which will list all ckeys of players & admins (separately), clicking on them will dropdown a menu to Ignore (or Unignore if they are ignored).

## Completed Changes

If this HackMD is ever brought to completion, it would be better to archive the changes completed rather than leave behind an empty document, as this doc doubles as a 'checklist' of sorts.

#### Status Tab Entries

New player lobby info - https://github.com/tgstation/tgstation/pull/90572
Reboot timer - https://github.com/tgstation/tgstation/pull/95357
Round Time: https://github.com/tgstation/tgstation/pull/95744
Vampire & Soulscythe Blood level - https://github.com/tgstation/tgstation/pull/90578
Plasma Vessel organ - https://github.com/tgstation/tgstation/pull/95119
Changeling - https://github.com/tgstation/tgstation/pull/95460
Space suit - https://github.com/tgstation/tgstation/pull/95463
Health assembly - https://github.com/tgstation/tgstation/pull/95461
Life link / Assassin Stealth Holoparasite / Guardian's "Check Guardian Type" - https://github.com/tgstation/tgstation/pull/95543

#### Tab & Verbs

Ghost tab - https://github.com/tgstation/tgstation/pull/91370
Examine & Point To Verbs / Object & Server Tabs - https://github.com/tgstation/tgstation/pull/95292
Toggle Fullscreen - https://github.com/tgstation/tgstation/pull/91234
Sleep verb - https://github.com/tgstation/tgstation/pull/91256
Internals tanks - https://github.com/tgstation/tgstation/pull/91387
Spells - https://github.com/tgstation/tgstation/pull/95293
Memories - https://github.com/tgstation/tgstation/pull/95303
Toggle Status Bar - https://github.com/tgstation/tgstation/pull/95328
Say/Me/OOC/Pray & Admin Notes: https://github.com/tgstation/tgstation/pull/95477
Emote Panel & Hotkeys Help: https://github.com/tgstation/tgstation/pull/95383

# Misc rants while this is being worked on

1. I don't like how the combat indicator is on so many basic mobs meanwhile it's utterly useless to them. I messed a bit with Dogs & Soulscythes and their combat indicator does nothing for them. Would like it if these mobs got a proper "combat"/"not combat" mode so it doesn't feel like the game UI just lies to the player.
2. If a mob isn't supposed to have a combat indicator at all, it should remove the UI element and give them `TRAIT_COMBAT_MODE_LOCK` instead. Preferably the basic hud unit test added [here](https://github.com/JohnFulpWillard/tgstation/blob/0e849fc39fa6050a9af0fc1ad13a2368ea051d46/code/modules/unit_tests/huds.dm#L22) could be moved to test ALL HUDs instead, I just couldn't be assed to go fix all the ones that currently don't work (and if you're going to do it, please also make it require a memory HUD too!).

###### tags: `TGstation`