---
# System prepended metadata

title: F11C Code Review

---

# F11C Code Review

Compare the files on the tutorial repository - [**review_1.py**](https://gitlab.cse.unsw.edu.au/COMP1531/21T1/content/-/blob/master/tutorials/tut04/review_1.py) and [**review_2.py**](https://gitlab.cse.unsw.edu.au/COMP1531/21T1/content/-/blob/master/tutorials/tut04/review_2.py).

Consider:
- Style
- Readability
- Is it Pythonic?

Choose which one you prefer (there is no right answer, but you should justify why you chose the one you did).

## AERO
The second one.
    * It has the explaination on top of the function to give details about what the code is doing
    * The style is more readable to human that avoid to put all the conditions in one place
    * Compare to the first code, the second code used a list to put horrible password inside avoid to use comparison multiple times
    * For loop in the second one is easier to read compare to the first one that put all the conditions in one line.


## BLINKER
The second one is more pythonic
1. Function made was given comments on input, output, and its objective
2. Variables constants were assigned appropriate name
3. It is overall more readable by user
4. Code written is efficient and not bulky


## CACTUS
- Review 1 uses multiple OR statements whilst Review 2 uses an array
- Review 1 does NOT use commenting whilst Review 2 uses comment
- Review 2 makes boolean checks only once throughout the code whilst Review 1 calls upon the same statement multiple times
- Review 2 could use more comments within the main part of the code to explain what each line is trying to achieve
We prefer Review 2


## DORITO
We believe the second program is better as it the comments throughout the program help us understand what the program is trying to achieve.

The indentation and spacing of the second program allow us to easily read the program.

However, the program is not pythonic.


## ECHO


