---
# System prepended metadata

title: Suggestions and Issues

---

# Suggestions and Issues 

## Developer tools
* eslint rules and configuration
* homologate npm -g packages and rules config
## Garbage Code - Bad implementation and Deprecated code 
* Validate modules in UI's 
    * Unused components
    * Remove react warning's 
    * Check dependencies B2C - Unused packages
    * Best practices on hooks
        * Avoid use it on for,while,foreach,map,etc
        * State management with Context
        * HOC with context approach 
        * REDUX against hooks 
* Cloudflare workers refactor 
* Code review for refactor
* Documentation with best practices for onboarding 
## Upgrade version of npm packages and runtime
* Fastify Upgrade https://github.com/fastify/fastify/blob/main/docs/Migration-Guide-V3.md
* Nextjs upgrade 
* NodeJS upgrade
## Unit test 
* Cross component 
    * for every container and component, Marketplace with priority
* B2C plans page coverage 
* falabella-ui-kit, templates 
## Performance test for UI's and services
* Lighthouse report - for every release
* Regression for Marketplace 
* Performance test when we add a new endpoint 
* Gatlin report 
## CI/CD 
* Gitlab 
* Add new step or script to update common packages
    * how we can increase the version automatically?
    Think on implement one snippet/bash for run this task even if I need this version in different environments
* Check Audit stages
## Infraestructure understanding 
* Skaffold -> raise cluster locally 
* kubectl
* Dockerfiles 
* Kubernetes Cluster and how we can check POD's
* GCP services + Logs 
## Monitoring tools
* DataDog 
* Grafana 
## Alerts and thresholds
* function for retrieve tresholds for every service in a normal day vs event day
* slack integration for alerts 
* Status of the site and services every day 
* Cloudflare reports 

NOTE: NextJS upgrade y Code review for refactor
## NextJS
* process.browser is deprecated used in CC and B2C
* GetInitialProps: Next "Recommended: getStaticProps or getServerSideProps."

## Talk - Consider
* Add toggles configuration to jarvis
* Validate categories and subcategories path in Jarvis


{“login”:{“clienteID”:“”,“genero”:“unset”,“tipo”:“person”},“page”:{“loginStatus”:“falabella guest”,“canal”:“internet”,“serverName”:“CATALYST”,“sessionId”:“bede9592c8e44c008e0f05640761f578-1644455299941",“geolocation”:“”}}