---
# System prepended metadata

title: Online Offers

---

# Online Offers

1. (Bug) CreateUserCommand - bug on api key length not being parsed to int - Franco (staged/commited/PR)
2. (Bug) ComponentLock - same issue in optusperks with entity manager instance - Franco (staged/commited/PR)
3. (Bug) RakutenOfferMapper::mapFromArray
    - `offerdescription` is null from client 
    - Franco (Parked|need clarification)
4. Repositories - using column id for relation query instead of relation property name.
    - `’mtfm.merchantId', ':merchantId’`
    - Franco (PR)
5. Classes not declared as final
    - Kernel
    - League/Csv/
    - AuthServiceProvider
    - EventServiceProvider
    - KernelTest
    - LoggableEventSubscriberTest
    - tests/Tools
    - Franco (progress)
6. (Requirement) Start task - Online Offers Easy Docker - dex
    - Delete all docker files
    - Use easy docker
    - Run tests
    - Run postman tests
7. Feed Syncer review and test (postman) - dex
    - Review mappers
    - Review Syncers

# RecRoom

1. Database column name relation mapping issue. [Jordan]
    - app/Repositories/Doctrine/ORM/Comments/PostRepository.php
    - app/Repositories/Doctrine/ORM/Likes/PostRepository.php
    - app/Repositories/Doctrine/ORM/Organisations/Events/MemberRepository.php
    - app/Repositories/Doctrine/ORM/Organisations/Events/PostRepository.php
    - app/Repositories/Doctrine/ORM/Organisations/Groups/MemberRepository.php
    - app/Repositories/Doctrine/ORM/Organisations/Groups/PostRepository.php
    - app/Repositories/Doctrine/ORM/Users/Awards/PostAwardRepository.php
    - app/Repositories/Doctrine/ORM/Users/Posts/ReportedPostRepository.php
    - app/Repositories/Doctrine/ORM/Users/MemberRepository.php
    - app/Repositories/Doctrine/ORM/CommentRepository.php
    - app/Repositories/Doctrine/ORM/LikeRepository.php

    - Update all to parameterised query as well.
2. Conventions/Standards Issue: [Jerric Calosor]
    - App\Services\CacheStore\CacheStore | Missing doc block comments
        - Tests\App\Unit\Services\CacheStore\CacheServiceTest needs to be renamed to Tests\App\Unit\Services\CacheStore\CacheStoreTest
    - App\Providers\CacheStoreServiceProvider | Missing doc block comments
    - App\Services\Engagement\PointsService | Translator should be removed as dependency since it wasn’t used
    - App\Services\InstantChat\TokenService | switch statement was not terminated properly `missing break tag`
    - App\Services\InstantChat\RoomService | messageRepository should be removed as dependency since it wasn’t used
    - App\Services\InstantChat\ParticipantService | setTyping() alpha sort issue
    - Controller public methods: Alpha sorted Dependency over primitive
3. Unused service - InstantChat Service might need to be removed since it’s no longer being used.
4. Classes are not declared as final: [Jerric Calosor]
    - App\External\Libraries\Doctrine\Extensions
        - LoggableEventSubscriber
        - LoggableExtension
    - App\External\Libraries\Doctrine\Paginator
        - PaginationData
        - PaginatorWrapper
    - App\Services\Engagement\PointsService
    - App\Services\Post
        - Generators
            - AwardGenerator
            - PollGenerator
            - PostGenerator
        - PostFactory
        - PostWrapperService
    - App\Services\QueryModifier
        - QueryModifierRepository
        - RepositoryFactory
    - App\Services\ResultWrapper\Results\PerfFix
        - FeedWrapper
        - GroupMembersWrapper
        - GroupWrapper
        - LoginMemberWrapper
        - PostAwardWrapper
        - PostPollWrapper
        - PostWithFrom
        - PostWrapper
        - ReportedPostWrapper
        - SearchMemberWrapper
        - Users\Awards\PostAwardWrapper
5. Update doc blocks to remove exception not thrown and update to static closures [Jordan]
6. Needs to be updated:
    - App\External\Libraries\Doctrine\Paginator
        - Replace *StepTheFkUp\EasyPagination\Interfaces\LengthAwarePaginatorInterface* of *LoyaltyCorp\EasyPagination\Interfaces\LengthAwarePaginatorInterface
7. App\Services\Post\PostWrapperService | Has 16 dependencies this needs to be refactored - low prio since it does it's job as of the moment
8. Unused dependency
    - MessageFactory Remove unused dependency and create Unit Test
    - app/Observers/Listeners/AddPointsToMemberListener.php
    - app/Services/Engagement/PointsService.php
    - app/Services/InstantChat/RoomService.php
