# Standup Notes
(Starting from March 16th, 2021)

**Tuesday, March 16th**
Done
- Pairing on Billy about branching stuff
- Integrating changes from Vino's [merged branch](https://github.com/Shopify/email/pull/8036) into this [branch](https://github.com/Shopify/email/pull/7970).

To Do
- Tophatting Billy's branch
- Passing failing tests on both open PRs: [here](https://github.com/Shopify/email/pull/7970) and [here](https://github.com/Shopify/email/pull/8118)
- Syncing with [this PR](https://github.com/Shopify/email/pull/8070) on backend changes if they happen today
- Backlog meeting n stuff

**Wednesday, March 17th**
Done
- Updated trigger description branch with Vino's changes
- Updating branches to pass CI
- Backlog meetings
- Paperclips

To Do
- Go over Felipe review
- Start resourceitem fix
- 1:1 with Eric

**Thursday, March 18th**
Done
- Submitted resourceitem fix
- tophatted Billy and Juwan PRs
- Fixed editor trigger description PR

To Do
- Meet with Felipe to merge editor trigger description branch
- Is this pattern extensible for the read only state of the editor?
- How to handle nullable fields like title and triggerDescription
- Type checks errors in CI
- Update read only state branch
- Demo prep
- Merge resource item fix (squash before merging)
- Rebase read only ui branch
- Felipe To Do
- Meeting about read only fields UX w Felipe and Natalie
- Add graphql troubleshooting instructions to docs
- Create ambiguous topbar loading component
- AutomationFrame component?

**Friday, March 19th**
Done
- Merged `editor-trigger-description` and `resourceitem-fix`

To Do
- X Rebase `editor-read-only-state` branch
- Tophat activity badge PR
- X Add graphql commands to troubleshooting docs
- X Create tophatting branch for `editor-read-only-state`
- Setup meeting w Natalie on readonly field ui stuff
- X Create issue for email editor loading component
- email + spin??

**Monday, March 22nd**
Done
- Created issue for editor loading component
- Opened up UI PR

To Do
- Rebase on `editor-read-only-state` branch again
- Start implementing universal loading component
- Request review on UI pr from Felipe and setup meeting with Natalie

**Tuesday, March 23rd**
Done
- Paired with Billy on Loading component
- Opened Loading state PR

To Do
- X Delegating PRs to Billy for hackdays
- Reading on Spin for email
- X UX tophatting with Natalie

- X Can you create an issue and add the Tech Debt label for us to investigate this?

**Monday, March 29th**
Done
- CHEO Hackdays project

To Do
- X Resolve conflicts on loading frame and ping Felipe about it
- X Address tooltip and
- X welcome email issues
- X replicate behaviour locally
- How to set theme colors on local?? https://github.com/Shopify/online-store-web
- Email + Spin integration for Co-op report
- Reply to Oliver about Hackathon

**Tuesday, March 30th**
Done
- submitted PR's for tophatting issues
- Paired w Felipe on new approach for Editor Loading component
- Paired with Billy on Apollo caching redirect issue

To Do
- Updating loading component PR
- Pair w Billy and Juwan
- 1:1

**Wednesday, March 31st**
Done
- Updated LoadingFrame PR
- Tophatted billy PR
- Submitted PR for Banners issue

To Do
- X Set meeting about Email + Spin with Alexander Lam
- X Wrap up open PRs
- X Update Oliver from H5P
- X Notes for marketing automation

**Monday, April 5th**
Done
- Upgrade to Big Sur
- Setting up store, email, marketing app

To Do
- X Submit PR for updated pricing banners
- X Pair with Juwan on removing published automation toast on dismiss
- X Update LoadingFrame PR
- X Tophat rename automation PR

**Tuesday, April 6th**
Done
- Merged welcome email changes
- Merged automation banners checks

To Do
- Exploring flow and spin
- Meetings

**Wednesday, April 7th**
Done
- Pair with Benny Zhao on Editor Loading State PR and ReadOnlyRenderer fixes
- Asked for more review on Editor Loading State PR

To Do
- Pair with Billy on ReadOnlyRenderer changes
- Get scope from Alex Lam
- Progress
- Overview of technical implementation
- Spin people to meet with
- Timeline?

## Spin + Email

Timeline: 2 weeks part-time work

**Thursday, April 8th**
Done
- Merged Loading State PR

To Do
- Meet with Benny Zhao about email modes + discount button changes
- Setup meeting with Olga
- Pair with Eric

**Friday, April 9th**
Done
- Tophatting session
- Set meeting with Olga
- Created class for logging and statsD stuff

To Do
- Create branch for Spin integration on email
- Go over logging service class with Eric
- Outline for co-op report?
- 1:1 with Billy
- Write tests for flow api service

## TODO NEXT WEEK

List questions for Olga
- How do you persist shop data on spin? Do I have to add the same products every time I spin up a new instance for development?

- How do I get notified when a branch on an instance doesn’t compile?
U get logs i guess

- Is the purpose of spin more to optimize for speed or to prevent dev up/compile issues?

- How long will an instance keep existing without any interaction?

One trade-off is convenience versus speed; to have the convenience of debugging and developing locally you have to trade off the speed of using an optimized instance to run your code

* Continue Marketing Overview Quick actions fix
* Get advice on testing flow service class from Reem
* Ask Felipe about discount button styling stuff

**April 13th, 2021**
Done
- Addressing quick actions PR comments
- Started tests for quick actions hook thing

To Do
- Start writing tests X
- Tophat Juwan + Billy Prs
- Pair w Reem on service wrapper thing X
- Pair with Billy on better hook testing method X

**April 14th, 2021**
Done

To Do
- submit quick actions PR

**April 21, 2021**

To Do
- Fix banner pr tests + add tests
- Add tests to automation delete refetch pr X
- look into flow service logs parsing potentially X
- Maybe use the debugger?

Create tickets for creat automation page
Resolve banner PR

**April 27th, 2021**

To Do
- Sync w reem on templates endpoint

**April 29th, 2021 - (Second last day!)**

To Do:
- Refer Neel Sharma?
- Refer Brandon Toy?
- Make groupchat for intern squad

- Loading state for AutomationTemplates page
- Custom component for third party automations card?
-