---
# System prepended metadata

title: Veloren Aug 15th 2021 MR overview (by Imbris)

---

# Veloren Aug 15th 2021 MR overview (by Imbris)
Here is a survey of the current MRs and notes based on what I currently know about their status.

## Review of all MRs and their current status
### Open
* https://gitlab.com/veloren/veloren/-/merge_requests/2708 Modular weapons
    * Work being done
* https://gitlab.com/veloren/veloren/-/merge_requests/2729 Add choosing how many pieces can be crafted simultaneously and require free space to able to craft
    * Work being done
* https://gitlab.com/veloren/veloren/-/merge_requests/2756 Split up iteration of rtsim entities each tick
    * Ongoing review, discussion, and changes with zesterer, xMAC94x, and ubruntu
* https://gitlab.com/veloren/veloren/-/merge_requests/2761 Split 'path_toward_target' function into 'path_toward_target_separate' and...
    * Needs review to determine if we want this
* https://gitlab.com/veloren/veloren/-/merge_requests/2754 Seperation of targets vs interactables. Cleaner cursor interactions.
    * Needs review from imbris
* https://gitlab.com/veloren/veloren/-/merge_requests/2701 add smaller variant of the code of conduct and include feedback
    * Undergoing discussion and changes
* https://gitlab.com/veloren/veloren/-/merge_requests/2757  alxly/update-ru_RU: add ru_RU missed translations
    * A few threads open but many are resolved, not sure what the current state is
* https://gitlab.com/veloren/veloren/-/merge_requests/2537 Added veloren-publish tags and veloren-build tags to CI configuration
    * Discussion with xMAC94x and xvar
* https://gitlab.com/veloren/veloren/-/merge_requests/2080 use reqwest in authc and enable trust_dns
    * Waiting for auth MR https://gitlab.com/veloren/auth/-/merge_requests/24 (and then needs review)
* https://gitlab.com/veloren/veloren/-/merge_requests/1735 Improve CI run time + workflow
    * Blocked on incremental issues
* https://gitlab.com/veloren/veloren/-/merge_requests/2712 Extract functions from buffs update
    * Needs review/discussion/changes 
* https://gitlab.com/veloren/veloren/-/merge_requests/2739 new-sfx-01
    * Blocked on developing strategy for attributing assets for assets licences that require attribution (ofc would also be nice to be able to attribute assets to artists in general).
* https://gitlab.com/veloren/veloren/-/merge_requests/2749 Replace shaderc with naga
    * Concerns about useability when developing shaders (e.g. error message quality, potentially running into unsupported cases)
    * Other thoughts might have been mentioned in #rendering....
* https://gitlab.com/veloren/veloren/-/merge_requests/2570 Swrup/fix melee attack through wall
    * Has comments for the author to address and then may need final review
* https://gitlab.com/veloren/veloren/-/merge_requests/2725 Improve plugin system
    * Needs zesterer to review (gone for a few weeks atm)
* https://gitlab.com/veloren/veloren/-/merge_requests/2489 Added concurrent execution of plugins
    * > still being worked on
    * maybe needs more discussion/changes?


### Open - marked as draft

* https://gitlab.com/veloren/veloren/-/merge_requests/2547 Draft: Econsim rework (new Goods: Ores, Coal, Armor(Kind))
    * Work in progress, recent activity
* https://gitlab.com/veloren/veloren/-/merge_requests/2763 Draft: Caverns
    * Work in progress. Last update 3 weeks ago.
* https://gitlab.com/veloren/veloren/-/merge_requests/2695 Draft: Spots
    * Work in progress. Last update 1 week ago.
* https://gitlab.com/veloren/veloren/-/merge_requests/2425 Draft: Plugin API Improvements
    * still being worked on, also has a few open comments. Last update 1 month ago.
* https://gitlab.com/veloren/veloren/-/merge_requests/2439 Draft: Add a more precise `in_swept_circle` to `SpatialGrid`, and use it in entity-entity broadphase.
    * > This solution doesn’t work for all lines, just north/south.
* https://gitlab.com/veloren/veloren/-/merge_requests/2226 Draft: Sync entities for group members regardless of distance.
    * Needs to deal carefully with syncing invariants or sync this data separately from regular syncing

### Recently closed as stale but may still be relevant
* https://gitlab.com/veloren/veloren/-/merge_requests/2610 Draft: Init server-api
    * Work in progress but looks like they may be looking for feedback on a few things
* https://gitlab.com/veloren/veloren/-/merge_requests/2601 Resolve all '#[allow(clippy::float_cmp)]' error supressions
    * comments to address
* https://gitlab.com/veloren/veloren/-/merge_requests/2615 Resolve all '#[allow(clippy::needless_update)]' error supressions
    * TODO comments should be replaced with a note (see MR comments)
* https://gitlab.com/veloren/veloren/-/merge_requests/2549 Change ordered_recipes to sort into 3 groups, (Craftable, Craftable missing station, Unable to craft) 
    * Needs UX/UI disccsion, I believe there were some alternative ideas that were more favored
* https://gitlab.com/veloren/veloren/-/merge_requests/2381 Draft: Gliding improvements
    * Work still in progress afaik
* https://gitlab.com/veloren/veloren/-/merge_requests/2314 Resolve "Toggle cursor automatically when chat is active"
    * There are some fundametental issues with determining when to grab/ungrab the cursor that we need to work out (see comments)
* https://gitlab.com/veloren/veloren/-/merge_requests/2306 Sprite manifest refactoring (precursor to farming).
    * Needs comments addressed and/or additional work
    * Somewhat stale wrt to work being done on it
* https://gitlab.com/veloren/veloren/-/merge_requests/2254 Draft: Farming
    * Blocked on sprite manifest MR (2306)?
* https://gitlab.com/veloren/veloren/-/merge_requests/2065 [WIP] Map indicators work
    * Potentially useful refactor but needs review and rebase
* https://gitlab.com/veloren/veloren/-/merge_requests/2043 WIP: Animation Events and Outcomes
    * Somewhat stale (3 months) but looks like something that was wanted


## 5 MRs highlighted for discussion
1. https://gitlab.com/veloren/veloren/-/merge_requests/2739
2. https://gitlab.com/veloren/veloren/-/merge_requests/2761
3. https://gitlab.com/veloren/book/-/merge_requests/114
4. https://gitlab.com/veloren/book/-/merge_requests/95
5. https://gitlab.com/veloren/auth/-/merge_requests/24
6. https://gitlab.com/veloren/site/-/merge_requests/206 Approved but needs rebase
