# 2022-06-12 Weekly Meeting

###### tags: `weekly-meeting`

### Topics:

#### Issues

- https://gitlab.com/veloren/veloren/-/issues/1574 YuriMomo wanted to discuss.
- (@aweinstock) for 1574, it seems unexpected that gear swaps count as pickups for the display on the left, does it display any inventory change, not specifically pickup/collect events?
- (@aweinstock) and for the second part of 1574 (which seems like a distinct issue), 1) is the counterparty inventory window showing loadout slots or inventory slots 2) how are you exiting to character select during trade? exiting to character select should cancel existing trades, and the client UI also prevents bringing up the escape menu during a trade if the client is unmodified
- https://gitlab.com/veloren/veloren/-/issues/360 Could add info to this on what has been done so far, and things that could possibly be improved
- Will be brainstormed below
- https://gitlab.com/veloren/veloren/-/issues/1300 Feels like we should have a discussion about this due to recent issues on the server.
- Have a no-colour zone within a certain range of a town
- Can be done with safezone?
- Have blocks return to their original colour in a certain amount of time, would be shorter in towns
- Downsides
- Don't see environmental damage for as long
- Would take a lot of chunk storage
- Wouldn't work if the reset time was greater than ~10 seconds
- Grass/wildfire system spreads over time to either grow the patch back or just make the problem larger
- Story-driven approach
- Some guard kills you for using fireballs in town
- https://gitlab.com/veloren/veloren/-/issues/933 More info could be added

### Brainstorming Improve onboarding of new contributors (!360)

- Pipeline of how people get started
- Find out about the game
- Find a link to the Discord
- From Github/Gitlab/site
- Need to message in #new-contributors
- Need to ask for Gitlab perms
- Need to find a task to work on
- *Work on the task*
- Need to know how to create an MR
- MR template should be bigger than it is
- Need to know who to ping
- Need to fix changes
- Need to ask for merge

- Methods of instruction
- Ideally the book
- There still isn't a simple list of steps there
- It kind of just has everything instead of an intro
- More verbose MR template
- Asking someone in Discord
- Would be better if we could add some kind of FAQ to the bot
- Would be nice if we could add someone's Gitlab account automatically with the bot

- Current problems
- Hard to know who code owners are
- Hard to get reviewers other than core devs (pinged with the role)
- Not a ton of references to the architecture of the game
- You need to ask for lots of context for domain-specific things

- Ideas
- Monthly FAQ for contributors
- Monthly "Town Hall"
- Big part focuses on onboarding new developers
- Live streaming coding
- Systems documentation
- Would be great to have an owner take this on
- Doesn't need to be perfect, will be reviewed
- Defining some type of "mentorship" program
- For core devs, this would mean having a thread open that they'd be willing to get pinged in
- For new contributors this means
- A first MR
- Easy place to get questions answered (outside of #questions)
- A mentorship program with defined bounds
- "Like GSoc but we accepted ourselves:tm:"

### Code reading club

## Next week leads

Lead: xmac
Call for Review!: aweinstock
Issues (limit 7): holychowders
Minutes: angel (if available)

### Todo agenda: