---
# System prepended metadata

title: T-style triage meeting 2024-06-05
tags: [triage-meeting, minutes, T-style]

---

---
title: T-style triage meeting 2024-06-05
tags: ["T-style", "triage-meeting", "minutes"]
date: 2024-06-05
discussion: https://rust-lang.zulipchat.com/#narrow/stream/346005-t-style/topic/meeting.202024-06-05
url: https://hackmd.io/XgsxF_HZRHGObXw28Jzqsw
---

# T-style meeting agenda

- Meeting date: 2024-06-05

## Attendance

- People: TC, Caleb, Josh

## Meeting roles

- Facilitator: TC
- Minutes: TC

## Check-in

(Not minuted.)

## Scheduled design meetings

None.

Update these [here](https://github.com/orgs/rust-lang/projects/38/views/1).

## Proposed design meetings

None.

Update these [here](https://github.com/orgs/rust-lang/projects/38/views/1).

## Announcements or custom items

(Meeting attendees, feel free to add items here!)

## Nominated RFCs, PRs, and issues

### "Tracking Issue for Rust 2024: rustfmt enable `overflow_delimited_expr`" rust#123751

**Link:** https://github.com/rust-lang/rust/issues/123751

We verified this has been merged in the style guide.  We've checked that box and verified the others are correct.  This still needs to be implemented in terms of flipping the flag.

### "Tracking Issue for RFC 3325: unsafe attributes" rust#123757

**Link:** https://github.com/rust-lang/rust/issues/123757

Josh: Example would be: `#[unsafe(no_mangle)]`.

Questions:
- Where should line breaks go?
- Should `unsafe` go inside or outside `cfg_attr`, and is that something style should specify?

```rust
#[unsafe(very_long_attribute(with, many, parameters))]

// Would we break this as...

#[unsafe(very_long_attribute(
    with,
    many,
    parameters,
))]
```

Caleb: I don't see why we'd give this any special treatment.

TC: We'll unnominate and mark the relevant checkbox as N/A.

### "Tracking Issue for Rust 2024: rustfmt style editions" rust#123799

**Link:** https://github.com/rust-lang/rust/issues/123799

We still need to merge this.  This would be a good place to discuss, e.g., what people with CIs who are running `rustfmt --check` will need to do, and it might be good to discuss a summary of the rustfmt stability policy.

### "Tracking Issue for Rust 2024: rustfmt use version sort" rust#123800

**Link:** https://github.com/rust-lang/rust/issues/123800

This one is correct in terms of checkboxes and labels.

Actually, the implementation might be done, but we need to confirm, and then we'll update if necessary.

### "Tracking Issue for Rust 2024: rustfmt change sort to Unicode-aware "non-lowercase before lowercase"" rust#123802

**Link:** https://github.com/rust-lang/rust/issues/123802

This one is correct in terms of checkboxes and labels.

### "Tracking Issue for Rust 2024: rustfmt improve impl generics indentation " rust#124758

**Link:** https://github.com/rust-lang/rust/issues/124758

The implementation is believed done.  We'll check and update the tracking issue with the details.

### "Tracking Issue for Rust 2024: rustfmt trailing comment alignment" rust#124760

**Link:** https://github.com/rust-lang/rust/issues/124760

The implementation is believed done.  We'll check and update the tracking issue with the details.

### "Tracking Issue for Rust 2024: rustfmt raw identifier sorting" rust#124764

**Link:** https://github.com/rust-lang/rust/issues/124764

The implementation is believed done.  We'll check and update the tracking issue with the details.

### "Tracking Issue for Rust 2024: rustfmt closure body braces" rust#124767

**Link:** https://github.com/rust-lang/rust/issues/124767

The implementation is believed done.  We'll check and update the tracking issue with the details.

### "`edition.md` is causing many conflicts" style-team#192

**Link:** https://github.com/rust-lang/style-team/issues/192

Josh: I started the `edition.md` would help with the edition migration documentation.  However, what I'm finding is that adding the bullet point line invariably creates conflicts.

Caleb: We could use separate files here.

TC: We could take it out of the style guide and link to the edition guide.

## Edition misc

To see examples of other edition tracking issues, see, e.g.:

<https://github.com/rust-lang/rust/issues?q=label%3AC-tracking-issue+label%3AA-edition-2024%2CA-edition-2027+-label%3AS-tracking-ready-to-stabilize+-label%3AT-style>

Schedule:

| Date       | Version       | Edition stage           |
|------------|---------------|-------------------------|
| 2024-06-13 | Release v1.79 | Checking off items..... |
| 2024-07-25 | Release v1.80 | Checking off items..... |
| 2024-09-05 | Release v1.81 | Checking off items..... |
| 2024-10-11 | Branch  v1.83 | Go / no go on all items |
| 2024-10-17 | Release v1.82 | Rust 2024 nightly beta  |
| 2025-01-03 | Branch  v1.85 | Cut Rust 2024 to beta   |
| 2025-02-20 | Release v1.85 | Release Rust 2024       |

## Pending PRs on the style-team repo

None.

## RFCs waiting to be merged

None.

## `S-waiting-on-team`

None.

## Proposed FCPs

**Check your boxes!**

### "style-guide: Note that we don't account for comments in every possible place" rust#121762

**Link:** https://github.com/rust-lang/rust/pull/121762

## Active FCPs

None.

## P-critical issues

None.

## Check-out

(Not minuted.)
