# Rats - Archive Dec 10 2022 - Jan 27 ## Jan 27th (Fri) **Boris** - current: - Community permissions: - Fix and update protobuf, persistence and so on after testing **r4bbit** - done - Investigated bug that, for some reason, discord messages wouldn't be rendered properly - Turns out the bug was introduced here - https://github.com/status-im/status-desktop/commit/0fb954b640f7645e9e9947bacc9340b5285a6b1d - And the commit has already been reverted but pending - https://github.com/status-im/status-desktop/pull/9294 - current - See if I can apply some changes to speed up bootstrap time as investigated in - https://github.com/status-im/status-desktop/issues/9193 **mprakhov** - review: - [chat_getMembers should be cached to not hit the DB each time we add a member #8901](https://github.com/status-im/status-desktop/issues/8901). Reviewed, require QA verification - current: - [App hangs when closing on Windows after downloading an image #8868](https://github.com/status-im/status-desktop/issues/8868). Was unable to reproduce the issue, found another hang in waku if application was started and closed with disabled internet connection - [Enforce Alphanumerical characters in community items #9180](https://github.com/status-im/status-desktop/issues/9180). Prepared the fix, during dev testing found weird behavior with filters (error msg is not dissapearing), looking for a fix and will be on a review **Igor** - in review: - [#9930](https://github.com/status-im/status-desktop/pull/9330) fix: Fixed tokens initialization. Fixed SendModal for ENS. - [#9036](https://github.com/status-im/status-desktop/pull/9036) ENS usernames depends on the network \ Rebase and fix conflicts, check everything works - current: - [#9235](https://github.com/status-im/status-desktop/issues/9235) Only keep last 5 channels in memory **MishkaRogachev** - done: - hotfix for building status-go on m1 - in review: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/pull/9226) - Nervous waiting for the green CI - current: - [Create new test configuration flag](https://github.com/status-im/status-desktop/issues/9210) - On Monday **Michal** - done: - #9233 Save deployed collectibles information in database - added database for tokens and API - next: - #9233 Save deployed collectibles information in database - keep smart contract address in community description **rramos.eth** - done: - status-im/status-go#3140 fix: add cursors to store queries - waku-org/go-waku#430 fix: add sleep to iterator in case of err - current: - Investigating status-im/status-desktop#9339 App is not closing if launch, login and close the application - waku-org/go-waku#431 fix: adding circuit relay information to enr - Added more experimental code, waiting for feedback from Vac team ## Jan 26 (Thu) **Boris** - current: - Community permissions: - Update db structure - Fix code in proccessing community changes with permissions **MishkaRogachev** - in review: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/pull/9226) - Review & tests fixes - current: - [Create new test configuration flag](https://github.com/status-im/status-desktop/issues/9210) - paused because of AC notifications status-go fixes **r4bbit** - done - Finished implementing refactor of import tool to work with data chunks - PR https://github.com/status-im/status-go/pull/3134 - Desktop PR https://github.com/status-im/status-desktop/pull/9309 **mprakhov** - review: - [chat_getMembers should be cached to not hit the DB each time we add a member #8901](https://github.com/status-im/status-desktop/issues/8901). QA testing needed - current: - [App hangs when closing on Windows after downloading an image #8868](https://github.com/status-im/status-desktop/issues/8868). Configured Windows dev enviroment **Michal** - current: - [#9233](https://github.com/status-im/status-desktop/pull/9233) Save deployed collectibles information in database - continue with task **rramos.eth** - done: - status-im/status-go#3135 feat: send message type to opt-in telemetry service. PR in status-desktop to bump status-go version - waku-org/go-waku#429 fix: only lock keepAlive mutex when necessary. PRs in status-go and status-desktop to bump version - status-im/status-go#3137 fix(waku2): use parent ctx (of 30s instead of 20s) and log requestID in case of failures when doing store queries. PR in status-desktop to bump status-go version - status-im/telemetry#9 feat: add migrations and messageType column ## Jan 25 (Wed) **Boris** - current: - Community permissions: - Fix and update code in status-go after testing **MishkaRogachev** - in review: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/pull/9226) - Added visualisation for read flag - New commits [here](https://github.com/status-im/status-go/pull/3126) - [Figuring](https://github.com/status-im/status-go/pull/3126#discussion_r1086952865) out notification flags - current: - [Create new test configuration flag](https://github.com/status-im/status-desktop/issues/9210) - paused because of AC notifications status-go fixes **Michal** - sickness yesterday - done: - reviews - [#8921](https://github.com/status-im/status-desktop/pull/8921) Nim backend for minting tokens functionality - changing supply from string to int - current: - [#9233](https://github.com/status-im/status-desktop/pull/9233) Save deployed collectibles information in database **mprakhov** - done: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090) - current: - [chat_getMembers should be cached to not hit the DB each time we add a member #8901](https://github.com/status-im/status-desktop/issues/8901). Refactored the code, added additional signals to notify about members amount changes, got rid from unnesessary `chat_getMembers` call. Dev testing **rramos.eth** - done: - waku-org/go-waku#428 refactor(c-bindings): do not subscribe automatically to default waku topic - status-im/status-go#3132 fix: add missing waku2 store columns to node config query - rebased: - status-im/status-desktop#6875 feat: add custom waku2 nodes - status-im/status-desktop#6780 feat: waku2 store **r4bbit** - done - Continued working on making the discord import tool working on chunks - Implemented front-end changes - Implemented backend - Testing ## Jan 24 (Tue) **Boris** - Working on permissions in community **MishkaRogachev** - paused: - [Replace MailserverConnectionDialog with banner](https://github.com/status-im/status-desktop/pull/9172) - waiting [this](https://github.com/status-im/status-desktop/issues/9210) - in review: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/pull/9226) - Syncing read status and counting - status-go changes [needed](https://github.com/status-im/status-go/pull/3126) - current: - [Create new test configuration flag](https://github.com/status-im/status-desktop/issues/9210) **r4bbit** - done - Investigated race condition when handling magnetlink links - Fix: https://github.com/status-im/status-go/pull/3123 - Add validation that discord import files aren't bigger than 50 MB - Issue: https://github.com/status-im/status-desktop/issues/9261 - PR: https://github.com/status-im/status-go/pull/3125 - current - Make discor dimport tool work with chunks - https://github.com/status-im/status-desktop/issues/9262 **Igor** - done: - Looking for a bug in [#9036](https://github.com/status-im/status-desktop/pull/9036), found and reported [#9264](https://github.com/status-im/status-desktop/issues/9264) - current: - [#7858](https://github.com/status-im/status-desktop/issues/7858) Previously used pic and ENS shown to contacts after account restore when neither are set - [#7733](https://github.com/status-im/status-desktop/issues/7733) Community -> Recovered account: community that user has left, is recovered in new installation **mprakhov** - review: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Was fixed found crash - current: - [chat_getMembers should be cached to not hit the DB each time we add a member #8901](https://github.com/status-im/status-desktop/issues/8901) **Jo** - done: - meetings - added some more tests back to the community instead of public chat - current: - fixing issues found on the flatten chat model PR **rramos.eth** - done: - status-im/status-go#3127 fix: don't return an error on empty rows - status-im/status-desktop#9278 chore: remove bloom filter usage - status-im/status-desktop#9270 fix: cancel mailserver requests on shutdown and execute status-go logout() on logout - status-im/status-go#3129 fix: cancel mailserver requests when stopping messenger - issues opened: - status-im/status-desktop#9276 shutdown desktop gracefully - status-im/status-desktop#1506 feat request: add store query request duration metric ## Jan 23 (Mon) **MishkaRogachev** - in review: - [Replace MailserverConnectionDialog with banner](https://github.com/status-im/status-desktop/pull/9172) - waiting for decision with tests. Probably need go for [this](https://github.com/status-im/status-desktop/issues/9210) - current: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/pull/9226) - Switched to status-go impl, and yes, it's not working as expected :) - Fixing read status for notifications with CTA **Michal** - done: - reviews - #8921 #3051 - preparing pull requests for collectibles phase1 - current: - [#9233](https://github.com/status-im/status-desktop/pull/9233) Save deployed collectibles information in database **Igor** - done: - [#9231](https://github.com/status-im/status-desktop/pull/9231) fix(Makefile): Fixed ANSI coloring - Fixed review bug in [#9036](https://github.com/status-im/status-desktop/pull/9036) - Attempts to debug status-desktop app - current: - [#7859](https://github.com/status-im/status-desktop/issues/7859) Device sync: second instance of the same account recovered requires a back up of the seed **mprakhov** - review: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090) - current: - [chat_getMembers should be cached to not hit the DB each time we add a member #8901](https://github.com/status-im/status-desktop/issues/8901) **Jo** - done: - created a couple new issues for performance - meetings - finished removing the public chats - moved a couple of the public chat tests to community - current: - finish moving public chat tests to community **rramos.eth** - done: waku-org/waku-react-native - fix: timestamp to date, and building .aar - release 0.1.0 waku-org/go-waku - #426 fix: empty responses should not generate an error - release 0.4.0 status-im/status-go#3124 chore: increase mailserver timeout to 30s - current: - Populate ENR with circuit-relay multiaddresses ## Jan 20 (Fri) **Boris** - `Permissions`: - Create new db table - Accessors to data - General API to create, edit, read and delete permissions Next step is provide changes to network and add API to `nim`. **MishkaRogachev** - in review: - [Replace MailserverConnectionDialog with banner](https://github.com/status-im/status-desktop/pull/9172) - tests... - current: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/issues/8074) - Discussing with mobile team, moving to a new endpoint for counting **Michal** - current: - #8921 #3051 - preparing minting collectibles pr with phase1 - deployment ERC721 smart contract with parameters from UI - next: - testing smart contract functions with Andrea - token transfers and minting - Save deployed collectibles information in status-go database. **mprakhov** - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Mostly done, need to do dev-testing before moving to PR - code reviews **Igor** - done: - [#8970](https://github.com/status-im/status-desktop/issues/8970) Notifications: The double notification 'Community imported' - [status-go #3066](https://github.com/status-im/status-go/pull/3066) [#9036](https://github.com/status-im/status-desktop/pull/9036) ENS usernames depending on current network \ Addressing last comments, rebasing - current: - [#7859](https://github.com/status-im/status-desktop/issues/7859) Device sync: second instance of the same account recovered requires a back up of the seed **r4bbit** - done - Updated and merged PRs related to archive protocol improvements - Don't make people's app crash when processing archives - https://github.com/status-im/status-go/pull/3086 - Archive import resumability - https://github.com/status-im/status-go/pull/3111 - Archive generation size max cap - https://github.com/status-im/status-go/pull/3095 - current - Desktop startup perf analysis - https://github.com/status-im/status-desktop/issues/9193 **rramos.eth** - current - Discuss with @helium protocol improvements for Waku messaging - Populate ENR with circuit-relay multiaddresses - current ## Jan 19 (Thu) **MishkaRogachev** - in review: - [Replace MailserverConnectionDialog with banner](https://github.com/status-im/status-desktop/pull/9172) - choosing warning color - current: - [Move AC notifications counting to status-go](https://github.com/status-im/status-desktop/issues/8074) - Read notification discussion **mprakhov** - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Continue working on the improvement - **Michal** - current: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - replacing testing smart contract with original ERC721 **Jo** - done: - fixed the delete category bug in my PR plus code reviews - cherry picked and tested RC3 - current: - meetings and planning **rramos.eth** - current: - Discuss with @helium protocol improvements for Waku messaging - Populate ENR with circuit-relay multiaddresses - Fix heuristics for choosing the most external address in go-waku ## Jan 18 (Wed) **MishkaRogachev** - done: - Tiny [fix](https://github.com/status-im/status-desktop/pull/9154) for [Can not connect to mailserver error](https://github.com/status-im/status-desktop/issues/9131) - Minor [hotfix](https://github.com/status-im/status-desktop/pull/9173) for AC notifications - in review: - [Replace MailserverConnectionDialog with banner](https://github.com/status-im/status-desktop/pull/9172) - next - Need more issues or i can start [this](https://github.com/status-im/status-desktop/issues/8074) **mprakhov** - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Started working on the implemetation part **Michal** - done: - meetings - [#8921](https://github.com/status-im/status-desktop/issues/8921) - Nim backend for minting tokens functionality - trying to investigate transaction signalization problem - cooperation with Anthony **rramos.eth** - done: - Pair with @roman to determine why discv5 was not finding peers on mobile after being offline for minutes - status-im/status-go#3105 fix: dropping peer in mailserver cycle - status-im/status-go#3109 fix: only evaluate connected peers in mailserver cycle when active mailserver is set - #3108 fix: no messages from storenode - current: - squish+storenode: - Working with @Noelia to determine why squish reports some test cases as failed while running the same scenario manually is succesful - status-im/status-go#3106 chore: create "none" fleet for tests - status-im/status-desktop#9177 test: storenode ci - Discuss with @helium protocol improvements for Waku messaging ## Jan 17 (Tue) **Boris** - Working on permissions in status-go part **Patryk** - done: - found and fixed edge case of [Chat: Messages are not being grouped by received date](https://github.com/status-im/status-desktop/pull/9146#issuecomment-1385274140) - current: - [enable featured communities with wakuconnect](https://github.com/status-im/status-desktop/issues/7534) - next: - one week off **MishkaRogachev** - done: - [Fixed](https://github.com/status-im/status-desktop/pull/9080) ContactVerificationRequestPopup for [#8950](https://github.com/status-im/status-desktop/issues/8950) and [#9002](https://github.com/status-im/status-desktop/issues/9002) - Reported a few bugs - in review: - Tiny [fix](https://github.com/status-im/status-desktop/pull/9154) for [Can not connect to mailserver error](https://github.com/status-im/status-desktop/issues/9131) - current: - [Move mailserver disconnect notification to app's banner line](https://github.com/status-im/status-desktop/issues/6213) **Michal** - done: - meeting with Andrea - [#8921](https://github.com/status-im/status-desktop/issues/8921) - Nim backend for minting tokens functionality - continue - signalization about minting - next: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - replace testing smart contract with original ERC721 **Igor** - done: - ENS L2 meeting (prior reading articles and diving into the topic) - current: - [#8970](https://github.com/status-im/status-desktop/issues/8970) Notifications: The double notification 'Community imported' **Jo** - done: - removed contact request count in chat badge - current: - Fix issue where quoted message doesn't update when it gets fetched - Refactoring the chat list to use a single model instead of model and submodel **r4bbit** - done - Landed pending PRs (finally) - https://github.com/status-im/status-go/pull/3085 - https://github.com/status-im/status-desktop/pull/9111 - https://github.com/status-im/status-desktop/pull/9064 - https://github.com/status-im/status-desktop/pull/8954 - Make backup seed modal scrollbar always visible - https://github.com/status-im/status-desktop/pull/9153 - current - Testing memory pressure improvements for archive protocol - https://github.com/status-im/status-go/pull/3086 - **Seems to work great!** **mprakhov** - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Reviewed the code for potential changes and solutions. Proposed 2 solutions - wrote out new found bugs - code review **rramos.eth** - done: - Pair with @roman to determine why discv5 was not finding peers on mobile after being offline for minutes - Fix issues found in status-im/status-go#3092 (restart discv5) that were related to locked goroutines - Discuss with @LNSD why storing raw protobuffers in the DB is required to guarantee WakuMessages are not modified ## Jan 16 (Mon) **Boris** - Checking and researching information about community permissions **MishkaRogachev** - done: - Tested [AC status-go changes](https://github.com/status-im/status-go/pull/3088#pullrequestreview-1249758038) with desktop master - in review: - [Fixed](https://github.com/status-im/status-desktop/pull/9080) ContactVerificationRequestPopup for [#8950](https://github.com/status-im/status-desktop/issues/8950) and [#9002](https://github.com/status-im/status-desktop/issues/9002) - qa - current: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) **Patryk** - reviewed PRs - updated translations: https://github.com/status-im/status-desktop/pull/9134 - proposed dependencies solution: https://github.com/status-im/status-desktop/issues/9125#issuecomment-1384246830 - reported https://github.com/status-im/status-desktop/issues/9144 - reopened, investigated and fixed [Chat: Messages are not being grouped by received date](https://github.com/status-im/status-desktop/issues/8962) **r4bbit** - Reviewed and updated PRs - Still couldn't land any due to e2e tests acting up - Implemented max cap for archive size, ensuring sum of messages payload+sig doesn't exceed certain threshold - https://github.com/status-im/status-go/pull/3095 - Looking into testing memory improvements of archive protocol tomorrow with Iuri **mprakhov** - done: - [[automation]: edit community test sometimes fails #8977](https://github.com/status-im/status-desktop/issues/8977) - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090). Collecting the information for potential changes **Michal** - current: - part time today - visiting doctor - [#8921](https://github.com/status-im/status-desktop/issues/8921) - Nim backend for minting tokens functionality - continue - signalization about minting, improvements in workflow **rramos.eth** - done: status-im/status-go#3092 waku2 - restart discv5 when peers are low and use newer go-waku code to deal with discovery - current: go-waku: adding circuit relay information to multiaddr **Jo** - done: - fixed issue with release build time out - new RC :tada: - current: - Refactoring the chat list to use a single model instead of model and submodel - categories now work - need to re-hook the edit and delete signals ## Jan 13 (Fri) **MishkaRogachev** - in review: - [Fixed](https://github.com/status-im/status-desktop/pull/9080) ContactVerificationRequestPopup for [#8950](https://github.com/status-im/status-desktop/issues/8950) and [9002](https://github.com/status-im/status-desktop/issues/9002) - still here, having problem with MessageView's implicit height - current: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) **Patryk** - implemented [bulk insertion algorithm](https://github.com/status-im/status-desktop/pull/9104) - reviewed PRs - created [Can't connect to store node until app restart](https://github.com/status-im/status-desktop/issues/9114) **r4bbit** - Rebased pending PRs - Fixed a bug in latest `QuotedMessage` changes to make message replies reliable, where imported messages don't have author data - https://github.com/status-im/status-go/pull/3085 - https://github.com/status-im/status-desktop/pull/9111 - Implemented better memory efficient handling of history archives - https://github.com/status-im/status-go/pull/3086 **mprakhov** - review: - [[automation]: edit community test sometimes fails #8977](https://github.com/status-im/status-desktop/issues/8977) - current: - [Refactor Members list to only have one list per community #9090](https://github.com/status-im/status-desktop/issues/9090) **Michal** - done: - [#6567](https://github.com/status-im/status-desktop/issues/6567) Tolerate better network disconnects - stickers - sync, resolve conflicts, testing, merging - current: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - continue - changing input&output deployment function parameters - [#8921](https://github.com/status-im/status-desktop/issues/8921) - Nim backend for minting tokens functionality - continue - signalization about minting, gas estimation **Igor** - current: - [#8034](https://github.com/status-im/status-desktop/issues/8034) Create new test case `tst_communitiesNavigation` - next: - [#8970](https://github.com/status-im/status-desktop/issues/8970) Notifications: The double notification 'Community imported' appeared **Jo** - done: - meetings - current: - Refactoring the chat list to use a single model instead of model and submodel for categories **rramos.eth** - done: - waku-org/go-waku#424 refactor: peer discovery management for discv5 and peer exchange - waku-org/go-waku#423 fix: obtain multiple multiaddresses from single enode - waku-org/go-waku#422 feat: add p2p-circuit to enr to indicate it uses circuit relay - status-im/status-go#3090 fix: decode peerID string into peer.ID - Investigated and opened the following issues: - waku-org/nwaku#1491 To investigate: adding circuit relay information to multiaddr - waku-org/nwaku#1492 bug: MULTIADDR_ENR_FIELD is not read when extracting dialable peer info from enr record - waku-org/nwaku#1493 to investigate: discv5 and private IPs ## Jan 12 (Thu) **Patryk** - analyzed and elaborated on [Optimise messages model operations](https://github.com/status-im/status-desktop/issues/9068#issuecomment-1379987041) - implemented [Messages fetched from store nodes shouldn't be loaded on the ui](https://github.com/status-im/status-desktop/issues/8907) **r4bbit** - Loked into bug that removing pasted images into chat input causes error message - https://github.com/status-im/status-desktop/issues/8644 - Revisiting making community chat categories bold if any of their chats have unread messages - https://github.com/status-im/status-desktop/pull/9064 - Fixed bug that chat input doesn't leave reply mode after sending a gif reply - https://github.com/status-im/status-desktop/pull/9078 - Looking implementing memory improvements for archive protocol as discussed with cammellos **MishkaRogachev** - current: - [Fixing](https://github.com/status-im/status-desktop/pull/9080) ContactVerificationRequestPopup for [#8950](https://github.com/status-im/status-desktop/issues/8950) and [9002](https://github.com/status-im/status-desktop/issues/9002) - still here, having problem with MessageView's implicit height - next: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) **mprakhov** - done: - [Chat: can't send a standalone picture as a message, a corresponding text is required #8999](https://github.com/status-im/status-desktop/issues/8999) - [Opened community categories/channel list UI is corrupted #8897](https://github.com/status-im/status-desktop/issues/8897). Prepared the MR, but it seems I late on 1 day and it was fixed before in other ticket - review: - [Chat: the incorrect GIF address doesn't look good #8560](https://github.com/status-im/status-desktop/issues/8560). Maybe will be moved to the box for better times - current: - [[automation]: edit community test sometimes fails #8977](https://github.com/status-im/status-desktop/issues/8977) ## Jan 11 (Wed) **Boris** - Fix new messages marker [PR #9062](https://github.com/status-im/status-desktop/pull/9062) - Review some prs - Working on bag with emoji in last message **Patryk** - fixed tests-nim: https://github.com/status-im/status-desktop/pull/9041 - reviewed massive [Improve chat scrolling performance #9031](https://github.com/status-im/status-desktop/pull/9031) in depth - reviewed various smaller PRs - closed: [Chat: Messages are not being grouped by received date](https://github.com/status-im/status-desktop/issues/8962) - couldn't reproduce on real data on latest master - most likely fixed by my previous changes related to ordering **Igor** - [#9058](https://github.com/status-im/status-desktop/issues/9066) [#8043](https://github.com/status-im/status-desktop/issues/8043) Fix showing message "Resend" button - [PR #9058](https://github.com/status-im/status-desktop/pull/9058) Show "Disconnected" banner on startup with no connection **mprakhov** - review: - [Chat: can't send a standalone picture as a message, a corresponding text is required #8999](https://github.com/status-im/status-desktop/issues/8999). Will be merged today, resolved all questions - done: - [Editing communities is broken when community tag list is empty #9024](https://github.com/status-im/status-desktop/issues/9024) - [Using the Start chat section, the message is not sent when creating a chat #8991](https://github.com/status-im/status-desktop/issues/8991) - current: - [Opened community categories/channel list UI is corrupted #8897](https://github.com/status-im/status-desktop/issues/8897). Found the problem, trying to get rid from binding loop **MishkaRogachev** - done: - [Update ActivityNotificationMessage's text maximum width](https://github.com/status-im/status-desktop/pull/9003) - current: - Fixing ContactVerificationRequestPopup for [#8950](https://github.com/status-im/status-desktop/issues/8950) and [9002](https://github.com/status-im/status-desktop/issues/9002) - Investigating logs - next: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) **Michal** - done: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - improving nim and status-go smart contarct services, adding authentication to the flow - next: - [#3051](https://github.com/status-im/status-go/issues/3051) - signalization about minting, gas estimation **rramos.eth** - done: - waku-org/go-waku#419 feat: load config from toml file - waku-org/go-waku#420 feat: update localnode ENR without having to restart discv5 - waku-org/zerokit#92 feat(rln-wasm): expose set_leaves_from and init_tree_with_leaves - status-im/status-go#3078 fix: split waku2 queries in 1d batches - Hunt for missing community join requests. With status-go#3073 I wasnt able to reproduce the issue anymore. Hope we finally got rid of this bug - current: - Looking at storenode functionality in status-desktop CI ## Jan 10 (Tue) **Boris** - *day off* **mprakhov** - review: - [Chat: can't send a standalone picture as a message, a corresponding text is required #8999](https://github.com/status-im/status-desktop/issues/8999). Need clarify localization question - [Using the Start chat section, the message is not sent when creating a chat #8991](https://github.com/status-im/status-desktop/issues/8991). Onboarding e2e test failing. Need to investigate what's the problem - current: - [Opened community categories/channel list UI is corrupted #8897](https://github.com/status-im/status-desktop/issues/8897) **r4bbit** - done - Had a call with cammellos discussing the memory issues of the archive protocol an how to overcome them - Highlight community category when underlying chats have unread messages: - https://github.com/status-im/status-desktop/pull/9064 **Patryk** - fixed: [Chat: Messages sent earlier have disappeared](https://github.com/status-im/status-desktop/issues/8965) - fixed: [Right click - quit app makes the app not responding](https://github.com/status-im/status-desktop/pull/9040) - current: investigating [https://github.com/status-im/status-desktop/issues/8962](https://github.com/status-im/status-desktop/issues/8962) **MishkaRogachev** - in review: - [Update ActivityNotificationMessage's text maximum width](https://github.com/status-im/status-desktop/pull/9003) - current: - [Contact Verification: the answer overlaps another text](https://github.com/status-im/status-desktop/issues/8950) - next: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) **Igor** - in review: - [status-go #3066](https://github.com/status-im/status-go/pull/3066) feat: Added ens_usernames database table - current: - [#3234 ENS usernames depend on the network](https://github.com/status-im/status-desktop/issues/3234) - Opening PR, making last checks **Michal** - current: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - adding Nim service for collectibles, deploying testing smart contract in Status application - next: - [#3051](https://github.com/status-im/status-go/issues/3051) - adding authentication, fee estimation, signalization about minting **rramos.eth** - done: - waku-org/go-waku#418 feat: use backedoff connector and discovery - waku-org/go-waku#417 fix: discv5 was not being registered as discovery mechanism - chore: Check that holepunching is working in go-waku - status-go: add even more logging to determine why the join requests are missing and simplify content topic extraction - Something interesting to note is that even tho a filter was registered for the content topic: `t=2023-01-10T08:21:57-0500 lvl=dbug msg="registering filter for" namespace=filtersManager chatID=04073514d4c14a7d10ae9fc9b0f05abc904d84166a6ac80add58bf6a3542a4e50aec09b4907f23da30e01af5b142b7e3f2ef48b83c757b0c8d4418a2b3407f9b41 type=public topic=0x6a4860f5` it still reports that there's no filter registered for that topic: `t=2023-01-10T08:49:50-0500 lvl=dbug msg="filters did not match" hash=0x36a08e7ce17c7510d285b9c6259645dee1a11ae5dccd1d79a11bf6fb32a72e4e contentTopic=/waku/1/0x6a4860f5/rfc26` - current: - waku-org/go-waku: load config from file ## Jan 09 (Mon) **Boris** - done: - Update and rebase old PR's - Review - [issue #8938](https://github.com/status-im/status-desktop/issues/8938) Not reproduced in current master **r4bbit** - done: - Caught up on PRs to review - Tested Backup profile PR from Sale - current: - Working on highlighting categories - https://github.com/status-im/status-desktop/issues/8604 **MishkaRogachev** - in review: - [Update ActivityNotificationMessage's text maximum width](https://github.com/status-im/status-desktop/pull/9003) - current: - Catching up after vacation - next: - [Activity Center: message that was read in chat, should be marked as read in activity center](https://github.com/status-im/status-desktop/issues/8820) - can i move into current iteration? - new bug: - [Text overlapping when verification request question is too long #9002](https://github.com/status-im/status-desktop/issues/9002) **mprakhov** - done: - [Message box buttons do not work in group chat creation screen #8730](https://github.com/status-im/status-desktop/issues/8730) - [Chat: Unable to paste images (macos) #8771](https://github.com/status-im/status-desktop/issues/8771). Was already fixed - [Receiving a mention in the channel you're in (but inactive section) doesn't show the badge #8940](https://github.com/status-im/status-desktop/issues/8940) - current: - [Chat: the incorrect GIF address doesn't look good #8560](https://github.com/status-im/status-desktop/issues/8560). Prepared the potntial ad-hoc fix (as discussed), but did not push it to the review, required proper testing and I see flickering. Temporary switched to more priority bugs in the list as this one is a low priority one - [Using the Start chat section, the message is not sent when creating a chat #8991](https://github.com/status-im/status-desktop/issues/8991) **Patryk** - done: - fixed: [Channel logo is shown in the middle of the chat](https://github.com/status-im/status-desktop/pull/9001) - extended nim unit tests - reviewed and tested/debugged locally: [fix(desktop/chat): show the badge during receiving the new messages in inactive section](https://github.com/status-im/status-desktop/pull/8984/) - reviewed various PRs - narrowed down reproduction criteria: [Chat: Messages sent earlier have disappeared](https://github.com/status-im/status-desktop/issues/8965) **Michal** - done: - reviews - current: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - continue **r4bbit** - OOO - sick leave ## Jan 06 (Fri) **mprakhov** - review: - [Receiving a mention in the channel you're in (but inactive section) doesn't show the badge #8940](https://github.com/status-im/status-desktop/issues/8940) - current: - [Chat: the incorrect GIF address doesn't look good #8560](https://github.com/status-im/status-desktop/issues/8560). Need to discuss the potential fix - [Message box buttons do not work in group chat creation screen #8730](https://github.com/status-im/status-desktop/issues/8730) - new bug: - [Sticker button is not fully displayed in the sticker popup #8989](https://github.com/status-im/status-desktop/issues/8989) **rramos.eth** - done: - Pair with @Jo trying to find out why the community requests aren't received - waku-org/js-noise: add docs - waku-org/go-waku#414 refactor: service interface - waku-org/go-waku#415 refactor: improve store iterator - status-im/go-waku#3058 chore: update gowaku **r4bbit** - OOO ## Jan 05 (Thu) **r4bbit** - done - Tried heling alexwl (in discord) as he can't and receive messages in the Status community - Implemented a mechanism where pending outgoing contact requests recovered from backups are re-requested - https://github.com/status-im/status-go/pull/3052 - https://github.com/status-im/status-desktop/issues/8702#issuecomment-1369793368 - Reviewed PRs **mprakhov** - done: - [[suite_communities / tst_communityFlows] - " The admin edits a community" doesn't include description and color validation #8008](https://github.com/status-im/status-desktop/issues/8008) - [Group chat: No members shown in members list and member count #8958](https://github.com/status-im/status-desktop/issues/8958) - current: - [Receiving a mention in the channel you're in (but inactive section) doesn't show the badge #8940](https://github.com/status-im/status-desktop/issues/8940). Fixed issue with badge, but got a bug with "new messages" marker. Trying to solve the regression **Michal** - current: - [#3051](https://github.com/status-im/status-go/issues/3051) Collectibles - smart contract and service - collectibles service in status-go for smart contract deployment **Patryk** - done: - reviewed another bunch of PRs - investigated mailserver fetch timeouts - learned about golang Contexts - created https://github.com/status-im/status-go/issues/3053 - fixed: [Text inside comunity welcome modal is cut](https://github.com/status-im/status-desktop/issues/8334) - also added `CommunityIntroDialogPage` to Storybook **rramos.eth** - done: - waku-org/waku-react-native: - fix: storeQuery base64 decode - feat: remove @waku/react-native dependency from example app - Create docs to fix [route ip+net: netlinkrib: permission denied in android](https://github.com/waku-org/waku-react-native/blob/master/android-netlink.md) ## Jan 04 (Wed) **mprakhov** - done: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889) - [[Automation] Can reply to a message in a community channel #6892](https://github.com/status-im/status-desktop/issues/6892). Closed as there was a PR at the end of November. Didn't know why it was added again - review: - [[suite_communities / tst_communityFlows] - " The admin edits a community" doesn't include description and color validation #8008](https://github.com/status-im/status-desktop/issues/8008) - [Group chat: No members shown in members list and member count #8958](https://github.com/status-im/status-desktop/issues/8958) - current: - [Receiving a mention in the channel you're in (but inactive section) doesn't show the badge #8940](https://github.com/status-im/status-desktop/issues/8940) - new bug: - [Chat input: User cant's mark a specific line of text as quote #8956](https://github.com/status-im/status-desktop/issues/8956) **Patryk** - done: - analyzed Mishka's logs regarding group chat messages sending failure - reviewed bunch of PRs - [extended](https://github.com/status-im/status-desktop/compare/9b2d26d5ea2fc82ed51c67075c0d3f37c8f14ad3..60af41895820c15cf9ca6f94f4a03977247c28a6) threadpool logging - identified root cause behind [Right click - quit app makes the app not responding #5938](https://github.com/status-im/status-desktop/issues/5938) - switched to 0.9.0 RC1 - measured time intervals for "fetch more messages" to determine proper timeout **Michal** - current: - [#8921](https://github.com/status-im/status-desktop/issues/8921) Nim backend for minting tokens functionality - finishing testing UI - preparing for smart contract integration - installing geth tools, generating ABI/BIN for a testing smart contract **r4bbit** - done - Ensure tags only become clickable if they refer to channels that indeed exist in the community where a message was sent - https://github.com/status-im/status-desktop/pull/8954 - Remove "Today" and "Yesterday" labels from message group - https://github.com/status-im/status-desktop/pull/8957 - Reviewed some pending PRs **rramos.eth** - done: - waku-org/go-waku#412 feat: postgresql support - waku-org/go-waku#413 fix(c-bindings): simplify discv5 API - pair with @alaibe to investigate why token transfer transactions bridged to L2 failed ## Jan 03 (Tue) **mprakhov** - review: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889). Have a trouble with container to run and if it pass - with the tests. Review passed. - current: - [[suite_communities / tst_communityFlows] - " The admin edits a community" doesn't include description and color validation #8008](https://github.com/status-im/status-desktop/issues/8008). Fixed failing test, adding standalone tests for each scenario (color/description/name) **Michal** - current: [#8921](https://github.com/status-im/status-desktop/issues/8921) Nim backend for minting tokens functionality - simple UI for minting collectibles flow connected with minting module **Patryk** - done: - in scope of [Right click - quit app makes the app not responding #5938](https://github.com/status-im/status-desktop/issues/5938): - learned nim's threadpool internals - learned nim's chronicles to [add better logging](https://github.com/status-im/status-desktop/pull/8952) to determine which tasks are blocking at exit, example: `DBG 2023-01-03 16:45:47.500+01:00 [threadpool task thread] sending 'done' notice to pool topics="task-threadpool" tid=663916 file=threadpool.nim:105 threadid=6 task="{\"$type\":\"RequestMoreMessagesTaskArg:ObjectType\",\"chatId\":\"test2\",\"vptr\":94752975488384,\"slot\":\"mailserverSynced\",\"tptr\":94752923572720}"` - created and [addressed](https://github.com/status-im/status-desktop/pull/8937) [Enable logs for release version #8932 ](https://github.com/status-im/status-desktop/issues/8932) **r4bbit** - done - Looked into reproducing - https://github.com/status-im/status-desktop/issues/8702 - Managed to reproduce it, needs further thought on how to handle it - Looked into - https://github.com/status-im/status-desktop/issues/7913 - Was no longer reproducible **rramos.eth** - done: - waku-org/go-waku#411 fix(chat2): /peers command - waku-org/go-waku#410 feat: use env. variables for arguments - waku-org/go-waku#408 fix: enable store only when WithWakuStore is used - waku-org/go-waku#407 fix: start rpc/rest with no relay - waku-org/go-waku#409 Release 0.3.1 - status-im/status-go#3044 fix: set nameserver via config - waku-org/waku-react-native: - fix: use date for timestamps - fix: use bigints - Release 0.0.11 - current: - go-waku: postgresql support ## Jan 02 (Mon) **Michal** - current: [#8921](https://github.com/status-im/status-desktop/issues/8921) Nim backend for minting tokens functionality - adding needed view, module **Jo** - done - Rebased and retested test PRs - Fixed the issue found by Igor in my replied as mention PR - I needed to add the `Replied` prop in the Message object in status-go, models, items **r4bbit** - done - First day of the year after offtime - Catching up on emails and reviews - Looked into outstanding assigned issues - Particularly - https://github.com/status-im/status-desktop/issues/8702 - Fixed a bug in app search popup - https://github.com/status-im/status-desktop/pull/8927 - Helped in the migration support channel on discord ## Dec 30 (Fri) **MishkaRogachev** - done: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - [#8586](https://github.com/status-im/status-desktop/pull/8916) AC: Profile data change not reflected - next: - vacation until 9.01 **mprakhov** - done: - [User can't leave non joined community #8885](https://github.com/status-im/status-desktop/issues/8885) Not reproduced - review: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889) - current: - [[suite_communities / tst_communityFlows] - " The admin edits a community" doesn't include description and color validation #8008](https://github.com/status-im/status-desktop/issues/8008) - new bug: - [Chat input: can't send html text from the clipboard #8919](https://github.com/status-im/status-desktop/issues/8919) - important: - Happy new year, my dear reader :slightly_smiling_face: :christmas_tree: **Igor** - done: - code reviews - current: - [#3234](https://github.com/status-im/status-desktop/issues/3234) ENS usernames depending on current network **Michal** - done: - [#6567](https://github.com/status-im/status-desktop/issues/6567) Tolerate better network disconnects - next: - [#8921](https://github.com/status-im/status-desktop/issues/8921) Nim backend for minting tokens functionality ## Dec 29 (Thu) **Michal** - done: - #7848 cpp: send message - improvements after code review, adding test - current: - #6567 Tolerate better network disconnects - continue with task **mprakhov** - done: - [Punctuation character in the Contract Request message ends up inappropriately escaped #8613](https://github.com/status-im/status-desktop/issues/8613) - current: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889). Almost done, testing and fixing found issues **MishkaRogachev** - in review: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - QA fixes - current: - [#8586](https://github.com/status-im/status-desktop/issues/8586) AC: Profile data change not reflected - created: - [#8910](https://github.com/status-im/status-desktop/issues/8910) No padding for input fields ## Dec 28 (Wed) **Patryk** - done: - created [Messages fetched from store nodes shouldn't be loaded on the ui](https://github.com/status-im/status-desktop/issues/8907) - not feeling well, most likely will take day off tomorrow **MishkaRogachev** - done: - found issue with creating new acc in status-go (upd: fixed) - [#8388](https://github.com/status-im/status-desktop/pull/8883) Outgoing contact request notification - in review: - [#8387](https://github.com/status-im/status-desktop/pull/8887) AC notification text formatting issues - current: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - QA fixes - next: - [#8586](https://github.com/status-im/status-desktop/issues/8586) Handling contact info updates **Michal** - done: - catching up after holidays - code reviews - syncing and merging tasks **mprakhov** - done: - [Clicking "Go to Community" on a big community calls chat_getMembers a ton #8801](https://github.com/status-im/status-desktop/issues/8801) - review: - [Punctuation character in the Contract Request message ends up inappropriately escaped #8613](https://github.com/status-im/status-desktop/issues/8613) - current: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889) ## Dec 27 (Tue) **mprakhov** - done: - [Save profile Bio shows store password popup #8843](https://github.com/status-im/status-desktop/issues/8843) - review: - [Clicking "Go to Community" on a big community calls chat_getMembers a ton #8801](https://github.com/status-im/status-desktop/issues/8801) - [Punctuation character in the Contract Request message ends up inappropriately escaped #8613](https://github.com/status-im/status-desktop/issues/8613) - current: - [App doesn't remember which channel in a community was active on restart #8889](https://github.com/status-im/status-desktop/issues/8889). The problem is actual not only for the community, but for 121 chats too. We store active section, but not active chat/channel - new bugs (regression im master): - https://github.com/status-im/status-desktop/issues/8897 - https://github.com/status-im/status-desktop/issues/8898 **MishkaRogachev** - done: - Crapped my old status account - [Here](https://github.com/status-im/status-desktop/issues/8902) how i did it - [This](https://join.status.im/u/zQ3shNaALHWy2PtaPgpE2t9NWDu53tU7EzmWneYpsknfxuGU4) is new one, feel free add to contacts - in review (same as before, review please): - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - [#8388](https://github.com/status-im/status-desktop/pull/8883) Outgoing contact request notification - [#8387](https://github.com/status-im/status-desktop/pull/8887) AC notification text formatting issues - current: - Figuring why i can't create new acc with development version - next: - [#8586](https://github.com/status-im/status-desktop/issues/8586) Handling contact info updates **Patryk** - done: - reviewed PRs - reproduced [Right click - quit app makes the app not responding #5938](https://github.com/status-im/status-desktop/issues/5938) - current: - figuring out the root cause of [Right click - quit app makes the app not responding #5938](https://github.com/status-im/status-desktop/issues/5938) **Igor** - done: - [PR #8893](https://github.com/status-im/status-desktop/pull/8893)fix(PinnedMessagesPopup): Force show repeat header - current: - [#3234](https://github.com/status-im/status-desktop/issues/3234) ENS usernames depending on current network **Jo** - current: - Struggling to fix the issue that hangs the Windows app when closing after downloading or copying an image - I'll need the help of a C++ expert once I'm back - next: - Fix logic issue found by Igor in my reply as mention PR ## Dec 26 (Mon) **MishkaRogachev** - in review: - same as before - current: - debugging problems with cursor - [#8586](https://github.com/status-im/status-desktop/issues/8586) Handling contact info updates - still blocked **Jo** - done: - Enabled admins to delete other users' messages + tests - Added a new test to send a contact request from the chat profile ## Dec 23 (Fri) **MishkaRogachev** - in review (review please): - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - [#8388](https://github.com/status-im/status-desktop/pull/8883) Outgoing contact request notification - [#8387](https://github.com/status-im/status-desktop/issues/8387) AC notification text formatting issues - current: - [#8586](https://github.com/status-im/status-desktop/issues/8586) Handling contact info updates - need to merge other PRs to make sure they are also being updated **mprakhov** - done: - [Creating a category and selecting a channel for it leaves the chat view in limbo #8297](https://github.com/status-im/status-desktop/issues/8297) - [Chat: it's possible to send an empty message #8268](https://github.com/status-im/status-desktop/pull/8882) - [The suggestion to enable link previews in chats is displayed even when the option is already enabled #8631](https://github.com/status-im/status-desktop/issues/8631) closed as fixed - review: - [Save profile Bio shows store password popup #8843](https://github.com/status-im/status-desktop/issues/8843) - current: - [Clicking "Go to Community" on a big community calls chat_getMembers a ton #8801](https://github.com/status-im/status-desktop/issues/8801). Found 2 issues, described in [comment](https://github.com/status-im/status-desktop/issues/8801#issuecomment-1363935012), require clarification of expected behavior - [Punctuation character in the Contract Request message ends up inappropriately escaped #8613](https://github.com/status-im/status-desktop/issues/8613) ## Dec 22 (Thu) **Boris** - done: - Update, test and fix ban functionality in the community [#8841](https://github.com/status-im/status-desktop/pull/8841) - current: - checking the PRs and issues before days off **MishkaRogachev** - in review: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - Verification request now are unidirectional - [#8388](https://github.com/status-im/status-desktop/pull/8883) Outgoing contact request notification - current: - [#8387](https://github.com/status-im/status-desktop/issues/8387) AC notification text formatting issues **r4bbit** - done - Updated PR to edit last message using arrow-up key - https://github.com/status-im/status-desktop/pull/8873 - Put my thoughts on paper regarding memory efficiency of the import and archive tool - https://github.com/status-im/status-desktop/issues/8857#issuecomment-1362788402 - **feedback welcome** **mprakhov** - review: - [Creating a category and selecting a channel for it leaves the chat view in limbo #8297](https://github.com/status-im/status-desktop/issues/8297). Fixed unloading the channel after review - [Chat: it's possible to send an empty message #8268](https://github.com/status-im/status-desktop/pull/8882) - current: - [Clicking "Go to Community" on a big community calls chat_getMembers a ton #8801](https://github.com/status-im/status-desktop/issues/8801) **Jo** - done: - Tried updating my mentions status-go PR to make it more efficient, but I gave up as it just created more trouble - current: - Fixing the issue where replies sometimes show `<deleted>` as the quoted text even though it wasn't deleted - I pretty much finished fixing - I did so by using the QuotedMessage property that's alreayd part of Message - No more JSON fetching from QML for this (mostly) - The only small thing I need to figure out is if we want to show `deleted` when the message is actually deleted - the reason I'm asking is because if we do, then status-go has a bug, because QuotedMessage stays as the old message when it is deleted ## Dec 21 (Wed) **Boris** - current: - Checked the code about community updates, ban users and so on. - Checking the problem with ui test when admin creates a channel in the community **Patryk** - done: - reviewed PRs - https://github.com/status-im/status-desktop/pull/8866 - https://github.com/status-im/status-desktop/pull/8867 - fixed [Messages loading doesn't work when messages fetch is ongoing](https://github.com/status-im/status-des) **MishkaRogachev** - in review: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - Finaly working! **Jo** - done: - Added replied as mentions on status-go + test - Small adjustements to PRs - Tested and reviewed PRs **Igor** - done: - [#8261](https://github.com/status-im/status-desktop/issues/8261) Edited text shows even though message isn't edited - [#8273](https://github.com/status-im/status-desktop/issues/8273) Chat toolbar sometimes shows letter identicon, even though profile image is available - current: - [#3234](https://github.com/status-im/status-desktop/issues/3234) ENS usernames should depend on the network **r4bbit** - done: - Looked into app search freezing when emitting too many requests - This turned out to be not reproducible - Implemented arrow-up to edit last message - https://github.com/status-im/status-desktop/pull/8873 - Other than that, busy with family as I need to take care of two kids atm ## Dec 20 (Tue) **Boris** - done: - Change `joined` flag for banned users to `false` - Checked the bug with Requests to join for banned users and found it as side effect from ban user bug. - Review some PR's - current: - Ui test when admin creates community channel **Igor** - done: - minor fixes for [#8802](https://github.com/status-im/status-desktop/pull/8802) - discuss and plan [#3234](https://github.com/status-im/status-desktop/issues/3234) with Anthony - current: - [#8273](https://github.com/status-im/status-desktop/issues/8273) Chat toolbar sometimes shows letter identicon, even though profile image is available - [#3234](https://github.com/status-im/status-desktop/issues/3234) ENS usernames should depend on the network **mprakhov** - done: - [Settings -> Change password: user is forced to bypass biometrics prompt #7349](https://github.com/status-im/status-desktop/issues/7349) - review: - [Creating a category and selecting a channel for it leaves the chat view in limbo #8297](https://github.com/status-im/status-desktop/issues/8297) - current: - [Clicking "Go to Community" on a big community calls chat_getMembers a ton #8801](https://github.com/status-im/status-desktop/issues/8801) **MishkaRogachev** - in review: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - nim & qml seems to be ok - current: - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - still stuck figuring why some of notifications are not invoked **Jo** - done: - Investigated why messages from cammellos were not received - It seems like a store node issue - Fixed issue where the app doesn't show on start on Windows when the monitors changed - Fixed issue where images were not downloaded on Windows - current: - Fixing issue where replies don't count as mentions **r4bbit** - Done - Updated pending Prs for `@everyone` support - Done some brainstorming/thinking about solving memory issues with the import tool/archive tool - current - **Might need some new smaller tasks** - Because of holidays coming up and there's very little sense in starting something big **Patryk** - done: - [Old messages fetched from the store node or import should not go to the front-end](https://github.com/status-im/status-desktop/pull/8854) - rebased PRs and resolved conflicts **rramos.eth** - done: - waku-org/go-noise - status-im/status-go#3032 fix: temporarily setting WakuMessage RateLimitProof to nil so it matches the protobuffer we are sending - Troubleshoot reported error on @waku/react-native. No error found. Waiting for more input - current: - go-waku <> js-waku Noise Interop ## Dec 19 (Mon) **Boris** - done: - Fix build for sandboxapp [PR#8840](https://github.com/status-im/status-desktop/pull/8840) - in review: - Ban state for community [PR #8841](https://github.com/status-im/status-desktop/pull/8841) - Skip processing request to join from banned users [Status-go #3030](https://github.com/status-im/status-go/pull/3030) - current: - Fixing bug when admin ban some member and request to join still in pending after accepting. - Ui test for creating community channel **Patryk** - done - reviewed and tested: [feat(communities): Add ban state for spectated community](https://github.com/status-im/status-desktop/pull/8841) - followed and discussed: https://github.com/status-im/status-desktop/pull/8796#discussion_r1049067422 - most likely fixed: [https://github.com/status-im/status-desktop/issues/8466](https://github.com/status-im/status-desktop/issues/8466) - introduced nim-tests **mprakhov** - review: - [Settings -> Change password: user is forced to bypass biometrics prompt #7349](https://github.com/status-im/status-desktop/issues/7349) - current: - [Creating a category and selecting a channel for it leaves the chat view in limbo #8297](https://github.com/status-im/status-desktop/issues/8297) - new bug: - https://github.com/status-im/status-desktop/issues/8843 **MishkaRogachev** - current: - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - Fixed outgoing requests notifications - Still figuring out why decline is not updating - next: - [Refactor user model](https://github.com/status-im/status-desktop/pull/8791) Needed both for [#8437](https://github.com/status-im/status-desktop/pull/8612) and [#8586](https://github.com/status-im/status-desktop/issues/8586) **r4bbit** - done - Revisited PRs that implemented `@everyone` - Update parser: https://github.com/status-im/markdown/pull/5 - Mark message as mentioned: https://github.com/status-im/status-go/pull/3026 - Replace systen mentions with labels: https://github.com/status-im/status-desktop/pull/8809 **Jo** - done: - meetings - Fixed an issue where joining a public chat sometimes crashed the app https://github.com/status-im/status-desktop/pull/8851 - current: - Fixing issues with the badge on chats **rramos.eth** - done: - waku-org/go-waku#400 feat: add discV5 to c-bindings - current: - waku-org/go-noise - go-waku <> js-waku Noise Interop ## Dec 16 (Fri) **Boris** - done: - 💀 - current: - Block request to join for banned members (almost done) **Patryk** - done: - reported: [Messages loading doesn't work when messages fetch is ongoing](https://github.com/status-im/status-desktop/issues/8831) - reported: [Removing group members results in "admin has added"](https://github.com/status-im/status-desktop/issues/8832) - fixed: [Removing group members results in "admin has added"](https://github.com/status-im/status-desktop/issues/8832) - tiny cleanup: [chore: remove unused loadingHistoryMessagesInProgress property](https://github.com/status-im/status-desktop/pull/8835) - current: - ongoing investigation on messages ordering **MishkaRogachev** - done: - reported: [Duplicated AC notification for contact request](https://github.com/status-im/status-desktop/issues/8834) - but can't reproduce it - current: - [#7373](https://github.com/status-im/status-go/pull/3029) New identity verification AC notifications for status-go - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - Catching bugs - Need ~2 days to finish it - next: - [Refactor user model](https://github.com/status-im/status-desktop/pull/8791) Needed both for [#8437](https://github.com/status-im/status-desktop/pull/8612) and [#8586](https://github.com/status-im/status-desktop/issues/8586) **mprakhov** - done: - [OS notifications showing Contact Request message from myself #8381](https://github.com/status-im/status-desktop/issues/8381) - [Contact request: accepted contact requests are shown after relogin #8488](https://github.com/status-im/status-desktop/issues/8488) - review: - [Settings -> Change password: user is forced to bypass biometrics prompt #7349](https://github.com/status-im/status-desktop/issues/7349) - current: - [Creating a category and selecting a channel for it leaves the chat view in limbo #8297](https://github.com/status-im/status-desktop/issues/8297) **r4bbit** - done - Investigated a crash when downloading magnetlinks and implemented a fix - Implemented keeping track of last handled magnetlink - https://github.com/status-im/status-go/pull/3028 - current - Revisiting `@everyone` mention as functionality needs to be moved to markdown parser - Also introduce system codes for `@everyone` **Jo** - done: - meetings - Finally figured out why the group chats go invisible - When re-importing the account, if you get the signal from a non-contact, it counts as "spam" - discussed with Andrea and we think it would be better to show it in the AC like before, at least for this case - waiting to check with John - current: - trying to fix the issue where reopening the app with no monitors causes the app to no show **Michal** - done: - Minting meeting - #8789 Opening profile link in community navigates to 1-1 chats - current: - #6567 Tolerate better network disconnects - applying context in status-g; nim part **Igor** - done: - [#8802](https://github.com/status-im/status-desktop/pull/8802) Show identicon ring during onboarding - current: - [#7733](https://github.com/status-im/status-desktop/issues/7733) Previously used pic and ENS shown to contacts after account restore when neither are set **rramos.eth** - done: - waku-org/js-noise#11 feat: add form to send/receive messages after handshake - Discussed with @cammellos about status-go/go-waku possibly not generating deterministic message IDs - Described issue and possible solutions in [Calculating ID of the messages for status-go and deterministic WakuMessage bytes #563](https://github.com/vacp2p/rfc/issues/563) - current: - go-waku <> js-waku Noise Interop ## Dec 15 (Thu) **Boris** - done: - Update and fix comments in bunch of warnings PRs, Pass test - current: - Disable `Request to Join` button for banned users **MishkaRogachev** - done: - [#8437](https://github.com/status-im/status-desktop/pull/8612) Cancel identity verification (status-desktop part) - current: - [#7373](https://github.com/status-im/status-desktop/pull/8246) Add identity verification AC notifications - Resumed & rebased - [Refactor user model](https://github.com/status-im/status-desktop/pull/8791) Needed both for [#8437](https://github.com/status-im/status-desktop/pull/8612) and [#8586](https://github.com/status-im/status-desktop/issues/8586) **mprakhov** - review: (both bugs fix provided in one [PR](https://github.com/status-im/status-desktop/pull/8808)) - [OS notifications showing Contact Request message from myself #8381](https://github.com/status-im/status-desktop/issues/8381) - [Contact request: accepted contact requests are shown after relogin #8488](https://github.com/status-im/status-desktop/issues/8488) - current: - [Settings -> Change password: user is forced to bypass biometrics prompt #7349](https://github.com/status-im/status-desktop/issues/7349). Waiting for a response from designers - wrote out new StatusChatInput bugs: - https://github.com/status-im/status-desktop/issues/8814 - https://github.com/status-im/status-desktop/issues/8815 - https://github.com/status-im/status-desktop/issues/8819 **Patryk** - done: - restored my test account, investigated group chat not appearing issue - code reveiws - participated in discord tool meeting conducted by Pascal - imported legacy data folder to latest master - spent a lot of time on the crash caused by migration issue - "album_id" can't be null.. - after import issue with unordered messages is not visible anymore - current: - trying to reproduce [Messages not in order post application restart #8466](https://github.com/status-im/status-desktop/issues/8466) **Michal** - done: - OOO yesterday due to child's sickness - syncing and merging some pending prs - #6567 Tolerate better network disconnects - dealing with Infura requests limit - setting up own account - discord tool meeting - current: - #6567 Tolerate better network disconnects - #8789 Opening profile link in community navigates to 1-1 chats **Jo** - done: - nice presentation by Pascal - Was able to reproduce the invisible group chat issue - The Active property was indeed set to false, which is not correct - I tracked it down to a place in status-go - sent a PR that I hope solves it - task assignments **rramos.eth** - done: - waku-org/go-waku#398 feat(noise): Pairing object including unit test - waku-org/go-waku#399 fix: insert receiver timestamp if sender timestamp is 0 - Created [script](https://github.com/richard-ramos/test-waku-query/tree/messageFinder) to check whether a message is stored in the status.prod fleet - current: - go-waku <> js-waku Noise Interop **r4bbit** - done - Implemented first version of `@everyone` support - https://github.com/status-im/status-desktop/pull/8809 - https://github.com/status-im/status-desktop/pull/8809 - Fixed bug that was introduced in status-go migration when adding album support - https://github.com/status-im/status-go/pull/3023 - Prepared/slides presentation about Discord Import tool - Slides: https://docs.google.com/presentation/d/175g6PEhNbmPsbAy0UOphLcPUhZ8nGjUZFiZ9-Gad3kU/edit?usp=sharing - Recording: https://drive.google.com/file/d/1NhULFpanh_rceqgD_iLa0J6Ri1wnDPS6/view?usp=sharing - Transcript: https://docs.google.com/document/d/12AMQ03aiQeFs4VhhKNbQIyEyRLxjthpITjVqbX5turU/edit#heading=h.3ex77srmraqr - Did the presentation - Current - Look into bug that causes crash of app when handling magnetlink messages ## Dec 14 (Wed) **Boris** - done: - update and rebase old PRs - in review: - the last(i hope) PR with warnings fixes [PR #8797](https://github.com/status-im/status-desktop/pull/8797) - current: - Captcha discussion - Banned user state for community **Patryk** - done: - reported [Search freezes the app](https://github.com/status-im/status-desktop/issues/8777) - merged [feat: add FirstUnseenMessageID API](https://github.com/status-im/status-go/pull/3018) - rebased [Feat/8572/new messages marker ](https://github.com/status-im/status-desktop/pull/8756) - reported [Make "fetch more messages" interactions more user friendly](https://github.com/status-im/status-desktop/issues/8780) - got better udnerstanding of magnetlinks distribution - reported [App crashes immediately post login](https://github.com/status-im/status-desktop/issues/8785) - investigated and fixed [App crashes immediately post login](https://github.com/status-im/status-desktop/issues/8785) - cherry picked [App crashes immediately post login](https://github.com/status-im/status-desktop/issues/8785) to 0.8.x - reviewed PRs **MishkaRogachev** - done: - [#8437](https://github.com/status-im/status-go/pull/2992) Cancel identity verification (status-go part) - in review: - [#8437](https://github.com/status-im/status-desktop/pull/8612) Cancel identity verification (status-desktop part) - waiting review, recaftor moved to another PR - current: - [Refactor user model](https://github.com/status-im/status-desktop/pull/8791) Needed both for [#8437](https://github.com/status-im/status-desktop/pull/8612) and [#8586](https://github.com/status-im/status-desktop/issues/8586) - Question: there are lots of changes, is it a good idea to fix it now or i can just fix doubled connection and implement AC notifications first? - next: - Identity verification notifications\ - status-go PR is merged so it's unblocked **mprakhov** - current: - [OS notifications showing Contact Request message from myself #8381](https://github.com/status-im/status-desktop/issues/8381). So the problem is that we are sending approved contact request notification as a simple chat message. **Jo** - done: - Had a meeting with cammellos for community join spam issue and captcha - Found an issue where a group chat became invisible, but messages still came in (with notifications) - Sadly, we fixed it by kicking and re-adding, so I no longer can reproduce - I still investigated the code, I think it might be related to Active being set to false, but I can't prove it - Patryk was able to reproduce, it's indeed related to Active being set to false - current: - trying to fix the reactions not showing for the mobile team (probably on app restart?) - Turns out it might be the same as the pending requests - the filter is not listened to, but only in the Status CC community - Finally figured it out, it's related to enryption in the community - The special messages like delete, edit, pin and reactions were not encrypted, so they fell in the wrong topic **Igor** - done: - [#8802](https://github.com/status-im/status-desktop/pull/8802) No identicon ring on new profile setup - rebasing with conflicts and dealing with squish tests in [#8762](https://github.com/status-im/status-desktop/pull/8762) - current: - [#7733](https://github.com/status-im/status-desktop/issues/7733) Previously used pic and ENS shown to contacts after account restore when neither are set **r4bbit** - done - Landed PRs that improve mangetlink download handling and getting latest magnetlink from community owner - Started working on presentation for discord import tool - current - Implementing/testing `@everyone` mentions **rramos.eth** - done: - waku-org/noise#000 - Add generateKeyPairFromPrivateKey - Expose Hash, RS, H from the handshake state, and add `ad` to Encrypt funcs - Discuss with @s1fr0 differences in go vs nim implementation of noise - waku-org/go-waku#397 feat(noise): WakuPairing - Pair with @Jo to hunt the cause for missing reactions in communities in status-go - current: - waku-org/go-waku#398 feat(noise): Pairing object ## Dec 13 (Tue) **Boris** - done: - Rebase, fix and pass ui tests for old PR's - in review: - Several PRs about warnings - current: - Community ui warnings - next: - [When banned in community user needs some sort of notification](https://github.com/status-im/status-desktop/issues/7374) **MishkaRogachev** - in review: - [#8437](https://github.com/status-im/status-go/pull/2992) Cancel identity verification - still waiting review... - add fix for several identity verification requests from same account - Refactor user model and contacts service to get updates from status-go side. Needed both for [#8437](https://github.com/status-im/status-desktop/pull/8612) and [#8586](https://github.com/status-im/status-desktop/issues/8586) - dataChanged doesn't work well, i'm going to stay with itemChanged(pubKey) - moved service layer refactor commit to #7373 - question about mutalContactsModel and contactRequestModel. With current approach i need to subscribe both - next: - [#7373](https://github.com/status-im/status-desktop/issues/7373) Identity verification notifications **Michal** - done: - [#8694](https://github.com/status-im/status-desktop/issues/8694) - meeting with Noelia - current: - [#6567](https://github.com/status-im/status-desktop/pull/6567) Tolerate better network disconnects - trying to use go contexts to add timeout functionality in stickers; blocked by Infura daily request limit **mprakhov** - done: - [Text Size settings from Appearance doesn't apply correctly on restart #8462](https://github.com/status-im/status-desktop/issues/8462) - created new bugs - https://github.com/status-im/status-desktop/issues/8731 - https://github.com/status-im/status-desktop/issues/8740 - https://github.com/status-im/status-desktop/issues/8741 - https://github.com/status-im/status-desktop/issues/8742 - current: - [OS notifications showing Contact Request message from myself #8381](https://github.com/status-im/status-desktop/issues/8381). Gathered all needed information, checked mockups, working under fix **rramos.eth** - done: - waku-org/go-waku#389 feat: allow passing params to db url and connection pool params (required for supporting postgresql in the future) - waku-org/go-waku#390 refactor: use context instead of quit channel - waku-org/go-waku#393 feat: add /debug/pprof endpoint when using --pprof flag - waku-org/go-waku#394 fix: handle missing pagingInfo - waku-org/go-waku#395 target android 31 - waku-org/waku-react-native#000 update example and test functionality targeting Android 13 - API 30 - status-im/status-go#3019 debug: add more logs to determine why community requests are missing - current: - Hunting bug that causes Iuri to not receive community join requests immediatly - Jo and I were able to see that the issue happens in status-go. The requests are received but dropped for some reason. - After some time the requests arrive again via History request - According to status-go code, there are not many places where this should fail. I believe the problem is due to filters not being executed, and created status-im/status-go#3019 which adds extra logging to determine if this is the case. - Currentyl waiting for Iuri to reproduce the issue - js-noise <> go-waku pairing - next: - Desktop: improve node management section **Patryk** - done: - Implement new messages marker #8572 - feat: add FirstUnseenMessageID API #3018 - resolved merge conflicts - code reviews - tried to help Pascal with deadlocks - current: - Messages not in order post application restart #8466 **r4bbit** - done - Refactored pending PR that makes handling community archive downloads more robust - Resulted in a deadlock - Debugged deadlock scenario in community archive protocol handling - Explored different solutions, ended up implementing one - Updated PR that adds magnetlink to community request to join response - This one sits on top of the download handlning PR which is why this needed rebase - current - Continuing working on support for `@everyone` mentions - Also create slides/preso for discord import tool session on thursday - next - ^ **Jo** - done: - Fixed small issues with muted chat notifs and badge in master - Resend PR merged - Fixed sending images using the Send image button - Tested sending big images on Windows - I could not reproduce the issue Elina had where it would crash - Tested sending and receiving emoji reactions - Could not reproduce the issue Diana had. I asked her to retest and check the amount of peers - Investigated the community requests not being received with Richard - I had a way to reproduce it using my dev and release accounts - Release didn't receive it, but it got the envelope - sadly, it ended up fixing itself for some reason and I can no longer reproduce - we still learned that the issue is in status-go (somewhere, maybe with filters) - current: - triaging tasks to give new stuff to myself and others - next: - banned user can still request to join and that request reaches the admin still **Igor** - done: - [#8762](https://github.com/status-im/status-desktop/pull/8762) Fix ENS names inconsistency across app - current: - [#7733](https://github.com/status-im/status-desktop/issues/7733) Previously used pic and ENS shown to contacts after account restore when neither are set - next: - [#3234](https://github.com/status-im/status-desktop/issues/3234) ENS usernames should depend on the network