# Wallet - Archive May 18 - July 31
## July 29 (Fri)
**Anthony**
- done:
- Script to install the app on ubuntu20.04
- This is required in order to have ci + squish running as we are removing the docker part and instead going for the same solution as in windows
- current:
- Fix total balance
- Add test to ci
- [X] Scripts to run test
- [X] Fix import path
- [X] Fix python version
- [X] Problem with loading the AUT: LD_LIBRARY_PATH
- [X] Adding missing library on host: glib
- [X] Install headless X
- [ ] replace docker by running the test directly on the host (waiting for Jakub)
- next:
- As I am waiting for Jakub I can pickup other taks in the meantime
**Stefan**
- done:
- finished minimal POC to show non-native token count for enabled non-test networks and hard-coded list of tokens [in review PR 6645](https://github.com/status-im/status-desktop/pull/6645)
- next: follow on reviews and merge POC PRs
- Friday, offline
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6616](https://github.com/status-im/status-desktop/pull/6616) - Keycard Epic
- Moving changes I've done in PR#6000 to the new startup flow we have in the `master` branch, there are lot of incompatibilities since I was developing keycard based on the tangled onboarding flow before and now need to map and test all that carefully again
- `new user - first run - new keys` - **done**
- `new user - first run - import seed phrase into keycard` - **done**
- `new user - first run - keycard import` - **done**
- `old user - not first run - keycard login` - **in progress** (biometrics used for pin, log in flow completed, testing flows and connected flows, might be some bugs there)
- next:
- (new issue, based on PR#6616) add animation screen to all endpoints we have now
- (new issue) to develop factory reset flow according to the design we have here: https://www.figma.com/proto/idUoxN7OIW2Jpp3PMJ1Rl8/⚙️-Settings-|-Desktop?node-id=7258%3A188342&scaling=contain&page-id=199%3A2653
**Khushboo**
- done:
- [#6587](https://github.com/status-im/status-desktop/issues/6587): Send modal should work as a wizard
- current:
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
- working on this dedicatededly now. wasnt completeing other tasks.
- [#5355](https://github.com/status-im/status-desktop/issues/5355): Can't scroll when having focus in seed phrase grid in wallet
- tested on macOs with mouse wheel and it works okay
- Using wheel handler i can scroll it but need to fine tune it to give us correct scrolling behaviour
- next:
- [#6491](https://github.com/status-im/status-desktop/issues/6491): Token View
## July 27 (Wed)
**Anthony**
- done:
- Enable goerli as main testnet + Fix goerli
- current:
- Add test to ci
- [X] Scripts to run test
- [X] Fix import path
- [X] Fix python version
- [ ] Problem with loading the AUT
- So far we copied the qt to the host
- Next error is we need to add the env var LD_LIBRARY_PATH
**Khushboo**
- done:
- [#6497](https://github.com/status-im/status-desktop/issues/6497): Send Transation modal colors need to be adjusted to match designs
- [#6499](https://github.com/status-im/status-desktop/issues/6499): Token selector in the send modal doesn't look like design and overflows window
- fixed issues found during test
- current:
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
- testing a fix simultaneously
- [#6587](https://github.com/status-im/status-desktop/issues/6587): Send modal should work as a wizard
- next:
- next item in list
**Sale**
- done:
- Issue-6551 - `status-desktop` [PR#6607](https://github.com/status-im/status-desktop/pull/6607), `statusq` [PR#799](https://github.com/status-im/StatusQ/pull/799) - searching doesn't work when "In: Anywhere" set by X button
- Splash screeen moved - [PR#6579](https://github.com/status-im/status-desktop/pull/6579) - Added new commit which does setup/login account in an async way, the purpose of it is to release main event loop as soon as possible (without keeping UI blocked)
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6616](https://github.com/status-im/status-desktop/pull/6616) - Keycard Epic
- Moving changes I've done in PR#6000 to the new startup flow we have in the `master` branch, there are lot of incompatibilities since I was developing keycard based on the tangled onboarding flow before and now need to map and test all that carefully again
- `new user - first run - new keys` - **done**
- `new user - first run - import seed phrase into keycard` - **done**
- `new user - first run - keycard import` - **done**
- `old user - not first run - keycard login` - **in progress** (found out how to differ accounts created using keycard and regularly created accounts)
- After keycard meeting we had today, the following changes are needed:
- already implemented feature, one we already have in the `master` branch, is wrongly implemented in case of import seed phrase for new user (because of that `new user - first run - import seed phrase into keycard` is also implemented the same way and need to fix both, but that's kind bigger thing (fetching profile data from waku))
- storing pin to biometrics in case of mac need to be added for all flows
- factory reset flow need to follows design we have here: https://www.figma.com/proto/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?node-id=7258%3A188342&scaling=contain&page-id=199%3A2653
**Stefan**
- done:
- investigated and fixed linux plugin loading issue [in review PR #6478](https://github.com/status-im/status-desktop/pull/6478)
- implemented watch only account [in review PR #6618](https://github.com/status-im/status-desktop/pull/6618)
- follow on reviews and fix/improve PRs
- next/current:
- continue balance UI integration for POC. Thanks to colleagues for help understanding the requirements
- day off tomorrow
## July 25 (Mon)
**Anthony**
- done:
- Add test for sending transaction
- current:
- Add test to CI
- next:
- Enable goerli as main testnet
**Sale**
- done:
- Issue-6551 - `status-desktop` [PR#6607](https://github.com/status-im/status-desktop/pull/6607), `statusq` [PR#799](https://github.com/status-im/StatusQ/pull/799) - searching doesn't work when "In: Anywhere" set by X button
- Splash screeen moved - [PR#6579](https://github.com/status-im/status-desktop/pull/6579) - Added new commit which does setup/login account in an async way, the purpose of it is to release main event loop as soon as possible (without keeping UI blocked)
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6616](https://github.com/status-im/status-desktop/pull/6616) - Keycard Epic
- Moving changes I've done in PR#6000 to the new startup flow we have in the `master` branch, there are lot of incompatibilities since I was developing keycard based on the tangled onboarding flow before and now need to map and test all that carefully again
- `new user - first run - new keys` - **done**
- `new user - first run - import seed phrase into keycard` - **done**
- `new user - first run - keycard import` - **in progress**
- `old user - not first run - keycard login`
**Khushboo**
- current:
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
-current:
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
- seems like the usga eof all model is causing the crash trying to fix it still
- [#5355](https://github.com/status-im/status-desktop/issues/5355): Can't scroll when having focus in seed phrase grid in wallet
- discussed with the ream, will give it a go.
[#6570](https://github.com/status-im/status-desktop/issues/6570): QR code in the Receive modal of the wallet doesn't appear
- not able to reproduce
- next:
- [#6497](https://github.com/status-im/status-desktop/issues/6497): Send Transation modal colors need to be adjusted to match designs
- why was this unassigned to me? By tlaking to John we agreed to implment it as it is in design for now.
- next item in list
**Stefan
- done: integrated wallet APIs [in review PR #6618](https://github.com/status-im/status-desktop/pull/6618)
- fixed the networks configuration
- missing crypto helpers like `BigInt` for C++. Looked into a generic implementation and none was convincing. I quickly implemented one for displaying only until more time is dedicated to this
- still retrieving balance for test-net doesn't work
- next/current: investigate balance on test-net blocking issue and continue balance UI integration for POC
- day off on Thursday, will be offline tomorrow between ~12-16 CET
## July 22 (Fri)
**Anthony**
- curent:
- Add test for sending transaction
- Add test to CI
**Khushboo**
- done:
- [#6498](https://github.com/status-im/status-desktop/issues/6498): In the Send Modal the saved addresses and my accounts sections need to be adjusted to match design
- [#6499](https://github.com/status-im/status-desktop/issues/6499): Token selector in the send modal doesn't look like design and overflows window
- fixed review comments and pushed PR's
- current:
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
- as this takes ~30 mins to reproduce, trying something then waiting for a break to test :D
- [#5355](https://github.com/status-im/status-desktop/issues/5355): Can't scroll when having focus in seed phrase grid in wallet
- next:
- [#6497](https://github.com/status-im/status-desktop/issues/6497): Send Transation modal colors need to be adjusted to match designs
- will clarify during UI meeting
**Sale**
- done:
- Checked and added necessary updates to make `statusq` demo app buildable and runable on mac
- [PR#6579](https://github.com/status-im/status-desktop/pull/6579) - prepared PR to show how the app would work if we use splash screen as app loading animation, if that doesn't work we can keep it on the app start and prepare some new animation for that point
- current:
- Moving changes I've done in PR#6000 to the new startup flow we have in the `master` branch, there are lot of incompatibilities since I was developing keycard based on the tangled onboarding flow before and now need to map and test all that carefully again
- `new user - first run - new keys` - done
- `new user - first run - import seed phrase into keycard` - in progress
- next:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard - done
- Create account using existing keys from keycard - done
- login with keycard
**Stefan**
- done: finalized create account PR [in review #6478](https://github.com/status-im/status-desktop/pull/6478)
- Had issues with opening a NIM generated DB. It seems NIM password hash is capitalizing and C++ wasn't
- current: working to show token balance [draft PR #6586](https://github.com/status-im/status-desktop/pull/6586)
- Encountered issues fetching networks. It seems the node and user configuration wasn't in sync with NIM.
## July 20 (Wed)
**Anthony**
- done:
- Add test for all type of account creation
- Add test for deleted generated account
- current:
- Add test for sending transaction
**Khushboo**
- done:
- [#6388](https://github.com/status-im/status-desktop/issues/6388): Wallet account generation popup doesn't support tab navigation
- [#5725](https://github.com/status-im/status-desktop/issues/5725): adapt view for settings as shown during account generation
- [#6496](https://github.com/status-im/status-desktop/issues/6496): Multinetwork QR code sometimes doesn't update when there is only 1 network left
- current:
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
- Still waiting for test network svg
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
- as this takes ~30 mins to reproduce will try ti check it now and then in between breaks
- [#6498](https://github.com/status-im/status-desktop/issues/6498): In the Send Modal the saved addresses and my accounts sections need to be adjusted to match design
- next:
- next task assigned
**Sale**
- done:
- [Issue-6473](https://github.com/status-im/status-desktop/issues/6473) [PR#6550](https://github.com/status-im/status-desktop/pull/6550) - Onboarding/Login flow improvements
- current:
- need to rebase and align changes I've done so far for Issue-5972 to the new changes we have in PR#6550
- next:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard - done
- Create account using existing keys from keycard - done
- login with keycard
**Stefan**
- current: Wallet UI POC [WIP PR #6478](https://github.com/status-im/status-desktop/pull/6478)
- Found the root cause of the issue with colleagues help
- Update tests to embed the knowledge
- Working to add derived addresses to the wallet POC
- next:
- finalize and merge the wallet POC PR
- Demo and discussion with the team about the C++ current state and moving forward
## July 18 (Mon)
**Anthony**
- current:
- Adding test for add watch only account
- next:
- need new task. should I continue to write test?
**Stefan**
- current: Wallet UI POC [WIP PR #6478](https://github.com/status-im/status-desktop/pull/6478)
- Create wallet account after onboarding works
- Have issues creating an account after logging in
- `generateAccountWithDerivedPath` fails with "account already exists"
- tried `loginWithConfig` and have the same result
- investigated the NIM code and found that there are two flows
- one creates an account with `getDerivedAddressesForPath`
- and the other without. This one fails in the same manner but the corner case is hard to reach by user, still I can reproduce in the UI
- found another failing corner case
- next:
- finalize and merge the wallet POC PR
- Demo and discussion with the team about the C++ current state and moving forward
**Khushboo**
- done:
- current:
- [#5725](https://github.com/status-im/status-desktop/issues/5725): adapt view for settings as shown during account generation
- [#6196](https://github.com/status-im/status-desktop/issues/6196): Wallet / Send Popup - Can't scroll outside the list of accounts after selecting one
- works on linux , there is an issue with scrolling on Mac. Asking ELina if adding a scrollbar will make it more clear for the user?
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
- Waiting for svgs from carl to solve blurring issue
- next:
- [#6388](https://github.com/status-im/status-desktop/issues/6388): Wallet account generation popup doesn't support tab navigation
- had alook at it for sometime. rather tricky.
- [#6474](https://github.com/status-im/status-desktop/issues/6474): Crash when staying on Advanced screen for ~30 minutes
**Sale**
- current:
- [Issue-6473](https://github.com/status-im/status-desktop/issues/6473) - Onboarding/Login flow improvements - started with implementation (affected areas login, onboarding, startup modules)
- (temporary postponed till I finish Issue-6473) [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard - done
- Create account using existing keys from keycard - done
- login with keycard
## July 15 (Fri)
**Anthony**
- done:
- Fix test for linux
- multi transaction => now need to plug in Khusboo UI
- current:
- Adding test for add watch only account
**Khushboo**
- done:
- [#6056](https://github.com/status-im/status-desktop/issues/6056): The asset name is overlapped by an arrow
- need to check if the widget itself needs updating as it looks different in design
- [#6320](https://github.com/status-im/status-desktop/issues/6320): The 'Receive' pop-up doesn't look good in the minimized window
- discussed this in desktop-ui channel and will try out an approach next
- [#6196](https://github.com/status-im/status-desktop/issues/6196): Wallet / Send Popup - Can't scroll outside the list of accounts after selecting one
- current:
- [#6196](https://github.com/status-im/status-desktop/issues/6196): Wallet / Send Popup - Can't scroll outside the list of accounts after selecting one
- works on linux , there is an issue with scrolling on Mac. Looking at it now
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
- Waiting for svgs from carl to solve blurring issue
- [#5725](https://github.com/status-im/status-desktop/issues/5725): adapt view for settings as shown during account generation
- design needs to be finalized first. discussion with Carl ongoing.
- next:
- [#6388](https://github.com/status-im/status-desktop/issues/6388): Wallet account generation popup doesn't support tab navigation
- had alook at it for sometime. rather tricky.
- check the crash Nastya is facing.
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard - done
- Create account using existing keys from keycard - in progress - almost done - need to finish wrong PUK flow here
- login with keycard
**Stefan**
- done: fixed leftovers from the previous [PR](https://github.com/status-im/status-desktop/pull/6326)
- current/next:
- Working on wallet UI POC
## July 13 (Wed)
**Khushboo**
- done:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- fixed crash and fixed review comments
- [#6059](https://github.com/status-im/status-desktop/issues/6059): Wallet icon background color seems off in wallet settings
- current:
- [#6056](https://github.com/status-im/status-desktop/issues/6056): The asset name is overlapped by an arrow
- need to check if the widget itself needs updating as it looks different in design
- [#6320](https://github.com/status-im/status-desktop/issues/6320): The 'Receive' pop-up doesn't look good in the minimized window
- discussed this in desktop-ui channel and will try out an approach next
- [#6386](https://github.com/status-im/status-desktop/issues/6386): QR network picker style is a bit off
- Waiting for svgs from carl to solve blurring issue
- next:
- pick next task from list
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard - done
- Create account using existing keys from keycard - in progress - have some issues here
- login with keycard
**Stefan**
- had a sick day
- done:
- finalized the wallet API [in review PR ](https://github.com/status-im/status-desktop/pull/6326)
- current/next:
- working on wallet UI POC
- I will have the first half day off tomorrow
## July 11 (Mon)
**Anthony**
- done:
- Fix estimating time for a tx to happen
- current:
- Grouped transaction
- [X] Create table for grouped transaction
- [X] New API endpoing to create grouped transaction
- [ ] Integration with status-desktop, replacement for send transaction WIP
- [ ] Status-desktop UI on send transaction
- [ ] Status-desktop UI on activities
**Khushboo**
- done:
- current:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- found a weird crash when fixing review comment changes and working on resolving that. I did not see it before when I was working on it, I think a rebase on master caused this
- Found a different crash and reported it, Jo is working on it
- [#6320](https://github.com/status-im/status-desktop/issues/6320): The 'Receive' pop-up doesn't look good in the minimized window
- next:
- pick next task from list
**Stefan**
- done:
- found and fix the root cause for account creation APIs failing [missing line](https://github.com/status-im/status-desktop/blob/3715c9b7f985ae4a76c9773fa28b66a26a9a086a/libs/Onboarding/src/Onboarding/Accounts/AccountsService.cpp#L99) due to wrong requirements/understanding
- finished status-go POC API wrapper [in review PR #6326](https://github.com/status-im/status-desktop/pull/6326)
- Wasted some time debugging why account deletion test fails and traced it to the issue reported here [comment in status-go PR #2703](https://github.com/status-im/status-go/commit/3dee94e50548c091c7c9869a7e126fbb39e715bd#r78203102)
- next:
- finalize TODOs on the API then continue with wallet presentation-layer POC
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard
- Create account using existing keys from keycard
- login with keycard
## July 8 (Fri)
**Anthony**
- done:
- Fix estimating time for a tx to happen
- current:
- Grouped transaction
- [ ] Create table for grouped transaction WIP
- [ ] New API endpoing to create grouped transaction
- [ ] Integration with status-desktop, replacement for send transaction
- [ ] Status-desktop UI on send transaction
- [ ] Status-desktop UI on activities
**Khushboo**
- done:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- [x] fixing some mismatches in the current implementation and desired design
- [x] Using StatusCard and imeplemting the dyanamic arrow drawing
- [x] Finding a way to display hasGas and balance on chain for each token
- [x] Implement all the error states (In progress)
- [x] Fix other bugs on Send Modal reported by Igor
- [x] Add BE code to calculate new suggested route when one of them is disabled
Should be done today.
- [#6257](https://github.com/status-im/status-desktop/issues/6257): 'Generate an account' dialog doesn't look good
- current:
- fix review comments for the SendModal task
- next:
- need new task
**Stefan**
- done: addressed more reports and and finally merged the login PR
- current/next: working to have `generateAccountWithDerivedPath` working
- I always encounter error `cannot retrieve a valid key for a given account: no key for given address or file`
- Tried and checked a lot of debugging ideas from team but without success
- Now I'm looking trough the existing login code and check against the NIM version and see if there are some inconsistencies that might affect only account generation. Found and fixed few already but without success.
- I'm not debugging node configuration that seems to miss some fields that are in the NIM version
## July 6 (Wed)
**Anthony**
- done:
- Fix for message missing when joining a community
- Very general fix, in waku V1, so potentialy a fix for most of message missing
- Also we should look at the bloom filter for machine being slow
- current:
- Fix estimating time for a tx to happen
- Algo is totally off all the time (compared with metamask and others)
- Don t work for non EPI1559 chain (e.g arbitrum/optimism) => cause a crash
- Is in desktop rather than status-go
=> trying to fix all of those
- next:
- need new ticket
**Khushboo**
- done:
- current:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- [x] fixing some mismatches in the current implementation and desired design
- [x] Using StatusCard and imeplemting the dyanamic arrow drawing
- [x] Finding a way to display hasGas and balance on chain for each token
- [ ] Implement all the error states (In progress)
- [ ] Fix other bugs on Send Modal reported by Igor
- [x] Add BE code to calculate new suggested route when one of them is disabled
Should be done today.
- next:
- [#6257](https://github.com/status-im/status-desktop/issues/6257): 'Generate an account' dialog doesn't look good
**Stefan**
- done: fix outstanding issues on the login PR
- CI fails compiling status-go, will disable for now
- current/next: status-go wrapper for wallet [WIP PR #6326](https://github.com/status-im/status-desktop/pull/6326)
- Defined API parsing rules
## July 4 (Mon)
**Anthony**
- done:
- Display balance for network (waiting for multi network to be pushed)
- current:
- Missing messages after joining community
- I can reproduce but I don t identify the problem yet
- next:
- [BLOCKED] scan QR code (I send back the laptop for repair)
- need new ticket
**Khushboo**
- done:
- current:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- [x] fixing some mismatches in the current implementation and desired design
- [x] Using StatusCard and imeplemting the dyanamic arrow drawing
- [x] Finding a way to display hasGas and balance on chain for eahc token (In progress)
- [ ] Implement all the error states
- [ ] Fix other bugs on Send Modal reported by Igor
- [ ] Add BE code to calculate new suggested route when one of them is disabled
Taking longer than anticipated!
- next:
- [#6257](https://github.com/status-im/status-desktop/issues/6257): 'Generate an account' dialog doesn't look good
**Stefan**
- current: merged base PRs and follow up on the remaining reviews
- next: finish status-go wrapper for wallet [WIP PR #6326](https://github.com/status-im/status-desktop/pull/6326)
## July 1 (Fri)
**Anthony**
- done:
- mvp multi network: waiting for release to build
- Display ETH/SNT/DAI even if balance == 0
- current:
- Display balance for network (waiting for multi network to be pushed)
- Missing messages after joining community
**Stefan**
- done: fixed CI and merged most of the PRs except [PR #5952](https://github.com/status-im/status-desktop/pull/) blocked and [PR #6157](https://github.com/status-im/status-desktop/pull/6157) which require fixing after refactoring
- current:
- working towards wallet POC [WIP PR #6326](https://github.com/status-im/status-desktop/pull/6326)
- Validated `getAccounts` work in a test
- next: fix and merge remaining PRs and continue wallet POC
**Khushboo**
- done: [#6289](https://github.com/status-im/status-desktop/pull/6289): Removed the condition that was causing the chat highlight animation to run each time it was visible
- current:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- next:
- [#6257](https://github.com/status-im/status-desktop/issues/6257): 'Generate an account' dialog doesn't look good
## June 29 (mon)
**Anthony**
- done:
- MVP for multi network
- [X] Fix send tx modal, was broken due to latest change on estimation
- [X] Estimation takes in consideration the chain
- [X] Remove multi network toggle
- [X] Remove current network id usage
- [X] Transaction history shows tx for all enabled chains
- [X] Check recent history multi network
- [X] Browser network consideration
I expect to come back to this one after QA as there is many changes
- Fix send modal amount input (fixed was already done by Khusboo :( )
- current:
- Display ETH/SNT/DAI even if balance == 0
- Display balance for network
- next:
- scan QR code (my laptop charger just died, i don t have camera on my desktop, waiting for new one)
**Khushboo**
- done: NA
- current:
- [#6268](https://github.com/status-im/status-desktop/issues/6268): Implement the advanced view with simple same network transfers
- Added the disbaled and low balance states for the StatusCard
- implementing the new flows currently (advanced + custom)
- next:
- Need new task
**Stefan**
- done: Follow PRs review and prepare first tree for merging [#5754](https://github.com/status-im/status-desktop/pull/5754), [#6011](https://github.com/status-im/status-desktop/pull/6011), [#5910](https://github.com/status-im/status-desktop/pull/5910)
- current:
- CPP - Create/login POC using vanilla UI [WIP PR #6157](https://github.com/status-im/status-desktop/pull/6157)
- next:
- CPP - use the NIM clone of Wallet as a base to Wallet POC
## June 27 (mon)
**Anthony**
- done:
- Add telemetry waku version dimension
- [X] Status-go
- [X] Telemetry service
- Update python test with typing
- current:
- MVP for multi network
- [X] Fix send tx modal, was broken due to latest change on estimation
- [ ] Estimation takes in consideration the chain
- [X] Remove multi network toggle
- [ ] Remove current network id usage => in progreess
- [ ] Transaction history shows tx for all enabled chains
- [X] Check recent history multi network
- [ ] Browser network consideration
**Khushboo**
- done:
- current:
- [#6228](https://github.com/status-im/status-desktop/issues/6228): Using Floating Buttons in the Send Modal - Almost done. Fixing small issues found on SendModal Page
- next:
- Need new task
**Stefan**
- done:
- cleanup the C++ PR to have them reviewd and merged, taking a lot of effort to maintain them
- built a test for status-go startMessenger crash and validated that it work for C++ integration
## June 24 (Fri)
**Anthony**
- done:
- Address selector broken in send modal
- Fix toggle on node type back to normal
- suggestion for adding type hint to python (a PR has been done)
- current:
- Add telemetry waku version dimension
- [X] Status-go
- [ ] Telemetry service in progress
**Stefan**
- done:
- fixed all the encountered issues and have an end to end test working to create account; Updated [WIP PR #6157](https://github.com/status-im/status-desktop/pull/6157)
- The DB issue was due to missing uninitialized keystore. Explicitly initialize where it is needed (before creating account)
- SignalManager fixes
- Incomplete API
- current
- CPP - Finish minimal login POC by integrating business logic with UI [WIP PR #6157](https://github.com/status-im/status-desktop/pull/6157)
- next:
- CPP - understand the wallet POC minimal requirements and start from scratch
**Khushboo**
- done:
- [#582](https://github.com/status-im/StatusQ/issues/582): Resume Networks Component
- Created StatusCard in StatusQ
- Write a function in StatusQ Utils for drawing arrows
- in the StatusQ demo page for StatusCard, demonstrated how to implment the network routing.
- current:
- [#6228](https://github.com/status-im/status-desktop/issues/6228): Using Floating Buttons in the Send Modal
- next:
- Need new task
**Sale**
- done:
- Issue-6189 - contact request accepted but not reflected on sender's side - was investigating a lot, discussed with Richard and Cammellos, it's a bug which is happening only in local if you're running two app instances, one of them cannot locate peers in that case so signal when one "accept contact request" is not broadcasted, discussed in `status-go` channel
- Issue-6167 - Sometimes joining a community has blank channels on the sidebar - cannot reproduce at all after last rebase to `dogfooding/phase4`, commit `95326620c`
- current:
- Reviewing basic cpp PR#5754 (prepared new draft PR with potential improvement while I am reviewing it)
- next:
- vacation for 2 weeks
## June 22 (wed)
**Anthony**
- done:
- Bring back download messages
- current:
- Address selector broken in send modal
- next:
- Add telemetry waku version dimension
**Khushboo**
- done: was on sick leave
- current:
- [#582](https://github.com/status-im/StatusQ/issues/582): Resume Networks Component, working with canvas to draw arrows, next figure out how to draw them dynamically.
- next: ^
**Sale**
- done:
- Issue-6170 - [PR#6180](https://github.com/status-im/status-desktop/pull/6180) - intermittent with community invites
- Issue-5935 - [PR#6178](https://github.com/status-im/status-desktop/pull/6178), [StatusQ-PR#737](https://github.com/status-im/StatusQ/pull/737) - nothing happens after clicking on any notification
- Issue-5923 - [PR#6176](https://github.com/status-im/status-desktop/pull/6176) - filter paid stickers if the wallet is not enabled
- Multiple issues - [PR#6178](https://github.com/status-im/status-desktop/pull/6156):
- Issue#6131 - Channel is blank on first time joining
- Issue#6139 - Contacts list is empty when trying to invite/share community
- Issue#6105 - The same name is shown for all invited contacts
- Issue#6084 - The names and avatars of contacts are empty in the Contact requests
- Issue#6106 - 'Invite friends' dialog doesn't look good in the minimized app mode
- current:
- Issue-6167 - Sometimes joining a community has blank channels on the sidebar
**Stefan**
- done:
- Investigate and fixed build error encountered yesterday [details PR #6202](https://github.com/status-im/status-desktop/pull/6202)
- Long story short - mainly a coincidence of deleting the tmp folder content for testing purpuses, expired token and build not reporting the failure
- Test case run outcome [#6203](https://github.com/status-im/status-desktop/issues/6203)
- current/next:
- CPP - Minimal login POC [WIP PR #6157](https://github.com/status-im/status-desktop/pull/6157)
- Fixed more errors in creating accounts but still get "failed to initialize db package=status-go/api.GethStatusBackend err="unable to open database file""
## June 20 (mon)
**Anthony**
- done:
- Fix community bubble
- Fix image placeholder when message is coming from mobile
- current:
- new bug?
- next:
- finalize making multinetwork fully ready
**Stefan**
- done: Porting the old C++ code
- current:
- CPP - Minimal login POC [WIP PR #6157](https://github.com/status-im/status-desktop/pull/6157)
- The login Controller fails to setup account, fixed the first root cause: missing keystore initialization
## June 17 (Fri)
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic
- Create account using new keys - done
- Import seed phrase into a new keycard
- Create account using existing keys from keycard
- login with keycard
- @iuri would be good to sort out onboarding + login flow along with this or as a separate issue, but anyhow the current state of that part is very messy and hard for maintaining
- next:
- Review c++ - PR#5676, PR#5952
- Start working on c++ app, wallet or some other part
**Khushboo**
- done:
- Got the Receive modal merged.
- [#6091](https://github.com/status-im/status-desktop/issues/6091): Coins balance is copypasted
- current:
- [#582](https://github.com/status-im/StatusQ/issues/582): Networks Component
- next: ^
**Stefan**
- done: Qt conference
- current:
- CPP - Minimal login POC [#6028](https://github.com/status-im/status-desktop/issues/6028)
- Ported the previous code to the new structure, now refactoring to have login working and proceed with wallet part
- next:
- CPP - wallet module POC
## June 15 (Wed)
**Khushboo**
- done:
- current:
- [#582](https://github.com/status-im/StatusQ/issues/582): Networks Component
- Completed card component
- Checking how to implement arrows connecting the cards. Thought of a static way which would be simpler and fast, but will need update everytime we support a new network.
- next:
- ^
## June 13 (Mon)
**Khushboo**
- done:
- [#6013](https://github.com/status-im/status-desktop/issues/6013): Wallet balance is 0 when enabling multinetwork toggle
- [#5735](https://github.com/status-im/status-desktop/issues/5735):Multichain QR Code - Resolve all review comments
- [#6057](https://github.com/status-im/status-desktop/issues/6057): Update multi network selection list
- current:
- [#582](https://github.com/status-im/StatusQ/issues/582): Networks Component
- next:
- ^
## June 10 (Fri)
**Anthony**
- current:
- Make multinetwork the only way
- [X] multinetwork toggle removed
- [X] Remove old UI for network selection
- [X] Remove old call to get network
- [X] TX history multinetwork
- [X] Contact service multinetwork
- [X] Node configuration multinetwork
- [ ] Transaction receipt multinetwork
**Sale**
- current:
- [Issue-6004](https://github.com/status-im/status-desktop/issues/6004) - [PR#6050](https://github.com/status-im/status-desktop/pull/6050) - messages sometimes assigned to the wrong user - within this issue, inserting and removing message is handled in a way that they are taking into consideration first message beneath and resolve its header (the same as in Discord now)
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic - onboardin new user flow - new keys
- next:
- Review c++ - PR#5676, PR#5952
- Start working on c++ app, wallet or some other part
**Stefan**
- done:
- CPP - CI integration [WIP PR #6011](https://github.com/status-im/status-desktop/pull/6011)
- Fixed some jenkins integration issues
- crrent:
- CPP - Minimal login POC [#6028](https://github.com/status-im/status-desktop/issues/6028)
- Dropped redesigning following module approach and started migrating the current structure [1487b5](https://github.com/status-im/status-desktop/commit/1487b5d61ecfda932cc2c5a898e0c348877e9d92)
- note:
- won't be available Monday-Wednesday next week
- next:
- CPP - wallet module POC
## June 8 (Wed)
**Anthony**
- done:
- Send transaction modal (Tested, waiting for mobile team to test status-go)
- current:
- Transaction history multi network
- I will also remove multi network toggle here
**Khushboo**
- done:
- [#5735](https://github.com/status-im/status-desktop/issues/5735):Multichain QR Code
- current:
- [#6013](https://github.com/status-im/status-desktop/issues/6013): Wallet balance is 0 when enabling multinetwork toggle
- next:
- [#5735](https://github.com/status-im/status-desktop/issues/5735):Multichain QR Code - Resolve all review comments
- need new task
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3), `StatusQ` [PR#717](https://github.com/status-im/StatusQ/pull/717) - Keycard Epic - onboardin new user flow - new keys
- next:
- Review c++ - PR#5676, PR#5952
- Start working on c++ app, wallet or some other part
**Stefan**
- done:
- CPP - CI integration [WIP PR #6011](https://github.com/status-im/status-desktop/pull/6011)
- Dropped finalizing it due to slow moving forward with Jenkins integration
- crrent:
- CPP - Minimal login POC [#6028](https://github.com/status-im/status-desktop/issues/6028)
- next:
- CPP - wallet module POC
## June 6 (mon)
**Anthony**
- current:
- back to transaction, there was a few thing not being handle well
- [X] Arbitrum crash go-ethereum code !!!!
- [X] Showing all token with total balance in send modal popup without considering enable network
- [X] Gas Validator updated based on chain ids of the token
- [X] Gas selector updated to handle case where we can go from network with EIP1559 enabled or not on the fly
- [X] Move detection of EIP1552 in status-go via suggested fees endpoint
- [X] UI: make an horizontal scroll bar for networks (Noelia is helping)
- [X] Browser needs a single network, using mainnet/ropsten depending on the toggle
- [ ] Test/Fix SNT/Stickers/Chat transaction
**Stefan**
- current:
- CPP - CI integration [#5676](https://github.com/status-im/status-desktop/issues/5676)
- experimenting with Qt6 dependencies to find a working setup base
- next:
- CPP - start wallet module POC
**Sale**
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - `status-desktop` [PR#6000](https://github.com/status-im/status-desktop/pull/6000) `status-keycard-go` [PR#1](https://github.com/status-im/status-keycard-go/pull/1) `nim-keycard-go` [PR#3](https://github.com/status-im/nim-keycard-go/pull/3)- Keycard Epic - setting up new `nim-keycard-go` and `status-keycard-go` lib
- next:
- Review c++ - PR#5676, PR#5952
- Start working on c++ app, wallet or some other part
## June 3 (fri)
**Anthony**
- current:
- back to transaction, there was a few thing not being handle well
- [X] Arbitrum crash go-ethereum code !!!!
- [X] Showing all token with total balance in send modal popup without considering enable network
- [X] Gas Validator updated based on chain ids of the token
- [X] Gas selector updated to handle case where we can go from network with EIP1559 enabled or not on the fly
- [X] Move detection of EIP1552 in status-go via suggested fees endpoint
- [ ] UI: make an horizontal scroll bar for networks (Noelia is helping)
- [ ] Test/Fix SNT/Stickers/Chat transaction
- [ ] Browser needs a single network, not sure what to do here?
**Stefan**
- done:
- CPP - main window layout [in review PR #5952](https://github.com/status-im/status-desktop/pull/5952)
- current:
- CPP - CI integration [#5676](https://github.com/status-im/status-desktop/issues/5676)
- next:
- CPP - start wallet module POC
**Sale**
- done:
- Issue-5398 - [PR#5980](https://github.com/status-im/status-desktop/pull/5980) - estimated time for transaction is always Unknown
- Issue-5445 - [PR#5992](https://github.com/status-im/status-desktop/pull/5992) - 18 words seed option is missing when adding an account in wallet
- chore, removed some unused files
- current:
- [Issue-5972](https://github.com/status-im/status-desktop/issues/5972) - Keycard Epic
- next:
- Review c++ - PR#5676, PR#5952
- Start working on c++ app, wallet or some other part
## June 1 (Wed)
**Stefan**
- done:
- chased and solved conflicts with [overlapping PR](https://github.com/status-im/status-desktop/pull/5852)
- current:
- working on CPP - main window layout [Draft PR #5952](https://github.com/status-im/status-desktop/pull/5952)
- next:
- CPP work basic CI & Testing
**Anthony**
- done:
- ENS/Stickers ready for multi network
- Check update ready for multi network
- Fix send modal after latest change to token
- current:
- Multi network for contact/node configuration
- Send transaction PR needs update after all changes to the token. + a weird bug which appears only with test network
**Sale**
- done:
- Issue-5914 - [PR#5936](https://github.com/status-im/status-desktop/pull/5936) - need empty screen for “DApp Permissions” screen
- Issue-3375 - app support for status-im:// URIs - mac - completed, merged
- current:
- Issue-5398 - Estimated time for transaction is always Unknown
- next:
- Need to review c++ PR#5676
- Want to start working on c++ app
## May 30 (Mon)
**Anthony**
- done:
- Add network image + align network naming with design
- ENS/Stickers ready for multi network
- current:
- Test feedback on send transaction pr
- next:
- Make the rest of the app multi network ready: contact/about/browser/... everything that touch the network => we can then remove the multi network toggle?
**Sale**
- done:
- Issue-5859 - [PR#5863](https://github.com/status-im/status-desktop/pull/5863) - added support for browser wallet
- Issue-5914 - [PR#5863](https://github.com/status-im/status-desktop/pull/5914) - settings -> Browser, connected dapps items do not follow figma
- rebased Feat/uri support mac again
- current:
- continue with the issues from UI meeting
- next:
- review c++ PR#5676
**Stefan**
- done:
- Started status-go integration to test the arm: [WIP PR #5910](https://github.com/status-im/status-desktop/pull/5910)
- current:
- working on CPP - main window layout [#5902](https://github.com/status-im/status-desktop/issues/5902)
- next:
- CPP - basic tests for status-go integration
## May 27 (Friday)
**Sale**
- done:
- Issue-5859 - [PR#5863](https://github.com/status-im/status-desktop/pull/5863) - show all tokens in wallet that have balance > 0 (it's a bigger change), after rebasing I had to add aggregating token balance across chains (previously done by Anthony)
- rebased few obsolete PRs (status-go and status-desktop) since there were a lot of changes in meantime which produced a lot of conflicts
- current:
- Issue-5906 - Settings -> Browser, connected dapps items do not follow figma - covers 3 issues form the notes from the last UI meeting (issues 13, 14, 15)
- next:
- review c++ PR#5676
**Stefan**
- done:
- Finished cropping editor for community logo editing in the new edit view [in review PR #5404](https://github.com/status-im/status-desktop/issues/5404)
- Implemented banner tests in status-go
- One vacation day
## May 25 (wed)
**Anthony**
- done:
- Multinetwork transaction in send modal
- [X] Routing to detect possible network
- [X] Fetch data from backend
- [X] Send transaction with chain id params
- [X] UI
- Mostly done, I need to make it looka bit nicer
- [X] Speed is slow, makes request async, use debounce
- [X] Ensure all type of transaction keep working
- Aggregate amount per token
- current:
- Closing the gap (fixing problem) for making multi network the complete and being able to remove the toggle
- [] ENS/Stickers multinetwork
**Stefan**
- done:
- vacation day
- follow up on review of banner backend support [in review PR #5437](https://github.com/status-im/status-desktop/pull/5437)
- auto resize if copped banner is bigger than allowed
- optimized resizing when cropping is smaller
- follow up with image quality tests to asses optimal parameters
- small improvements
- current: Use cropping editor for community logo editing in the new edit view [#5404](https://github.com/status-im/status-desktop/issues/5404)
- next:
- Will have free half-days after noon tomorrow and day after
- building banner tests
- Editing profile picture using crop editor - [#5322](https://github.com/status-im/status-desktop/issues/5322)
**Sale**
- done:
- Issue-5856 - [PR#5857](https://github.com/status-im/status-desktop/pull/5857) - remove the Manage Assets & Lists functionality from Settings/Wallet
- current:
- Issue-5859 - [PR#5863](https://github.com/status-im/status-desktop/pull/5863) - show all tokens in wallet that have balance > 0 (it's a bigger change)
- next:
- review c++ PR#5676
## May 23 (Mon)
**Anthony**
- current:
- Multinet network "simple" transaction
- [X] Routing to detect possible network
- [X] Fetch data from backend
- [X] Send transaction with chain id params
- [] UI
- Mostly done, I need to make it looka bit nicer
- [ ] Speed is slow, makes request async, use debounce
- [ ] Ensure all type of transaction keep working
The feature is working but need improvement now: e.g tx made with multi network:
https://ropsten.etherscan.io/tx/0xe4946bcd8d12a79cbfad6d608a37bc86057be90266e25690b24d5699cbc95e08 :joy_cat:
- next:
- Aggregate amount per token rather than per network + token
**Stefan**
- finshed:
- banner in new edit community settings view [in review PR #5437](https://github.com/status-im/status-desktop/pull/5437)
- banner backend support [in review PR #2687](https://github.com/status-im/status-go/pull/2687)
- StatusQ fix [in review PR #685](https://github.com/status-im/StatusQ/pull/685)
- current: Use cropping editor for community logo editing in the new edit view [#5404](https://github.com/status-im/status-desktop/issues/5404)
- next:
- Will have a free day tomorrow, still with spotty availability
- Editing profile picture using crop editor - [#5322](https://github.com/status-im/status-desktop/issues/5322)
- ~~Should I refactor the new community modal? [#5840](https://github.com/status-im/status-desktop/issues/5840)~~
- Continue C++ base refactoring
**Sale**
- done:
- Issue-5649 [PR#2669](https://github.com/status-im/status-go/pull/2669) - Move notifications settings to `status-go` - this was initially done, but for the `status-go` part I have to crate new table just for storing notifications settings data instead of doing that in a new column, discussed [here](https://github.com/status-im/status-go/pull/2669#discussion_r869598466)
- [PR#5849](https://github.com/status-im/status-desktop/pull/5849) - crash enabling/disabling communities
- current:
- starting with wallet issues from the list created on last UI meeting
- next:
- review c++ PR#5676
## May 20 (Fri)
**Anthony**
- current:
- Multinet network "simple" transaction
- [X] Routing to detect possible network
- [X] Fetch data from backend
- [ ] UI
- [ ] Send transaction with chain id params
**Sale**
- done:
- [Issue-5765](https://github.com/status-im/status-desktop/issues/5765) - [PR#5785](https://github.com/status-im/status-desktop/pull/5785) - changing username is not immediately updating
- [Issue-5668](https://github.com/status-im/status-desktop/issues/5668) - [PR#5812](https://github.com/status-im/status-desktop/pull/5812) - [very hard to replicate] 1 to 1 chat window contains messages from other contacts
- current:
- Issue-5649 - Move notifications settings to `status-go` - this was intially done, but for the `status-go` part I have to crate new table just for storing notifications settings data instead of doing that in a new column, discussed [here](https://github.com/status-im/status-go/pull/2669#discussion_r869598466)
**Stefan**
- current: Working to finalize banner implementation [#5403](https://github.com/status-im/status-desktop/issues/5403)
- next: CPP refactoring - setup window layout [PR #5754](https://github.com/status-im/status-desktop/pull/5754)