# Wallet - Archive January 13 2021 - May 18 2021 ## May 18 (Wed) **Khushboo** - done: - [#5700](https://github.com/status-im/status-desktop/issues/5700): add custom derivation path : Fix the crash Nastya found - [#5765](https://github.com/status-im/status-desktop/issues/5765): changing username is not immediatly updating - closed and merged and pending derivation path PR's - tested [#5164](https://github.com/status-im/status-desktop/issues/5164): Contact state isn't properly updated in chat tool bar, tested with Sales PR and it is fixed by that. - current: - [#5735](https://github.com/status-im/status-desktop/issues/5735): Multichain QR Code, almost ready, needs clean up + check if new Qr for each network prefix is generated - next: ^ **Anthony** - done: - Fix adding channel to category - Fix seting pubkey - Fix dont show edit message on only emoji message type - Fix do not display date in load more if there is no previous load - Fix image don t overlap with placeholder - current: - Invite modal hide already contact - next: - new bug or multi network tx **Stefan** - current: Advanced and addressed reviews for CPP refactoring [PR #5754](https://github.com/status-im/status-desktop/pull/5754) - next: Finalize banner implementation [#5403](https://github.com/status-im/status-desktop/issues/5403) **Sale** - done: - [Issue-5803](https://github.com/status-im/status-desktop/issues/5803) - [PR#5807](https://github.com/status-im/status-desktop/pull/5807) - timestamps are constant - [Issue-5767](https://github.com/status-im/status-desktop/issues/5767) - [PR#5778](https://github.com/status-im/status-desktop/pull/5778) - adding a contact with chat key should not immediatly open a 1 on 1 chat or should block input - [Issue-5763](https://github.com/status-im/status-desktop/issues/5763) - touch id issues - checked, commented - code reviews - Issue-5786 -[PR#5797](https://github.com/status-im/status-desktop/issues/5797) - member list is empty when joining a community one is not an admin of - current: - [Issue-5668](https://github.com/status-im/status-desktop/issues/5668) - [very hard to replicate] 1 to 1 chat window contains messages from other contacts - next: - Issue-5649 - Move notifications settings to `status-go` - this was intially done, but for the `status-go` part I have to crate new table just for storing notifications settings data instead of doing that in a new column, discussed [here](https://github.com/status-im/status-go/pull/2669#discussion_r869598466) ## May 16 (Mon) :100: **Anthony** - current: - Scan QR code: - [X] Button/Popup - [ ] Filter qrcode (##IN PROGRESS##) - [ ] modal aligned with design - [ ] ask permission modal - [ ] Interpret qr code **Stefan** - done: clarified all the Qt6 CMake API issues faced and found alternative workarounds [PR #5754](https://github.com/status-im/status-desktop/pull/5754) - current/next: continue with CPP refactoring [#5676](https://github.com/status-im/status-desktop/issues/5676) **Sale** - done: - [Issue-5714](https://github.com/status-im/status-desktop/issues/5714) - `status-desktop`[PR#5749](https://github.com/status-im/status-desktop/pull/5749) `status-go`[PR#2675](https://github.com/status-im/status-go/pull/2675) - Add support for Arbitrum L2, added optimism test network as well - Issue-5721 [PR#5750](https://github.com/status-im/status-desktop/pull/5750) - wrong screen is shown when claiming tokens in simpledapp.eth - current: - Issue-5649 - Move notifications settings to `status-go` - this was intially done, but for the `status-go` part I have to crate new table just for storing notifications settings data instead of doing that in a new column, discussed [here](https://github.com/status-im/status-go/pull/2669#discussion_r869598466) **Khushboo** - done: - [#5508](https://github.com/status-im/status-desktop/issues/5508): Activity Centre's Activity tool tip is slightly off - current: - [#5700](https://github.com/status-im/status-desktop/issues/5700): add custom derivation path : Fix the crash Nastya found - [#5735](https://github.com/status-im/status-desktop/issues/5735): Multichain QR Code - next: ^ ## May 13 (Fri) 💀 **Anthony** - done: - Merging/Rebasing PRs - Remove # in front of placeholder new/edit channel - Specs for Send/Swap/Bridge ready for review - current: - Investigate flakey test in join communities - Adding a filter to scan qr code **Stefan** - done: - Investigated no profile set issue, seems taht it might be a migration issue [#5701](https://github.com/status-im/status-desktop/issues/5701) - Helped with testing randon PR was inneficient - current: experiment with new Qt6 CMake APIs **Sale** - done: - rebsed following obsolete PRs (including PRs of their submodules): - https://github.com/status-im/status-desktop/pull/5706 - https://github.com/status-im/status-desktop/pull/5648 - https://github.com/status-im/status-desktop/pull/5334 - https://github.com/status-im/status-desktop/pull/5087 - tried to fix tests issues, and fixed some issues, but there are more and more test issues appearing, not releted to my initial changes, commented [here](https://github.com/status-im/status-go/pull/2672#issuecomment-1125766117) (asked for help) - current: - [Issue-5714](https://github.com/status-im/status-desktop/issues/5714) - Add support for Arbitrum L2 **Khushboo** - done: - [#5453](https://github.com/status-im/status-desktop/issues/5453): Complete work for derivation path - Update the add account with private key flow [#5699](https://github.com/status-im/status-desktop/issues/5699) - add custom derivation path [#5700](https://github.com/status-im/status-desktop/issues/5700): In progress, discussing some ambigous things with carl - [#5013](https://github.com/status-im/status-desktop/issues/5013): Can't sign in to Cryptokitties (sing a message to dapp) - current: - next: - need new task! ## May 11 (wed) **Anthony** - current: - Specs for send/swap/bridge - Scan QR code **Sale** - done: - Issue-5473 [PR#5706](https://github.com/status-im/status-desktop/pull/5706) - redesigned wallet addresses are missing checksum - Issue-5649 [PR#5697](https://github.com/status-im/status-desktop/pull/5697) - Move notifications settings to status-go - Helped Pascal with the community edit issue he had - Code reviews - current: - About to start working on adding new table only for notificaitons settings as it is discussed [here](https://github.com/status-im/status-go/pull/2669#discussion_r869542156) is that ok? - next: - C++ app? My allocation there? - Issue-4920 - Keycard settings screen & functionality using status-keycard-go **Khushboo** - done: - [#5655](https://github.com/status-im/status-desktop/issues/5655): show appropriate activity in derived addresses list (has activity/ no activity) - solved review comment for concurrency when fetching derived addresses - current: - add custom derivation path [#5700](https://github.com/status-im/status-desktop/issues/5700): In progress, discussing some ambigous things with carl - next: - [#5453](https://github.com/status-im/status-desktop/issues/5453): Complete work for derivation path - Update the add account with private key flow [#5699](https://github.com/status-im/status-desktop/issues/5699) - adapt similar view for settings **Stefan** - in review: - Fix slider grab [PR #665](https://github.com/status-im/StatusQ/pull/665) - Limit zoom to fill image in image cropper control [PR #666](https://github.com/status-im/StatusQ/pull/666) - in progress: C++ base: [cpp branch](https://github.com/status-im/status-desktop/tree/cpp) - next: back with focus on C++ work ## May 9 (Mon) **Anthony** - done - Keep doing fixing issues as well as dealing with PR feedback - Redo the work for the keystore with a more robust solution - current: - keep fixing issues **Sale** - done: - Issue-5650 [PR#5670](https://github.com/status-im/status-desktop/pull/5670) - Settings - content on the right side for all subsections need to have the same geometry - C++ related discussion - current: - Checking/trying to reproduce the issue displaying messages in a wrong chat/channel - next: - C++ app? My allocation there? - Issue-5649 - Move notifications settings to status-go - Issue-4920 - Keycard settings screen & functionality using status-keycard-go **Stefan** - done: - rebased and fixed [conflicting changes](https://github.com/status-im/status-desktop/pull/5550) for onboarding user image [PR #5631] (https://github.com/status-im/status-desktop/pull/5631) - C++ related discussions - in progress: banner status-go implementation: [8aaa4d](https://github.com/stefandunca/status-go/commit/8aaa4d6bcb97fb699a56fe718b3225844d283e46) - next: CPP work? or other assigned tasks? **Khushboo** - done: - [#5655](https://github.com/status-im/status-desktop/issues/5655): show appropriate activity in derived addresses list (has activity/ no activity) - [#656](https://github.com/status-im/StatusQ/issues/656): Button component should keep its original width/size when it enters loading state - [#5633](https://github.com/status-im/status-desktop/issues/5633): Language drop should be right aligned to button - current: - [#5671](https://github.com/status-im/status-desktop/issues/5671): System appearance illustration is wrong. - next: - [#5453](https://github.com/status-im/status-desktop/issues/5453): Complete work for derivation path (Still need some things cleared) ## May 6 (Fry) ** Anthony ** - current: - Keep doing fixing issues as well as dealing with PR feedback - Redo the work for the keystore with a more robust solution ## May 4 (Wed) **Anthony** - current: - Fixing issues from the desktop notes ## April 13 (Wed) **Anthony** - done: - Update account modal close policy - Remove needs for password when adding a watch only account - Fix loading collectible - Disable tx in chat when wallet is disabled - re disable wallet and browser by default - Generate account use correct root address + path - Hide use 24 word in wallet - Fix import same account twice - Fix import mnemonic after private key and vice versa - current: - new get wallet api **Khushboo** - done: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - fixed review comments and merged now - [#5472](https://github.com/status-im/status-desktop/issues/5472): Send modal has a big space when created addresses section is empty - [#5534](https://github.com/status-im/status-desktop/issues/5534): Can't add an address to saved addresses - current: - next: - [#5453](https://github.com/status-im/status-desktop/issues/5453): Complete work for derivation path - [x] show appropriate activity in derived addresses list (has activity/ no activity **(In progress)** - [ ] infinite number of pages in derived addresses list - [ ] move derivation path list once confirmed by carl to status_go - [x] [#5539](https://github.com/status-im/status-desktop/issues/5539): greying out already imported/derived addresses in address list and also choosing next available as default one (Done will raise PR now) - [ ] add custom derivation path (no design available yet?) - [ ] adapt similar view for settings ## April 11 (Mon) **Khushboo** - done: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [#5471](https://github.com/status-im/status-desktop/issues/5471): Re-add adding watch-only address to wallet - current: - [#5472](https://github.com/status-im/status-desktop/issues/5472): Send modal has a big space when created addresses section is empty - next: - [#5453](https://github.com/status-im/status-desktop/issues/5453): Complete work for derivation path - travelling to dubai on Thursday. Friday and Monday are public holidays :) ## April 8 (Fri) - done: - Finalize review on tx fix - keystore directory per account - current: - No validation present when importing the same account **Khushboo** - done: - [#5406](https://github.com/status-im/status-desktop/issues/5406): Can't paste private key of an account - current: - next: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [x] Adding derivation path to generate account api - [x] Creating new backend model for generated accounts and who they are derived from (was stuck here due because of the api's introduced, login and account generation wouldnt work, anthony found the issue :) - [x] trying to derive new accounts from seed and imported keys. Seed works, imported from Private key is not able to derive children from existing api (DESCOPED) - Had many discussions with aAnthiny and Richard about deriveing an account from an imported Private Key, still not clear , needs to be tested out - [x] Solved the issue of derived addresses not matching bip39 (almost done) - [x] retreive a list of address when path selected is changed - [x] Complete flow - [x] Code clean up and raise PR - Pending tasks after PR - [ ] show appropriate activity in derived addresses list (has activity/ no activity) - [ ] infinite number of pages in derived addresses list - [ ] move derivation path list once confirmed by carl to status_go - [ ] greying out already imported/derived addresses in address list and also choosing next available as default one - [ ] add custom derivation path (no design available yet?) ## April 6 (Wed) **Khushboo** - done: - https://github.com/status-im/status-desktop/pull/5370 - current: - next: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [x] Adding derivation path to generate account api - [x] Creating new backend model for generated accounts and who they are derived from (was stuck here due because of the api's introduced, login and account generation wouldnt work, anthony found the issue :) - [x] trying to derive new accounts from seed and imported keys. Seed works, imported from Private key is not able to derive children from existing api (in progress) - Had many discussions with aAnthiny and Richard about deriveing an account from an imported Private Key, still not clear , needs to be tested out - [x] Solved the issue of derived addresses not matching bip39 (almost done) - [ ] retreive a list of address when path selected is changed - [ ] Complete flow **Anthony** - done: - Fix importing mnemonic account and sending tx with it - Fix etherscan link when doing tx - Fix seed phrase on onboarding to allow to enter last word - fix send 0 tx - Fix gas estimate erroring when balance not enought to cover the cost of tx - current: - Crash when using rinkeby - next: - more bugs - continue new wallet api ## April 4 (mon) **Anthony** - done: - help Kushboo about the derivation path - Move visible token to status-go - gas estimation issue - current: - new Wallet API on client side (for ease: visible token first) **Khushboo** - current - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [x] Adding derivation path to generate account api - [x] Creating new backend model for generated accounts and who they are derived from (was stuck here due because of the api's introduced, login and account generation wouldnt work, anthony found the issue :) - [x] trying to derive new accounts from seed and imported keys. Seed works, imported from Private key is not able to derive children from existing api (in progress) - [ ] retreive a list of address when path selected is changed - [ ] Complete flow - next: ^ ## April 1 (Fri) **Khushboo** - current - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [x] Adding derivation path to generate account api - [x] Creating new backend model for generated accounts and who they are derived from - [ ] retreive a list of address when path selected is changed - [ ] Complete flow - next: ^ ## March 30 (Wed) **Khushboo** - done: - [#5073](https://github.com/status-im/status-desktop/issues/5073): New Account Import Modal UI : ALmost done needs clean up. - [#5194](https://github.com/status-im/status-desktop/issues/5194): attempting to download image on a 1 on 1 crashes on mac - [#5123](https://github.com/status-im/status-desktop/issues/5123): In the dark mode, the menu of networks in wallet looks incorrect - current: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [#5234](https://github.com/status-im/status-desktop/issues/5234): Send transaction from an empty account goes through - next: ^ **Anthony** - done: - Fix network serialization - Move post message async - Handle status being nil in sticker - Remove edit account from wallet - current: - wallet api ## March 28 (Mon) **Anthony** - done: - Fix sticker pack view - Rebase and update the rpc call refactor - current: - many call when accessing browser (side effect: slow browser) **Khushboo** - done: - [#5073](https://github.com/status-im/status-desktop/issues/5073): New Account Import Modal UI : ALmost done needs clean up. - current: - [#5194](https://github.com/status-im/status-desktop/issues/5194): attempting to download image on a 1 on 1 crashes on mac - next: - [#5074](https://github.com/status-im/status-desktop/issues/5074): Support for custom derivation paths when creating an account - [#5123](https://github.com/status-im/status-desktop/issues/5123): In the dark mode, the menu of networks in wallet looks incorrect ## March 25 (Fri) **Anthony** - done: - toggle test network (not merged yet cause no tester this week) - Remove eth service (not merged yet cause no tester this week) - Move suggested fee to status-go (not merged yet cause no tester this week) - remove account settings from wallet section (moved to settings section) - Cache price to avoid multiple call - Simplify code for saved address - Fix darkmde for wallet account view in settings - current: - Shared assets view/tx view - Require a quite big refactor on transaction to work well **Khushboo** - done: - [#5037](https://github.com/status-im/status-desktop/issues/5037): User stays on removed account view in wallet after account removal from settings - current: - [#5073](https://github.com/status-im/status-desktop/issues/5073): New Account Import Modal UI - next: ^ ## March 23 (Wed) **Anthony** - done: - toggle test network - Remove eth service - current: - Move suggested fee to status-go: - Fix calculation based on what is happening on mobile - re-enabed the simple UI **Khushboo** - done: - [#5040](https://github.com/status-im/status-desktop/issues/5040): new Send Modal - [#5075](https://github.com/status-im/status-desktop/issues/5075): move action buttons to bottom - current: - [#5037](https://github.com/status-im/status-desktop/issues/5037): User stays on removed account view in wallet after account removal from settings - next: - [#5073](https://github.com/status-im/status-desktop/issues/5073): New Account Import Modal UI ## March 21 (Mon) **Anthony** - done: - toggle test network - Move fetch price to status go - current: - Remove eth service ## March 18 (Fri) **Anthony** - done: - toggle test network - Unlink current account between wallet and browser - Fix disconnect when url is ens - current: - Move fetch price to status go **Khushboo** - done: - current: - [#5040](https://github.com/status-im/status-desktop/issues/5040): new Send Modal - next: - [#5037](https://github.com/status-im/status-desktop/issues/5037): User stays on removed account view in wallet after account removal from settings ## March 16 (Wed) **Khushboo** - done: - [#4053](https://github.com/status-im/status-desktop/issues/4053): Disconnect wallet in browser is not disconnecting the wallet - [#5039](https://github.com/status-im/status-desktop/issues/5039): adapt receive modal design - [#5025](https://github.com/status-im/status-desktop/issues/5025): Can't scroll the list of wallets till the end of the list - current: - [#5040](https://github.com/status-im/status-desktop/issues/5040): new Send Modal - next: - need task **Anthony** - done: - Fix current wallet account being same as browser account (allow to change current account in browser) - Fix resolving dapp via ens in browser - Fix redirecting to etherscan when doing transaction in browser - current: - Toggle test network (blocked until design is decided) ## March 14 (Mon) **Anthony** - done: - Dapp permission in settings - Fix fetching token details when creating new custom tokens - Fix showing token details - next: - Toggle test/prod network **Khushboo** - done: - [#5026](https://github.com/status-im/status-desktop/issues/5026): Adapt Emoji for wallet accounts in wallet settings and communities - current: - [#4053](https://github.com/status-im/status-desktop/issues/4053): Disconnect wallet in browser is not disconnecting the wallet - next: - need task ## March 11 (Fri) **Khushboo** - done: - [#4926](https://github.com/status-im/status-desktop/issues/4926): Support assigning emojis to wallet acounts - current: - next: - [#5026](https://github.com/status-im/status-desktop/issues/5026): Adapt Emoji for wallet accounts in wallet settings - [#4053](https://github.com/status-im/status-desktop/issues/4053): Disconnect wallet in browser is not disconnecting the wallet **Anthony** - done: - Adapt feature flag for wallet - Clean up asset list from wallet - Fix at boot loading the correct token - Diplay account information in settings - current: - Fixing problem in dapp permission PR - The browser won t load since this morning - next: - @ho90b1bVQo-PG331Km2B2A what do u think of fixing problems in browser next sprint ## March 9 (Wed) **Khushboo** - done: out of office from last Friday to Tuesday - current: - [#4926](https://github.com/status-im/status-desktop/issues/4926): Support assigning emojis to wallet acounts - next: **Nastya** - current: - https://github.com/status-im/status-desktop/pull/4978 - **Anthony** - done: - Moving dapp permission to wallet settings - New statusQ component - Status go updated - Client updated => Browser needs a lot of love to be something we want to have - current: - Edit account (needs sync with Khusbhoo) - Clean up asset list from wallet - Adjust feature flag ## March 7 (Mon) - Standup meeting **Anthony** - done: - Add new component for showing tags in list item - Create account view - current: - Moving dapp permission to wallet settings - Need answer about permission - Edit account - next: - Update networks with mapping with test network (those are new changes so backend changes are required too) ## March 4 (Fri) - Standup meeting **Anthony** - done: - List network match design - Move token selection to settings - Component switched to statusQ - current: - Moving dapp permission to wallet settings - Including tags to status list component (statusQ) ## March 2 (Wed) - Standup meeting **Anthony** - done: - Fix EIP1559: Carl, what is the status of the advance/simple - Add main view of new settings - Update status Q component - Add accounts to main view settings - current: - Style network list component - next: - Add custom network - Delete custom network - Edit network **Khushboo** - done: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - [#4925 ](https://github.com/status-im/status-desktop/issues/4925): add/re-add buy crypto feature - current: - update design for [#4925](https://github.com/status-im/status-desktop/issues/4925)? - [#4926](https://github.com/status-im/status-desktop/issues/4926): Support assigning emojis to wallet acounts - next: ## February 28 (Mon) - Standup meeting ** Anthony - current: - EIP1559: re-add to refactored part - next: - Wallet settings - ENS/Sticker toggle - Balance per network - Improve perf when switching network **Khushboo** - done: - current: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - understand keycard and current state - [#4920](https://github.com/status-im/status-desktop/issues/4920): Keycard settings screen & functionality using status-keycard-go - next: ## February 25 (Fri) - Standup meeting **Khushboo** - done: - [#4821 ](https://github.com/status-im/status-desktop/issues/4821): Can sign token transaction with wrong password - [#4358](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4358): Store pass to keychain does not validate current password which results to inability to login - current: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - next: ## February 23 (Wed) - Standup meeting **Khushboo** - done: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets - [X] Add API to generate new account and import them - [X] API to set current active wallet -> This and the one above PR was created and merged. - [ ] Tokens: Depends on task by Anothony on multi networks would also need multi networks service and etc? : On hold after discussions with Boris, Sale and Patryk. - Did discussion with Boris, Patryk and Sale about the cpp design and architecture. - current: - [#4834](https://github.com/status-im/status-desktop/issues/4834): Cpp: Wallet: Use google fruit for dependency injection - currently going through the tutorial. Sale has implemented this in some project before. Some people in the team may be faster at this cause I am entriely new to fruit. - next: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - [#4358](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4358): Store pass to keychain does not validate current password which results to inability to login - ## February 21 (Mon) - Standup meeting **Khushboo** - done: - [#4824](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4824): Cpp: Enable UI to show the different sections: Merged after fixinf review comments and discussion with Boris - current: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets - [X] Add API to generate new account and import them - [X] API to set current active wallet (in progress) - [ ] Tokens: Depends on task by Anothony on multi networks would also need multi networks service and etc? - next: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - [#4358](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4358): Store pass to keychain does not validate current password which results to inability to login ## February 18 (Fri) - Standup meeting **Anthony** - done: - Multi network for assets: - [x] Feature flag Toggle - [x] Remove Network selection from advance settings if feature flag toggled - [X] Update service network based on the feature flag - [X] Update token service with ChainIds - [X] Update wallet account service with ChaindIds - [X] Add network selection in wallet - [X] Update Token list UI - [X] Update main wallet UI - current: - Edit/Add networks - next: - ENS/Stickers toggle for only mainnet/ropsten **Khushboo** - done: - [#4824](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4824): Cpp: Enable UI to show the different sections: working on some very good review comments from Boris. - current: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets - [X] Add API to generate new account and import them - [X] API to set current active wallet (in progress) - [ ] Tokens: Depends on task by Anothony on multi networks would also need multi networks service and etc? - next: - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - [#4358](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4358): Store pass to keychain does not validate current password which results to inability to login ## February 16 (wed) - Standup meeting **Anthony - current: - Fix add back fallback image for custom token or token without icon - Multi network for assets: - [x] Feature flag Toggle - [x] Remove Network selection from advance settings if feature flag toggled - [X] Update service network based on the feature flag - [X] Update token service with ChainIds - [X] Update wallet account service with ChaindIds - [ ] Manage networks in settings (in progress) - [ ] Add network selection in wallet (in progress) - [ ] Update Token list UI - [ ] Update main wallet UI - [ ] ENS/Stickers toggle for only mainnet/ropsten **Khushboo** - done: - [#4750](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4750): cpp: list accounts - [x] Prepare Main for Wallet Section - [x] Create Skeleton for Wallet - [x] Add the list accounts functionality - current: - [#4824](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4824): Cpp: Enable UI to show the different sections - next: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets - [#4747](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4747): add saved addresses to wallet section - [#4358](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4358): Store pass to keychain does not validate current password which results to inability to login ## February 14 (Monday) - Standup meeting **Anthony** - done: - fix opensea api - current: - Fix add back fallback image for custom token or token without icon - Multi network for assets: - [x] Feature flag Toggle - [x] Remove Network selection from advance settings if feature flag toggled - [X] Update service network based on the feature flag - [X] Update token service with ChainIds - [X] Update wallet account service with ChaindIds - [ ] Manage networks in settings (in progress) - [ ] Add network selection in wallet - [ ] Update Token list UI - [ ] Update main wallet UI - [ ] ENS/Stickers toggle for only mainnet/ropsten **Khushboo** - done: - current: - [#4750](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4750): cpp: list accounts - [x] Prepare Main for Wallet Section - [x] Create Skeleton for Wallet (in progress) - [ ] Add the list accounts functionality - next: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets ## February 11 (Fri) - Standup meeting **Anthony** - current: - Multi network for assets: - [x] Feature flag Toggle - [x] Remove Network selection from advance settings if feature flag toggled - [X] Update service network based on the feature flag - [X] Update token service with ChainIds - [X] Update wallet account service with ChaindIds - [ ] Manage networks in settings (in progress) - [ ] Add network selection in wallet - [ ] Update Token list UI - [ ] Update main wallet UI - [ ] ENS/Stickers toggle for only mainnet/ropsten **Khushboo** - done: - [#4610](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4610): can't request or send transaction in chat: All done , fixed some side impacts on browser send functionality - current: - [#4750](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4750): cpp: list accounts - next: - [#4751](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4751): cpp: select account and list assets ## February 9 (Wed) - Standup meeting **Anthony** - done: - Fix gif retry when connection is lost - current: - Multi network for assets: - [x] Feature flag Toggle - [x] Remove Network selection from advance settings if feature flag toggled - [X] Update service network based on the feature flag - [X] Update token service with ChainIds - [ ] Update wallet account service with ChaindIds (In progress) - [ ] Add network selection in wallet - [ ] Update Token list UI - [ ] Update UI - next: - multi network for transactions(read) - multi network for transactions(write) **Khushboo** - done: - current: - [#4610](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4610): can't request or send transaction in chat - Still wokring on the end to end for send and receiuve transaction in chat messages - next: - [#4750](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4750): cpp: list accounts ## February 7 (Mon) - Standup meeting **Anthony** - done: - Remove leftover directory from merge - Remove status lib deps - current: - Fix gif retry when connection lost **Khushboo** - done: - OOO Thurs Fri. - current: - [#4610](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4610): can't request or send transaction in chat - next: - ^ ## February 4 (Fri) - Standup meeting **Anthony** - done: - Move status-lib to desktop - Fix uneeded import - Fix group removing member - Fix group showing admin - Fix send tx with ENS - Fix switch to section/chat when clicking message in activity center - Fix context menu for admin in group - Fix promoting a member of a group as an admin show admin instead of the context menu - current: - Running CPP app and trying to better understand QT/C++ - next: - new ticket?/new wallet?/wallet in CPP? ## February 2 (Wed) - Standup meeting **Khushboo** - done: - [#2508](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-go/2508): Add tests for gif service - [#4609](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4609): context menu is gone for pictures - [#4623](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4623): send transaction to address UI is broken - some reviews - current: - [#4610](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4610): can't request or send transaction in chat - next: - ^ **Anthony** - done: - fix group when removing people - fix duplication in activity center - current: - fixing activity center switch and missing attributes - next: - send transaction with ens ## January 31 (Mon) - Standup meeting **Anthony** - done: - Fix crash when accessing manage asset - Fix showing group popup from chat list - current: - Looking at the missing attribute for activity center: looks like the attribute are not used anymore, not sure if needed - Opensea not returning assets is because we need an API key. Currently syncing with John/Andrea/Jakub - can't remove a member from a group **Khushboo** - done: - [#4355](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4355): Move gif to status-go : Merged - [#4551](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4551): can't reply to a reply - [#4531](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4531): send message is not working from context menu - current: - [#2508](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-go/2508): Add tests for gif service - next: - next assigned base_bc tasks ## January 28 (Fri) - Standup meeting **Anthony** - done: - Fix message parsing to display link - Refactor unfurl link - Persist storage of showing chat image and profile pic of unknown contact - Fix Activity center listening event - Fix seeing empty view when creating community chat - current: - Looking at the missing attribute for activity center ## January 26 (Wed) - Standup meeting **Anthony** - done: - Fix copy to clipboard in receive modal - Fix my own mistake with the empty chat view - Fix Cannot see the Community channel member list - Fix can t improt private key in wallet - Fix can t clear history - Fix can t leave chat - Fix hiding signing phrase when clicking ok - current: - refactor unfurl link and image for gif - next - Fix/refactor activity center **Khushboo** - done: - [#4519](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4519): Newly created Community remains highlighted: Spent a day on this with no root cause found :( have updated comments and will revisit with a fresh perspective - current: - [#4355](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4355): Move gif to status-go : almost done, really slow cause a lot fo things are new for me here. - next: - next assigned base_bc tasks ## January 24 (Mon) - Standup meeting **Anthony** - done: - merge move account!!! finally ;) - Fix receive modal - Address comments in performance issue branch - Crash in browser: not a real issue - current: - fix text area in wallet import mnemmonic - next: - more base bc issues **Khushboo** - done: - [#4504](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4504): Joined communities updates not visible: fixed review comments and merged on Friday - current: - [#4355](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4355): Move gif to status-go : need to ask if to implement on base_bc? - [#4519](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4519): Newly created Community remains highlighted ## January 21 (Fri) - Standup Meeting **Anthony** - done: - Fix create community button always enabled - Fix performance issue (Thanks Jo) - current: - new issue in base bc - merge move accounts to status-go **Khushboo** - done: - [#499](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/statusq/499): Introduce message component(s) : Merged finally :D - [#4415](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4415): option to delete community channel is missing - [#4504](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4504): Joined communities updates not visible - current: - [#4504](https://app.zenhub.com/workspaces/status-desktop-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4504): Joined communities updates not visible: fixing review comments and position change issue found - [#4355](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4355): Move gif to status-go ## January 19 (Wed) - Standup Meeting **Anthony** - done: - Fix duplicate message being received while being offline - Move account generation to status-go - Fix User agent for opensea API - Fix adding no autoclose in onboarding popup - current: - new issue in base bc: User not being notified in case of edit message with mention - next: - new issue in base bc **Khushboo** - done: - [#4410](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4410): edit message not working - [#4415](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4415): option to delete community channel is missing: Fixed review comments. fixing some other bugs for the whole flow - current: - [#499](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/statusq/499): Introduce message component(s) : Need to look at remaning review comments and get this closed - [#4415](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4415): option to delete community channel is missing - working on an issue left of when a new community is created , then delete option is unavaialble - next: - base_bc branhc issues for communities update addition deletion issue OR - [#4355](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4355): Move gif to status-go ## January 17 (Mon) - Standup Meeting **Anthony** - done: - Fix joining public channel - Fix onboarding popup when clicking outside - Fix importing a community key UI - current: - new issue in base bc **Khushboo** - done: - current: - [#4410](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4410): edit message not working - next: - [#4415](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4415): option to delete community channel is missing ## January 14 (Fri) - Standup Meeting **Anthony** - done: - Merge all PRs regarding moving stuff to status go (ENS + tokens) - Fix gif in base bc - Fix copy to clipboard in base bc - current: - trying to find new issue in base bc **Nastya** - current: focused on base_bc PRs and testing branch itself, nothing much from my side for now for wallet **Khushboo** - done: - [#4411](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4411): delete message not working - [#4413](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4413): no option to pin/unpin messages - current: - [#4410](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4410): edit message not working - next: - [#4415](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4415): option to delete community channel is missing ## January 12 (Wed) - Standup Meeting **Anthony** - current: - Move account creation to status-go (paused) - Working on gif not working - next: - Contact request **Nastya** - done: - https://github.com/status-im/status-desktop/pull/4378 - https://github.com/status-im/status-desktop/pull/4398 - https://github.com/status-im/status-desktop/pull/4377 - https://github.com/status-im/status-desktop/pull/4359 - next: - waiting for fixes of bugs for base_bc and any other prs that will be merged to this branch **Khushboo** - done: - [#2915](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/2915): Recipient of the transaction message is not notified that transaction is completed - Analyzed non issue, its a config that the Verify transaction only works for a minnent transaction so that the end user is no cheated on. This will have to re thought when multi network comes into picture - current: - [#499](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/statusq/499): Introduce message component(s) : Looking at review comments and fixing them - [#4411](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4411): [base_bc] delete message not working - next: - next base_bc assigned ## January 10 (Mon) - Standup Meeting **Anthony** - done: - Fix delete account - Fix transaction history showing historical node and timestamp of tx - next: - need task **Khushboo** - done: - [#2915](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/2915): Recipient of the transaction message is not notified that transaction is completed - Done fixing the breaking UI changes - current: - [#2915](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/2915): Recipient of the transaction message is not notified that transaction is completed - The same issue is present on mobile, trying to analyze the issue still. ## January 7 (Fri) - Standup Meeting **Anthony** - done: - ENS register/release - Move wallet tokens to status go - Fix text area for mnemonic - current: - Investigate message missing - Investigate transaction missing **Khushboo** - done: - [#3444](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3444): Transaction history is empty when account is recovered from scratch: With the help of Anthony we realized it is not a bug, but the fact that we use a non-archival key for Infura that causes this behaviour. An account with more recent transactions are visible correctly and after using the archival key, even an account with old transactions are visible. - current: - [#2915](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/2915): Recipient of the transaction message is not notified that transaction is completed ## January 5 (Wed) - Standup Meeting **Anthony** - done: - Fix collectible when no assets in collection - ENS register/release/setpublickey moved to status-go - current: - move wallet tokens to status go **Khushboo** - done: - [#4353](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4353): Whitespaces are not trimmed when re-importing key, which leads to wrong account recovered - [#4351](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4351): browser tab, can't click send button - current: - [#4353](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/4353): Whitespaces are not trimmed when re-importing key, which leads to wrong account recovered: Fixing the lint error in the PR - next: - [#3444](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3444): Transaction history is empty when account is recovered from scratch ## January 3 (Mon) - Iteration Meeting **Anthony** - done: - move ENS read function such as price/public key/owner of.... to status-go - current: - bug hunting in master - move ENS write function such as register/estimate gas/relase/set public key to status-go **Carl** - done: - current: **Khushboo** - done: - current: **Nastya** - done: - current: