# Rats - Archive june 24 2021 - September 17th ## September 17 (Fri) - Standup **Nastya** - current: - retested status-desktop/pull/3570 (replies in communities) - test status-im/status-desktop/pull/3586 (i was never able to see it so will try to get assistance from others) - status-im/status-desktop/pull/3584 - status-im/status-desktop/pull/3513 - status-desktop/pull/3590 **Michael** *Since being re-assigned from Jackalopes to Rats, I didn't realize (until today) that standup notes for Rats are posted on a weekday daily-basis. Henceforth, I *will* post mine on a weekday daily-basis. Below includes catch-up notes:* - done: - reviewed PRs [#3464](https://github.com/status-im/status-desktop/pull/3464), [#3545](https://github.com/status-im/status-desktop/pull/3545), [#3577](https://github.com/status-im/status-desktop/pull/3577), [#3578](https://github.com/status-im/status-desktop/pull/3578). - current: - waiting on review for [PR #3582](https://github.com/status-im/status-desktop/pull/3582). The PR resulted from an [exchange](https://github.com/status-im/status-desktop/pull/3545#discussion_r709388487) with Andrei and Jakub. - waiting on review for [PR #3583](https://github.com/status-im/status-desktop/pull/3583). The PR resulted from my review (and subsequent learning/experimentation re: [previously mentioned exchange](https://github.com/status-im/status-desktop/pull/3545#discussion_r709388487)) of Boris' [PR #3464](https://github.com/status-im/status-desktop/pull/3464). - PR [#3534](https://github.com/status-im/status-desktop/pull/3534) is waiting on a final bit of advice (someone please?!) re: getting `"app-logs"` to appear as `"Application Logs"`. Maybe it can/should be "hardwired" to string ``"Application Logs"`` to effectively unblock the PR (not that it's blocked *per se*). - Still researching the race condition in [PR #3530](https://github.com/status-im/status-desktop/pull/3530). I feel it's not a difficut to problem solve, but I was focusing on other tasks, will get back to it pronto. **Andrei** - done: - DOtherSide/QGuiApplication refactoring - https://github.com/status-im/status-desktop/pull/3585 - investigation: - UI issue (disappearing text) with Pascal - crash in signal:message.new handling - https://github.com/status-im/status-desktop/pull/3586 - next: - #3546 Notification badge is shown even the chat is opened and message is read - #3522 Activity center is showing wrong messages **Anthony** - Done: - Fix rebase issue on eth multi chain - Fix master with status-go bump - Current: - ENS name + profile picture disapearing **Sale** - done: - Issue 3490 [`status-desktop` PR-3570, PR `status-lib` PR-34] - replies are not working in communities - Issue 2675 - support (optionally) OS keychain to login password - fixed two sets of issues Iuri found - current: - Issue 3305 - new activity tab for wallet - next: - Issue 3378 -Fix the scenarios for closing the app on Mac (minimise on close On / Off) - Issue 3489 - channel links sends to main public channel instead of a channel in that community - Issue 3418 - Blocked user messages disappear after the user is blocked - Issue 2552 - Push notification is not send when mentioning a user having a chat muted **Richard** - done: - status-desktop#3588 missing signal type attribute - status-desktop#3580 display current active mailserver - status-lib#32 example QT app - Works in linux and mac m1 - Also fixes compile issue on c test - Kudos to @michaelb for explaining me what was install_name_tool for, and the changes he did on nim-status related to rpath (those were really important to make the app run on mac) - Created header file for library manually as well as used GC_ref and GC_unref to avoid Nim GC removing the status object - current: - Building Desktop on macOs M1: - I managed to compile QT except for the WebEngine submodule - Desktop app starts, but required two changes: - Commented the BrowserLayout since without WebEngine it will not work - Commented the SystemTrayIcon because it freezes the app on startup. I saw some changes related to this component, so I'll retry later - I'm trying to figure out the cause of an error when calling `wakuext_startMessenger` (right after login). The app freezes, and lldb displays this error: ``` Process 5688 stopped * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x00000001022d9ca4 libstatus.dylibnotok + 4 libstatus.dylibnotok: -> 0x1022d9ca4 <+4>: str x8, [x8] 0x1022d9ca8 <+8>: b 0x1022d9ca8 ; <+8> 0x1022d9cac <+12>: udf #0x0 libstatus.dylib`runtime.open_trampoline: 0x1022d9cb0 <+0>: str x30, [sp, #-0x10]! Target 0: (nim_status_client) stopped. ``` - status-desktop: generating a .deb for status-desktop: - Dockerfile created. Working on Makefile changes for building .deb - display history node interactions in node section ## September 16 (Thu) - Standup **Nastya** - current: - struggling with testing status-desktop/pull/3570 (replies) **Andrei** - current: - #3324 Windows zip version - feature is completed - discussing global Makefile refactoring - #3546 Notification badge is shown even the chat is opened and message is read - #3522 Activity center is showing wrong messages ## September 15 (Wed) - Standup **Andrei** - current: - #3324 Windows zip version (pending review) - next: - #3500 custom window title bar for windows - need Iuri's and Simon's opinion on the feature - pending: - single-instance + deep-links: waiting for @Rr6NF1uvSWGqnpkndZRtWQ to test it on Mac? **Nastya** - current: - status-desktop/pull/3537 (ens name) - status-desktop/pull/3534 (application logs) - status-desktop/pull/3530 (profile modal) - status-desktop/pull/3516 (leave chat modal) - status-desktop/pull/3003 (multiple instances) **Anthony** - done: - Download message log from a channel - Retry tenor API up to 3 times - Show a retry button when tenor API fail - UI to select the network (pure UI for now I need to do the binding later) - current: - Ens name + profile picture disapear when accepting contect until restart **Richard** - done: - status-desktop#3536 display logs in node management tab - status-desktop#3537 set preferred ENS username automatically when buying first ENS - status-lib#31 feat: trigger a signal for chronicles logs - status-desktop#3499 chore: upgrade to QT 5.15.2 - WE NEED TO MERGE THIS! - rebased status-desktop#3127 chore: use Status QT mirror (QT 5.15.2) - WE NEED TO MERGE THIS! - current: - status-desktop#3512 WIP: generating a .deb for status-desktop - I investigated all the requirements for creating a .deb, using the OS QT libraries - Initial steps for getting a .deb file, It complains about files not found, but at least the libraries are loaded correctly (QT, StatusGo). It will require changes on Desktop related to the loading of these resources (like the icons, fleets.json, etc) - A new dockerfile will be created just for handling the creation of the .deb - status-lib#32 example QT app - Already created the initial work for the example app (just a hello world that calls status-lib) - Stuff I'm currently investigating: - Stop nim from mangling struct names in header files - Stop cmake from creating directories for 'libstatuslib' - Figure out how nim GC works when returning ref objects - Make it work on macos / windows - finish setting up macos dev environment (installing xcode and qt took forever) - display current history node - next: - display history node interactions in node section **Sale** - current: - Issue 3305 - new activity tab for wallet - next: - Issue 3378 -Fix the scenarios for closing the app on Mac (minimise on close On / Off) - Issue 3490 - replies are not working in communities - Issue 3489 - channel links sends to main public channel instead of a channel in that community - Issue 3418 - Blocked user messages disappear after the user is blocked - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## September 14 (Tue) - Standup **Nastya** - current: - addressing issues of community dogfooding **Andrei** - done: - #3460 [Windows] Right click in task bar is gone - current (investigating): - #3477 can't turn off sounds for the notifications, toggling the setting off does not make an effect - could not reproduce on Windows yet ## September 13 (Mon) - Standup **Andrei** - current: - #3370 group messaging performance issues **Nastya** - done / current: - status-desktop/pull/3454 (ENS name appearance) **Richard** - done: - rebase infinite PRs - current - rebase QT 5.15.2 PR - import status-lib in QT app **Anthony** - done: - Add max_value attribute for trait in opensea integration - Fix opensea unmarshalling when value is a number - Rebase multichain opensea PRs - Fix deserialization/serialization of Network - Clean up wallet2 by removing old collectible code - current: - Enable wallet2/stickers/tokens/ens to specify a network for their API => We will need to created stickers2/tokens2/ens2 (Are you ok?) **Sale** - done: - Issue 3375 (`status-desktop` PR-3465, `dotherside` PR-50, `nimqml` PR-33) - app support for status-im:// URIs - Issue 2675 - support (optionally) OS keychain to login password - swithcing account issue fixed - current: - Issue 3305 - new activity tab for wallet - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## September 10 (Fri) - Standup **Nastya** - current: - test release - logged several issues **Anthony** - done: - rebase PRs - Help Eric with rebase on status-go for the pr about addresses - Allow multi network with opensea API - fix broken test on status-go (prevent merging) - current: - Allow rpc client to be network aware (status-go) - Adapt status-lib wallet to look at multiple chain **Richard** - done: - status-desktop#3437 and status-lib#0 refactor: extract src/status to separate library - status-desktop#3438 and status-lib#1 refactor: move most of the signal processing logic to status-lib - status-desktop#3455 rename nim-status-lib to status-lib - status-desktop#3459 - refactor: remove constants from status-lib (these constants depended on nim-confutils, and it cannot be used in dynamic libraries) - refactor: remove submodules from status-desktop since they're imported already in status-lib - status-lib#9 generate a dynamic library. - So far it only exposes the status object creation and initNode procs. - The other procs must be exposed - New procs with c parameter types might need to be created to simplify interop between c and nim - try to unsuccesfully figure out why status-go CI was failing. The error was figured out by @jakubg and fixed by @alaibe - current: - rebase EIP1559 PR (I'll merge it immediatly afterwards) - rebase all the Waku2 PRs - rebase QT 5.15.2 PR - import status-lib in QT app - next: - Figure out how to create a .deb and .rpm for status-desktop distribution **Sale** - done: - Issue 3376 (PR 3427) - move Qt logic out of src/status library - rebased - Issue 3368 - missing message history gaps - discussed with mobile team, I faced issues in the mobile app while I was checking, wasn't able to see any inconsistencies in the desktop app - Set up local environment for building specs using `jekyll` - New url scheme [(specs)PR-159] defined - current: - Issue 3375 - app support for status-im:// URIs - mac - applied private messaging, need to add other actions defined in the spec (specs/PR-159) - next: - Issue 3305 - new activity tab for wallet - Issue 2552 - Push notification is not send when mentioning a user having a chat muted **Andrei** - done: - #3374 Integrate status-im protocol handling with the single instance check - next: - #3370 improve performance of group messages - on hold: - audio messages, until Ogg codec is accepted by @cammellos ## September 9 (Thu) - Standup **Nastya** - current: - test release - test https://github.com/status-im/status-desktop/pull/3372 to make andrey happy - https://github.com/status-im/status-desktop/pull/3452 - https://github.com/status-im/status-desktop/pull/3453 **Andrei** - current/done: - #3329 Community invite is not shown in 1-1 chat from desktop - rebased deep-links PR - next: - #3370 improve performance of group messages - on hold: - deep-links/single-instance requires https://github.com/status-im/status-desktop/pull/3372 to be merged - audio messages, until Ogg codec is accepted by @cammellos ## September 8 (Wed) - Standup **Nastya** - current / done: - checking bug fixes + testing release candidate **Andrei** - current: - #3426 Change password is not possible - status-im:// protocol support bugfixing and testing - #3374 Integrate status-im protocol handling with the single instance check - https://github.com/status-im/status-desktop/pull/3372 is a pre-requisite and better to be merged to proceed with #3374 **Anthony** - Done: - Add more attribute to collect from opensea - List network/add networkd/ edit network API in status-desktop - Remove popup when a request fail on windows - Fix issue about removing message - Current: - We do many eth call via status-go those call needs to also be network aware. Working on finding a way to change this - Next: - Add chain id for opensea (support are only mainnet and rinkeby) **Richard** - Done: - status-desktop#3413 fix membership requests dissapearing during a drag-drop - status-desktop#3383 Waku V2 light client mode - status-desktop#2818 EIP1559: calculate fees using same logic as mobile and disable suggestions - status-go#2351 WakuV2 Lightpush / Filter integration - go-waku#50 fix: check for messages on filter protocol in case a non null request is being sent - Current: - Update go-waku / status-go roadmap with regards to progress and questions - Extract src/status to separate repo **Sale** - done: - Issue 3376 (PR 3427) - move Qt logic out of src/status library - current: - Need to rebase 3376, expected lot of conflicts - Issue 3375 - app support for status-im:// URIs - mac - next: - Issue 3305 - new activity tab for wallet - Issue 3368 - missing message history gaps - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## September 7 (Tue) - Standup **Nastya** - current (done): - logged https://github.com/status-im/status-desktop/issues/3384 - need to create how-to for dogfooding: https://hackmd.io/@status-desktop/SJoM4c4MY - https://github.com/status-im/status-desktop/pull/3359 - https://github.com/status-im/status-desktop/pull/3281 - logged https://github.com/status-im/status-desktop/issues/3387 - bunch of issues for UI - https://github.com/status-im/status-desktop/pull/3406 **Andrei** - current/done: - #3357 Sign Out & Quit hangs the app (PR) - #3374 Integrate status-im protocol handling with the single instance check - rebased https://github.com/status-im/status-desktop/pull/3372 - rebased https://github.com/status-im/status-desktop/pull/3281 ## September 6 (Mon) - Standup **Nastya** - current / done: - https://github.com/status-im/status-desktop/pull/3362 - logged https://github.com/status-im/status-desktop/issues/3371 - https://github.com/status-im/status-desktop/pull/3359 - https://github.com/status-im/status-desktop/pull/3281 - logged https://github.com/status-im/status-desktop/issues/3378 **Andrei** - current: - #837 support to status-im:// protocol (Windows) - PoC to review https://github.com/status-im/status-desktop/pull/3372 - needs integration of "single instance" feature https://github.com/status-im/status-desktop/pull/3003 **Richard** - current: - WakuV2 issue hunting: - Disconnecting from internet does not reset the peer count to 0 - Store resume is being called before a peer is available - Dialing a peer does not trigger the connstatus signal - Lighpush / filter integration **Anthony** - done: - Hide text when a link is only a gif - current: - Finalising PR about multiple network **Sale** - done: - Issue 2120 (PR 3359) - implement buy crypto feature - Because of an idea to have `src/status` Qt free, as a part of this ticket I was trying to find a way to do async jobs in `src/status` without inheriting from `QObject` but it came out that it is not posible as long as we have this Qt dependant classes there: - /src/status/tasks/marathon/mailserver/controller.nim - /src/status/signals/core.nim - /src/status/tasks/marathon/mailserver/events.nim - /src/status/tasks/qt.nim after all the question is do we really need to have `src/status` Qt free? Or maybe to agree on some new architecture? Also as a part of this ticket I added `wallet2` related classes to the `src/status` part (I will need that for Issue-3035), that's in the PR-3359 - current: - Issue 3305 - new activity tab for wallet - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## September 3 (Fri) - Standup **Anthony** - current: - Working on making wallet transfers working with multiple chain. This should be the latest effort in order to have the wallet supporting multiple chain. You can follow the PR here: https://github.com/status-im/status-go/pull/2349 **Andrei** - done: - #3361 Windows: nim/installer is missing cacert.pem - #3270 code tags, addressed PR feedback - current: - investigating #3363 "could not load: DOtherSide.dll" - next: - #837 app support for status-im:// URIs in the browser **Sale** - done: - Issue 2675 (PR 3318) - "store to the keychain" logic update - Issue 2120 (PR 3359) - implement buy crypto feature - Issue 2996 (PR 3269) - clicking push notification does expand the app but does not open correct channel/chat - fixed the issue caused by rebasing this branch - current: - Issue 3305 - new activity tab for wallet - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted **Richard** - done: - status-go#2347 fix waku2 history query using the wrong cursor and content topics - status-desktop#3354 mailserver cycle waku v2 compatibility disable adding custom mailservers when wakuv2 is enabled - current: - WakuV2 issue hunting: - Disconnecting from internet does not reset the peer count to 0 - Store resume is being called before a peer is available - Dialing a peer does not trigger the connstatus signal - Lighpush / filter integration ## September 2 (Thu) - Standup **Nastya** - current / done: - status-desktop/pull/3356 -> scaling issues - status-desktop/pull/3269 -> notification redirect **Andrei** - done: - #2178 Fix Scaling Issues - next: - #837 app support for status-im:// URIs in the browser ## September 1 (Wed) - Standup **Nastya** - current / done: - status-desktop/pull/3269 (notification redirect) - status-desktop/pull/2818 (EIP1559) **Richard** - done: - status-go#2344 add function to free memory - status-go#2342 and status-desktop#3338 fix net address conv error when switching to waku fleet with an old account - status-go#2341 add MultiaddressPing fn (for wakuv2) to determine which mailserver to use - status-go#2340 RPC methods for adding store peers, fix peer count and fix format of peer stats signal - status-go#2345 Add relay peers and dial peers - go-waku#46 emit connection status when there's an update when peers change connectivity - go-waku#45 add connected peer IDs and supported protocols to connection status and expose list of peers - nim-status-go#3 and status-desktop#3343 free strings returned by c-go to avoid memory leaks - status-desktop#3337 show connection status when using wakuv2 - Rebase status-desktop#2818 EIP1559 and status-desktop#3188 Release ENS - current: - status-desktop#0000: Update mailserver cycle for compatibility with wakuV2 - status-desktop#2346 support linking to messages **Anthony** - done: - Improve performance when showing suggestion with a lot of members (input chat was not responsive) - Improve performance when switching chat: move mark all message as read async and remove unecessary call to getContact - Added trait to the opensea API - Added new settings to enable opensea API - current: - Trying to figure out a way to make the wallet multi chain. Either by creating a wallet2 or by modifying the current wallet while keeping the current functionality. This is the main modification for adding support to optimism, which is actually multichain support **Andrei** - current: - 4K scaling issues, WIP **Sale** - done: - Update for Issue 2675 so it should be working on other mac machines now - Was trying to help Nastya to build the app on her mac, but we did not succeed to make it - Issue 3259 - no identicon/profile picture shown and wrong timestamp format in search results - current: - Issue 2120 - implement buy crypto feature - next: - Issue 3305 - new activity tab for wallet - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## August 31 (Tue) - Standup **Andrei** - done: - #3313 edit channel modal keeps previously edited description instead of newest one - #3283 communities local usernames not being reflected - current: - #2178 Fix Scaling Issues - Reviewed voice messages recording UI **Nastya** - current / done: - status-desktop/pull/2818 (EIP1559) - rebase required - spent several hours to debug issue with building the app (same issue is exeprienced by Eric) - status-desktop/pull/3322 (Pasting text with emoji) - status-desktop/pull/3269 (notification redirect) ## August 30 (Mon) - Standup **Nastya** - current / done: - catching up on everything - status-desktop/3221 -> verified and closed - status-desktop/3190 -> still reproducible, added a video - status-desktop/pull/3188 (release ENS) - spent some time to build the app locally but still running into issues **Anthony** - done: - Add trait to opensea response - Fix perf issue when typing message in a chat with a lot of members - Do not use chatUpdate when sending a message - current: - Fix slow chat switch **Andrei** - done: - #3313 edit channel modal keeps previously edited description instead of newest one - next: - #3283 communities local usernames not being reflected **Richard** - current: - status-desktop#2346 support linking to messages - Peer management on status-go + go-waku **Sale** - done: - Update for Issue 2675 - constants updated so it can be buildable on older MacOs version (>10.15), fixed issue for Windows, so it's buildable there also, but it's mac only feature - Issue 3320 (PR 3327) - after reaching the top of chat history, unable to scroll down again - Issue 3190 - Scrolling increases the real memory usage in several times - discussed with Nastya, not reproducible neither with builds built on my machine, nor with the same master build as she tested (from Jenkins) - current: - Issue 3259 - no identicon/profile picture shown and wrong timestamp format in search results - next: - Issue 2120 - implement buy crypto feature - Issue 3305 - new activity tab for wallet - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## August 27 (Fri) - Standup **Andrei** - done #3270 & #1368: all about code tags - branch to test: `feat/edit-msg-md` - PR: https://github.com/status-im/status-desktop/pull/3281 - PR: https://github.com/status-im/dotherside/pull/46 **Richard** - done: - nim-status#298 add /joinpublicchat and /leavepublicchat commands to join status channels on waku2 - current: - status-desktop#2346 support linking to messages - next: - Peer management on status-go + go-waku **Sale** - done: - Issue 2675 (PR-47[dotherside], PR-30[nimqml], PR-3318[status-desktop])- support (optionally) OS keychain to login password - MacOs only feature - current: - Updating errors constants depends on MacOs version (update for Issue 2675) - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - For issues 3190 and 3221 I need Iuri's decision ## August 25 (Wed) - Standup **Andrei** - done: - #3270 editing a message to deal with original markdown input, not rich text - current: - #1368 UI feature request: improve code tags display - prototyping a solution with js library **Richard** - done: - rendezvous#30 Add function for clients to know their external IP address - status-go#2333 If AdvertiseAddr IP is empty, loopback or private, use external IP address - This will require redeploying the rendevouz fleet - Once this PR is merged, desktop status-go version needs to be updated for rendezvous to work - status-go#2334 Expose bloom filter - status-desktop#3286 Display bloom filter usage and set BloomMode as default - status-desktop#2729 Rebase update-version - status-desktop#3274 Add RegisterTopic to the configuration - Help Hester and Carl verify if SupeRare proxy contract had name() and symbol() functions available (contract is not verified) - Explore rendezvous+status-Go to understand why discovery wasn't working **Anthony** - done: - Rebuild suggestion using member of channel/communities and avoid serializing/deserializing contacts - Add cache for opensea query - Add confirmation modal when using wallet feature (ENS/Sticker/Transaction) - current: - Do no use chatUpdate when sending message to avoid long wait when sending message **Sale** - done: - Checking drag&drop (StatusQ, branch `drag-and-drop-cats`), created mini demo project demonstrating drag&drop feture to see what's the issue with onDropped slot, discussed with Pascal - Issue 3190 - Scrolling increases the real memory usage in several times - commented - Issue 3221 - Messages counter is increasing dramatically when scrolling chat back and force - commented - current: - Issue 2675 - support (optionally) OS keychain to login password - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## August 24 (Tue) - Standup **Andrei** - done: - #3260 Channel suggestions are not being displayed in the chat list - current: - #3270 editing a message to deal with original markdown input, not rich text ## August 23 (Mon) - Standup **Anthony** - done: - Fix case when opensea API triggers a timeout - current: - Trying to fix the problem on performance when sending a message. So far I identified 2 possible cause could add up to nearly 1s to send a message: - 1) The more contact there is the more it will be slow as we replace ens name or alias. I am improving the algorithm here - 2) The second and more problematic is the chatUpdate event. For example when sending messages we also update the muted chat list. I think chatUpdate should be broken up but that looks like a rabbit hole problem (Needs discussion) **Sale** - done: - Issue 2996 ([dotherside PR-45], [nimqml PR-29], [status-desktop PR-3269])- Clicking push notification does expand the app but does not open correct channel / chat - current: - Checking drag&drop (StatusQ, branch `drag-and-drop-cats`) - Issue 3190 - Scrolling increases the real memory usage in several times - next: - Issue 3221 - Messages counter is increasing dramatically when scrolling chat back and force - Issue 2675 - support (optionally) OS keychain to login password - Issue 2552 - Push notification is not send when mentioning a user having a chat muted **Richard** - done: status-node#000 hunt causes of low peers and no discovery status-desktop#3263 switch deletedMessages from string array to object array (required due to upcoming status-go PR) status-go#2325 waku v2 bandwidth stats - current: - Receive and decode public messages from status-go in nim-status ## August 20 (Fri) - Standup **Anthony** - done: - Fix leaving the timeline - Avoid to resend notification on scroll - Fix offline indicator in dark mode - Specific log file per app start - current: - Fix reaction in timeline **Andrei** - done: - fix/warnings - fix/issue-3163 (members list) - current: - feat/code-tags **Richard** - done: status-node#0 Status Node, CI, Linux AppImage status-go#2318 Start a node by passing a config json nim-status-go#2 Adding simple node startup procs - current: - Receive and decode public messages from status-go in nim-status **Sale** - done: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat: - MacOS - handling notifications on MacOs is completely done - Windows - adding notifications and handling click on them is done - current: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat: - Windows - need to find a way to set unique identifier for each added notification and read it once user clicks it - next: - Issue 3190 - Scrolling increases the real memory usage in several times - Issue 3221 - Messages counter is increasing dramatically when scrolling chat back and force - Issue 2675 - support (optionally) OS keychain to login password - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## August 18 (Wed) - Standup **Andrei** - done: - #3163 improve member list sorting - next: - #1368 improve code tags display **Anthony** - done: - Integrate opensea API to collectible (status-go + status-desltop) - current: - Suggestion to preview link to showing in some condition - Push notification are sent in double **Richard** - done: - status-go PR housekeeping - rebase EIP1559 PR - fix code review items on nim-status#268 (sendTransaction) - current: - Implement a simple status node GUI. Progress can be seen here - https://github.com/status-im/status-node - https://github.com/status-im/status-go/pull/2318 - next: - Receive and decode public messages from status-go in nim-status **Sale** - done: - Issue 2934 (PR 3231)- implement search results for communities, channels - current: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat - next: - Issue 3190 - Scrolling increases the real memory usage in several times - Issue 3221 - Messages counter is increasing dramatically when scrolling chat back and force - Issue 2675 - support (optionally) OS keychain to login password - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## August 17 (Tue) - Standup **Andrei** - current: - #3163 improve member list sorting ## August 16 (Mon) - Standup **Anthony** - current: - Close modal when viewing cryptokitties - Working on opensea collectibles wallet v2 - Go side is working, will publish PR all together with the UI **Sale** - done: - Issue 2934 (PR 3231)- implement search results for communities, channels - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - waiting for Simon's review and Iuri's final decision before I continue with this - need more tasks **Andrei** - current: - #2840 Update options for a message in Pinned messages modal - #1620 Change password - next: - polishing voice messages (new StatusQ) - #1642 Switching between chats on macOS is slow ## August 13 (Fri) - Standup **Nastya** - current: - status-desktop#3215 Improving win installer - status-desktop#3212 Delete messages bug - status-desktop#3220 Seed phrase bug - status-desktop#3219 Missing replies **Andrei** - done (testing): - Inno Setup script improvements - #1620 Change password functionality missing in Privacy and Security pane - current: - rebasing pending PRs - next: - #1642: switching between chats on macOS is slow **Sale** - done: - Issue 1725 [PR-25(nimqml), PR-37(dotherside), PR-3208(status-desktop)]- Changing System Appearance on the fly is not working - Issue 2934 - implement search results for communities, channels - done: - (1) Need to update model according to the newest UI changes regarding icons/images/color (and using "#" icon instead of adding it as a text), also updated search popup and location menu componet so they follow now abstract list models, updated search list of search popup component - (3). Ens names resolved - (4). Discussed with Pascal, time will be handled once I finised this feature through some new ticket, as that is a new component in the statusq part - current: - Issue 2934 - implement search results for communities, channels - still need to be done: - (2) Have to add same popup modal for the search on the left side (above channels list), so far all was related to the magnifier on the right side when you have an active chat/channel (but that should not be to complex, but need to be done) - (5) The last and the most complex thing I need to handle is jumping to the selected message from the search result. For some messages that requires changing active channel, and for some requires changing a section (community) and selecting channel there and after that loading more messages for that channel in the past till we are sure that we have appropriate message to point to - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - waiting for Simon's review and Iuri's final decision before I continue with this **Anthony** - done: - Fix again connection when appmain is being displayed - Fix replying message not being shown - Browser: hide favorite bar when there is no favorite - Going from communities to chat reopen last chat - Fix Access to chat via Ctrl+k shortcut from communities - New way to handle blocked contact - current: - Opensea integration (GO side) **Richard** - done: - status-go#2310 fix: delete messages when the signal arrives before the OG msg - current: - nim-status#268 add /sendtransaction command to TUI. Only missing validating the transaction and signing it. nim-web3 seems to not support EIP1559 transactions - status-desktop: new wallet tab ## August 12 (Thu) - Standup **Nastya** - current: - status-desktop#3212 Delete messages bug - status-desktop#3194 Crash on logout (windows) - status-desktop#3215 Improving win installer **Andrei** - done: - fixed crash on login/create account - current: - #1620 Change password functionality missing in Privacy and Security pane ## August 11 (Wed) - Standup **Andrei** - current: - #1620 Change password functionality missing in Privacy and Security pane **Nastya** - current: - status-desktop#3194 Crash on restoring account - status-desktop#3193 Deinstalling windows build - status-desktop#3200 Crash on creating account on Win **Anthony** - done: - Crash on restoring account - nim-status integration with opensea - Enable Stickers on ropsten - current: - blocking a user new behaviour **Sale** - done: - Issue 3043 - clicking unfurling 'Enable in Settings' should direct to the privacy & security section not just the profile section - checked, commented - Issue 3142 - Search results do have broken UI - checked, commented, will be fixed within Issue-2934 since we have new UI for that part - Issue 3112 (PR 3197) - on macos, right clicking the icon on the dock and pressing quit is not quitting (but works in the top menu) - current: - Issue 1725 - Changing System Appearance on the fly is not working - Issue 2934 - implement search results for communities, channels - pretty complex, did a lot of things here, faced a lot of issues also (discussed with Aleksandra and Pascal), still need to be done: 1. Need to update model according to the newest UI changes regarding icons/images/color (and using "#" icon instead of adding it as a text) 2. Have to add same popup modal for the search on the left side (above channels list), so far all was related to the magnifier on the right side when you have an active chat/channel (but that should not be to complex, but need to be done) 3. Need to think a bit where to get from an ens name for the message sender as messages I am receiving has only 3 words alias instead of that pretty ens name for users which have it (don't have sender PK) 4. Need to think about the time, as by design time is only set, what is not enough if we have messages from yesterday or even more in the past (should be added day/date) but that is not in the design 5. The last and the most complex thing I need to handle is jumping to the selected message from the search result. For some messages that requires changing active channel, and for some requires changing a section (community) and selecting channel there and after that loading more messages for that channel in the past till we are sure that we have appropriate message to point to - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - waiting for Simon's review and Iuri's final decision before I continue with this **Richard** - done: - status-desktop#3188 release ENS names - status-desktop#3196 display ENS on contact search results - status-go#2301 fix issue when sorting chats due to maps not keeping order - status-go#2281 / nim-waku - bridge Waku V1-V2 messages. Issues identified in nim-waku - current: - status-desktop#3181 add wallet tab ## August 10 (Tue) - Standup **Nastya** - status-desktop#3188 Release ENS names - status-desktop#3186 Stickers on Ropsten **Andrei** - done: - voice messages recording & playback (PoC) - waiting for status-go PR (agreement on Opus) - waiting for recording UX - #2929 [Windows] Deinstalling the .exe app does not remove shortcuts / task bar pins - next: - #1620 Change password functionality missing in Privacy and Security pane ## August 9 (Monday) - Standup **Nastya** - current: - status-desktop#2818 EIP1559 - status-desktop#3151 Wallet total includes tokens - status-desktop#3164 Audio Messages - **Anthony** - done: - Fix buy stickers and restarting the app while tx is pending - Add scrollbar for advance settings - Fix sharing community link - current: - Blocking contact UI **Andrei** - current: - voice messages recording: - done simple UI - done PoC - done status-go part (PR) - work is in progress **Richard** - done: - status-desktop#2818 EIP1559 Fix issues reported by @nastya - status-go#2304 add index on user_messages to speed-up marking all messages as read - current: - status-desktop#782 Add button to release status ENS usernames after one year of being registered - status-desktop#3077 Missing information when clicking the ens name **Sale** - current: - Issue 2934 - implement search results for communities, channels - working on coresponding changes for the nim part, remains qml part to be adapted once Aleksandra updates it since I found some new errors there today - next: - Issue 3043 - clicking unfurling 'Enable in Settings' should direct to the privacy & security section not just the profile section - Issue 1725 - Changing System Appearance on the fly is not working - Issue 3142 - Search results do have broken UI - Issue 3112 - on macos, right clicking the icon on the dock and pressing quit is not quitting (but works in the top menu) - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - waiting for Simon's review and Iuri's final decision before I continue with this ### August 6 (Friday) - Standup **Richard** - done: - status-desktop#3173 selector for online or invisible state - status-desktop#3174 fix: userlist - status-desktop#3172 fix: etherchains api parsing error - status-desktop#2818 EIP1559 - rebase against master - fix bug in browser transaction modal (transactions were not sent) - status-go#2301 fix: allow empty category id when sorting chats and fix error messages - statusQ#312 replace profile icon - statusQ#311 add profile button to StatusAppNavBar - nim-status#259 code review items in /call command - status-desktop#3175 remove etherchains (not needed after EIP1559) - current: - nim-status - send transactions **Andrei** - done: - fixed SingleInstance - crash on shutdown (Linux) - next: - voice messages recording **Anthony** - done: - Re-enable unfurling of tenor - Wallet total balance reflect real total balance - Close browser choice when opening - Fix click on contact lead to contact chat - Community invite only for contacts - Recent and Favorites are now fully working (There was an issue of concurrent save) - current: - How best to display tenor link? - Community link are not being displayed properly **Sale** - done: - Issue 3005 - resolved conflicts - current: - Issue 2934 - implement search results for communities, channels - had some issues exposing list of QVariants to qml, finally made it work, but accessing property of QVariant which is an item of QVariant list still doens't work. I switched to abstract list model, created models (have part of the logic already), but UI is created in a way that it doesn't support repeaters/instatinators/models for dinamically menu creation, commented on https://github.com/status-im/StatusQ/pull/301 (Alexandra should update that soon) and also here about some UI improvements https://github.com/status-im/StatusQ/issues/264#issuecomment-894082596 (waiting for Simon), meanwhile I developed necessary part in status-go PR-2303 - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - had a call with Simon, created a table which defines actions in case of different user's settings and different events which may happen, Simon needs to review that before I start with the changes ### August 5 (Thursday) - Standup **Andrei** - done: - audio messages playback (initial version) - current: - audio messages recording ### August 4 (Wednesday) - Standup **Andrei** - current: - audio messages playback with WebEngine, prototype **Nastya** - current: - https://github.com/status-im/status-desktop/pull/2818 (EIP 1559) **Anthony** - done: - Gif recent and favorites - Disable gif on edit message - Add popup to confirm the usage of gif widget - Hide communities button if not enabled - Fix the total balance on the wallet taking into account all assets - Fix clicking on a profile (merge conflict) - Remove chat when blocking a contact - current: - Improve community invite - next: - add tenor API to CI - Clicking on favorite gif weird behaviour **Richard** - done: - status-desktop#2818 EIP1559 - suggest fees - nim-status#259 call rpc methods - current: - nim-status - send transactions - next: - status-go: waku2 bandwidth stats **Sale** - done: - Issue 2912 - resolved conflicts, tried to do linting but from some reason wasn't able to do it locally - current: - Issue 2934 - implement search results for communities, channels - next: - Issue 2552 - Push notification is not send when mentioning a user having a chat muted - commented on this, need a decision should I just fix that for this particular case or sort out entire notification part ### August 3 (Tuesday) - Standup **Nastya** - current: - testing beta 11 again - PR 3132 **Andrei** - current: - audio messages playback (investigation) ### August 2 (Monday) - Standup **Anthony** - done: - display gif on 3 columns with improvement on max height - Load collectible for first account in wallet - current: - Style the gif widget according to design - Improve speed of gif loading - next: - recent & favorites gif - add tenor api to CI **Richard** - done: - status-desktop#3130 enter gas prices with decimals - status-desktop#3127 rebase - use Status QT mirror (for QT 5.15.2) - status-desktop#3125 fix translations - status-desktop#2818 EIP1559 - fix decimals shown on ETH values - current: - status-go: continue work on lightpush+filter mode - next: - status-go: waku2 bandwidth stats **Sale** - done: - Issue 2972 (PR 3131) - `joinedCommunities` doesn't seem to update underlying community models in the view (seems that was never developed), this is in a draft since I need changes from PR-3058 in order to continue, commented there. - Issue 3112 ((dotherside) PR 34) - on macos, right clicking the icon on the dock and pressing quit is not quitting (but works in the top menu) - StatusQ PR-304 - code checked, commented, also fixed the issue Pascal faced with an empty object for errors - next: - Need new tickets **Andrei** - done: - #3072 mentions support in message editing mode - #3124 picture profile in Timeline - #3118 community profile popup is not being closed when leaving the community - next: - audio messages playback (investigation) ### July 30 (Friday) - Standup **Jonathan** - done: - Lock community type back to on request - Remove ctivity center backdrop - current - Continued work on making the pins permanent - I'm having issues with the status-go prototocol. The message protobuf I'm getting doesn't contain enough data - I asked for help in #status-go **Andrei** - done: - #3067 Scrolling chat history is not smooth ongoing CPU usage investigations (investigation) - current: - #1642 Switching between chats on macOS is slow **Anthony** - done: - Display gif on 3 columns - Disable copy to clipboard from profile context menu - handle empty textbox in add contact modal from profile - Fix translation for members count in communities - Erase mnemonic when using existing account - Correct position of error not enough gas - current: - Display loading state (UI) - next: - Add confirmation modal to emoji widget - Add favorites and recent to emoji widget **Sale** - done: - Issue 3049 (PR 3107) - clicking 'notification settings' should take the user directly to that section instead of just the general settings - Issue 3005 (PR 3058) - support jumping to search result message that is not currently loaded in memory - fixed two crashes caused by changes applied to this feature. This feature is fully completed now. - Issue 2420 - high memory usage in beta.9 and beta.8 - checked using Callgrind profiling tool on mac, but it doesn't give me any meaningful info about mem leaks, commented - Issue 3112 - on macos, right clicking the icon on the dock and pressing quit is now quitting (but works in the top menu) - checked, commented - current: - Issue 2972 - `joinedCommunities` doesn't seem to update underlying community models in the view (seems that was never developed) - next: - Need to check this code https://github.com/status-im/StatusQ/pull/304 as there is some issue using list of validators **Richard** - done: - go-waku: fix timestamp format - go-waku: fix protocol matching function (attempting to refactor code to avoid maintaining separate libp2p library) - libp2p/go-libp2p-pubsub#440 add support for custom protocol matching function (once this is merged, hopefully I'll be able to remove status-im/go-wakurelay-pubsub) - status-go#2992 and status-desktop#3114 bump go-waku - status-desktop#2729 version updating - status-desktop#3103 disable dynamic translations on linux - fixed code review item - status-desktop: hunt performance issues - current: - status-go: continue work on lightpush+filter mode - next: - status-go: waku2 bandwidth stats ### July 29 (Thursday) - Standup **Nastya** - done / current: - continue testing release candidate beta 11 - PR 3090, PR 3076 **Andrei** - done: - #3068 Image limit for chats is 0,5 Mb, images are not shrink when sending - #3070 No sound when receiving a message (only when sending) - current: - #3067 Scrolling chat history is not smooth - ongoing CPU usage investigations ### July 28 (Wednesday) - Standup **Jonathan** - done: - Lots of rebases both on desktop and status-go which most of them ended up being merged (thank god) - Tested and fixed a lot of issues on the activity center - current - Continued work on making the pins permanent **Anthony** - done: - Display correct context menu for reply - Add input validation when buying stickers - Do not allow to put decimal is gas input field - Revert logic to control the visible of fetch more message - current: - Try understand more about the issue on performance - next: - is there any ticket that needs to be fix for release? **Richard** - done: - status-desktop#3078 refactor: SNT transaction modal (for buying sticker packs and ens) - status-desktop#3075 regression in user status (users were always online) - status-desktop#3065 group member list - status-desktop#2818 EIP1559. Only missing the suggestions for priority fees (depends on status-go). - Identify commits that cause high CPU usage on Linux - Add roadmap to go-waku section of @status-desktop book - fix issues found on PR status-desktop#3065 (group member list) - current: - status-go: continue work on lightpush+filter mode - next: - status-go: waku2 bandwidth stats **Sale** - done: - Issue 2994 (PR 3060)- Gas Selector modal has text, divider and custom/suggestions toggle overlapped - ((dotherside) PR 32) Started by checking memory leak caused with the commit where translation is included, turned out it's not a mem leak, but CPU usage issue - (PR 3092) High CPU usage issue - spent some time working on it, finally manged to fix it - current: - next: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat ### July 27 (Tuesday) - Standup **Andrei** - current: - #2603 Crash on login possibly due to getSettings, SIGSEGV on login - #3064 Push notification contains initial message body when the message has being replied to, instead of a text of reply ### July 26 (Monday) - Standup **Nastya** - PR 3025 (pin limit) - PR 3032 (ens) **Jonathan** - done: - Fixed a UX issue with the pin limit - Mostly finished the status-go part of permanent pins - current - Making the front-end work with the new pins inside the community chat object **Richard** - done: - status-desktop#3042: bandwidth stats - go-waku#40: pagination into resume protocol - status-go#2287: wakuv2 peer persistence - current: - status-desktop: EIP1559 - next: - status-go: waku2 bandwidth stats - status-go: continue work on lightpush+filter mode **Anthony** - done: - Fix merge with master issue for communities chat color PR - Remove the keyuid from login page which was display by mistake as address - current: - "try" debug the issue on performance **Sale** - done: - Issue 3005 (PR 3058) - support jumping to search result message that is not currently loaded in memory - Issue 2994 (PR 3060) - Gas Selector modal has text, divider and custom/suggestions toggle overlapped - current: - Checking translations issue Pascal had - next: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat ### July 23 (Friday) - Standup **Nastya** - done / current: - PR 3025 (limit pin messages to 3) **Jonathan** - done: - Limit to 3 pin messages pet channel - Done so that we ca save them permanently in communities - Fix mark as read in the activity center - Fix pin counter in communities - current - Making pin messages permanent in communities - will be done my saving the pin messages inside the community chats (description) **Sale** - done: - Issue 2912 (PR 3008) - implement search on sqlcipher / status-go side - current: - Issue 3005 - support jumping to search result message that is not currently loaded in memory - next: - Issue 2996 - Clicking push notification does expand the app but does not open correct channel / chat - Issue 2994 - Gas Selector modal has text, divider and custom/suggestions toggle overlapped **Richard** - done: - go-waku#34: added support for multiple protocol IDs - go-waku#35: fixed order of fields of HistoryResponse protobuf (due to spec change) - go-waku#36: refactor store - go-waku#37: added error messages in HistoryResponse (spec change) - go-waku#38: lint - status-desktop#3026: limit suggestions to member list in communities - status-desktop#3032: display current user's ENS in profile and share URL - go-wakurelay-pubsub#4: add constructor that supports a protocol matcher function - status-go#2283: exclude bindata.go from codeclimate - status-go#2284: exclude migrations from codeclimate - rebases - status-desktop#2654: go-waku - status-desktop#2872: status of community members - status-go#2276: user status - current: - status-desktop#2935: upload/download bandwidth metrics - next: - status-go: add go-waku peer store table to sqlcipher - status-go: continue work on lightpush+filter mode - status-desktop: EIP1559 **Andrei** - done: - #2919 missing context menu to quit app on windows - #2992 Timestamp appears after each message in community channel, also Fetch messages as well - #2603 Crash on login possibly due to getSettings, SIGSEGV on login - #2843 Improve error handling during login - #2840 Update options for a message in Pinned messages modal - #3002 Membership request count doesn't seem to change when switching communities - single app instance (per app dir) - current: - #3022 Channel history is not shown when upgrading the app - reminder: - limited availability on Monday 07/26 **Anthony** - done: - Redundant notification on joining/leaving a group chat - Gif widget MVP - Remove add to contact banner - Fix uploading an image with special character - Fix translation of gas selector modal - prevent double addition of private chat - next: - need ticket ### July 22 (Thursday) - Standup **Nastya** - done / current: - testing master build focusing on communities - logged various issues - retested delete messages PR again - tested PR 3020 **Andrei** - done: - #2603 Crash on login possibly due to getSettings, SIGSEGV on login - #2843 Improve error handling during login - single app instance bound to the current app dir - current: - #2840 Update options for a message in Pinned messages modal - next: - need more tasks ### July 21 (Wednesday) - Standup **Nastya** - done / current: - testing master build focusing on communities **Jonathan** - done: - Add handling of group chat links - Created an issue to add the handling of requesting access to that group chat, but it requires designs - 1-1 session with Sale to explain how status-go works and how to tackle the search task - Fixed one remaining warning/useless log - most other warnings were already fixed previously - Added the unfurling message/buttons for unfurling normal images - Now users will see where to go to enable displaying all images - Did a lot of rebases and made sure my status-go PRs built so that they can be merged (soon) - next - Pin message limit and save **Andrei** - done: - #2919 missing context menu to quit app on windows - #2752 Add Account modal is not being closed when clicking Add Account - current: - #2603 Crash on login possibly due to getSettings, SIGSEGV on login - #2843 Improve error handling during login - second app instance check **Anthony** - done: - Ensure that the chat loaded in communities always contains all the information required in order to display it. This require to merge community chat and chat - In the wallet, display the number of confirmation for a transaction rather than the static value: 9999 - Allow to start a chat when the requested is accepted while the app was open - Restore mute/unmute communities - current: - Initial work on trying to get gif from tenor API - Add a new advance setting to enable the feature - Backend: query trending gif as well as search - Create view dedicatedf for gif - Add gif icon in the chat bar - Create a basic popup to render the trending and allow to search gif - next: - Redundant notification when creating/leaving a group **Sale** - done: - Issue 2833 (PR 2960) - Use different icons for Windows/Linux and MacOS - Issue 2409 - clicking on fetch more messages should have immediate feedback and prevent multiple clicks - checked, commented on this - Issue 2467 (PR 2937) - Imported community needs a loading state - within this ticket I added translations for all untranslated properties we have so far - current: - Issue 2912 - implement search on sqlcipher / status-go side - adapted code for future changes (fixe memory issue I found there), prepared status go part, also appropriate nim part, need to develop fetch more messages if user clicks on some message from the search result list which is not displayed in the channel yet. - next: - Need new tickets **Richard** - done: - status-desktop#2964: make gas selector visible in transaction modals - status-desktop#2990: refactor node config logic - status-go#2281: content topic format - rebases - status-desktop#2872: show status of community members - status-desktop#2654: go-waku - status-go#2276: user status - status-desktop#3004: support bloom filter levels - next: - status-desktop#2935: upload/download bandwidth metrics ### July 20 (Tuesday) - Standup **Nastya** - done / current: - PR 2936 (delete messages) retest - next: - https://github.com/status-im/status-desktop/pull/2950 - https://github.com/status-im/status-desktop/pull/2963 ### July 19 (Monday) - StandUp **Nastya** - done / current: - tested again 2800 PR (installer) - retest PR 2936 (delete messages) **Jonathan** - done: - Fixed some issues with the delete identified by Nastya and Andrei - Added tests for delete in status-go - This uncovered another bug I had where if you receive the signal for a deleted message before the actual message, the backend woudl freeze - This is because I did a query in status-go to fetch the delete messages (I had already thought of dealing with previously dleete messages), but only fetched the first row, since it's always just a one for one. But that freezes the DB, because it doesn't consider the query done - Anyway, don't do the same mistake. It took me a long time to understand what the issue was (it just froze and tests timed out) - Good news though, I found that in Code, you can run individual tests, so no need to run the whole suite, good time saver - next: - Fix/add group chat links in the chat - Pin message limit and save **Anthony** - done - Display reaction in pinned modal. Also allow to add reaction directly from pinned modal - Fix unpin message index - current - Display the number of confirmation in the wallet (currently a TODO) **Andrei** - current - #2919 missing context menu to quit app on windows - prepared all changes - NEED RW ACCESS to DOtherSide and nimqml repos - improved `make run` performance and fixed qrc generation script - next - #2752 Add Account modal is not being closed when clicking Add Account **Sale** - done: - Feature 2467 (PR 2937) - Imported community needs a loading state - updated code according to the code review comments - Issue 2646 - Error execution reverted when quitting app having pending transaction. I commented on this. Checked also variant to exit the app from c++ instead of qml code, but didn't work. - current: - Issue 2409 - clicking on fetch more messages should have immediate feedback and prevent multiple clicks - behaviour is correct, yet not sure in what cases the issue is happening - Issue 2833 - Use different icons for Windows/Linux and MacOS - used this ticket to set up windows env for developent, want to complete this and check changed icon there before I commit the changes - next: - Issue 2912 - implement search on sqlcipher / status-go side ### July 16 (Friday) - StandUp **Nastya** - done / current: - investigated more the crash in win installer PR - PR 2936 (delete messages) **Jonathan** - done: - Unblocked the Chat input when we have no confirmation of mutual contacts (#2911) - Added 1-1 message from strangers to the activity center (#2911) - Those two above make it possible to chat with mobile - Finished the delete message feature on status-go (#2279) and desktop (#2936) - current: - Adding tests to the status-go delete messages PR **Andrei** - done: - #2922: invitation bubble long text support - #2913: mentions badge cleanup - #2918: render message age instead of message time - next: - Need more tasks **Anthony** - done: - Remove context menu when not admin/manager - Propagate communities chat correctly - current: - Need more tasks - Exploring statusQ / nim-status **Sale** - done: - Issue 2719 (PR 2914) - Sign and Send appears for both recipient and sender when sharing the address. Discussed on Discord, new ticket created Issue 2915. - Feature 2467 (PR 2937) - Imported community needs a loading state - Issue 2651 - Status app is not responding when right click -> Quit the app after sleep. Cannot reproduce, commented. - current: - Issue 2646 - Error execution reverted when quitting app having pending transaction. I commented on this, but trying to check why do we have that delay. - next: - Need new tickets ### July 15 (Thursday) - StandUp **Nastya** - done / current: - PR 2914 (sharing address issue) - PR 2911 (enabling chat input) - PR 2800 (win installer) **Andrei** - done: - #2918 Message date in 'status updates' - #2768 [Windows] Clicking notification for 1x1 chat from notification center does not open the app - next: - #2913 mentions badge not being cleared ### July 14 (Wednesday) - StandUp **Nastya** - done - retested search PR, it is ready to be merged - investigated several issues: closed 2494, checking transaction behavior on mobile - https://github.com/status-im/status-desktop/pull/2908 **Jonathan** - done: - Fixed issues with the search - Helped Sale with the chat command transactions - current: - Finishing up delete message - Signal works now, but still need to make it send the message as well (it deletes, but after restart) - Need to add tests - Show a warning when first deleting **Sale** - done: - Issue 2551 (PR 2910) - Push notification is duplicated when mentioning - Issue 2837 (PR 2866) - Accepting contact request crashes the app, I checked the issue Nastya found after my initial pr request, but it’s new issue, not related to changes made in my pr and this issue. - Issue 2369 - searching for an ens name and adding it should remove that contact from the 'non contacts' category in the search. Checked, commented. - current: - I am working on issues 2719 and 2720, they are connected (this will also fix issue 1205, currently assigned to Jo). Still have some doubts what’s the right flow for sending/receiving transaction in 1:1 chat - Issue 2719 - Sign and Send appears for both recipient and sender when sharing the address - Issue 2720 - Accept and Send remains active after the transaction was sent - next: - Issue 2651 - Status app is not responding when right click -> Quit the app after sleep - Issue 2646 - Error execution reverted when quitting app having pending transaction - feature 2467 - Imported community needs a loading state **Andrei** - done: - #1919 Windows application unresponsive when fetching Status updates - next: - #2768 Clicking notification for 1x1 chat from notification center does not open the app - may be impossible to fix on the client side, but I will investigate this **Anthony** - done: - Nickname disappears when closing the modal and open profile - Changing nickname or a profile picture triggers an accept contact request notification - Push notification preview is a placeholder when receiving a sticker / picture as a message - Clicking Add Contact button does not have any visual representation - Unmute button in Profile -> Notifications does not have any action mapped to it - next: - Communities don't seem to propagate their color properly ### July 13 (Tuesday) - StandUp **Nastya** - done / current: - retest 2846 (chat search) - testing categories again with mobile implementation https://github.com/status-im/status-react/pull/12264 - closed https://github.com/status-im/status-desktop/issues/2546 - retest 2866 (accept contact request crash) - logged https://github.com/status-im/status-desktop/issues/2902 **Andrei** - done: - #2647 Picture preview is not shown when posting to Timeline - #1920 Auto scroll after fetching messages in Status updates - #2856 Fetch more messages functionality is gone in public chats - #2835 Timeline: cannot attach a valid JPG file having extension in capital letters - #2382 Wrong message when all contacts have been added to a group chat - current: - #2768 [Windows] Clicking notification for 1x1 chat from notification center does not open the app // seems impossible to fix on the client side, looks like a limitation of the current Qt implementation; a possible solution is to use a 3rd party library for notifications. - next: - #1919 Windows application unresponsive when fetching Status updates ### July 12 (Monday) - StandUp **Nastya** - done / current: - PR 2846 (search) - logged 2874 - PR 2872 (community members status) - PR 2866 - PR 2858 - next: - whatever is in PR queue **Jonathan** - done / current: - Vaccinated :mask: - Fixed issues in the mentions PR - Fixed the order to be more complex and relevant - Fixed the index to be on the first in the order list - Was way harder than it should have, because the index of the item changes when you sort it, so I tried a ton of thing to make it work until it did - next - Fix max-height issue on the local search - Finish delete message **Richard** - done - Updated go-waku and status-go with latest store protocol changes - status-desktop#2872 show status of community members - status-go#2276 user status - status-desktop#2877 waku bloom filter mode switch - current - Waku relay switch on desktop - next - Display status of added contacts - Vacations :beach_with_umbrella: **Sale** - current: - Issue 2719 - Sign and Send appears for both recipient and sender when sharing the address - next: - Issue 2720 - Accept and Send remains active after the transaction was sent **Anthony** - done: - Decline/Reject all contact request when the full list of request cannot be displayed on the screen - Hide edit message in pinned message popup - current: - Double send notification about being able to chat with someone **Andrei** - done: - #2673 Can't click the links and hashtags in timeline - #2845 Navigating from Chats to Timeline shows wrong messages - next: - Need more tasks ### July 9 (Friday) - StandUp **Nastya** - done / current: - closed issue with running status process on windows (can't reproduce) - PR 2844 (timeline links) - PR 2834 (wrong password signing txn)-> can't reproduce the crash, need some hints - PR 2847 (re-encrypt blank screen) -> done - PR 2848 (zero txn) - next - search messages PR **Jonathan** - done: - Finished the local message search (PR #2846) - Need to fix the max-height and scroll - Fix blank screen in the onboarding (PR #2847) - Make it possible to send 0 value TX (with warning) (PR #2848) - Show mentions ordered by relevance (PR #2850) - current: - Delete message work - Status-go change mostly done. Missing tests - Add a warning - Testing propagation **Sale** - done: - Issue 2837 (PR 2866) - Accepting contact request crashes the app - Issue 2819 (PR 2861) - Crash when clicking notification with mention - Issue 2825 (PR 2858) - Leaving chats crashes the application - next: - Need new tickets **Andrei** - done: - #2673 Can't click the links and hashtags in timeline - #2789 Crash when pinning a message for a chat with cleared history - #2859 Scroll to the bottom button does not work - PoC for `SortFilterProxyModel` memory usage - current: - code reviews (desktop, StatusQ) - nim-status-client.pro + nim_status_client.dll - next: - need new ticket(s) **Richard** - done: - Spec for user status in status-desktop#2811 - Rebased status-desktop#2712 (QT 5.15). - Found an issue related to the user list. - I'll wait until this component is implemented in StatusQ to fix this issue. I'll keep rebasing the PR in the meantime - current: - status-desktop#2811 - implement spec for user status in status-go - Updating go-waku store protocol - EIP1559. Some information still missing that depends on status-go (see #eip1559 channel). I'll test sending transactions today with this [status-go branch](https://github.com/status-im/status-go/compare/feature/upgrade-geth) - next: - Implement Waku RLN: how to call smart contract operations from go-waku **Anthony** - current - Update color of close button on chat layout for suggestion - Update color ot time in the timeline for images - Avoid rpc error when iterating over collectible - Fix timeline to display messages ### July 8 (Thursday) - StandUp **Nastya** - current / done: - working on alignment of pinned messages with desktop and mobile - - - **Andrei** - current: - #2789 Crash when pinning a message for a chat with cleared history - PoC for `SortFilterProxyModel` - done: - #2673 Can't click the links and hashtags in timeline - #2430 Add members window shown when accessing 1x1 chat within group chat ### July 7 (Wednesday) - StandUp **Jonathan** - done: - Rebased and merged the group request in activity center PR - current: - Message search almost done. Need to fix the display and add the click events and polish **Richard** - done: - status-desktop#2810 - when in a community use the member list as a source for the user list - Rebased PRs status-desktop#2793, status-desktop#2784 status-desktop#2709 - Discussed with @cammellos status-desktop#2811 to determine how to implement user's current status in status-go - status-desktop#2774 fetch more than 24 hours by default - Address code review issues in status-go#2258 PR (go-waku store) - Debug cause of invalid address in transaction command in status-go - current: - Currently working on EIP1559. Some fields data are still missing. Working on sending transactions with hardcoded values - next: - Update go-waku Store protocol (current go-waku version is outdated compared to nim-waku) - Implement Waku RLN: how to call smart contract operations from go-waku **Andrei** - done: - Fixed 2430 (in review) - Checked almost all Desktop articles on hackmd.io - current: - 2673 - Can't click the links and hashtags in timeline **Sale** - done: - Issue 2623 (PR 2834) - Status desktop crashes when siging token transaction with invalid password - Issue 2718 (PR 2829) - Clicking Sign and Send crashes the app - Issue 2788 (PR 2814) - Mark as read does not clear @ symbol in chat - conficts resolved - Issue 2260 (cannot reproduce it) - transfering balance between accounts does not immediately update in the UI - next: - Need new tickets **Nastya** - current / done: - testing recent master build - logged https://github.com/status-im/status-desktop/issues/2837, - https://github.com/status-im/status-desktop/issues/2838 - https://github.com/status-im/status-desktop/issues/2839 - https://github.com/status-im/status-desktop/issues/2840 - next: - continue with that, checking pin / edit messages with mobile, also communities and so on ### July 6 (Tuesday) - StandUp **Nastya** - current / done: (a lot of small bug fixes, all ready to be merged) - 2817 - 2816 - 2815 - 2814 - 2809 - PR 2785 (communities notifs) -> retested, good to merge but might need a rebase - next - deal with PR 2793 (user list feature) - PRs queue - test master since there are a lot of fixes merged also mobile merged a lot of status-go stuff , so would be nice to test integration, which i plan to be busy with tomorrow **Andrei** - done: - 2151 - updated status icons - Running the project from QtCreator (initial version works, more work TBD later this week) - next: - 2673 - can't click the links and hashtags in timeline ### July 5 (Monday) - Iteration Meeting **Andrei** - done: - Fixed 2379 (pending PR) - Fixed 2743 (pending PR) - current: - learning nim... - investigating UI project to link status_client_nim. **Nastya** - current / done: - PR 2625 (edit messages) -> retested, ready to merge - PR 2793 (user list feature) -> postponed, figuring out designs and reqs - PR 2785 (communities notifs) - logged https://github.com/status-im/status-desktop/issues/2819 - next - https://github.com/status-im/status-desktop/pull/2817 - https://github.com/status-im/status-desktop/pull/2816 - https://github.com/status-im/status-desktop/pull/2815 - https://github.com/status-im/status-desktop/pull/2814 - https://github.com/status-im/status-desktop/pull/2809 **Sale**: - current/done: - Issue 2788 (PR 2814) - Mark as read does not clear @ symbol in chat - Issue 2804 (PR 2815) - Onboarding screen changes - Issue 2755 (PR 2816) - Clicking Request Address when sending -1 STT crashes the app - Issue 2753 (PR 2817) - Crash when enter -1 to Gas Selector - next: - Need new tickets **Richard**: - current/done: - Currently working on EIP1559 (I have doubts regarding the origin of fields in the UI). See demo at https://github.com/status-im/status-desktop/pull/2818 - Address code review issues in status-go#2258 PR (go-waku store) - next: - Implement Waku RLN: how to call smart contract operations from go-waku **Jonathan**: - current/done: - I was off - Continue working on the chat message search **other meeting notes**: - Andrei experimenting compiling Nim code into a C library accessible in a c++ app so we can open the project in qt creator - Discussion about objects received from status-go library that are replaced in the status-lib library - Discussion about available docs, lack of docs for status-go apis ### July 2 (Friday) - Standup **Andrei** - current / done: - continue onboarding - added intro video - 2379 (in PR) starting a group chat shouldn't show the section to fetch more messages - 2560 (in PR) Dap.ps is not opened by default when accessing browser - 2795 (in PR) SNT icon is blurred - 2796 (in PR) ENS usernames: Wallet address copy button copies wrong value - next: TBD **Nastya** - current / done: - logged 2804 - tested PR 2801 - tested PR 2802 - tested PR 2803 - retesting PR 2625 - next - PR 2793 (user list feature) **Sale**: - current/done: - Issue 2449 (PR 2779) - bug: "Invite successfully sent" shown prematurely on Community invite popup - Issue 2788 (in progress) - Mark as read does not clear @ symbol in chat (this issue is slightly extensive, requires lot of changes) - next: - Issue 2804 - Onboarding screen changes - Issue 2755 - Clicking Request Address when sending -1 STT crashes the app - Issue 2753 - Crash when enter -1 to Gas Selector **Richard**: - current/done: - status-desktop#2793 user list - status-desktop#2798 invalid keyuid used on first time login - status-desktop#2801 fix rebase error affecting loading and counter of pin messages - status-desktop#2802 fix: channel description width - status-go#2273 fix: make community id prefix optional on chat ids - Fixed PR issues in status-desktop#2625 and status-desktop#2709 - Currently working on EIP1559 - Address code review issues in status-go#2258 PR (go-waku store) - next: - Implement Waku RLN: how to call smart contract operations from go-waku **other meeting notes** - It should be possible in windows to use encryption library with all the optimizations which should help with the dropped group messages issue ### July 1 (Thursday) - Standup **Nastya**: - current/done: - PR 2790 - PR 2782 - PR 2787 - PR 2779 - next: - focus on testing master tomorrow ### June 30 (Wed) - Standup **Nastya**: - current/done: - logged https://github.com/status-im/status-desktop/issues/2788 - logged https://github.com/status-im/status-desktop/issues/2789 - PR 2625 (edit messages) -> left a comment with the issues found - next: - noticed that a lot of things are broken with recent merge of huge refactor, so might focus on testing master but will review PRs queue first **Jonathan**: - current/done: - Addressed issues found by Nastya on the history button PR - Button didn't fetch (at least didn't crash) - I needed to fix the initial fetch and initial balance init that was commented during the refactors - Rebased a couple of PRs - Added the notification setting to communities - required a status-go PR - Fix crash when going back to the chat from a community - next: - Implement channel search **Sale**: - current/done: - Issue 2267 (PR 2779) - typing in `<` in the input box deletes everything afterwards in - Issue 2297 (PR 2782) - Naming validation for communities - next: - Issue 2449 - bug: "Invite successfully sent" shown prematurely on Community invite popup - Need new tickets **Richard**: - current/done: - status-desktop#2786 Generate log file with console output in status-desktop - status-desktop#2784 Refactor wallet calls - Rebased Edit Messages PR - Working on EIP1559 - next: - Address code review issues in status-go#2258 PR (go-waku store) - Implement Waku RLN: research how to call smart contract operations from go-waku ### June 29 (Tuesday) - Standup **Nastya**: - current/done: - spent some time to replicate this issue, still no luck https://github.com/status-im/status-desktop/issues/2758 - PR 2747 (profile refactor) - tested, issues - PR 2761 -> retested, good to merge - PR 2757 -> retested, good to merge - PR 2770 (new onboarding screen) -> good to merge - PR 2625 (edit messages) - next: - PR 2625 (edit messages) ### June 28 (Monday) - Iteration Meeting **Iteration Highlights**: - status-desktop#2537 - EIP 1559 - status-desktop#2468 - refactor wallet calls for security - status-desktop#2771 - local message search support - status-desktop#2772 - simple channel user list - [see zenhub for other tasks](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/board?milestones=Rats%20Cohort%20-%20Iteration%201%232021-07-04&filterLogic=any&repos=261270348,264545442&showPRs=false&showClosed=false) **Nastya**: - current/done: - PR 2766 (community chat view) - good to be merged - PR 2757 (delete community channels) -> one issue found - PR 2737 (community push notifications) -> need Eric to take a look - dig into PNs on windows - next: - PR 2763 (community names) -> good to merge - PR 2767 (community context menu) -> good to merge - PR 2747 (profile refactor) -> in testing right now - test PNs on windows more (could be delayed) - https://github.com/status-im/status-desktop/issues/2758 -> to reproduce (was not able to replicate yet) **Aleksandar**: - current/done: - Issue 2558 (PR 2770) - Mobile onboarding slider is shown on desktop - next: - Getting familiar with the code - Need new tickets **Jonathan**: - current/done: - Finished the feature to delete community channels - Fixed QML warnings/errors caused by rebases - Removed the Nim import warnings - Fixed the load more history button crash - next: - Waiting for the contact request refactor spec to be reviewed - Work on new issues assigned today **Richard**: - current/done: - Update status-go to use latest go-waku version - Implement Waku RLN: Researched how to call a rust lib from go - Currently working on modifying status-go code to use lightpush/filter instead of relay - next: - Implement Waku RLN **Other meeting notes**: - status-desktop#2506 - we still need to wait for mobile to implement contact requests, we could remove the restriction on the input for now so the messages sending work again - status-desktop#2604 - waiting on a PR review on status-go - status-desktop#2343 - discussion of breaking down search task - status-desktop#2772 - discussion of how to implement a simple user list - status-desktop#2758 - discussion about issue, natsya will verify ### June 24 (Friday) - Standup **Aleksandar**: - current/done: - Issue 2492 (PR 2763) - Long community names should be truncated - Issue 2547 (PR 2767) - Right click inside the community pane does not open context menu - Issue 2558 - Mobile onboarding slider is shown on desktop - next: - Getting familiar with the code **Jonathan**: - OOO **Richard**: - current/done: - status-desktop#2576 - rebase error fix. prevMsgTimestamp and nextMsgTimestamp - status-desktop#2729 - desktop updater. Still pending using the correct ENS address - go-waku#32 added prometheum metrics to go-waku - go-waku#28 Completed Lightpush / Filter protocols showcase for example chat app - Unsuccesfully hunting for the login crash\ - status-desktop#2747 - refactored profile section code - next: - Update status-go to use latest go-waku version - Use Lightpush / Filter (?) in status-go via setting - Implement Waku RLN **Nastya**: - current/done: - PR 2749 -> looks good apart 1 possible fix, need Jo to advise - PR 2761 -> history is not loading, not ready to be merged - PR 2713 -> ready to be merged - next: - - PR 2766 (community chat view) - PR 2757 (delete community channels) - PR 2737 (community push notifications)