# Rats - Archive september 20 2021- december 30 ## December 27 (Mon) **Boris** - done: - Update Node PR - Reviewed bunch of PRs - current: - Update Groups PR ## December 24 (Fri) **Nastya** - done: - https://github.com/status-im/status-desktop/pull/4199 - https://github.com/status-im/status-desktop/pull/3825 - https://github.com/status-im/status-desktop/pull/4334 - https://github.com/status-im/status-desktop/pull/4333 - current: - test base_bc - retest some PRs after fixes **Sale** - done: - PR-4336 - load more messages - PR-4339 - profile settings (about & advanced subsections), required some minorr changes in `statusq`, PR-510 - current: - Continued checking profiles subsections, currently working on `Devices settings` that part was not refactored at all yet - next - rest of the context menu general options (copy image and so...) **Boris** - done: - Rebased and merged old PRs - Updated old PR for node and groups - current: - Updating node and groups bc of new refactoring changes - next: - Updating PR with Profile picture changing bc we have more than one `RootStore` ## December 22 (Wed) **Jo** - done: - Refactored the fecth version and update module - Fix/refactored the send message, send image and send sticker calls - Then now send correctly and show up in the message list - current: - Refactoring the QML for the chat commands - includes ENS resolving and some transaction modal fixes **Nastya** - current: - closing / moving issues from GH to https://notes.status.im/WRxqXVC7ReyBvl49nIBfdg?edit for base_bc - testing base_bc - https://github.com/status-im/status-desktop/pull/4314 - https://github.com/status-im/status-desktop/pull/4332 - https://github.com/status-im/status-desktop/pull/4278 **Sale** - done: - PR-4329 - add gropup/community admin and roles user has depends on the admin flag, this PR also included completion of `ChatContextMenuView`, `CreateChannelPopup` and updating `PinnedMessagesPopup` - current: - load more messages - next - rest of the context menu general options (copy image and so...) **Boris** - done: - Update move communities PRs [#142](https://github.com/status-im/status-lib/pull/142) and [#4321](https://github.com/status-im/status-desktop/pull/4321) - Rebase node section PR [#4114](https://github.com/status-im/status-desktop/pull/4114) - current: - Rebase Grops section PR ## December 20 (Mon) **Jo** - done: - Fixed version banner appearing wrongly - also fixed where it appears - also fixes the profile icon position - Fixed the profile popup missing properties **Nastya** - current: - switched to test master build as agreed because base_bc is not confirmed yet as stable - working on creating more scenarios for future automation Reminder, that i will be off next week **Boris** - done: - Draft PR with communities [#4321](https://github.com/status-im/status-desktop/pull/4321) - current: - Proccess communities responses, updates and other. **Sale** - current: - add/remove reaction for a certain message - next: - add gropup/community admin and roles user has depends on the admin flag - load more messages - rest of the context menu general options (copy image and so...) ## December 17 (Fri) **Jo** - done: - Finished joining a community - Refactored all of the community functions for the backend (controller, service and status-lib) - Fixed, rebased and merged those PRs - Fixed the issue with the mutual contact banner appearing all the time - current: - More fixes on the chat **Nastya** - current: - review new desgings and specs - started preparation for automation suite draft - polishing existing check list at the same time **Sale** - done: - profile/advanced tab - pin/unpin message, pinned message list - current: - add/remove reaction for a certain message **Boris** - done: - A bunch of community methods moved to View/Module/Controller (and vice versa) - current: - finish moving methods for community - next: - Rebase old PR's ## December 15 (Wed) **Jo** - done: - Finished fixing activity center according to reviews and merged - Rebased and fixed some stuff on my old profile refactor PR - It was way out of date and some stuff needs to be improved - Refactored the community list fetch and show - current: - Working on joining a community **Nastya** - done: - logged various issues for base_bc branch - added feature request to reimplement Update banner - current: - contiue testing base_bc - wanna make myself familiar with new designs **Boris** - done: - Communities: - accept/decline invitation - remove/invite users - current: - Next bunch of Communities methods **Sale** - done: - removed everything referring to the old code - started with add reactions to the messages, actually updating context menu which is used for other actions as well but was interupted with advance tab - added `globalUtils` instance which partly changes old `utilsModel` - current: - profile/advance tab updating ## December 13 (Mon) **Jo** - done: - Finished moving the activity center to the new architecture #4282 **Nastya** - done: - https://github.com/status-im/status-desktop/pull/4281 - https://github.com/status-im/status-desktop/pull/4277 - https://github.com/status-im/status-desktop/pull/4241 - this requires additional dev work, seems the feature was never working as expected - current: - testing base_bc branch **Boris** - done: - Add join methods and fix comments for groups PR - current: - Moving communities methods to new architecture **Sale** - done: - chat identifier message/component refactoring (remains to hook on the qml side to join/leave group chat methods) - rebased `refactoring/chat-communities` containing 7 features onto `base_bc` and fixed conflicts - current: - removing connections to the old code ## December 10 (Fri) **Jo** - done: - Created a PR for the work I had on fixing notifs and icon on Windows - current: - Refactoring activity center **Nastya** - done: - finally reproduced a crash with accepting contact request - current: - https://github.com/status-im/status-desktop/pull/4241 - https://github.com/status-im/status-desktop/pull/4276 - https://github.com/status-im/status-desktop/pull/4277 - https://github.com/status-im/status-desktop/pull/4278 **Boris** - done: - Add methods for getting profile images for contacts in chat [#4241](https://github.com/status-im/status-desktop/pull/4241) - Rebase PR for groups on new base_bc - current: - Trying to figure out why profile images still not working. - Adding last methods for groups (join's methods) and fixing comments from Sale **Sale** - done: - messages integration on the qml side per chat/channel - removed `NormalMessageView` and `useCompactMode` from qml - a list of users who reacted with an emoji now displays names instead of users' public key (done on the backend side only) - current: - chat identifier message/component refactoring ## December 8 (Wed) **Jo** - done: - Refactoring 1-1 chats - Investigated the crash on Windows but I still couldn't reproduce even after multiple tries and different setups - current: - Trying to fix the bug on Windows where the task bar icon and notifications sometimes stop working **Nastya** - done: - investigating issue with crashes on windows - updated a bit check list but need to invest more into this - assisting Abhi - current: - https://github.com/status-im/status-desktop/pull/4268 - https://github.com/status-im/status-desktop/pull/4258 **Sale** - done: - pin/unpin messages for chat/channel from chat/channel list as well from chat/channel title bar - current: - messages integration on the qml side per chat/channel **Boris** - done: - Move groups to new architecture [#4270](https://github.com/status-im/status-desktop/pull/4270) - Find method for displaying contact pictures[#4241](https://github.com/status-im/status-desktop/pull/4241) - current: - Fix displaying avatars for contacts which not in contact list [#4241](https://github.com/status-im/status-desktop/pull/4241) ## December 6 (Mon) **Jo** - current: - Refactoring 1-1 chats - Send images done - Leave channel done (also works for other types of chat) - Working on send and request transaction **Nastya** - current: - testing PRs that i was set as reviewer - https://github.com/status-im/status-desktop/pull/4243 - https://github.com/status-im/status-desktop/pull/4242 - https://github.com/status-im/status-desktop/pull/4241 - https://github.com/status-im/status-desktop/pull/4249 - working on adjusting test documentation along with testing master build **Sale** - done: - rebased `base_bc` onto `master` - fixed issues we had after rebase - updated `online_users` after rebase and fixed issues - current: - started with messages integration on the qml side per chat/channel **Boris** - done: - Move methods for groups to new architecture. - current: - add usage to QML and test ## December 3 (Fri) **meeting notes:** - release/0.4.0 has a pending [issue](https://github.com/status-im/status-desktop/issues/4240) - base_bc branch is currently being rebased on master, and the receive messages functionality needs to be moved to the new architecture, once that's done, nastya will do a smoke test so we can merge it into master as to not keep two main branches concurrently - Jo and Boris working on moving 1 on 1s and group chats to new architecture **Jo** - done: - Did the finishing touches on the stickers refactor + bug fixes - remove dependency on dto in views and use Item instead - Fix getting installed and recent stickers - Fix stickers appearing as loading on a new account when joining a channel for the first time - Remove import to the old status-lib code - current: - Refactoring 1-1 chats **Sale** - done: - PR-4234 - chat/channel users list refactored - PR-4228 - join/create public chat - current: - rebasing `base_bc` onto `master` - next: - start with an integration of initial messages on the qml side per chat/channel **Boris** - done: - Update node-section by last comments form Sale - Fix drawing icons for user out of contact list [#4241](https://github.com/status-im/status-desktop/pull/4241) - current: - Move groups chats to new architecture [#4223](https://github.com/status-im/status-desktop/issues/4223) **Nastya** - current: - reviewed (tested) bunch of PRs - assisting Abhi to get familiar with the app and infra etc - quick spin for beta 4. we need to bring emojis back and release ## December 1 (Wed) **Jo** - done: - Fixed Windows and Linux Notifications - Fixed missing taskbar icon - Fix nickname not populated when clicking the profile button is chat - investigated: - I tried to fix the problem with the thread not closing - It,s because the getLatestVersion call calls the IPFS gateway, but the version file was not pinned - Also, we don't have a way to interupt the request - I opened a ticket for it **Nastya** - current: - release leftovers - switching to test PRs for master - https://github.com/status-im/status-desktop/pull/4198 - https://github.com/status-im/status-desktop/pull/4207 - https://github.com/status-im/status-desktop/pull/4212 - https://github.com/status-im/status-desktop/pull/4218 **Sale** - done: - renamed `hasNotifications` property in `statusq` according to the review comments, that required updating `status-desktop` part as well - added option to select chat/channel from the list in chat/community section - added `name`, `icon` and `isIdenticon` properties to the global instance `userProfile` which will make qml part cleaner (also update qml accordingly) - current: - working on chat's and channel's users list **Boris** - done: - Update node section by last comments - Review bunch of PR's in details - current: - Bug with settings when toggle on some of settings has no affect. ## November 29 (Mon) **Jo** - done: - Helped Alex again with the contact PR, now it's all done - current: - Trying to fix the Windows notifications **Sale** - done: - Reviewed PRs - Re-checked `node section module`, added new comments there - merged/fixed/completed everything related to new backend models and statusq changes applied in PR-486, so chats/channels/categories list are displayed base on refactored models/code - Added `You` for messages sent by logged in user in app search result - current: - working on backend part for chat's, channel's users list, qml part is not in place yet, but I am trying to prepare the backend part first **Boris** - done: - Fix change password success dialog [#4199](https://github.com/status-im/status-desktop/pull/4199) - Fix most of comments for node section - Review some PRs - current: - Add methods for node section module - next: - Some available bugs ## November 26 (Fri) **Jo** - done: - Some more adjustments for the sticker refactor + now merged - Helped with Alex's contact issue - Tried to fix the channel select hover issue - couldn't find the reason, it's too weird - Fix reply image displaying your own image **Sale** - done: - Reviewed PRs: `status-desktop` 4137, 4113, 4092, 4170 `status-lib` 112 `statusq` 486 - Re-checked `stickers module`, added new comments there - aligned a structure for all modules, so we have an order of doing things and module related notifications - added new convenient methods to chat and contact services `getOneToOneChatNameAndImage` and `getContactNameAndImage` - updated components in `StatusQ/pull/486` in a shape we need them in the desktop app - current: - trying to merge and adapt new backend models and statusq changes applied in PR-486 - next: - to continiue on backend part for chat's, channel's users list **Boris** - done: - Finished with node section (#4114)[https://github.com/status-im/status-desktop/pull/4114] - Review bunch of PR's - next: - Bug for 0.4.0 ## November 24 (Wed) **Jo** - done: - Reviews and cherry picks for the release branch - Reviewed and updated the contact request refactor spec - Finally finished the sticker refactor - Removed tenor from the link whitelist since it no longer works - Tried replicating the giphy issue with unfurling - I cannot replicate. **Nastya** - current: - finalising release stuff **Sale** - done: - Reviewed PRs: `status-desktop` 4152, 4135, 4153, 4102, 4159 `status-lib` 110 - Rebased`base_bc` on top of `base_02`, lot of conflicts resolved - Prepared some instructions for development on `base_bc`, shared with Pascal - settings service is improved and now we have a single one instead of 2 as it was before, and also new convenient methods are added for reading/storing values to the settings (there's no need any more to deal with storing key as a string, so a possibility for an error is minimized) - old fleet model is now fleet configuration and it's now part of the StatusFoundation class - node configuration is introduced as a new service, so it can be used from each part of the app where is needed. It's not raw json object any more, but a complex object type with appropriate properties so the same thing as it's for settings a possibility for an error using wrong string key is reduced to a minimum - current: - need to check `StatusQ/pull/486` since it's rendering chats/channels based on new backend model - next: - to continiue on backend part for chat's, channel's users list **Boris** - done: - Nim part of node section - Review bug with GIF's and provide solution with bug on OSX - current: - QML part of node section - next: - Remove tenor from status-desktop - fix gifs for OSX ## November 22 (Mon) **Sale** - done: - Issue-4058 (PR-4145) - online/offline selector not changing color/state - Started with sorting out settings service since we have 2 services relate to the same thing, but was interupt since Pascal proposed to have that on `base_bc` instead on `base_02`, so I paused that until rebase `base_bc` - current: - rebasing `base_bc` onto `base_02` which is rebased on top of the `master` branch - next: - to continiue on backend part for chat's, channel's users list **Nastya** - current: - dealing with release/0.4.0 **Boris** - done: - Rewrite NetworkModule - Update Node Service - current: - Testing node section - preparing code for PR - next: - Bugs by priority ## November 19 (Fri) **Jo** - done: - Fix minimize app on Windows and Linux - Fix problems with link messages - Rebased and merged contacts refactor - Merged status-lib stickers refactor - Tried to reproduce empty activity center for replies and mentions - current: - Continue fixing the stickers refactor so that it doesn't use old status-lib **Nastya** - current: - continue on testing master and handling 0.4.0 issues **Sale** - done: - General improvements (I needed for users online list): - Contact service (signal's arguments updated, sent payload optimized, local nickname added to profile section contacts model, rest updated accordingly to above changes) - `nim_status_client.nim` file cleaned up - current: - for the issue 4058 I have to sort out settings service since we have 2 services relate to the same thing - next: - Issue-4058 - online/offline selector not changing color/state - to continiue on backend part for chat's, channel's users list **Boris** - done: - Add node module to main module - Add node async service - Update node section code for compilation - current: - Refactoring NetworkModel - Preparing code for PR ## November 17 (Wed) **Jo** - done: - Rebased and retested the contacts refactor branch - Tried to reproduce the 0.4 Windows account import crash, but couldn't - current: - Addressing comments on the stickers refactor PR **Nastya** - current: - https://github.com/status-im/status-desktop/pull/4098 - https://github.com/status-im/status-desktop/pull/4124 - https://github.com/status-im/status-desktop/issues/4069 - https://github.com/status-im/status-desktop/issues/4104 - testing master for release **Sale** - done: - Code reviewed: `status-desktop`: PR-4112, PR-4113, PR-4114, PR-4124; `status-lib`: PR-107 - started on backend part for chat's, channel's users list, but then I realized that some other general things need to be sorted out first and just added a model and item there and moved to following - General things: - async job for fetching crypto services moved to buy/sell controller - the old way of fetching crypto services asynchronous is removed - global things moved to `global` section of the app - core things moved to `core` section of the app - os notification service updated - managing signals from `status-go` added to the desktop app. New class `SignalsManager` is introduced which is a main point for receiving signals from `status-go`. - current: - moving old code to the temporary part of the `AppController` which will be removed once it gets refactored, and sorting out the `nim_status_client.nim` - next: - to continiue on backend part for chat's, channel's users list **Boris** - done: - ***Refactoring node section*** - fix comments for node section (rename interfaces, update methods and etc.) - add service for node section - Reviewed some PR's and rebased/merged my PR's - current: - Add node module to main module ## November 15 (Mon) **Jo** - done: - Finished the stickers refactor - current: - Nothing. Gonna pick something nmew on Monday **Nastya** - current: - https://github.com/status-im/status-desktop/pull/4065 - test 0.4.0 **Boris** - done: - Provide draft PR for node section refactoring [4114](https://github.com/status-im/status-desktop/pull/4114) - Fix bug with open url in status browser [4117](https://github.com/status-im/status-desktop/pull/4117) - current: - Will fix comments from Sale and add node section module to main module **Sale** - done: - Code reviewed: `status-desktop`: PR-4114, PR-4113, PR-4103; `status-lib`: PR-107 - message service (`base_bc`) - methods for mark all and mark certain messages as read added - contact service (`base_bc`) - backend updated to handle local name for a contact, saving contact method fixed, `userNameOrAlias` updated - current: - started on backend part for chat's, channel's users list ## November 12 (Fri) **Jo** - done: - Fix small small issues with contact request refactor and clean up - current: - Continue moving stickers to the new architecture **Nastya** - current: - finish testing of base_02 branch to get it ready for merge to master - bug fixes for base_02 branch **Boris** - done: ***Node Section***: - Implement `view`, `controller`, `module` - Implement `private_interfaces` - current: ***Node Section***: - Preparing code for WIP PR (in a hour) - add node section module as submodule to main module - testing **Sale** - done: - app search - added messages' time, pretty channel/user names, users' images (for the difference how it was now custom image is displayed in location menu and searched messages also) - did code review for `status-desktop` PR: 4103, comments are there - removed old app searc reletad code which is not needed any more - helping Boris getting up to the speed with new architecture - current: - preparing service functionality for marking messages read for channel/set of messages - next: - app search - 2 features need to be applied once we have user profile and related qml part added: - jump to a message - "You" instead of logged in user name ## November 10 (Wed) **Nastya** - current: - https://github.com/status-im/status-desktop/pull/4077 - https://github.com/status-im/status-desktop/pull/4076 - https://github.com/status-im/status-desktop/pull/4070 - https://github.com/status-im/status-desktop/pull/4080 - https://github.com/status-im/status-desktop/pull/4081 - next: -https://github.com/status-im/status-desktop/pull/4065 **Jo** - done: - Move contact requests to the new architecture - Fix adding custom tokens - The async call to fetch token details had not been moved to the new architecture - Move all the remaining contacts calls in QML to the new architecture model and remove the old Nim code - current: - Move stickers to the new architecture **Sale** - done: - chat section module - chat naming follows alias/ens naming now - did lot of small fixes, including qml cleaning/updating - take a look into the changes we need on the qml side, prepared a models which need to be firstly updated on the statusq side - current: - app search module is initially completed - need to set up some small but important things like messages' time, pretty channek/user names, users' images **Boris** - done: - Fixed bug when app crashing of custom network usage [#4080](https://github.com/status-im/status-desktop/pull/4080) [#105](https://github.com/status-im/status-lib/pull/105) - current: - Node section. ## November 8 (Mon) **Jo** - done: - Fix adding and getting balance of custom tokens - Fix chat link preview being empty because of undefined whitelist setting - current: - Trying to add QJsonObject as a possible QVariant param so that we can use that as a default in the settings - This is so that we no longer have the issue as above where an object or array starts as undefined **Nastya** - current: - https://github.com/status-im/status-desktop/pull/4021 - https://github.com/status-im/status-desktop/pull/4046 - reviewing the board (Review/QA column): closed several issues, need an advise what to do with PRs here, for example https://github.com/status-im/status-desktop/pull/3608 - will continue reviewing the board, want to do some clean up there **Boris** - current: - Crashing on login via custom network. Almost done. - next: - Move node section to new architecture **Sale** - done: - Did rebse of `refactoring/base_02` and `refactoring/base_bc` - current: - working on app search module ## November 5 (Fri) **Nastya** - current: - revisiting the issues in base_01 branch - test https://github.com/status-im/status-desktop/pull/4033 - test https://github.com/status-im/status-desktop/pull/3965 - added https://github.com/status-im/status-desktop/issues/4052 - finally was able to reproduce https://github.com/status-im/status-desktop/issues/4041 - closed https://github.com/status-im/status-desktop/issues/4039 - retest https://github.com/status-im/status-desktop/pull/3965 - retest https://github.com/status-im/status-desktop/pull/4033 **Jo** - done: - Fix edit community channel - Fix delete community channel - Move logDir function to new architecture - Fix channel context menu data loss and group info empty bugs - Fix Send modal in the wallet - Helped Anthony find the source of the channel list being empty sometimes - current: - Fix adding custom token **Sale** - done: - Chat/communities - on the backend side added convenient methods for add/remove reactions, pin/unpin messages, pinned model added to the chat content module, message service updated accordingly for those changes. Message model is shared between chat content and messages modules - [`status-go` PR: 2423] - added new methods for fetching message details and message reactins by message id - current: - working on chat/communities part ## November 3 (Wed) **Jo** - done: - Moving fleets to the new architecture - Make ENS name search and tx history fetch async - Fix community edit and community banners - Fix profile pic change and move to new architecture - Fix changing language - current: - Fix community channel change **Nastya** - current: - testing refactoring/base_01 branch - attend QT World Summit 2021 (several sessions) - tested: - https://github.com/status-im/status-desktop/pull/4008 - https://github.com/status-im/status-desktop/pull/4012 - https://github.com/status-im/status-desktop/pull/4022 - https://github.com/status-im/status-desktop/pull/4021 - https://github.com/status-im/status-desktop/pull/4020 - added: - https://github.com/status-im/status-desktop/pull/4014 - https://github.com/status-im/desktop-ui-tests/pull/41 - https://github.com/status-im/desktop-ui-tests/pull/42 - https://github.com/status-im/desktop-ui-tests/pull/43 - https://github.com/status-im/StatusQ/pull/481 - closed: - https://github.com/status-im/status-desktop/issues/3974 **Sale** - done: - Issue-3953 - [refactoring/base_01] crash on recovering account - Issue-3944 - [refactoring/base_01] crash on creating new account - Issue-3945 - [refactoring/base_01] profile picture is missing when recovering account - Fixed the issue with "I have a Keycard" button - Chat/communities - added new chat content module there which contains `users`, `inputArea` and `messages` submodules, qml updated to have a single `ChatLayout` component for Chat section as well as for each Community section - current: - working on chat/communities part **Boris** - done: - Avoid crashes in GroupInfoPopup [#4024](https://github.com/status-im/status-desktop/pull/4024) - Tests review - current: - Application crash on custom network [#3963](https://github.com/status-im/status-desktop/issues/3963) ## November 1 (Mon) **Jonathan** - done: - Finished the refactor of network selection and custom networks - current: - Working on making the ENS search for contacts and the transaction history fetch async **Sale** - done: - [PR-3966] - user profile added globally - current: - [Draft PR-3937] - working on chat/communities part **Boris** - current: - Checking why some tests is not working - Working on node section ## October 29 (Fri) **Jonathan** - done: - Rebased and fixed the Profile refactor Iuri started - Refactored device sync - Refactored the contacts only message switch in Privacy - current: - Working on the Advanced panel - Boilerplate and Current network done - Working on the custom networks **Nastya** - current: - testing refactroring/base_01 branch **Sale** - done: - sorted out refactor related branches - rebase `refactoring/base_01` and make it ready for merging into `master` branch - current: - [Draft PR-3937] - working on chat/communities part ## October 28 (Thu) **Nastya** - current: - testing refactoring/base branch: Login flows ## October 27 (Wed) **Jonathan** - done: - Basic transaction history - Added back the transaction hisotry events - Added the multiple account support - current: - Moved the async transaction history fetch to the service - I'm stuck with the fact that the asyync task never calls back the slot - current: - Working on the refactor of the transaction history - Trying to make the thread to fetch transactions work **Nastya** - current: - continue working on tests **Sale** - current: - [Draft PR-3931] - working on chat/communities part ## October 26 (Tue) **Nastya** - done: - https://github.com/status-im/desktop-ui-tests/pull/37 - https://github.com/status-im/status-desktop/pull/3912 - https://github.com/status-im/desktop-ui-tests/pull/38 - https://github.com/status-im/desktop-ui-tests/pull/39 - https://github.com/status-im/desktop-ui-tests/pull/40 - current: - tests for modals ## October 25 (Mon) **Jonathan** - current: - Working on the refactor of the transaction history - Trying to make the thread to fetch transactions work **Boris** - done: - Add test for StatusSwitch [#33](https://github.com/status-im/desktop-ui-tests/pull/33) - Add test for StatusPickerButton [#34](https://github.com/status-im/desktop-ui-tests/pull/34) - Review tests PRs - Add the base files for issue [#3805](https://github.com/status-im/status-desktop/issues/3805) - current: - Working on issue [#3805](https://github.com/status-im/status-desktop/issues/3805). Trying to understand how it worked and how it should work within the new archcitecture **Nastya** - done: - https://github.com/status-im/desktop-ui-tests/pull/32 - https://github.com/status-im/status-desktop/pull/3912 - https://github.com/status-im/desktop-ui-tests/pull/36 - current: - continue on modal tests **Sale** - done: - App sections [`status-dektop` PR-3903] - current: - working on chat/communities part ## October 22 (Fri) **Nastya** - current: - fixing and refactoring test for GenKeyModal.qml component https://github.com/status-im/desktop-ui-tests/pull/32 - https://github.com/status-im/status-desktop/pull/3902 **Jonathan** - done: - Finished the refactor of the contacts sub-section - current: - Working on the transaction history sub-section of the wallet **Boris** - done: - Add check for hunspell existance [#462](https://github.com/status-im/StatusQ/pull/462) - Rebase abandoned spellchecking branch to master [#3690](https://github.com/status-im/status-desktop/pull/3690) - Add tests methods with input checking [#30](https://github.com/status-im/desktop-ui-tests/pull/30) - current: - working on moving node tab to new architecture [#3805](https://github.com/status-im/status-desktop/issues/3805) **Sale** - done: - Issue 3860 [`statusq` PR-461]: Adapt StatusAppNavBar to the new refactoring changes - current: - working on app_sections part ## October 21 (Thu) **Nastya** - current: - refactored tests for StatusButton.qml control https://github.com/status-im/desktop-ui-tests/pull/28 - refactoring tests for StatusChatInfoButton.qml control https://github.com/status-im/desktop-ui-tests/pull/29 - https://github.com/status-im/desktop-ui-tests/pull/31 ## October 20 (Wed) **Jonathan** - done / current: - Had issues building the app because of double QT versions getting installed - Learned about the new architecture - Helping Iuri with the Profile section refactor - Doing the Contacts module - Finishing up the QML hooks and reimplementing harder features like ENS lookup **Nastya** - current: - continue on unit tests - https://github.com/status-im/desktop-ui-tests/pull/28/ - https://github.com/status-im/desktop-ui-tests/pull/27 **Boris** - done: - Update submodules for ui-tests [#25](https://github.com/status-im/desktop-ui-tests/pull/25) - Move init and cleanup methods to base class [#26](https://github.com/status-im/desktop-ui-tests/pull/26) - Add test for components in StatusQ: - StatusExpandableItem [#24](https://github.com/status-im/desktop-ui-tests/pull/24) - current: - Preparing tests for usage and POC with comments and "how to" - next: - Update head and build for abandoned Spellchecking PR **Sale** - done: - Issue 3802 (PR-3813)- `localAccountSetting`, `accountSettings` and `globalSettings` moved to Nim and code update accordingly - Added multiple fixes to `refactoring/base` - current: - continue working on app_sections part ## October 19 (Tue) **Nastya** - current: - https://github.com/status-im/desktop-ui-tests/pull/21 - https://github.com/status-im/desktop-ui-tests/pull/22 - https://github.com/status-im/desktop-ui-tests/pull/23 - https://github.com/status-im/StatusQ/pull/455 - https://github.com/status-im/StatusQ/pull/456 ## October 18 (Mon) **Nastya** - done / current: - https://github.com/status-im/desktop-ui-tests/pull/15 - continue working on tests for statusQ controls - https://github.com/status-im/desktop-ui-tests/pull/19 - hopefully the intreview wont be shifted again so I can talk to potential QA today (this is done) **Boris** - done: - Add higlighting qml modules [#14](https://github.com/status-im/desktop-ui-tests/pull/14), [#448](https://github.com/status-im/StatusQ/pull/448), [#3828](https://github.com/status-im/status-desktop/pull/3828) - Add objectName's for tests [#449](https://github.com/status-im/StatusQ/pull/449), [#3839](https://github.com/status-im/status-desktop/pull/3839) - Update submodules [#17](https://github.com/status-im/desktop-ui-tests/pull/17) - Add test for components in StatusQ: - StatusChatInfoToolbar [#16](https://github.com/status-im/desktop-ui-tests/pull/16) - StatusItemList [#20](https://github.com/status-im/desktop-ui-tests/pull/20) - current: - Tests for StatusQ.Components **Sale** - done: - Issue 3802 (PR-3813)- Move Login to new architecture - `startup`, `login`, `onboarding` modules are completely done. - Worked on some architedturel improvements `refactoring/base`, community section module is now special kind of chat section module - current: - doing review for `refactoring/browser` - next: - continue working on chat/communities ## October 15 (Fri) **Nastya** - done: - testing Profile, Wallet, Commiunities because of refactoring merges - https://github.com/status-im/desktop-ui-tests/pull/11 - https://github.com/status-im/desktop-ui-tests/pull/12/ - logged several issues for desktop app: - https://github.com/status-im/status-desktop/issues/3822 - https://github.com/status-im/status-desktop/issues/3823 - https://github.com/status-im/status-desktop/issues/3826 - https://github.com/status-im/status-desktop/issues/3827 - current: - plan to be able to add tests for StatusQ.Controls - continue checking the app after refactoring merges **Boris** - done: - Update test for ProfilePopup[#8](https://github.com/status-im/desktop-ui-tests/pull/8) - Add modal helpers for testing[#9](https://github.com/status-im/desktop-ui-tests/pull/9) - Add helpers for old modal popups in status-desktop[#10](https://github.com/status-im/desktop-ui-tests/pull/10) - Add avatar changing functionality to profile popup[#3825](https://github.com/status-im/status-desktop/pull/3825) - Fix Pascal comments [#440](https://github.com/status-im/StatusQ/pull/440) - current: - Tests for StatusQ.Components **Sale** - current: - Issue 3802 - Move Login to new architecture - updated current code so we are able to have as many nested types as we want refering to the parent type. Onboarding module is done, working on login module now since they refer to the same flow. ## October 14 (Thu) **Nastya** - continue on tests and squish. Having an interview with QA today - https://github.com/status-im/status-desktop/pull/3815 - https://github.com/status-im/desktop-ui-tests/pull/7 ## October 13 (Wed) - Standup **Nastya** - https://github.com/status-im/desktop-ui-tests/pull/6 a simple test example how we can do the unit tests for the UI components - https://github.com/status-im/status-desktop/pull/3801 - please merge the fix , so the test implemented in above PR will pass in master - continue working on unit tests more for the GenKeyModal - think of the strategy how we want to cover the components in terms of testing, like what is a must to be covered (window sizes, colors, buttons, signals, etc.) **Michael** - days off: Oct 13-15. **Boris** - done: - PR for edit avatar from profile popup in StatusQ [#440](https://github.com/status-im/StatusQ/pull/440) - PR for edit avatar from profile popup in status-desktop - Help understand tests and QML for Nastya - Tests PRs review - next: - testing tests for POC - Check specs and diagrams about New Architecture **Sale** - current: - Issue 3802 - Move Login to new architecture ## October 12 (Tue) - Standup **Michael** - done - work on [#3724](https://github.com/status-im/status-desktop/issues/3724) is paused/canceled per yesterday's meeting, i.e. new plan to migrate much of status-lib logic/functionality into status-go. - current: - studying the `ChatCommunitiesHLClassDiagram` and changes in Sale's `refactoring/base` branch (PR [#3793](https://github.com/status-im/status-desktop/pull/3793)). - preparing to work on issue [#3805](https://github.com/status-im/status-desktop/issues/3805): *Move Node Tab to new architecture*. ## October 11 (Mon) - Standup **Michael** - current: - experimenting with latest Qt Creator (5.0.2) and Qt 6.2. - almost done with a PR for [#3724](https://github.com/status-im/status-desktop/issues/3724). **Nastya** - current: - https://github.com/status-im/status-desktop/issues/3794 sample, how we can use Squish to check the pixel perfect approach - continue investigating the tool **Boris** - done: - Fix issue with store in keychain popup [#3795](https://github.com/status-im/status-desktop/pull/3795) - current: - POC for tests: - Fixing test for ProfilePopup - Fixing avatar changing in ProfilePopup **Sale** - current: - Issue 3721 - refactor/group chat into each specific type of chat: communities, groups, 1 on 1s, public chats, timeline - started with implementation ## October 8 (Fri) - Standup **Nastya** - current: - digging into Squish thing more today, it really looks promising. Bugging Sale and Boris with all related stuff. Want to go through the new unit tests Boris created, but did not have a chance yet, hopefully later today. **Michael** - done: - finished working on the proposal with Eric; v1.0 has been submitted. This involved several hours of research earlier in the day on Thu (my tz) and then another approx. 4 hour meeting in the evening (my tz). - current: - resuming work on issue [#3724](https://github.com/status-im/status-desktop/issues/3724). I've been somewhat occpuied by research and long calls related to the aforementioned proposal. **Sale** - current: - Issue 3721 - refactor/group chat into each specific type of chat: communities, groups, 1 on 1s, public chats, timeline - started with implementation **Boris** - done: - Add test for avatar edit issue [#4](https://github.com/status-im/desktop-ui-tests/pull/4) - current: - Fixing avatar edit issue based on test [#3734](https://github.com/status-im/status-desktop/issues/3734) - next: - issue with keychain storage selection modal [#3638](https://github.com/status-im/status-desktop/issues/3638). Needs to be done for Squish POC. ## October 7 (Thu) - Standup **Michael** - current: - continuing work on the proposal with Eric. Earlier on Wed, I did additional research on points from our meeting Tue. We met for about 4 hours Wed, starting in the early evening (my tz). We plan to wrap up in a session Thu evening (my tz). ## October 6 (Wed) - Standup **Nastya** - current: - finish with Timelines and test communities again, however last master cant be built **Michael** - current: - still working on issue [#3724](https://github.com/status-im/status-desktop/issues/3724). I'm currently applying insights re: `trackPendingTransaction` made in PR [status-lib#76](https://github.com/status-im/status-lib/pull/76) (necessarily involves cross-module considerations). - per external request, started work with Eric on a several-days' effort (pairing sessions somewhat constrained by our differing timezones) to create a proposal. **Sale** - current: - Issue 3721 - refactor/group chat into each specific type of chat: communities, groups, 1 on 1s, public chats, timeline - started with implementation, need to check some concepts in nim first and create initial organization ## October 5 (Tue) - Standup **Nastya** - done: - focused on Timelines testing, since it was never tested a lot because of priorities **Michael** - done: - created PRs [status-lib#76](https://github.com/status-im/status-lib/pull/76) and [#3776](https://github.com/status-im/status-desktop/pull/3776) in relation to issue [#3725](https://github.com/status-im/status-desktop/issues/3725) (EPIC issue [#3717](https://github.com/status-im/status-desktop/issues/3717)). - current: - working on issue [#3724](https://github.com/status-im/status-desktop/issues/3724). ## October 4 (Mon) - Standup **Nastya** - current: - continue on regression for master, however spent a lot of time chasing https://github.com/status-im/status-desktop/issues/3754 . Nothing meaningful in logs for this moment. Will check more on that and continue regression testing. **Michael** - done: - PR [status-go#2358](https://github.com/status-im/status-go/pull/2358) should now be ready for merge. - current: - still working on issue [#3725](https://github.com/status-im/status-desktop/issues/3725). In `status-lib/status/types/transaction.nim` I've added `type PendingTransaction` and am working on a series of changes where this object is introduced in `status-lib/status/stickers.nim` as the return type for `proc buyPack` and the change ripplies through to status-desktop and its procs. There is an opportunity to clean up some `var success` parameters along the way, still figuring it out. **Sale** - current: - Issue 3721 - refactor/group chat into each specific type of chat: communities, groups, 1 on 1s, public chats, timeline - planning, reviewing current code and preparing high level class diagram - next: - Issue 3721 - work on implementation ## October 1 (Fri) - Standup **Michael** - done: - responded to feedback on PR [status-go#2358](https://github.com/status-im/status-go/pull/2358). Once I get final clarification from Samuel, I'll make a quick change and it should be ready for merge. - reviewed and then made some changes to Andrea's PR [status-lib#63](https://github.com/status-im/status-lib/pull/63). The GHA tests workflow is now passing on all platforms for that PR, but I didn't mark it as approved since it seems there is additional work to be done, possibly in that PR, possibly in follow-up PRs, I wasn't certain. - reviewed Anthony's (already merged) PRs [#status-lib#59](https://github.com/status-im/status-lib/pull/59), [#3733](https://github.com/status-im/status-desktop/pull/3733), [#status-lib#60](https://github.com/status-im/status-lib/pull/60), [#3735](https://github.com/status-im/status-desktop/pull/3735), [#status-lib#61](https://github.com/status-im/status-lib/pull/61), [#3736](https://github.com/status-im/status-desktop/pull/3736). By "reviewed" I mean came to a complete understanding of what work for EPIC issue [#3717](https://github.com/status-im/status-desktop/issues/3717) has already been completed and how it was done. I also left comments on those merged PRs, connecting them to issues that are part of [#3717](https://github.com/status-im/status-desktop/issues/3717): [#3729](https://github.com/status-im/status-desktop/issues/3729), [#3727](https://github.com/status-im/status-desktop/issues/3727), [#3726](https://github.com/status-im/status-desktop/issues/3726). - current: - working on issue [#3725](https://github.com/status-im/status-desktop/issues/3725). **Nastya** - current: - gave a try to bild the app again locally on M1 - exploratory testing of windows build - trying to understand the recent changes Boris has done in unit tests (this is hard lol) - continue on adding test scenarios in test rail **Boris** - done: - Add new test methods [#3](https://github.com/status-im/desktop-ui-tests/pull/3) - Review new status-desktop ui structure - current: - Working on issue [#3734](https://github.com/status-im/status-desktop/issues/3734) as base for POC for tests ## September 30 (Thu) - Standup **Michael** - done: - PR [#3731](https://github.com/status-im/status-desktop/pull/3731) has been merged. - PRs [status-lib#58](https://github.com/status-im/status-lib/pull/58) and [status-lib#66](https://github.com/status-im/status-lib/pull/66) have been merged. - current: - *thinking* ## September 29 (Wed) - Standup **Nastya** - current / done: - continue on the QML tests learning - progress with test documentation in test rail finally - regression testing which will be ongoing for upcoming month **Michael** - done: - PR [#3699](https://github.com/status-im/status-desktop/pull/3699) has been merged. - updated PR [#3731](https://github.com/status-im/status-desktop/pull/3731) after realizing that unused `nbaser` can be removed in addition to removing unused `nim-base32`. - updated PR [status-lib#58](https://github.com/status-im/status-lib/pull/58) re: Richard's review and my realization that we should use `stew/base58` instead of `nbaser`. - created PR [status-lib#66](https://github.com/status-im/status-lib/pull/66) to close issue [status-lib#65](https://github.com/status-im/status-lib/issues/65). - current: - EPIC issue [#3717](https://github.com/status-im/status-desktop/issues/3717). I need to review the related PRs already created by Anthony and later merged by Iuri, and then create several additional PRs. **Boris** - done: - Working on POC for QML tests [#3722](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3722): - Add a working Qt Quick Test project in new repo [#ui-tests](https://github.com/status-im/desktop-ui-tests) - Add two test cases for ProfilePopup - Explain some topics for Nastya - current: - Add helpers for TestCases with testing data and spetial ui methods(object searching and access) ## September 28 (Tue) - Standup **Nastya** - current: - work on regression testing for communities feature, verify designs , existing bugs and behavior , add test documentation **Michael** - done: - PR [#3652](https://github.com/status-im/status-desktop/pull/3652) has been merged. - concluded initial experiments re: issue [#3528](https://github.com/status-im/status-desktop/issues/3528). See my [comment](https://github.com/status-im/status-desktop/issues/3528#issuecomment-928160114) on that issue for more information. - created PR [#3731](https://github.com/status-im/status-desktop/pull/3731) to close issue [#1268](https://github.com/status-im/status-desktop/issues/1268). - created PR [status-lib#58](https://github.com/status-im/status-lib/pull/58) to close issue [status-lib#56](https://github.com/status-im/status-lib/issues/56). - current: - starting on EPIC issue [#3717](https://github.com/status-im/status-desktop/issues/3717). I'll need to coordinate with Anthony. ## September 27 (Mon) - Standup **Michael** - done: - PR [#3687](https://github.com/status-im/status-desktop/pull/3687) has been merged. - created PR [#3698](https://github.com/status-im/status-desktop/pull/3698) to address a very recent change in Homebrew for macOS re: OpenSSL. It has since been merged. - created PR [#3699](https://github.com/status-im/status-desktop/pull/3699) to close issue [#3462](https://github.com/status-im/status-desktop/issues/3462). - current: - researching issue [#3528](https://github.com/status-im/status-desktop/issues/3528). **Boris** - done: - Fix build in spellchecking PR [#3690](https://github.com/status-im/status-desktop/pull/3690) - Resolve conflicts on messages mouse areas [#3705](https://github.com/status-im/status-desktop/pull/3705) - current: - Create project for tests: - Create New Qt Quick Test project - Add StatusQ as submodule - Add status-desktop as submodule - Add several tests - next: - Need to assign ## September 24 (Fri) - Standup **Nastya** - current: - https://github.com/status-im/status-desktop/pull/3655 - https://github.com/status-im/status-desktop/pull/3691 - read more about QML types, need Boris to map StatusQ files to the project with tests so I can try to cover with some tests any real element - https://github.com/status-im/status-desktop/pull/3696 **Michael** - done: - re: [#3529](https://github.com/status-im/status-desktop/issues/3529), after some analysis and experiments, I don't think there's a way to change *just* the code (in status-desktop and status-lib) involved in adding a contact, in order to eliminate the UI freeze. See my [comment](https://github.com/status-im/status-desktop/issues/3529#issuecomment-926005489) on that issue for an explanation. In ZenHub I've marked it as blocked by [#3651](https://github.com/status-im/status-desktop/issues/3651), with hope that the contacts refactor will improve performance enough that the UI freeze is effectively eliminated or at least reduced. - Created PR [#3687](https://github.com/status-im/status-desktop/pull/3687) to avoid churn in `package-lock.json` in future commits. It's in draft currently because I need Jakub to take a look at how we can upgrade to npm v7 in the Jenkins macOS environment. - current: - working on issue [#3462](https://github.com/status-im/status-desktop/issues/3462), but currently blocked by local compile-time failures on macOS re: my branch off current `master`. **Boris** - done: - Introducing Nastya to Qt Test module and QML - Review and help Pascal with D&D PR - Add spellchecking to StatusChatInput and update DOtherSide part [#3690](https://github.com/status-im/status-desktop/pull/3690) - current: - Make links in active center clickable [#3593](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3593) **Sale** - done: - Issue 3594 (PR-3680)- Scrolling of the chat with code blocks and reactions is repetitive - current: - Issue 3626 (PR-3691) - Abnormal CPU usage and slowness - searching for a further improvements - next: - need new issues - will be off next week ## September 23 (Thu) - Standup **Nastya** - current: - diving into QML and tests for statusQ, spent a lot of time with Boris and documentation. Will continue on that, the approach looks promising. - reproducing the issues that were originally reported - read more about tests in QT **Michael** - done: - PR [#3650](https://github.com/status-im/status-desktop/pull/3650) has been merged. - revised PR [#3652](https://github.com/status-im/status-desktop/pull/3652) per feedback and updated relevant [dev docs](https://hackmd.io/OtFjDnH6QtOl3K65fKKEGg?view#3-Build-binnim_status_client-and-run-the-app). I think it's ready for merge. - current: - still working on issue [#3529](https://github.com/status-im/status-desktop/issues/3529). ## September 22 (Wed) - Standup **Nastya** - current: - https://github.com/status-im/status-desktop/pull/3474 - https://github.com/status-im/status-desktop/pull/3655 **Michael** - done: - created PR [#3650](https://github.com/status-im/status-desktop/pull/3650) to close issue [#3532](https://github.com/status-im/status-desktop/issues/3532). Waiting on rewiew/test. - created PR [#3652](https://github.com/status-im/status-desktop/pull/3652) to close issue [#3639](https://github.com/status-im/status-desktop/issues/3639). Waiting on feedback/review. - current: - working on issue [#3529](https://github.com/status-im/status-desktop/issues/3529). **Sale** - done: - Issue 3489 - channel links sends to main public channel instead of a channel in that community - Issue 3418 - Blocked user messages disappear after the user is blocked - Issue 3378 - Fix the scenarios for closing the app on Mac (minimise on close On / Off) - Issue 3579 - Removing contact results in the same contact's contact request showing up again - current: - Issue 3594 - Scrolling of the chat with code blocks and reactions is repetitive - very hard to catch/fix - next: - need new issues **Boris** - done: - Long brainstorm with Pascal about drag&drop - Change menu order for spellchecking [#420](https://github.com/status-im/StatusQ/pull/420) - Add spellchecker to syntaxhighlighter [#54](https://github.com/status-im/dotherside/pull/54) - current: - Prepare code and submodules for spellchecing PR in status-desktop - next: - Make linnks in active center clickable [#3593](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3593) ## September 21 (Tue) - Standup **Nastya** - current: - mostly busy with reproducing old issues and loggin new ones, testing master build **Michael** - current: - started work on issue [#3532](https://github.com/status-im/status-desktop/issues/3532). ## September 20 (Mon) - Standup **Nastya** - current: - https://github.com/status-im/status-desktop/pull/3555 - https://github.com/status-im/status-desktop/pull/3513 - https://github.com/status-im/status-desktop/pull/3530 - https://github.com/status-im/status-desktop/pull/3534 **Boris** - current: - Add spellchecker to syntaxhiglighter [#3450](https://app.zenhub.com/workspaces/nim-status-client--nim-status-5ea70d29c12ee928df5ae848/issues/status-im/status-desktop/3450) - next: - PR with all spellcchecking functionality **Michael** - done: - made changes re: reviews of PRs [#3582](https://github.com/status-im/status-desktop/pull/3582) and [#3583](https://github.com/status-im/status-desktop/pull/3583). They're ready for testing/merge. - finished post-review changes for PRs [#3530](https://github.com/status-im/status-desktop/pull/3530) and [#3534](https://github.com/status-im/status-desktop/pull/3534). They're ready for re-testing/merge. - contributed to now-merged DOtherSide PR [#52](https://github.com/status-im/dotherside/pull/52) and NimQML PR [#34](https://github.com/status-im/nimqml/pull/34). those changes played a role in my Status Desktop PR [#3534](https://github.com/status-im/status-desktop/pull/3534). - current/next: - TBD. **Sale** - done: - Issue 3305 (`status-lib` PR-39, `status-desktop` PR-3608)- new activity tab for wallet - almost done, few details are missing for single activity view, wrote about that in the `wallet-redesign` channel - current: - Issue 3489 - channel links sends to main public channel instead of a channel in that community - next: - Issue 3378 -Fix the scenarios for closing the app on Mac (minimise on close On / Off) - Issue 3418 - Blocked user messages disappear after the user is blocked - Issue 2552 - Push notification is not send when mentioning a user having a chat muted ## Changes * previous members: Andrei, Anthony, Aleksandar, Jonathan, Richard, Nastya * new members: Aleksandar, Boris, Jonathan, Michael, Nastya