# devenv Discussions 202104 Attendees: * Yung-Yu * Chun-Hsu * Chester * Tai Online (via zoom) ## Agenda 1. Bring all the enhancements to the upstream devenv repository. 1. One or two PR per week. 2. Set up regular sprints for solvcon. 1. We will use the sprints to find users. ## Action Items - Share the slides presented in Taipei.py (via slidedesk or something similar) - Share the codebased presented in Taipei.py ## Colaboration Protocol - some proposals - **[candance]** one or two pull request per week - **[pull request size]** - < 200 lines per pull request - [rule for cherry-pick]( https://www.facebook.com/champ.yen/posts/10221710168916740?comment_id=10221714700790034) . This also applies to commits/pull request - `cherry-pick 用熟了真的會上癮,特別是對那些熟悉「老派」[*] patch 管理方式的老手們,相當於只是提供了一個很好用的前端來控制一堆 patch 而已。 另外個人心得是,自己的 commit history 如果不能夠隨心所欲地在不同 branch 間做 cherry-pick,這可能是一個 bad smell of version controlling ,例如每次的 commit 並沒有作到邏輯模組化,或是每次做 house cleaning 沒有認真做、沒認真 rebase 髒髒的 commit history。好的 commit history 搭配 cherry-pick 在意見很多的 upstream 挑剔 pull request 的時候真的很好用,隨時抽掉 upstream 看不順眼的部份,「只挑對方喜歡吃的櫻桃給他吃~~~」[*] 單純按照時間線相對於現在 version control 滿天飛的描述,理性勿戰 XD` ## devenv slides - [slides](https://drive.google.com/file/d/1nAXAYAF5aSOvRhMzAl3GF4rjfNi_0kO0/view?usp=sharing) ## 本日金句 - [name=yyc] *This does not work on my laptop* a.k.a. 真實世界的鈔票