# DOJO Report - 13/07/2022

## Subjects

**1. Nock Issues**

	- Taras, had issues with the configuration, understanding of nock
	- XPO Token was required and should be mocked or Lazy loaded
	- Not easy to understand
	- Current solution (meanwhile the Lazy load) use the method `setupSmoneyAccessTokenScope`
	- nock.enableNetConnect(); activate real calls, to use BEFORE to create the FIRST fixture, maybe a reason why we use this method is to allow to connect with MongoMemory``` 

👉 Actions/Solutions/Decisions: 
		- Build the Lazy load solution - token 🟠
		- Current solution (meanwhile the Lazy load) use the method `setupSmoneyAccessTokenScope` 🟢
	- Jira Issue: N/A

 **2. Onboarding a new team member **

- For example Taras, to explain how nock works
- Pair programming sessions
- Vinius team doesn't have a Team Lead (Taras)
- Simon: Payment Scope tries to do the onboarding
- Problems:
- Time spent for the leads
- Official Onboarding sessions
- Information easy to find / understand```

- 👉 Actions/Solutions/Decisions:
- Save issues somewhere (like a internal StackOverflow)
- Write the issues in the a OPEN Channel like "Backend" instead of "private messages"
- Share the information that the Framework team can help cause they have a global knowlage of the project / scopes
- Write documentation / Record meetings ? 🟠
- Technical questions will be written in a specific channel get a StackOverflow Like solution 🟢
- Write instruction to search in Slack (write this in README) 🟢
- Create on a onboarding FILE ? 🟠
- Technical tasks ?? HOW TO COMPLETE / PRIO 🟠

**3. Luxun library updates**
❗️❗️❗️ NEW INFORMATION❗️❗️❗️
**(M.Lamim) M.Lamim has installed the Luxun type library 👍 he suggest to type correctly the Date time when we use Luxon Check the PR in progress**

**4. library V4**
Question: Belkacem, why there is different ways to use V4 Lib
- 👉 Actions/Solutions/Decisions:
- There is 2 Classes that allows you to create ID, so dont use the v4 lib directly in the usecase or the CORE
- ShortIdGenerator
- OrderId

Franck note: avoid to mock v4() library when u can.
Taras: Suggestion a solution to get unique ID, is it a real priority ? Ampah

**5. Tools CLI - Environments files**
Allal Question
How we to manage the environment variables inside TOOLS-CLI ?
Discuss with DEVOPS TEAM, to use the same system as API's and support many .env files (by environment)

**6. Tests suggestion**
Amine has suggested a solution inspired by cucumber, to make the tests readable
- 👉 Actions/Solutions/Decisions:
- Check this pull request to see the file that were created, and use the same pattern https://dev.azure.com/OneyPay/OneyPay-API/_git/oney/pullrequest/7848 🟢

**7. Aggregate root - updates**

❗️❗️❗️ NEW INFORMATION❗️❗️❗️
**There is a new why to create EVENTS when you change the state of an ENTITY (class) inside an aggregate ROOT
Please from now respect this new behaviour in your following Pull REQUEST**

examples inside:
BankAccount.ts (aggregate root)