# sciwork openspace in PyConTW 2020/9/5 Host: Yung-Yu ([@yungyuc](https://twitter.com/yungyuc)) Website: https://sciwork.dev/ Discord: https://discord.gg/6MAkFrD Attendees: Yung-Yu, Chun-Hsu, Shanny, Sharon, Shushi, Keith, TP, Chester, marr, Robert Next sprint: pip/packaging Sharon: checking in code should have unit tests accompanying TP: checkin needs to maintain patch cleanness, but sometimes mass change is needed for architecture change. Sharon: PR / code review should match change content. Yung-Yu: many scientist and engineers do not understand the concept of keeping patch clean. Sharon / TP: CI is necessary for tracking where bugs are introduced. There is a proper size for patch or PR. Sharon to Chun-Hsu: For embedded system, it's ok to test only on development architecture. Deployment / testing on the target architecture is considered separately. Chester: It's important to check for every commit. Shany: It's challenging to review code that one is not familar with. It's good to have a policy to have one review to focus on only one thing. TP to Chun-Hsu: It's hard to introduce the code review culture to teams that do not practice it. Chun-Hsu: Without code review the code quality drops. TP: The criteria for code review should be adqueate to the team.