---
# System prepended metadata

title: Feedback from "How" meeting

---

# Feedback from "How" meeting
## Decommissioning SQS
Max suggested it might be time to decommission SQS for shop updates if we believe RabbitMQ publishes all of that relevant information. If the work required isn't too much, we will bring it into scope.

## Hours into Elastic Search: Discover Filter
During the "HOW" session on our hours into ES effort, feedback was received about the discover filter. Specifically, this focused on the request body and content it might contain.

### Request Body
#### `delta_hours`: Opening Soon Field
This parameter caused some confusion with its name and negative value.

It should be renamed to better reflect its purpose and it should use a positive value to be more readily understood by clients.

We propose using `open_within` and a positive integer value in minutes. E.g. `{"open_within": 15}` would indicate that the client would like shops that are open within the next 15 minutes.

We recommend setting a maximum of 60 minutes for this value. This would prevent unintended bugs from arising (e.g. overlapping opening times) and we also do not foresee a use case for times this far out just yet.

Additionally, there is some consideration around whether this field should be specified in minutes (e.g. `15`) or milliseconds (e.g. `15000`).

#### `timestamp` Field
Feedback was given that maybe we have a `timestamp` field that will indicate the timestamp we are searching relative to.

We propose that if `timestamp` is provided, there should be some limits. The timestamp must be for a time greater than or equal to now, since we will purge historical data. Additionally, it cannot be more than four (4) days from the current time UTC. This is because we will not have enough data into ES to successfully fulfill that request.

When used with the `open_within` parameter, the value will be interpreted relative to `timestamp`. For example, if `timestamp` is provided as `2020-01-27T17:00:00Z` and `open_within` is provided as `15`, this query is interpreted as finding shops that are open at `timestamp` or opening within 15 minutes of `2020-01-27T16:45:00Z`.

All limitations mentioned on both fields remain in place.
