--- title: Triage meeting 2022-07-05 tags: triage-meeting --- # T-lang meeting agenda * Meeting date: 2022-07-05 ## Attendance * Team members: Josh, Scott * Others: Mark ## Meeting roles * Action item scribe: simulacrum * Note-taker: simulacrum ## Announcements or custom items (Meeting attendees, feel free to add items here!) * Planning meeting tomorrow * Need to see if any design projects are ready for design meetings * `rustc_must_implement_one_of` ## Action item review * [Action items list](https://hackmd.io/gstfhtXYTHa3Jv-P_2RK7A) ## Pending lang team project proposals ### "Deprecate target_vendor " lang-team#102 **Link:** https://github.com/rust-lang/lang-team/issues/102 ### "Support platforms with size_t != uintptr_t" lang-team#125 **Link:** https://github.com/rust-lang/lang-team/issues/125 ### "Positional Associated Types" lang-team#126 **Link:** https://github.com/rust-lang/lang-team/issues/126 ### "Interoperability With C++ Destruction Order" lang-team#135 **Link:** https://github.com/rust-lang/lang-team/issues/135 ### "allow construction of non-exhaustive structs when using functional update syntax" lang-team#143 **Link:** https://github.com/rust-lang/lang-team/issues/143 ### "Add #[deprecated_safe] attribute to allow functions be be marked unsafe in a backwards compatible fashion" lang-team#147 **Link:** https://github.com/rust-lang/lang-team/issues/147 ### "Async fns in traits" lang-team#150 **Link:** https://github.com/rust-lang/lang-team/issues/150 ### "dyn* trait" lang-team#158 **Link:** https://github.com/rust-lang/lang-team/issues/158 ### "Initiative: `?` traits, `try` blocks, `yeet` exprs, oh my" lang-team#160 **Link:** https://github.com/rust-lang/lang-team/issues/160 ### "Initiative: Ghost types and blocks" lang-team#161 **Link:** https://github.com/rust-lang/lang-team/issues/161 ### "Keyword generics" lang-team#162 **Link:** https://github.com/rust-lang/lang-team/issues/162 ### "Add const evaluatable `where const { <block> }`" lang-team#163 **Link:** https://github.com/rust-lang/lang-team/issues/163 ### "#[repr(Interoperable_2024)]" lang-team#165 **Link:** https://github.com/rust-lang/lang-team/issues/165 ## PRs on the lang-team repo ### "Note design constraints on hypothetical `DynSized`" lang-team#166 **Link:** https://github.com/rust-lang/lang-team/pull/166 ## RFCs waiting to be merged ### "Refined trait implementations" rfcs#3245 **Link:** https://github.com/rust-lang/rfcs/pull/3245 ## Proposed FCPs **Check your boxes!** ### "Tracking issue for `#![register_attr]`" rust#66080 - **Link:** https://github.com/rust-lang/rust/issues/66080 - [**Tracking Comment**](https://github.com/rust-lang/rust/issues/66080#issuecomment-1170274903): > Team member @joshtriplett has proposed to close this. The next step is review by the rest of the tagged team members: > > * [ ] @cramertj > * [x] @joshtriplett > * [ ] @nikomatsakis > * [ ] @pnkfelix > * [x] @scottmcm > > No concerns currently listed. > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/issues/66080#issuecomment-1170274839): > > It's quite possible that all the uses should migrate to #![register_tool] (https://github.com/rust-lang/rust/issues/66079) instead. > > We discussed this in today's @rust-lang/lang meeting, and we agreed: anything new should be scoped, and anything existing we need to support for backwards compatibility shouldn't require calling `register_tool` first, so we can just keep the hardcoding of the handful of exceptions in the compiler. > > @rfcbot close ### "Stabilize `let else`" rust#93628 - **Link:** https://github.com/rust-lang/rust/pull/93628 - [**Tracking Comment**](https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383585): > Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [x] @cramertj > * [x] @joshtriplett > * [x] @nikomatsakis > * [x] @pnkfelix > * [ ] @scottmcm > > Concerns: > > * need-consistency-rvalue-temporary-rules-between-let-and-let-else (https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523) > * ~~not-while-rustfmt-breaks-on-it~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1032936704 > * ~~semicolon~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1059799661 > * ~~stabilization-report~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1033846359 > * ~~summarize-concerns~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1056785904 > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383577): > Shall we stabilize `let else` syntax? We've had many demonstrated uses, including extensively throughout `rust-lang/rust`, we've seen the value of it, and there aren't any known issues with it. > > @rfcbot merge ### "do not mark interior mutable shared refs as dereferenceable" rust#98017 - **Link:** https://github.com/rust-lang/rust/pull/98017 - [**Tracking Comment**](https://github.com/rust-lang/rust/pull/98017#issuecomment-1163625324): > Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [ ] @cramertj > * [x] @joshtriplett > * [ ] @nikomatsakis > * [ ] @pnkfelix > * [x] @scottmcm > > No concerns currently listed. > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/pull/98017#issuecomment-1163625302): > @rfcbot merge ## Active FCPs ### "Deprecate target_vendor " lang-team#102 **Link:** https://github.com/rust-lang/lang-team/issues/102 ### "Positional Associated Types" lang-team#126 **Link:** https://github.com/rust-lang/lang-team/issues/126 ### "Interoperability With C++ Destruction Order" lang-team#135 **Link:** https://github.com/rust-lang/lang-team/issues/135 ### "allow construction of non-exhaustive structs when using functional update syntax" lang-team#143 **Link:** https://github.com/rust-lang/lang-team/issues/143 ### "Add #[deprecated_safe] attribute to allow functions be be marked unsafe in a backwards compatible fashion" lang-team#147 **Link:** https://github.com/rust-lang/lang-team/issues/147 ### "Async fns in traits" lang-team#150 **Link:** https://github.com/rust-lang/lang-team/issues/150 ### "Initiative: `?` traits, `try` blocks, `yeet` exprs, oh my" lang-team#160 **Link:** https://github.com/rust-lang/lang-team/issues/160 ### "Initiative: Ghost types and blocks" lang-team#161 **Link:** https://github.com/rust-lang/lang-team/issues/161 ### "Keyword generics" lang-team#162 **Link:** https://github.com/rust-lang/lang-team/issues/162 ## P-critical issues None. ## Nominated RFCs, PRs and issues discussed this meeting ### "Tracking issue for `..X`, and `..=X` (`#![feature(half_open_range_patterns)]`)" rust#67264 **Link:** https://github.com/rust-lang/rust/issues/67264 * There's lots of ways signed integers can be surprising/confusing in some cases * However, this doesn't seem like this is a particularly differentiated way, and we can add lints (to rustc or clippy) at a later point * For the time being, Scott to propose FCP. ### "Tracking issue for function attribute `#[no_coverage]`" rust#84605 **Link:** https://github.com/rust-lang/rust/issues/84605 * Tyler is asking for steps needed to stabilize * May want a different name (https://github.com/rust-lang/rust/issues/84605#issuecomment-1166065805) * Josh leaving comment asking for stabilization report, modulo rename, and S-ready-to-stabilize. ### "TypeId: use a (v0) mangled type to remain sound in the face of hash collisions." rust#95845 **Link:** https://github.com/rust-lang/rust/pull/95845 * Josh leaving a comment de-nominating for lang (seems like we addressed the concern on our side) ### "Implement pointee metadata unsizing via a JustMetadata\<T> container" rust#97052 **Link:** https://github.com/rust-lang/rust/pull/97052 * asked for more clarification, but we are still somewhat confused * leaving nominated to look again next week ### "Document the `target_feature_11` feature" reference#1181 **Link:** https://github.com/rust-lang/reference/pull/1181 * Looks good and ready to merge alongside stabilization. ### "Tracking Issue for `#[instruction_set]` attribute (RFC 2867)" rust#74727 **Link:** https://github.com/rust-lang/rust/issues/74727 * Waiting on Felix to stabilize ### "Keep valid scalar ranges attached to newtypes when dealing with their inner field." rust#97261 **Link:** https://github.com/rust-lang/rust/pull/97261 * https://github.com/rust-lang/rust/pull/97261#issuecomment-1171184280 is a key explainer ## Nominated RFCs, PRs and issues NOT discussed this meeting * All covered in-meeting