*-linux-musl
targets to musl 1.2.5" compiler-team#887 (Zulip)armv7-unknown-linux-musleabihf
to tier 2 with host tools" compiler-team#888 (Zulip)target_env = "macabi"
and target_env = "sim"
(rust#139451)
target_abi = "elfv{1,2}"
on powerpc64-any-unixy-elfy
targets" compiler-team#885 (Zulip)rustc_target::spec::Target
from a Builder" compiler-team#890 (Zulip)x86_64-unknown-linux-gnu
stable" rust#140525ast::ptr::P
" compiler-team#878 (Zulip)-Z hint-mostly-unused
option to hint that most of a crate's API surface will be unused" compiler-team#883 (Zulip)multivalue
, reference-types
, and tail-call
target features" rust#131080-Zdwarf-version
as -Cdwarf-version
" rust#136926unknown_or_malformed_diagnostic_attributes
lint" rust#140717derive(CoercePointee)
" rust#133820file!
" rust#134442ShouldPanic::YesWithMessage
's TrFailedMsg
" rust#136160unsupported_calling_conventions
lint to reject more invalid calling conventions" rust#141435Option<unsafe fn()>
" rust#141447feature(generic_arg_infer)
" rust#141610dangerous_implicit_autorefs
lint deny-by-default" rust#141661extern "{abi}"
s consistently in all positions" rust#142134T-compiler beta / T-compiler stable
T-compiler
this time.T-compiler
this time.T-types
this time.T-types
this time.P-critical
issues for T-compiler
this time.P-critical
issues for T-types
this time.P-high
beta regressions this time.Unassigned P-high nightly regressions
P-high
nightly regressions this time.A week dominated by the landing of a large patch implementing RFC#3729 which unfortunately introduced rather sizeable performance regressions (avg of ~1% instruction count on 111 primary benchmarks). This was deemed worth it so that the patch could land and performance could be won back in follow up PRs.
Triage done by @rylev.
Revision range: 45acf54e..42245d34
Summary:
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 1.1% | [0.2%, 9.1%] | 123 |
Regressions (secondary) | 1.0% | [0.1%, 4.6%] | 86 |
Improvements (primary) | -3.8% | [-7.3%, -0.3%] | 2 |
Improvements (secondary) | -2.3% | [-18.5%, -0.2%] | 44 |
All (primary) | 1.0% | [-7.3%, 9.1%] | 125 |
2 Regressions, 4 Improvements, 10 Mixed; 7 of them in rollups
40 artifact comparisons made in total
Sized Hierarchy: Part I #137944 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 1.3% | [0.1%, 9.9%] | 111 |
Regressions (secondary) | 0.9% | [0.2%, 2.9%] | 101 |
Improvements (primary) | - | - | 0 |
Improvements (secondary) | -0.7% | [-0.7%, -0.7%] | 1 |
All (primary) | 1.3% | [0.1%, 9.9%] | 111 |
Rewrite inline
attribute parser to use new infrastructure and improve diagnostics for all parsed attributes #138165 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.3% | [0.2%, 0.8%] | 12 |
Regressions (secondary) | 0.5% | [0.2%, 0.8%] | 21 |
Improvements (primary) | -0.2% | [-0.2%, -0.2%] | 2 |
Improvements (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
All (primary) | 0.3% | [-0.2%, 0.8%] | 14 |
[perf] Cache the canonical instantiation of param-envs #142316 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | - | - | 0 |
Regressions (secondary) | 0.7% | [0.7%, 0.7%] | 1 |
Improvements (primary) | -0.7% | [-0.9%, -0.6%] | 12 |
Improvements (secondary) | -5.0% | [-20.3%, -0.6%] | 15 |
All (primary) | -0.7% | [-0.9%, -0.6%] | 12 |
forward the bootstrap runner
to run-make
#141856 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | - | - | 0 |
Regressions (secondary) | - | - | 0 |
Improvements (primary) | -2.8% | [-2.8%, -2.8%] | 1 |
Improvements (secondary) | - | - | 0 |
All (primary) | -2.8% | [-2.8%, -2.8%] | 1 |
Rollup of 10 pull requests #142878 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 1.1% | [1.1%, 1.1%] | 1 |
Regressions (secondary) | 1.1% | [1.1%, 1.1%] | 1 |
Improvements (primary) | -0.3% | [-0.5%, -0.2%] | 11 |
Improvements (secondary) | -0.5% | [-0.7%, -0.3%] | 13 |
All (primary) | -0.1% | [-0.5%, 1.1%] | 12 |
Let String pass #[track_caller] to its Vec calls #142728 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | - | - | 0 |
Regressions (secondary) | - | - | 0 |
Improvements (primary) | -2.9% | [-2.9%, -2.9%] | 1 |
Improvements (secondary) | - | - | 0 |
All (primary) | -2.9% | [-2.9%, -2.9%] | 1 |
Change __rust_no_alloc_shim_is_unstable to be a function #141061 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.4% | [0.3%, 0.5%] | 3 |
Regressions (secondary) | - | - | 0 |
Improvements (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
Improvements (secondary) | -1.8% | [-3.1%, -0.3%] | 7 |
All (primary) | 0.1% | [-0.5%, 0.5%] | 4 |
Rollup of 6 pull requests #142689 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.3% | [0.2%, 0.4%] | 4 |
Regressions (secondary) | 0.2% | [0.2%, 0.2%] | 11 |
Improvements (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
Improvements (secondary) | - | - | 0 |
All (primary) | 0.2% | [-0.4%, 0.4%] | 5 |
Rollup of 7 pull requests #142697 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | - | - | 0 |
Regressions (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
Improvements (primary) | -0.4% | [-0.4%, -0.2%] | 3 |
Improvements (secondary) | - | - | 0 |
All (primary) | -0.4% | [-0.4%, -0.2%] | 3 |
Allow storing format_args!()
in variable #140748 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.4% | [0.2%, 1.0%] | 24 |
Regressions (secondary) | 1.6% | [0.3%, 4.7%] | 12 |
Improvements (primary) | -3.7% | [-7.1%, -0.3%] | 2 |
Improvements (secondary) | - | - | 0 |
All (primary) | 0.1% | [-7.1%, 1.0%] | 26 |
Rollup of 9 pull requests #142794 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 2.9% | [2.9%, 2.9%] | 1 |
Regressions (secondary) | 0.8% | [0.2%, 1.2%] | 10 |
Improvements (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
Improvements (secondary) | - | - | 0 |
All (primary) | 0.4% | [-0.2%, 2.9%] | 5 |
Rollup of 8 pull requests #142814 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | - | - | 0 |
Regressions (secondary) | 0.5% | [0.4%, 1.0%] | 7 |
Improvements (primary) | -1.4% | [-2.8%, -0.1%] | 2 |
Improvements (secondary) | -0.8% | [-1.4%, -0.3%] | 24 |
All (primary) | -1.4% | [-2.8%, -0.1%] | 2 |
Rollup of 3 pull requests #142826 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.3% | [0.3%, 0.3%] | 2 |
Regressions (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
Improvements (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
Improvements (secondary) | - | - | 0 |
All (primary) | 0.1% | [-0.4%, 0.3%] | 3 |
Only traverse reachable blocks in JumpThreading. #142546 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 1.6% | [0.3%, 2.9%] | 2 |
Regressions (secondary) | - | - | 0 |
Improvements (primary) | - | - | 0 |
Improvements (secondary) | -0.3% | [-0.3%, -0.3%] | 2 |
All (primary) | 1.6% | [0.3%, 2.9%] | 2 |
Skip no-op drop glue #142508 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 1.7% | [0.4%, 3.0%] | 2 |
Regressions (secondary) | - | - | 0 |
Improvements (primary) | -0.3% | [-0.4%, -0.3%] | 4 |
Improvements (secondary) | -1.8% | [-3.1%, -0.4%] | 6 |
All (primary) | 0.3% | [-0.4%, 3.0%] | 6 |
Rollup of 5 pull requests #142906 (Comparison Link)
(instructions:u) | mean | range | count |
---|---|---|---|
Regressions (primary) | 0.2% | [0.2%, 0.2%] | 1 |
Regressions (secondary) | 0.2% | [0.2%, 0.3%] | 3 |
Improvements (primary) | - | - | 0 |
Improvements (secondary) | -0.1% | [-0.1%, -0.1%] | 4 |
All (primary) | 0.2% | [0.2%, 0.2%] | 1 |
QueryStability
to handle IntoIterator
implementations" rust#139345 (last review activity: about 29 days ago)
&raw [mut | const]
for union field in safe" rust#141469 (last review activity: about 30 days ago)
Next meetings' agenda draft: hackmd link