---
# System prepended metadata

title: 'T-compiler 2021-07-16 steering meeting: review policy'
tags: [' rustc', steering]

---

---
tags: steering, rustc
---

# T-compiler 2021-07-16 steering meeting: review policy

doc: https://hackmd.io/2j3az2BdSr2-QrsUp_ZktQ?view

Highlighted comments follow

----

[comment](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246227691):
> I think it'd be good to add some section on "not assigned reviews" and best practices there -- both in terms of how to indicate you aren't the final reviewer to the author, but also whether e.g. it's acceptable to r- someone's PR asking them to cleanup commit history / fix the description / etc.

---

[comment](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246228726)

> In general, I would say the rationale should be roughly proportional to the size of the PR. If the PR just adds a regression test, not much rationale is required. If the PR is +900 -600 lines, we probably need more than just "Fixes #12345"

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246228963

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246229222

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246229512

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246230050

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246231988

----

https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-07-16.20compiler-team.23444/near/246232243

