# Alerts in Forta to be added/changed/removed

## ethereum-governance
New roles:
- `STAKING_MODULE_UNVETTING_ROLE` - which address?
- `APPEARED_VALIDATORS_PER_DAY_LIMIT_MANAGER_ROLE` - which address?
- `EXITED_VALIDATORS_PER_DAY_LIMIT_MANAGER_ROLE` (instead of `CHURN_VALIDATORS_PER_DAY_LIMIT_MANAGER_ROLE`) - the same address?

Removed roles:
- `STAKING_MODULE_PAUSE_ROLE`
- `STAKING_MODULE_RESUME_ROLE`

## ethereum-steth
Changed events:
- Deposit Security: Deposits paused
- No `stakingModuleId` param
- Deposit Security: Deposits resumed
- No `stakingModuleId` param
- Deposit Security: Max operators per unvetting changed
- based on event `MaxOperatorsPerUnvettingChanged`

Removed alerts:
- ⚠️ Deposit Security: Max deposits changed
- based on event `MaxDepositsChanged`
- ⚠️ Deposit Security: Min deposit block distance changed
- based on event `MinDepositBlockDistanceChanged`

## ethereum-validators-set
- accounting-oracle
- [x] add new alert based on event `ExtraDataSubmitted` that will notify whether all transactions were processed in 10 minutes
- node-operators-registry
- [x] `(Module name) NO Registry: Node operator target validators count changed`
- Add `targetLimitMode` parameter
- [ ] ? new alert based on `RewardDistributionStateChanged`
- staking-router
- [x] `Staking Router: staking module target share set`
- Change title to `Staking Router: staking module share limit set`
- With new parameters: `stakeShareLimit`, `priorityExitShareThreshold` and `setBy`
- [ ] `Staking Router: (Module Name) is about to reach the target share limit`
- is it the same as [existing alert](https://github.com/lidofinance/alerting-forta/blob/e4dd054a5d3e02e5ae94a334e21114c69528efcd/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L681)?
- [x] new alert `Max deposits per block set` based on event `StakingModuleMaxDepositsPerBlockSet`
- [x] new alert `Min deposit block distance set` based on event `StakingModuleMinDepositBlockDistanceSet`
- sanity-checker
- `Oracle Report Sanity Checker: limits were changed`
- [x] based on event `ExitedValidatorsPerDayLimitSet`
- [x] based on event `AppearedValidatorsPerDayLimitSet`

# Alerts which require an node operator name
- node-operators-registry
- [NODE-OPERATORS-BIG-EXIT](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L401)
- [NODE-OPERATORS-ALL-STUCK-EXITED](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L422)
- [NODE-OPERATORS-NEW-STUCK-KEYS](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L472)
- [NODE-OPERATORS-ALL-STUCK-REFUNDED](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L490)
- [NODE-OPERATORS-KEYS-REMOVED](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L530)
- [NODE-OPERATORS-VETTED-KEYS-SET](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L611)
- [NODE-OPERATORS-STUCK-PENALTY-ENDED](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/node-operators-registry/agent-node-operators-registry.ts#L763)
- exitbus-oracle
- [EXITBUS-ORACLE-EXIT-REQUESTS-DIGEST](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/exitbus-oracle/agent-exitbus-oracle.ts#L535)
- lido-report
- [Lido Summary Report digest](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/lido-report/agent-lido-report.ts#L103)
- set-ops
- [LOW-OPERATORS-AVAILABLE-KEYS-NUM](https://github.com/lidofinance/alerting-forta/blob/2b659de8ff9a4f60ee134ab6d5f7aa47a92f3396/ethereum-validators-set/src/subagents/set-ops/agent-set-ops.ts#L136)

See the list of alerts here: https://hackmd.io/@rOVWtirgSgu6p7oJgzGwVg/rJdBWakg1x