LH Audit Prep Oct 2020

This document tracks progress towards the Lighthouse sec review starting on the morning of Oct 6 (Sydney time).

Items: per-person

Allocated

• Paul
  • Validator key caching (review)
  • Validator top ups (review)
• Pawan
  • Validator top-ups (author)
• Benedikt
  • Validator key caching (author)
• Age
  • Upgrade discovery (author)

Unallocated tasks (plz adopt)

• Clippy lints (review)
• Update deps (review)
• Upgrade discovery (review)
• Worker Drop impl (review, easy)

Items: detail

Clippy Lints

Paul has made a PR to close it. Needs senior review, no candidates yet.

• https://github.com/sigp/lighthouse/issues/1388
• https://github.com/sigp/lighthouse/pull/1714

Validator key caching

Benedikt has made a PR, reviewed by Paul. Waiting on Benedikt for post-review changes.

• https://github.com/sigp/lighthouse/issues/1618
• https://github.com/sigp/lighthouse/pull/1695

Validator top-ups

Pawan has a WIP PR. No reviewer allocated.

• https://github.com/sigp/lighthouse/issues/1653
• https://github.com/sigp/lighthouse/pull/1694

Upgrade discovery

Branch has conflicts, needs to be resolved by Age.

• https://github.com/sigp/lighthouse/pull/1693

Update deps

Paul has created a PR. Requires review, no candidates yet.

• https://github.com/sigp/lighthouse/issues/1706
• https://github.com/sigp/lighthouse/pull/1711

Worker Drop impl

Paul has created a PR. Requires review, no candidates yet.

• https://github.com/sigp/lighthouse/pull/1718/files

Notes

• PH removed the "system endpoint" PR from A0 since I think it can wait. Happy to discuss.