## Attendees - @fdncred - @sholderbach - @jt - @storm - Andres - amtoine ## Agenda - [x] (!!) Post-release patch up/point release? - https://github.com/nushell/nushell/issues/9812 - [ ] (quick) plan who does the release note the week before - [ ] (quick) remove codeowner in `nu_scripts`? - [x] (quick?) deprecation !! - delete old deprecated commands - reenable `let-env`? => reach starship folks to have an idea of the next release date - true deprecation => in the future, for 1.0, but now we want to be able to remove commands # Discussed Topics ## Point release - JT: Let's wait for a few more hours so we don't have to repeat doing the hotfix process - 24h - We got a lot of things in the pipe that we can fix - Just release from main branch when we are ready ### Dataframe overloading remnants - There were overloading system requiring known type information at parse time to pick from several commands with exactly the same name - this obviously doesn't work anymore (hacks have been removed) - only worked for parse time - we don't always konw the type at parse time - Options: - runtime dynamic dispatch? - future vision to get df seamless would require it - tricky to implement without testing strategy - rename the lazy and eager commands - easiest one - degraded QoL - smush the impl together from two/three commands to one - eager,lazy,expression - bunch of work - could keep the prior design - still some additional tests - Problem dozens of commands that are undertested, less folks ready to work on, what can we get ready in a hotfix - Maxim-Uvarov was eager to get this back to work - sounds like time consuming - has this enough priority to be part of the general hotfix? - limited userbase - let's get the general feature set fixed without hesitation #### general df thoughts - Darren: keep dfs still living so people that are eager to work on this can jump in ### General type problem #### What should `append` do It's behavior violates its current signature Current state `"hello" | append "world"` ==> `["hello", "world"]` Resolve post meeting: prepend and append should behave the same! Q: is `++` equivalent to append? Should `append`/`prepend` create a list Is `++` weird? `"hello" | $in ++ " world"` vs. `"hello" | [$in, "world"]` Darren: currently weird ``` "one" ++ "two" "one" + "two" ``` **For now (hotfix) give them the correct signature resolve ambiguities later** ### Dealing with the ecosystem that breaks when we make breaking changes - we filed patches but releases were not out yet. - with `let-env` - should we pray and wait for their release (reach out) - get it back in with warning - There will always be the risk of release schedule mismatch. we still need to make breaking changes - JT: we need to break but want to be nice to our users - from users: expectation to have the ability to have warning deprecation ### general type system problems - when to use any ## Conclusion for hotfix - `ansi` (done in https://github.com/nushell/nushell/pull/9817) - `...rest` (done in https://github.com/nushell/nushell/pull/9816) - `append`/`prepend` - possibly `let-env` (if the external tools don't update) - collect list of commands that miss input output types - math commands Darren: we don't wait to long, we should also wait for the package managers for people to realize if something is broke JT: looks like normal day after progression in the next day we should see most of the missing and then it trickles Mixed feelings about how `let-env` went down - We gave 2 weeks notice. everyone accepted the patches eagerly - in the future be more explicit to 3rd parties when the hard breaking changes are coming - we should not signal too much stability because we will hurt people - too shiny documentation would cause whiplash - show the scars to get folks to be willing to fix ## `format` command family - should we have more `format` commands - [PR up for `format duration`](https://github.com/nushell/nushell/pull/9788) - e.g. - `format datetime` - `format money` - currently living in `extra` ## Issues > :bulb: the issues which [needs-core-team-attention](https://github.com/nushell/nushell/labels/needs-core-team-attention) > :bulb: **Note** > to list all the PRs currently [opened in `nushell/nushell`](https://github.com/nushell/nushell/pulls): > ```nu > gh pr list --json url,number,author,title > | from json > | each {|i| > $"- [($i.number)]\(($i.url)\) ($i.title) \(@($i.author.login)\)" > } > | reverse > | to text > ```