Meeting Minutes

Meeting Minutes === ###### tags: `working-group` `plugin` :::info - **Date:** 2022-12-20 - **Agenda:** - Ashley / Kira is working on the backend keyboard refactor (targeting 12/21) - part 2: resolving keybindings and handling keyboard events (targeting 12/22) - GUI refactoring (targeting 12/23) - dependent on backend refactoring - registering actions with app model - 2 user experience changes planned ([see link here](https://docs.google.com/document/d/1dNTizNL4GwgNa0Gm6PUEVonRXUBSN_0Miq9X8C_TR4s/edit#)): - Allow plugin developers to add default shortcuts for their plugin commands - New group is added to capture plugin key bindings - NAP - ::: :::info - **Date:** 2022-12-13 - **Agenda:** - backend refactoring targeting completion this week (12/16) - Kira to post intended UI as an issue so that Lisa can give feedback (12/16) - GUI refactoring targeting completion next week (12/23) ::: :::info - **Date:** 2022-11-29 - **Agenda:** - Kira completed code review with Andy - agreed to do the GUI refactor after backend refactor - backend targeting 1.5 weeks - GUI refactor targeting 2-3 weeks - run the UI/UX changes by design - Action: Jun to help set up - Ziyang will follow up with Draga on NAP progress ::: :::info - **Date:** 2022-11-22 - **Agenda:** - Ziyang will help set up code pairing with Kira for key binding in GUI (either with Andy or Danielle) - [done]Jun to schedule 30 mins with Kira on user experience - Draga will likely be taking on the NAP solo - targeting mid-Dec - discussed moving forward with a feature branch, will be reviewed as if it's a part of main ::: :::info - **Date:** 2022-11-15 - **Agenda:** - Menu - action: Kira and Draga to draft NAP (targetng first week of Dec) - Keybinding - action: Kira to add in keybinding - User experience: - plugin shortcuts will not show as a "group" - users can currently only see the shortcuts in documentation (e.g., hub) and in the manifest - refactor needed to get keybindings in GUI (refactor takes ~2weeks and a stretch goal) - action: Kira to schedule a code review session to look into this (with Ziyang and Nathan) - tentative decision: if we're not able to reach the goal of showing in the GUI, then it will spill into the next half (yay Kira for being a "completionist") - action: Ziyang to provide effort (approx length of time)needed if we were to spill into H1 2023 ::: :::info - **Date:** 2022-11-08 - **Agenda:** - Review actions from last meeting - Menu contributions - Discussion with core dev in Zulip - did not align on the "tools" menu - not a dependency to deprecate npe1 - options forward: - add in sub menus under their plugin name under the "plugin" menu - continue with context menus (aka right click on layer menus) - **Decision** to move forward with NAP on menu contribution location - action: Draga to take lead on writing NAP - **Decision** ~~move forward with right click context menus as a means to demo~~ - **Decision:** create demo on 2 different schemas (input/output and workflow) - action: Draga and Kira to work together on the demo - targeting mid Dec - keybinding events refactor PR needs review (#5296) - action: Nathan to review, Ziyang took a first pass ::: ## Notes - ... :::info - **Date:** 2022-11-01 - **Agenda:** - Review actions from last meeting - PR progress - tool menu (#5153): Draga to socialize the change with other core devs - file/window menu: need to be reviewed, Lucy has limited capacity to help - action: Draga to follow up on npe2 channel - Keybinding: most of the work done converting from vispy system. PR upcoming soon. - setting needs to be cleared with napari --reset (Grzegorz to create issue) - Ziyang on Robert outreach - not ready to do this yet, need to merge the tools menu - documentation - npe2 feature flag can be switched to build docs - flag is: hide_docs - revisit in 2 weeks - Refine feature roadmap timeline (1 pending milestone to be confirmed) - Next Steps - discussion on backup option if Robert doesn't convert by end of year - we have demo plugin to add this function (start mid-nov if we don't get Robert's conversions) - **Participants:** Draga, Kira, Ziyang, Nathan, Jun, Grzegorz ::: ## Notes - . :::info - **Date:** 2022-10-25 - **Agenda:** - Review actions from last meeting - tbd - Refine feature roadmap timeline - Next Steps - **Participants:** Draga, Kira, Lucy, Ziyang, Jun ::: ## Notes - What is remaining? - finish PRs (review and merge) - action: Ziyang to follow up with Jun on eng scope related to UX for 2022 - documentation - reach out to robert to start converting (initial connect next week) - action: Ziyang to do outreach to Robert (coordinate with Nathan to avoid duplicate outreach) - release with 0.4.18 (although release does not need to happen for plugin devs to start converting) :::info - **Date:** 2022-10-11 - **Agenda:** - Review actions from last meeting - tbd - Refine feature roadmap timeline - Next Steps - **Participants:** Draga, Kira, Lucy, Ziyang, Nathan, Jun ::: ## Notes - 5103 progress - app-model#66 merged - superqt issue resolved - investigating json-schema relate test failure - 4826 issues with the test. Lucy/Draga pairing. - test failures were due to fixture problem - fixture improvement is in flight - expect tests passing this next week :::info - **Date:** 2022-10-04 - **Agenda:** - Review actions from last meeting - 4826 - 5103 - finalize 4 remaining PRs (4865, 4922, 4977, 4991) - 4979 - 5079 - Clarification of comment here: https://github.com/napari/napari/pull/4991/files#r972649525 - Decision about: https://github.com/napari/napari/pull/4865/files#r986462579 - Review blockers - 0.4.17 release; what else can be worked on while we wait for the release? - Refine feature roadmap timeline (lower priority for this week) - Next Steps - **Participants:** Draga, Kira, Lucy, Ziyang, Nathan, Jun ::: ## Notes - 5103 blocked by 66, 68: waiting for Talley to green light new approach - [done] Action: Kira to contact Talley, tap Nathan for help - 4826 - Action: Draga to post on Zulip (ping Juan for review) on titlecase - Action: Draga to move forward with merging, we're not blocked on 0.4.17 release - finalize 4 remaining PRs (4865, 4922, 4977, 4991) - waiting on 4826 - Action: Draga and Lucy to pair on updating and getting ready for merge - Decision on 4865 - Viewer/Window approach used in File menu PR is prefered. patch that into 4826 - Action: Lucy to update PR 4826 - Clarification of comment on 4991 - Action: Lucy and Draga will pair to work on this - 4979 - lower priority, punt until after merge - 5079 - Action: Ziyang to decide who to pass this off to, not a blcoker :::info - **Date:** 2022-09-27 - **Agenda:** - Review actions from last meeting - 4826 testing - finalize 4 remaining PRs (4865, 4922, 4977, 4991) - 5103 enums - 5079 menu item location - Review blockers - Next Steps - **Participants:** Kira, Lucy, Nathan Ziyang, Jun ::: ## Notes - Recap of actions from last meeting - 4826 testing: - option 1: move forward with merging, add test in a follow up issue (#4979) - option 2: add test prior to merging - Decsision: move forward with option 1, rationale: tests are nice to have, should not be blocking the merge - Action: Ziyang will reach out to Draga to merge after 0.4.17 release - [done] Action: Ziyang will reach out to Draga about testing #4979 - finalize 4 remaining PRs (4865, 4922, 4977, 4991) - all are nearly finalized, need to clean and merge, blocked by #4826 - action: PR owners (Ziyang / Lucy) to clean and merge - 5103 enums - Unblocked the decision on keybindings, will need to add app model - 5079 contribution - [done] action: Ziyang to link the full whitelist :::info - **Date:** 2022-09-20 - **Agenda:** - Review actions from last meeting - plan towards merging 5 key PRs - menu contribution decisions - key bindings - Review blockers - Next Steps - **Participants:** ::: ## Notes - **plan towards merging 5 key PRs** - action: Nathan to reach out to Talley/Draga about merging 4826 - action: Ziyang will review and finalize remaining 4 PRs (4865, 4922, 4977, 4991) - **menu contribution decisions** - issue 5079 was opened - action: Ziyang will share out in community meeting and summarize discussions in 5079 issue - plugin wg is aligned on using [Robert's suggestion](https://github.com/napari/npe2/pull/161#pullrequestreview-965399728) of a set of categories under "Tools" menu - action: make an issue to test whether plugin dev B can contribute to plugin dev A's menu item (foriegn plugin reference)....talk about this in next meeting - **key bindings** - action: Kira to work through failed tests on PR 5103 (Ziyang will notify her) - action: Nathan to review Kira's PR 5103 - action: Kira to document impact on keybinding to public API - note: there may be no public API impact (TBD later on) - action: make an issue to test whether plugin dev B can contribute to plugin dev A's menu item (foriegn plugin reference)....talk about this in next meeting - [link to zulip topic](https://napari.zulipchat.com/#narrow/stream/309872-plugins/topic/.E2.9C.94.20Add.20submenus.20to.20the.20Plugins.20menu) Meeting Minute 2022-09-13 === ###### tags: `working-group` `plugin` :::info - **Date:** 2022-09-13 - **Agenda:** - review actions from [last meeting](https://hackmd.io/0a_8oCc-Sk2ELFMbvpHkSQ) - Ziyang's plugin demo - top level menu items - change - content - how to pick - conservativism - clear content choices - best practices docs - Review blockers - Next steps - **Participants:** :::  ## Next steps  embedded in notes section below - action: menu item PRs to be reviewed (4826, 4865, 4922, 4977, 4991) - [done] action: Ziyang to share out with community, ask for feedback, post on GH (re: identifying the menu item location) - [done] action: Kira to make a PR for internal representation of key bindings - [TBD if needed] action: Kira to document impact on keybinding to public API ## Notes  More discussion needed - what happens if we want to change something in the future (e.g., top level menu location, what are we allowing people to contribute to) - should be clear on where things should be placed What do we need decisions on? - what menus/toolbars can plugins contribute their actions to? Meeting Minute 2022-09-06 === ###### tags: `working-group` `plugin` :::info - **Date:** 2022-09-06 - **Agenda:** - review actions from [last meeting](https://hackmd.io/0a_8oCc-Sk2ELFMbvpHkSQ) - Announcment [Nathan] - Review blockers - Next steps - **Participants:** :::  ## Next steps  embedded in notes section below ## Notes  Recap of actions from last meeting: - **action**: #4826 reviews and get it merged! - action: Nathan to talk to Talley to merge (subject to 0.4.17 release) - option 1 - merge into 0.4.17 release - option 2 - merge none into 0.4.17 release - **Decision**: team aligned on going with option 2 --> get them ready to merge right after the release. Rationale: don't want to rush it in and encounter bugs - owners for each of the following PRs will get them ready for merge 4826, 4865, 4922, 4977, 4991 - **action**: Nathan: check if plugin menu is ready on npe2 side - **action**: Ziyang to create issue on npe2 menu integration - **action**: Ziyang: create an issue re end-to-end testing Next Steps - **action**: Ziyang to follow up with Kira on status for keybinding refactor part two - [ ] After the meeting add the minutes to the 'working-group/plugins' folder of [napari/meeting-notes](https://github.com/napari/meeting-notes). ## Links * [Calendar](https://calendar.google.com/calendar/u/0?cid=Y18zNXI5M2VjNnZ0cDhzbWhtN2R2NXVvdDB2NEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t) * [HackMD space](https://hackmd.io/team/napari-wg-plugin) * [Recorded meeting notes](https://github.com/napari/meeting-notes/tree/master/2021/working-groups/plugins)