# Admin UI Giga PR Review ## Given: - 🚨 = Action required - 👌 = Needs updated post after initial PR merge - 🤷‍♂️ = Optional --- ## TODOs - [x] Remove `.gitignore copy` 🚨 - [x] Git ignore `.env.local` 🚨 - [x] Remove unused code 🚨 - [x] `assets` - [x] `src/@types/index.d.ts` - [x] `components/*` - [x] `hooks/**/*` - [x] `types/**/*` - [x] `utils/**/*` - [x] Update `.env` values to match new repo/project if they haven't been updated 🚨 - [x] Home page content/copy. Right now it says `admin home` 🚨 - Suggestion: Redirect to `/scheduling` - [x] Disable open browser on start up 🤷‍♂️ - [x] Do away with `AdminTopics` dir and flatten to its subdirs 👌 - [x] Do away with magic strings 👌 - [x] Use `RouteParameter` constant instead of magic strings: - For example: - `src/routes/Scheduling/Resources/index.tsx` - `src/routes/Scheduling/Shops/$shopId/index.tsx`files - [x] Move `Providers` component to its own folder with an `index.tsx`: `src/routes/Scheduling/Providers.tsx` 👌 - [ ] Export components that are accessed outside of the `components` directory instead of deep imports 👌 - E.g. `src/routes/Scheduling/Resources/index.tsx` - [x] Upgrade node version to 18+ 🚨 - [ ] Handle loading & error states 👌 - [x] Scheduling -> Resources view should be almost identical to Scheduling -> Shops 👌 - [ ] Add search endpoint to appointment service to query shops/resources with partial criteria 👌 - [ ] RE: Shops... Make a clear distinction between shop resources list and shop actions 👌 - [x] Review breadcrumbs and providers. Make sure they are scoped appropriately. 👌 - [x] Clean out all unused service urls from `.env` 👌